[Lldb-commits] [lldb] [lldb] Disable TestConsecutiveBreakpoints.py for Windows x86_64 (PR #142192)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142192 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable TestReverseContinueBreakpoints.py and TestReverseContinueWatchpoints.py for Windows x86_64 (PR #142193)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/142129 >From 4c0bd999e60b7082fb30916c5f20d7ab064e76fe Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Fri, 30 May 2025 12:49:22 +0100 Subject: [PATCH 1/2] [lldb-dap][test] Fix DAP disassemble test compare the instru

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. The LLDB parts look good. https://github.com/llvm/llvm-project/pull/142164 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-06-02 Thread Pavel Labath via lldb-commits
@@ -8511,8 +8512,16 @@ TypeSystemClang::dump(lldb::opaque_compiler_type_t type) const { } #endif -void TypeSystemClang::Dump(llvm::raw_ostream &output) { - GetTranslationUnitDecl()->dump(output); +void TypeSystemClang::Dump(llvm::raw_ostream &output, llvm::StringRef filter)

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/142164 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-06-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/142164 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 68fd6f4 - [lldb] Disable TestReverseContinueBreakpoints.py and TestReverseContinueWatchpoints.py for Windows x86_64 (#142193)

2025-06-02 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2025-06-02T14:01:45+04:00 New Revision: 68fd6f4eb86121d107dd4d0b282b11b48e82183b URL: https://github.com/llvm/llvm-project/commit/68fd6f4eb86121d107dd4d0b282b11b48e82183b DIFF: https://github.com/llvm/llvm-project/commit/68fd6f4eb86121d107dd4d0b282b11b48e82183b.dif

[Lldb-commits] [lldb] [lldb] Disable TestReverseContinueBreakpoints.py and TestReverseContinueWatchpoints.py for Windows x86_64 (PR #142193)

2025-06-02 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/142193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fb86264 - [lldb] Disable TestConsecutiveBreakpoints.py for Windows x86_64 (#142192)

2025-06-02 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2025-06-02T14:01:13+04:00 New Revision: fb86264f4049e866d4058ea151edb47381c85b77 URL: https://github.com/llvm/llvm-project/commit/fb86264f4049e866d4058ea151edb47381c85b77 DIFF: https://github.com/llvm/llvm-project/commit/fb86264f4049e866d4058ea151edb47381c85b77.dif

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-06-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/142164 >From 662e07aa9bb6560f37c079ba6f13be17e7885b48 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 30 May 2025 15:44:09 +0100 Subject: [PATCH 1/6] [clang][Frontend] Add overload to ASTPrinter that doesn't

[Lldb-commits] [lldb] [lldb] Fix Linux core file tests hanging on Windows (PR #142143)

2025-06-02 Thread Pavel Labath via lldb-commits
labath wrote: This PR is correct. It would be nice to avoid this resume-core-file footgun, but I don't have an opinion on the proposed fix. https://github.com/llvm/llvm-project/pull/142143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-02 Thread Ebuka Ezike via lldb-commits
@@ -23,15 +19,23 @@ def test_disassemble(self): self.set_source_breakpoints(source, [line_number(source, "// breakpoint 1")]) self.continue_to_next_stop() -_, pc_assembly = self.disassemble(frameIndex=0) -self.assertIn("location", pc_assembly,

[Lldb-commits] [lldb] [lldb] Disable TestConsecutiveBreakpoints.py for Windows x86_64 (PR #142192)

2025-06-02 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/142192 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reimplement `runInTerminal` with signals (PR #142374)

2025-06-02 Thread Hu Jialun via lldb-commits
https://github.com/SuibianP updated https://github.com/llvm/llvm-project/pull/142374 >From a9c971019378236f7b4c680ff96c526625ff29ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jialun=20Hu=20=EF=BC=88=E8=83=A1=E4=BD=B3=E4=BC=A6?= =?UTF-8?q?=EF=BC=89?= Date: Mon, 2 Jun 2025 16:16:11 +0800 Subject:

[Lldb-commits] [lldb] [lldb][AIX] Added support to load DW_ranges section (PR #142356)

2025-06-02 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Motivated by https://discourse.llvm.org/t/why-is-wait-for-not-attaching/86636 --- Full diff: https://github.com/llvm/llvm-project/pull/142424.diff 2 Files Affected: - (added) lldb/test/Shell/Drive

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From b47eaa64397da7ea5d2a7ca46bea4513a37755f0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-06-02 Thread via lldb-commits
jimingham wrote: It would be better to add the same properties to the SBBreakpointName that the test failures showed up than to revert that test change. If SBBreakpoint's and SBBreakpointLocations have these properties, SBBreakpoint names should as well. https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] def17cd - [lldb][AIX] Added support to load DW_ranges section (#142356)

2025-06-02 Thread via lldb-commits
Author: Hemang Gadhavi Date: 2025-06-02T22:32:08+05:30 New Revision: def17cd38f48147ec2ab29674fc5746782c62b47 URL: https://github.com/llvm/llvm-project/commit/def17cd38f48147ec2ab29674fc5746782c62b47 DIFF: https://github.com/llvm/llvm-project/commit/def17cd38f48147ec2ab29674fc5746782c62b47.diff

[Lldb-commits] [lldb] [lldb][AIX] Added support to load DW_ranges section (PR #142356)

2025-06-02 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/142356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Greg Clayton via lldb-commits
@@ -120,6 +120,21 @@ TEST(Perf, RealPtraceScope) { << "Sensible values of ptrace_scope are between 0 and 3"; } +TEST(Perf, RealPtraceScopeWhenNotExist) { + // We first check we can NOT read /proc/sys/kernel/yama/ptrace_scope + auto buffer_or_error = + errorOrToExp

[Lldb-commits] [lldb] include telemetry session-id in diagnostic msg when enabled (PR #135924)

2025-06-02 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/135924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2025-06-02 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/87815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Greg Clayton via lldb-commits
@@ -120,6 +120,21 @@ TEST(Perf, RealPtraceScope) { << "Sensible values of ptrace_scope are between 0 and 3"; } +TEST(Perf, RealPtraceScopeWhenNotExist) { + // We first check we can NOT read /proc/sys/kernel/yama/ptrace_scope + auto buffer_or_error = + errorOrToExp

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-02 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142439 None >From 69efc48d722d18600018f25db0f9ea46b9fd1d97 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 14:02:01 +0100 Subject: [PATCH] [lldb-dap] Use structured types for stepInTargets request

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Jordan Rupprecht via lldb-commits
@@ -104,7 +104,7 @@ TEST(Perf, RealLogicalCoreIDs) { ASSERT_GT((int)cpu_ids->size(), 0) << "We must see at least one core"; } -TEST(Perf, RealPtraceScope) { +TEST(Perf, RealPtraceScopeWhenExist) { rupprecht wrote: I think it's a bug that I wrote `if (!*ptra

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht edited https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 01/20] Add commands to list/enable/disable plugins This commit a

[Lldb-commits] [lldb] [LLDB][NFC] Add accessor for SessionId (PR #142444)

2025-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142444.diff 1 Files Affected: - (modified) lldb/include/lldb/Core/Telemetry.h (+2) ``diff diff --git a/lldb/include/lldb/Core/Telemetry.h b

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
@@ -174,12 +174,21 @@ struct StatisticsOptions { return !GetSummaryOnly(); } + void SetIncludePlugins(bool value) { m_include_plugins = value; } + bool GetIncludePlugins() const { +if (m_include_plugins.has_value()) + return m_include_plugins.value(); +//

[Lldb-commits] [lldb] 8e8da88 - [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (#142224)

2025-06-02 Thread via lldb-commits
Author: royitaqi Date: 2025-06-02T10:43:58-07:00 New Revision: 8e8da88d46dcb1ba6ffe266779dd047fa772497e URL: https://github.com/llvm/llvm-project/commit/8e8da88d46dcb1ba6ffe266779dd047fa772497e DIFF: https://github.com/llvm/llvm-project/commit/8e8da88d46dcb1ba6ffe266779dd047fa772497e.diff LOG:

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +// Helper function to perform an action on each matching plugin. +// The action callback is given the containing namespace along with plugin info +// for each matching plugi

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
@@ -464,6 +466,24 @@ llvm::json::Value DebuggerStats::ReportStatistics( } } + if (include_plugins) { +json::Object plugin_stats; +for (const PluginNamespace &plugin_ns : + PluginManager::GetPluginNamespaces()) { + json::Array namespace_stats; + +

[Lldb-commits] [lldb] [LLDB][NFC] Add accessor for SessionId (PR #142444)

2025-06-02 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/142444 None >From 38e85beda6ddc9b102fab5ec9133364a75ac5022 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 2 Jun 2025 13:40:40 -0400 Subject: [PATCH] Add accessor for SessionId --- lldb/include/lldb/Core/Telemet

[Lldb-commits] [lldb] 88c1403 - [LLDB][NFC] Add accessor for SessionId (#142444)

2025-06-02 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-06-02T13:46:03-04:00 New Revision: 88c1403981dee9844042a99dc357d8034cf5d197 URL: https://github.com/llvm/llvm-project/commit/88c1403981dee9844042a99dc357d8034cf5d197 DIFF: https://github.com/llvm/llvm-project/commit/88c1403981dee9844042a99dc357d8034cf5d197.diff LOG

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +// Helper function to perform an action on each matching plugin. +// The action callback is given the containing namespace along with plugin info +// for each matching plugi

[Lldb-commits] [lldb] [LLDB][NFC] Add accessor for SessionId (PR #142444)

2025-06-02 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/142444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 01/21] Add commands to list/enable/disable plugins This commit a

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread via lldb-commits
@@ -74,7 +74,7 @@ lldb_private::process_linux::GetAvailableLogicalCoreIDs() { llvm::Expected lldb_private::process_linux::GetPtraceScope() { ErrorOr> ptrace_scope_file = getProcFile("sys/kernel/yama/ptrace_scope"); - if (!*ptrace_scope_file) + if (!ptrace_scope_file)

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread via lldb-commits
royitaqi wrote: Updated according to @labath 's comment. @JDevlieghere / @clayborg: Gentle ping - Do you guys want to review, or should I go ahead and land with @labath 's approval? https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/142224 >From 58b8a322a8cc6e3cce3d3e2d405fb915c338791a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Fri, 30 May 2025 14:21:06 -0700 Subject: [PATCH 1/5] Fix crash and add test --- lldb/source/Plugins/Process/Linux/Pr

[Lldb-commits] [lldb] 7365f02 - [lldb][NFC] Remove unused macro ENABLE_MEMORY_CACHING (#142231)

2025-06-02 Thread via lldb-commits
Author: Alex Langford Date: 2025-06-02T11:15:40-07:00 New Revision: 7365f029de77321d189bf138b73ff97502bbb77d URL: https://github.com/llvm/llvm-project/commit/7365f029de77321d189bf138b73ff97502bbb77d DIFF: https://github.com/llvm/llvm-project/commit/7365f029de77321d189bf138b73ff97502bbb77d.diff

[Lldb-commits] [lldb] e9fad0e - [lldb] Refactor away UB in SBValue::GetLoadAddress (#141799)

2025-06-02 Thread via lldb-commits
Author: Pavel Labath Date: 2025-06-02T09:39:56+02:00 New Revision: e9fad0e91c49ca0f2669989dbad95664cbc9cbf3 URL: https://github.com/llvm/llvm-project/commit/e9fad0e91c49ca0f2669989dbad95664cbc9cbf3 DIFF: https://github.com/llvm/llvm-project/commit/e9fad0e91c49ca0f2669989dbad95664cbc9cbf3.diff

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/141799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/142470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
@@ -280,6 +280,12 @@ SBError Driver::ProcessArgs(const opt::InputArgList &args, bool &exiting) { } if (args.hasArg(OPT_wait_for)) { +if (!args.hasArg(OPT_attach_name) || !args.hasArg(OPT_attach_pid)) { JDevlieghere wrote: Thanks for checking. I'll up

[Lldb-commits] [lldb] [lldb-dap] Correct the disconnect helper on server shutdown. (PR #142508)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142424 >From 988faae7eebaea3869d6717c35ac8757e19aa7d8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 2 Jun 2025 09:21:17 -0700 Subject: [PATCH] [lldb] Emit an error when using --wait-for without a nam

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/142424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/142439.diff 7 Files Affected: - (modified) lldb/tools/lldb-dap/Handler/RequestHandler.h (+15-1) - (modified) lldb/tools/lldb-dap/Handler/StepInTarg

[Lldb-commits] [lldb] [lldb][NFC] Remove unused macro ENABLE_MEMORY_CACHING (PR #142231)

2025-06-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/142231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread via lldb-commits
https://github.com/award999 created https://github.com/llvm/llvm-project/pull/142470 - Allow running when no workspace folder is present, and do not override the `cwd` set in the launch configuration - Support getting configuration from workspace file Issue: #142469 >From 5eec6c7d71bb3bc9c6b8

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (award999) Changes - Allow running when no workspace folder is present, and do not override the `cwd` set in the launch configuration - Support getting configuration from workspace file Issue: #142469 --- Full diff: https://github.co

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This fixes a data race between the main thread and the default event handler thread. The statusline format option value was protected by a mutex, but it was returned as a pointer, allowing one threa

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
@@ -414,6 +415,34 @@ bool fromJSON(const llvm::json::Value &, SteppingGranularity &, llvm::json::Path); llvm::json::Value toJSON(const SteppingGranularity &); +/// A `StepInTarget` can be used in the `stepIn` request and determines into +/// which single target

[Lldb-commits] [lldb] b9a5285 - [lldb-dap] Bump the version to 0.2.15

2025-06-02 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-02T14:43:24-07:00 New Revision: b9a528553a8d0fadaa167ea2b5c0f860cc0b33dc URL: https://github.com/llvm/llvm-project/commit/b9a528553a8d0fadaa167ea2b5c0f860cc0b33dc DIFF: https://github.com/llvm/llvm-project/commit/b9a528553a8d0fadaa167ea2b5c0f860cc0b33dc.d

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-02 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Thanks! LGTM https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/142470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
@@ -280,6 +280,12 @@ SBError Driver::ProcessArgs(const opt::InputArgList &args, bool &exiting) { } if (args.hasArg(OPT_wait_for)) { +if (!args.hasArg(OPT_attach_name) || !args.hasArg(OPT_attach_pid)) { JDevlieghere wrote: According to our `--help` ou

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From b47eaa64397da7ea5d2a7ca46bea4513a37755f0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH 1/2] [lldb][headers] Create Python script to fix up fra

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142489 >From bbdaa75ba4baa54d17fb1f8bbf6280b7e4521b84 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 2 Jun 2025 14:16:23 -0700 Subject: [PATCH 1/2] [lldb] Fix data race in statusline format handling

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/142424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

2025-06-02 Thread Prabhu Rajasekaran via lldb-commits
Prabhuk wrote: My team builds lldb on linux X64 and running into a test failure since this patch had landed. Builder link: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/lldb-linux-x64/b8713139267610948369/overview I am taking a closer look. CC: @mysterymath ``` FAIL: lldb

[Lldb-commits] [lldb] [lldb][headers] Create Python script to fix up framework headers (PR #142051)

2025-06-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/142051 >From b47eaa64397da7ea5d2a7ca46bea4513a37755f0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 28 May 2025 15:45:45 -0700 Subject: [PATCH 1/2] [lldb][headers] Create Python script to fix up fra

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread via lldb-commits
@@ -280,6 +280,12 @@ SBError Driver::ProcessArgs(const opt::InputArgList &args, bool &exiting) { } if (args.hasArg(OPT_wait_for)) { +if (!args.hasArg(OPT_attach_name) || !args.hasArg(OPT_attach_pid)) { jimingham wrote: I don't think we do `--wait-for

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/142489 This fixes a data race between the main thread and the default event handler thread. The statusline format option value was protected by a mutex, but it was returned as a pointer, allowing one thread to ac

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Greg Clayton via lldb-commits
@@ -120,6 +120,21 @@ TEST(Perf, RealPtraceScope) { << "Sensible values of ptrace_scope are between 0 and 3"; } +TEST(Perf, RealPtraceScopeWhenNotExist) { + // We first check we can NOT read /proc/sys/kernel/yama/ptrace_scope + auto buffer_or_error = + errorOrToExp

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From bb382b5e3f9bb5c64c5ea11fd2cb3ea94833c56a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint(Location) (PR #142215)

2025-06-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/142215 >From b969aeffa2726ef4e0714bde9de72a5292a8d8fa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 30 May 2025 14:11:19 -0700 Subject: [PATCH 1/4] [lldb] Add Python properties to SBBreakpointr(Location) ---

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Python properties to SBBreakpoint and similar (PR #142215)

2025-06-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/142215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-06-02 Thread John Harrison via lldb-commits
ashgti wrote: FYI, I am not a code owner of lldb-dap or lldb. I think its usually best to wait for one of the owners to sign off before submitting. See https://github.com/llvm/llvm-project/blob/main/lldb/Maintainers.md for the full list of active maintainers. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-02 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I updated this patch to remove everything that isn't related to how the tool works with the server emitters. This should simplify this patch and make it so that when later emitters are put up (such as the client and bindings emitters), the tool can be updated to accommodat

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. As far as I can tell this looks safe now. https://github.com/llvm/llvm-project/pull/142489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Adrian Prantl via lldb-commits
@@ -144,9 +144,9 @@ void Statusline::Redraw(bool update) { } StreamString stream; - if (auto *format = m_debugger.GetStatuslineFormat()) -FormatEntity::Format(*format, stream, &symbol_ctx, &exe_ctx, nullptr, - nullptr, false, false); + FormatE

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Adrian Prantl via lldb-commits
@@ -380,11 +380,11 @@ bool OptionValue::SetLanguageValue(lldb::LanguageType new_language) { return false; } -const FormatEntity::Entry *OptionValue::GetFormatEntity() const { +FormatEntity::Entry OptionValue::GetFormatEntity() const { std::lock_guard lock(m_mutex); if

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Adrian Prantl via lldb-commits
@@ -1534,15 +1534,13 @@ bool Debugger::FormatDisassemblerAddress(const FormatEntity::Entry *format, const ExecutionContext *exe_ctx, const Address *addr, Stream &s) { FormatEntity::Entry format

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/142489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Adrian Prantl via lldb-commits
@@ -1534,15 +1534,13 @@ bool Debugger::FormatDisassemblerAddress(const FormatEntity::Entry *format, const ExecutionContext *exe_ctx, const Address *addr, Stream &s) { FormatEntity::Entry format

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread via lldb-commits
github-actions[bot] wrote: @award999 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[Lldb-commits] [lldb] 9d356c3 - Have lldb-dap extension support multi-root workspace (#142470)

2025-06-02 Thread via lldb-commits
Author: award999 Date: 2025-06-02T14:31:40-07:00 New Revision: 9d356c39b7a594a1ce3a27c2487febc382f5a5a7 URL: https://github.com/llvm/llvm-project/commit/9d356c39b7a594a1ce3a27c2487febc382f5a5a7 DIFF: https://github.com/llvm/llvm-project/commit/9d356c39b7a594a1ce3a27c2487febc382f5a5a7.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142489 >From bbdaa75ba4baa54d17fb1f8bbf6280b7e4521b84 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 2 Jun 2025 14:16:23 -0700 Subject: [PATCH 1/2] [lldb] Fix data race in statusline format handling

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread via lldb-commits
@@ -280,6 +280,12 @@ SBError Driver::ProcessArgs(const opt::InputArgList &args, bool &exiting) { } if (args.hasArg(OPT_wait_for)) { +if (!args.hasArg(OPT_attach_name) || !args.hasArg(OPT_attach_pid)) { jimingham wrote: Process::Attach does: ``` ll

[Lldb-commits] [lldb] Make stop-hooks fire when lldb first gains control of a process. (PR #137410)

2025-06-02 Thread via lldb-commits
jimingham wrote: Try: diff --git a/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py b/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py index b71f3421f983..782d6f2004ea 100644 --- a/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py +++ b/lldb/test/A

[Lldb-commits] [lldb] Have lldb-dap extension support multi-root workspace (PR #142470)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-06-02 Thread David Peixotto via lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +// Helper function to perform an action on each matching plugin. +// The action callback is given the containing namespace along with plugin info +// for each matching plugi

[Lldb-commits] [clang] [lldb] [Clang][PowerPC] Add __dmr type and DMF integer calculation builtins (PR #142480)

2025-06-02 Thread Maryam Moghadas via lldb-commits
https://github.com/maryammo created https://github.com/llvm/llvm-project/pull/142480 Define the __dmr type used to manipulate the new DMR registers introduced by the Dense Math Facility (DMF) on PowerPC, and add six Clang builtins that correspond to the integer outer-product accumulate to ACC

[Lldb-commits] [clang] [lldb] [Clang][PowerPC] Add __dmr type and DMF integer calculation builtins (PR #142480)

2025-06-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Maryam Moghadas (maryammo) Changes Define the __dmr type used to manipulate the new DMR registers introduced by the Dense Math Facility (DMF) on PowerPC, and add six Clang builtins that correspond to the integer outer-product accumulate t

[Lldb-commits] [clang] [lldb] [Clang][PowerPC] Add __dmr type and DMF integer calculation builtins (PR #142480)

2025-06-02 Thread Maryam Moghadas via lldb-commits
https://github.com/maryammo edited https://github.com/llvm/llvm-project/pull/142480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added support to load DW_ranges section (PR #142356)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix data race in statusline format handling (PR #142489)

2025-06-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/142489 >From bbdaa75ba4baa54d17fb1f8bbf6280b7e4521b84 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 2 Jun 2025 14:16:23 -0700 Subject: [PATCH 1/3] [lldb] Fix data race in statusline format handling

[Lldb-commits] [lldb] [lldb] Emit an error when using --wait-for without a name or pid (PR #142424)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix SIGSEGV in `GetPtraceScope()` in `Procfs.cpp` (PR #142224)

2025-06-02 Thread Pavel Labath via lldb-commits
@@ -74,7 +74,7 @@ lldb_private::process_linux::GetAvailableLogicalCoreIDs() { llvm::Expected lldb_private::process_linux::GetPtraceScope() { ErrorOr> ptrace_scope_file = getProcFile("sys/kernel/yama/ptrace_scope"); - if (!*ptrace_scope_file) + if (!ptrace_scope_file)

[Lldb-commits] [clang] [lldb] [lldb] Add filter option to AST dump command (PR #142164)

2025-06-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/142164 >From 662e07aa9bb6560f37c079ba6f13be17e7885b48 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 30 May 2025 15:44:09 +0100 Subject: [PATCH 1/6] [clang][Frontend] Add overload to ASTPrinter that doesn't

  1   2   >