Author: Michael Buch
Date: 2025-05-30T11:48:55+01:00
New Revision: 76bd5da3248fd4affedfefec3b2a3e1acbe0a94a
URL:
https://github.com/llvm/llvm-project/commit/76bd5da3248fd4affedfefec3b2a3e1acbe0a94a
DIFF:
https://github.com/llvm/llvm-project/commit/76bd5da3248fd4affedfefec3b2a3e1acbe0a94a.diff
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/142129
compare the instructions before and after setting breakpoint to make sure they
are the same.
Do not use the source location as it is not guaranteed to exist.
>From 4c0bd999e60b7082fb30916c5f20d7ab064e76fe Mon
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/142143
After https://github.com/llvm/llvm-project/pull/141670, TestLinuxCore.py was
timing out on our Windows on Arm bot.
Non-Linux core files were ok, as were Linux core files unless it was ppc64le,
riscv64 or
Author: David Spickett
Date: 2025-05-30T14:14:38+01:00
New Revision: 3745e051be6ff7c2464f775f06a71bee79eaf16f
URL:
https://github.com/llvm/llvm-project/commit/3745e051be6ff7c2464f775f06a71bee79eaf16f
DIFF:
https://github.com/llvm/llvm-project/commit/3745e051be6ff7c2464f775f06a71bee79eaf16f.diff
Author: Charles Zablit
Date: 2025-05-30T14:27:17+01:00
New Revision: aaa9c19328b23319eb1b50789d9478f31dee09b1
URL:
https://github.com/llvm/llvm-project/commit/aaa9c19328b23319eb1b50789d9478f31dee09b1
DIFF:
https://github.com/llvm/llvm-project/commit/aaa9c19328b23319eb1b50789d9478f31dee09b1.diff
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/140761
>From 9ee1b6137acc6d74dba6d27aafd2395b7ec87075 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 21 May 2025 17:32:48 +0200
Subject: [PATCH] [LLDB] Avoid crashes when inspecting MS STL types
---
.../Language/C
Michael137 wrote:
> This test was failing on Windows I think because like many others, we're not
> making DWARF or we're not retaining it when linking with link.exe. I've
> skipped it there -
> [7a66b28](https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127).
Th
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/142164
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/142164
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/142164
Depends on https://github.com/llvm/llvm-project/pull/142163
This patch makes the `-ast-dump-filter` Clang option available to the
`target modules dump ast` command. This allows us to selectively dump
parts of
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
Depends on https://github.com/llvm/llvm-project/pull/142163
This patch makes the `-ast-dump-filter` Clang option available to the
`target modules dump ast` command. This allows us to selectively dump
parts
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Depends on https://github.com/llvm/llvm-project/pull/142163
This patch makes the `-ast-dump-filter` Clang option available to the
`target modules dump ast` command. This allows us to selectively dump
parts
@@ -2235,11 +2235,22 @@ class CommandObjectTargetModulesDumpClangAST
: CommandObjectTargetModulesModuleAutoComplete(
interpreter, "target modules dump ast",
"Dump the clang ast for a given module's symbol file.",
-//"target modules dump
Michael137 wrote:
@Nerixyz do you need us to merge this for you?
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8511,8 +8512,16 @@ TypeSystemClang::dump(lldb::opaque_compiler_type_t type)
const {
}
#endif
-void TypeSystemClang::Dump(llvm::raw_ostream &output) {
- GetTranslationUnitDecl()->dump(output);
+void TypeSystemClang::Dump(llvm::raw_ostream &output,
+
@@ -8511,8 +8512,16 @@ TypeSystemClang::dump(lldb::opaque_compiler_type_t type)
const {
}
#endif
-void TypeSystemClang::Dump(llvm::raw_ostream &output) {
- GetTranslationUnitDecl()->dump(output);
+void TypeSystemClang::Dump(llvm::raw_ostream &output,
+
fche wrote:
Neat. So much boilerplate for one new plugin mechanism, just to enable three
or four lines actually on topic!
https://github.com/llvm/llvm-project/pull/141773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
Jlalond wrote:
Hey @DavidSpickett thanks for fixing the test.
I think you fixed it the right way, but I wanted to share my understanding of
how this probably happened
In ProcessElfCore, we check the siginfo status of all the threads
```
if (!siginfo_signal_found) {
// If we don't have s
DavidSpickett wrote:
Sorry, the above failure is a different assumption.
Our disassembly test failure is:
```
==
FAIL: test_disassemble (TestDAP_disassemble.TestDAP_disassemble)
Tests the 'disassemble' request.
--
DavidSpickett wrote:
> The memory reference can have a corresponding source location. if there is
> debuginfo installed on the computer or it is downloaded with debuginfod.
Sounds like the failure we see:
```
FAIL: test_generic_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
--
Author: David Spickett
Date: 2025-05-30T08:48:29Z
New Revision: 114192f586f70d1f7ac91da88061e39524c98ca3
URL:
https://github.com/llvm/llvm-project/commit/114192f586f70d1f7ac91da88061e39524c98ca3
DIFF:
https://github.com/llvm/llvm-project/commit/114192f586f70d1f7ac91da88061e39524c98ca3.diff
LOG
DavidSpickett wrote:
Reverted, please take a look and fix. Reproducing should be possible by
installing the libc debug package, not sure what's going on with the other
failure. Let me know if you need me to investigate it locally.
https://github.com/llvm/llvm-project/pull/141689
__
da-viper wrote:
Changing the test for disassemble to not depend on source location.
#142129
https://github.com/llvm/llvm-project/pull/141689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Nerixyz wrote:
> @Nerixyz do you need us to merge this for you?
Yeah, that would be great!
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/142179.diff
1 Files Affected:
- (modified) lldb/tools/lldb-dap/Handler/SetBreakpointsRequestHandler.cpp
(+1-3)
``diff
diff --git a/lldb/
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Ack. My apt package doesn't install `libxml2-config-version.cmake` so I assume
CMake is falling back on some standard logic for finding it and that would
explain why CMake is happy to use 2.12 on my system.
That said, it seems like this is done intentionally, and this is w
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
See #138083 for details.
---
Full diff: https://github.com/llvm/llvm-project/pull/142192.diff
1 Files Affected:
- (modified)
lldb/test/API/functionalities/breakpoint/consecutive_breakpoints/TestConsecu
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142192
See #138083 for details.
>From 99e4418063a869e0d9bdec784e62c5ebcb569510 Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Fri, 30 May 2025 20:33:49 +0400
Subject: [PATCH] [lldb] Disable TestConsecutiveBrea
https://github.com/Steelskin updated
https://github.com/llvm/llvm-project/pull/142183
>From c517ba1aa6c17de47c125468c047366117a9989a Mon Sep 17 00:00:00 2001
From: Fabrice de Gans
Date: Fri, 30 May 2025 09:27:54 -0700
Subject: [PATCH 1/3] [lldb] Add build option to specify the libxml 2 version
@@ -290,6 +290,45 @@ else()
endif()
endif()
+# Stage all headers in the include directory in the build dir.
bulbazord wrote:
This looks very similar to some logic in `LLDBFramework.cmake`. Do we need this
logic in both places or could it only live here?
h
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142056
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2235,11 +2235,22 @@ class CommandObjectTargetModulesDumpClangAST
: CommandObjectTargetModulesModuleAutoComplete(
interpreter, "target modules dump ast",
"Dump the clang ast for a given module's symbol file.",
-//"target modules dump
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/142179
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/139170
>From c7432d04896c1eea67ed6a6d5f4b4c28941e5a90 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Thu, 8 May 2025 07:38:20 -0700
Subject: [PATCH 1/4] [lldb] Do not create SymbolFileDWARFDebugMap for
non-Mach-O files
royitaqi wrote:
Thanks for the great discussion, @JDevlieghere and @labath. I appreciate it and
am learning a lot by reading through it.
Re. CMakery and document, sorry that I cannot promise to do this by a timeline,
because as a CMake noob I will probably need to learn about it first before I
da-viper wrote:
@JDevlieghere sorry about that, I did assume since it was small. will wait
for the approval hence forth.
https://github.com/llvm/llvm-project/pull/141424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/Steelskin created
https://github.com/llvm/llvm-project/pull/142183
The Swift Windows toolchain uses its own static build of libxml 2, which is
more recent than 2.8, resulting in the provided libxml 2 to be rejected. This
change allows to specify a custom version for libxml 2
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Fabrice de Gans (Steelskin)
Changes
The Swift Windows toolchain uses its own static build of libxml 2, which is
more recent than 2.8, resulting in the provided libxml 2 to be rejected. This
change allows to specify a custom version for lib
Steelskin wrote:
This is how the version file is configured in libxml2:
https://github.com/GNOME/libxml2/blob/0740a367a570c40246fe8077c2d172b63693f105/CMakeLists.txt#L596
```cmake
write_basic_package_version_file(
${CMAKE_CURRENT_BINARY_DIR}/libxml2-config-version.cmake
VERSION $
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/142179
None
>From 68b17403353418674681a79e1d41fa57ae848db2 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Fri, 30 May 2025 16:56:18 +0100
Subject: [PATCH] [NFC][lldb-dap] remove unnecessary copy.
---
lldb/tools/l
https://github.com/Steelskin updated
https://github.com/llvm/llvm-project/pull/142183
>From c517ba1aa6c17de47c125468c047366117a9989a Mon Sep 17 00:00:00 2001
From: Fabrice de Gans
Date: Fri, 30 May 2025 09:27:54 -0700
Subject: [PATCH 1/2] [lldb] Add build option to specify the libxml 2 version
JDevlieghere wrote:
Could the problem be that the statically linked libxml2 is reporting the wrong
version or something? We don't pass the `EXACT` flag, which means that CMake
will find a version that "is compatible" [1]. The latter is intentionally vague
and I couldn't immediately find the co
@@ -51,13 +51,18 @@ macro(add_optional_dependency variable description package
found)
message(STATUS "${description}: ${${variable}}")
endmacro()
+set(LLDB_LIBXML2_VERSION "2.8" CACHE STRING
+ "Sepcify the version of libxml 2 to use with LLDB. This is only meant to be
ove
https://github.com/Steelskin updated
https://github.com/llvm/llvm-project/pull/142183
>From c517ba1aa6c17de47c125468c047366117a9989a Mon Sep 17 00:00:00 2001
From: Fabrice de Gans
Date: Fri, 30 May 2025 09:27:54 -0700
Subject: [PATCH 1/4] [lldb] Add build option to specify the libxml 2 version
@@ -51,13 +51,18 @@ macro(add_optional_dependency variable description package
found)
message(STATUS "${description}: ${${variable}}")
endmacro()
+set(LLDB_LIBXML2_VERSION "2.8" CACHE STRING
+ "Sepcify the version of libxml 2 to use with LLDB. This is only meant to be
ove
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142193
See #138084 for details.
>From 72e166aa5f1d851cfd0cc972e761536eed14679a Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Fri, 30 May 2025 22:19:28 +0400
Subject: [PATCH] [lldb] Disable TestReverseContinue
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
See #138084 for details.
---
Full diff: https://github.com/llvm/llvm-project/pull/142193.diff
2 Files Affected:
- (modified)
lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoin
llvmbot wrote:
@llvm/pr-subscribers-platform-windows
Author: Dmitry Vasilyev (slydiman)
Changes
See #138084 for details.
---
Full diff: https://github.com/llvm/llvm-project/pull/142193.diff
2 Files Affected:
- (modified)
lldb/test/API/functionalities/reverse-execution/TestReverseConti
Steelskin wrote:
> Ack. My apt package doesn't install `libxml2-config-version.cmake` so I
> assume CMake is falling back on some standard logic for finding it and that
> would explain why CMake is happy to use 2.12 on my system.
>
> That said, it seems like this is done intentionally, and thi
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/142183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
compare the instructions before and after setting breakpoint to make sure they
are the same.
Do not use the source location as it is not guaranteed to exist.
---
Full diff: https://github.com/llvm/llvm-proje
Author: Ebuka Ezike
Date: 2025-05-30T13:13:42+01:00
New Revision: af163a1c7f9d9c24521460a24b1d41a9b4b75ce8
URL:
https://github.com/llvm/llvm-project/commit/af163a1c7f9d9c24521460a24b1d41a9b4b75ce8
DIFF:
https://github.com/llvm/llvm-project/commit/af163a1c7f9d9c24521460a24b1d41a9b4b75ce8.diff
L
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/142139
This patch removes a redundant check in DemangledNameInfo::hasBasename.
Since the start and end range are unsigned, if end > start, then end is always
greater than 0.
>From 738d0058769811d6f760f0a351a43
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
Changes
This patch removes a redundant check in DemangledNameInfo::hasBasename.
Since the start and end range are unsigned, if end > start, then end is
always greater than 0.
---
Full diff: https://github.c
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/141122
>From 9408d17b1acf308c7a299bdc6c413a3505d1a039 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Wed, 21 May 2025 23:26:14 +0100
Subject: [PATCH 01/10] [lldb][lldb-dap] support DataBreakpointBytes capability
--
Author: David Spickett
Date: 2025-05-30T14:15:19Z
New Revision: 7a66b28fcafdb7546aedeca1271e66438ad04127
URL:
https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127
DIFF:
https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127.diff
LOG
DavidSpickett wrote:
This test was failing on Windows I think because like many others, we're not
making DWARF or we're not retaining it when linking with link.exe. I've skipped
it there -
https://github.com/llvm/llvm-project/commit/7a66b28fcafdb7546aedeca1271e66438ad04127.
https://github.com
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/142143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
After https://github.com/llvm/llvm-project/pull/141670, TestLinuxCore.py was
timing out on our Windows on Arm bot.
Non-Linux core files were ok, as were Linux core files unless it was ppc64le,
riscv6
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/142200
>From 05f09fa434c7fa925935337fb44740f1beba52ba Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 30 May 2025 12:02:02 -0700
Subject: [PATCH 1/2] Flip and add test
---
.../Plugins/Platform/Linux/PlatformL
Author: nerix
Date: 2025-05-30T20:43:53+01:00
New Revision: 9e9626b3d5aa56828b71b03d99bf3167fdfeb08d
URL:
https://github.com/llvm/llvm-project/commit/9e9626b3d5aa56828b71b03d99bf3167fdfeb08d
DIFF:
https://github.com/llvm/llvm-project/commit/9e9626b3d5aa56828b71b03d99bf3167fdfeb08d.diff
LOG: [L
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-05-30T12:46:34-07:00
New Revision: 03d1f3d7e34d3420b8ddafa7e6df0c1d8ad13c41
URL:
https://github.com/llvm/llvm-project/commit/03d1f3d7e34d3420b8ddafa7e6df0c1d8ad13c41
DIFF:
https://github.com/llvm/llvm-project/commit/03d1f3d7e34d3420b8ddafa7e6df0c1d8
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/142052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,10 @@
+#include
dmpots wrote:
The location of this test is under the "Register" directory, which looks like
it is for testing things like `register read`. Since this is not about
examining registers can we find a more suitable location?
https://git
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/142164
>From 662e07aa9bb6560f37c079ba6f13be17e7885b48 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 30 May 2025 15:44:09 +0100
Subject: [PATCH 1/5] [clang][Frontend] Add overload to ASTPrinter that doesn't
@@ -0,0 +1,6 @@
+# XFAIL: system-darwin
dmpots wrote:
Why is this expected to fail on darwin and windows? Can we use `REQUIRES` to
only run it on supported platforms?
https://github.com/llvm/llvm-project/pull/142200
_
@@ -290,6 +290,45 @@ else()
endif()
endif()
+# Stage all headers in the include directory in the build dir.
chelcassanova wrote:
The logic of finding all the headers for staging them in a directory should be
able to live here alone. The idea is that the fr
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/142164
>From 662e07aa9bb6560f37c079ba6f13be17e7885b48 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 30 May 2025 15:44:09 +0100
Subject: [PATCH 1/4] [clang][Frontend] Add overload to ASTPrinter that doesn't
@@ -0,0 +1,6 @@
+# XFAIL: system-darwin
Jlalond wrote:
Can you give me an example @dmpots? I would want to run this only on Linux
https://github.com/llvm/llvm-project/pull/142200
___
lldb-commits mailing list
lldb-comm
@@ -0,0 +1,10 @@
+#include
Jlalond wrote:
I do think it's weird. Strangely enough all the existing SIGINFO shell tests
also live in this directory. I think it would lead to more confusion to break
that, but it's a great refactoring opportunity
https://github
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/7] Reuse creation of Source objects for assembly and normal
sourc
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -139,15 +141,16 @@ static DisassembledInstruction
ConvertSBInstructionToDisassembledInstruction(
disassembled_inst.instruction = std::move(instruction);
- auto line_entry = addr.GetLineEntry();
+ auto source = CreateSource(addr, target);
+ auto line_entry = GetLineEn
@@ -0,0 +1,17 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
https://github.com/ashgti approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/140470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/142200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti commented:
Can we also move
https://github.com/llvm/llvm-project/blob/f7e172da4caeab9d92f6e97501b1a2c561e616c1/lldb/test/API/tools/lldb-dap/disassemble/main.c#L9
to line 11?
That should help us land on a location with a line associated with it.
https://github.com/llv
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/142051
>From dd86d088d6fb8b7632f310e2011c2031766ebf27 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 28 May 2025 15:45:45 -0700
Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Despite a great review from @labath, I accidentally landed the signal
with the UID and PID properties flipped. I was actually trying to write tests
for this feature when I discovered it.
This fixes that bu
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/142051
>From 4064ae7a71171f0c6d95826aff478ceabf036869 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 28 May 2025 15:45:45 -0700
Subject: [PATCH] [lldb][headers] Create Python script to fix up framewo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/test/Shell/Register/Core/Inputs/tkill.cpp
``
ashgti wrote:
> This PR seemingly made `disableASLR` default to `True` again.
doh... I'll fix this when I make a new attempt at merging this PR in.
> Reverted, please take a look and fix. Reproducing should be possible by
> installing the libc debug package, not sure what's going on with the o
@@ -0,0 +1,117 @@
+#!/usr/bin/env python3
+
+"""
+Usage:
+
+This script is used when building LLDB.framework or LLDBRPC.framework. For
each framework, local includes are converted to their respective framework
includes.
+
+This script is used in 2 ways:
+1. It is used on heade
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
ashgti wrote:
I meant should the file be `lldb/tools/lldb-dap/ProtocolUtils.{h,cpp}`
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/137793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,10 @@
+#include
dmpots wrote:
> Strangely enough all the existing SIGINFO shell tests also live in this
> directory
FWIW, I do see a
[command-thread-siginfo.test](https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/Commands/command-threa
1 - 100 of 177 matches
Mail list logo
