[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-27 Thread Pavel Labath via lldb-commits
@@ -723,22 +703,23 @@ SBBreakpoint SBTarget::BreakpointCreateByLocation( LLDB_INSTRUMENT_VA(this, sb_file_spec, line, column, offset, sb_module_list); SBBreakpoint sb_bp; - TargetSP target_sp(GetSP()); - if (target_sp && line != 0) { -std::lock_guard guard(target_sp-

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: > That's the part where I'm not sure either This PR is strictly better than before, so it's fine as it is. https://github.com/llvm/llvm-project/pull/141290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-27 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > But lets add a test to confirm that no plugin currently handles the new > `FunctionPrefix` variable Sorry I forgot about the test, will add it 👍 https://github.com/llvm/llvm-project/pull/140762 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The change looks reasonable. Can we test this (on Windows)? https://github.com/llvm/llvm-project/pull/141529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] DisassembleRequestHandler: use a better invalid instruction (PR #141463)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
@@ -847,8 +847,15 @@ bool fromJSON(const llvm::json::Value &Params, DisassembledInstruction &DI, } llvm::json::Value toJSON(const DisassembledInstruction &DI) { - llvm::json::Object result{{"address", "0x" + llvm::utohexstr(DI.address)}, -{"instru

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-27 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/140762 >From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Tue, 20 May 2025 17:45:20 +0100 Subject: [PATCH 1/5] refactor demangler range tracking --- lldb/include

[Lldb-commits] [lldb] [lldb][docs][NFC] Remove references to obsolete gnu-libstdc++ category (PR #141610)

2025-05-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/141610 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-27 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/140762 >From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Tue, 20 May 2025 17:45:20 +0100 Subject: [PATCH 1/6] refactor demangler range tracking --- lldb/include

[Lldb-commits] [lldb] [lldb-dap] DisassembleRequestHandler: use a better invalid instruction (PR #141463)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141463 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: There's a very good chance this is breaking a lot of tests on mac: https://green.lab.llvm.org/job/as-lldb-cmake/26580/console Could you have a look? The only other commit there is a table gen warning fix https://github.com/llvm/llvm-project/pull/140150 ___

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @felipepiovezan I am indeed the problem here. I'm confused how they're passing on Linux but failing on Mac. I'll investigate. https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] c0a8723 - [LLDB] Show exit code on Windows if process can't launch (#141290)

2025-05-27 Thread via lldb-commits
Author: nerix Date: 2025-05-27T13:16:03-07:00 New Revision: c0a87231069452dfeaf9f2601bb30a3f5e7eb840 URL: https://github.com/llvm/llvm-project/commit/c0a87231069452dfeaf9f2601bb30a3f5e7eb840 DIFF: https://github.com/llvm/llvm-project/commit/c0a87231069452dfeaf9f2601bb30a3f5e7eb840.diff LOG: [L

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/141290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-27 Thread via lldb-commits
Nerixyz wrote: > @Nerixyz Do you need someone to merge this on your behalf? Yes. https://github.com/llvm/llvm-project/pull/141290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-27 Thread via lldb-commits
Nerixyz wrote: >(on Windows)? That's the hard part 😅. I tried to get https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py to run on Windows, but it's too flaky. From my observation, the debug adapter is too fast at launching the program before

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/2] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @petrhosek Hey Petr, can you provide more information? For Linux environments, SI_DETHREAD should be present. The commit for this signal specifically is 13 years old, @DavidSpickett do you have any insight as to why this is happening? https://github.com/torvalds/linux/commit/8a

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-27 Thread John Harrison via lldb-commits
ashgti wrote: This was split out from #140777 to make a smaller commit. https://github.com/llvm/llvm-project/pull/141689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-05-27 Thread via lldb-commits
gulfemsavrun wrote: Any update about the issue that I reported above? https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: This looks like a good candidate for a [release note](https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb). You can add that here or in a follow up PR. https://github.com/llvm/llvm-project/pull/140150 ___

[Lldb-commits] [lldb] [lldb] Support riscv32 ELF corefiles (PR #115408)

2025-05-27 Thread via lldb-commits
@@ -0,0 +1,185 @@ +//===-- RegisterInfos_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From a6c3566dc11b27caaf98f1ae3c45fe30a4ee8d34 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [LLDB] Unify DWARF section name matching (PR #141344)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Neat, LGTM https://github.com/llvm/llvm-project/pull/141344 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From 8732082e1c688e335c6bf42701fc064abe5de1a5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-27 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/141543 >From 75f0f1463c7bcabb5ffef34c0f1e1c0b4ca91b04 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 27 May 2025 12:10:36 +0800 Subject: [PATCH 1/2] [libc++][lldb-dap][test] Fix CI for bootstrapping-build

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/test/Shell/RPC/Generator/Inputs/Server/CheckBa

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-27 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-27 Thread via lldb-commits
Nerixyz wrote: > I wondered if we could say `exited with NTSTATUS `, but I'm not sure > if all exit codes in this scenario would be NTSATUS or only a subset. That's the part where I'm not sure either, but as you mentioned, googling for the exit code usually gets you to the right destination.

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-27 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: > Added some delay You did, but to the wrong place. What I'm trying to ensure is that the child process does not exit before we can observe it. This makes that failure mode even likelier. Take a look at the suggested edits to see what I had in mind. https

[Lldb-commits] [lldb] 9392652 - [lldb][docs][NFC] Remove references to obsolete gnu-libstdc++ category (#141610)

2025-05-27 Thread via lldb-commits
Author: Michael Buch Date: 2025-05-27T18:08:17+01:00 New Revision: 9392652226003083dd2221dd17d6d972f3eac2a7 URL: https://github.com/llvm/llvm-project/commit/9392652226003083dd2221dd17d6d972f3eac2a7 DIFF: https://github.com/llvm/llvm-project/commit/9392652226003083dd2221dd17d6d972f3eac2a7.diff

[Lldb-commits] [lldb] [lldb][docs][NFC] Remove references to obsolete gnu-libstdc++ category (PR #141610)

2025-05-27 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/23267 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-27 Thread Michael Buch via lldb-commits
@@ -320,293 +319,3 @@ TEST(MangledTest, NameIndexes_FindFunctionSymbols) { EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeBase)); EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeMethod)); } Michael137 wrote: Did something go wrong with renaming th

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-27 Thread Pavel Labath via lldb-commits
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) { ASSERT_THAT(exit_status.get_future().get(), 0); } +TEST(Host, FindProcesses) { + SubsystemRAII subsystems; + + if (test_arg != 0) +exit(0); + + ProcessLaunchInfo info; + ProcessInstanceInfoList processes; + Pro

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-27 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/135778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @DavidSpickett I'll make a follow up patch! https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ff7bb17 - [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (#140150)

2025-05-27 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-05-27T09:13:50-07:00 New Revision: ff7bb17c88328276323603809d5d4549ca8bd22b URL: https://github.com/llvm/llvm-project/commit/ff7bb17c88328276323603809d5d4549ca8bd22b DIFF: https://github.com/llvm/llvm-project/commit/ff7bb17c88328276323603809d5d4549ca8bd22b.diff

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-27 Thread John Harrison via lldb-commits
ashgti wrote: Maybe we should update https://github.com/llvm/llvm-project/blob/ff7bb17c88328276323603809d5d4549ca8bd22b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py#L859C9-L859C20 to default to `False` instead of `True`? https://github.com/llvm/llvm-project/pull/141543

[Lldb-commits] [lldb] [lldb] Support riscv32 ELF corefiles (PR #115408)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > 1. This went in without tests, intentional? Intentional insofar that I cannot share the core files I tested this against, and that I don't know/have a way to generate one that I can check in. > 2. Seems like a release note worthy feature. I can add a release note 👍 htt

[Lldb-commits] [lldb] [lldb][lldb-dap] Support breakpoint info bytes (PR #141122)

2025-05-27 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [lldb] Support riscv32 ELF corefiles (PR #115408)

2025-05-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: @asb might have a IRSC-V Linux system handy to generate a core file from. `lldb/test/API/functionalities/postmortem/elf-core/main_fpr.c` would cover GPR and FPR, I think that's all we need here. It can be added to `lldb/test/API/functionalities/postmortem/elf-core/TestLinu

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-27 Thread Michael Buch via lldb-commits
Michael137 wrote: > Maybe we should update > https://github.com/llvm/llvm-project/blob/ff7bb17c88328276323603809d5d4549ca8bd22b/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py#L859C9-L859C20 > to default to `False` instead of `True`? Yea i think that's the best way forward h

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. +1 on what @labath said https://github.com/llvm/llvm-project/pull/141478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Generally makes sense But lets add a test to confirm that no plugin currently handles the new `FunctionPrefix` variable https://github.com/llvm/llvm-project/pull/140762 ___ lldb-commits mailing list lldb-commi

<    1   2