@@ -1668,6 +1668,26 @@ SBError SBTarget::SetLabel(const char *label) {
return Status::FromError(target_sp->SetLabel(label));
}
+uint32_t SBTarget::GetMinimumOpcodeByteSize() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ TargetSP target_sp(GetSP());
+ if (target_sp) {
+retur
https://github.com/JDevlieghere commented:
As a general comment, the code is becoming quite complicated and I think it
would help if we can break things up more. Looking at the protocol arguments we
have and offset in bytes, an offset in instructions, and then an instruction
count. If possible
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
JDevlieghere wrote:
Maybe add a comment saying that this is the _number_ of instructio
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
gmock doesn't let you do anything that wouldn't be possible without it. For
this to work, the code which interacts with the mock needs to be ready to
accept something other than the real object somehow. That usually means
making the mocked object polymorphic, but that is a no
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux`
running on `fuchsia-debian-64-us-central1-b-1` while building `lldb` at step 4
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/11/builds/15495
Here is the relevant p
@@ -627,6 +627,60 @@ struct InstructionBreakpoint {
bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &,
llvm::json::Path);
+/// Properties of a single disassembled instruction, returned by `disassemble`
+/// request.
+struct DisassembledInstruction
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ita-sc wrote:
Thanks for review.
Could you please merge this? (I do not have write access yet)
https://github.com/llvm/llvm-project/pull/139916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/2] [lldb-dap] Migrate disassemble request to structured
handler
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/3] [lldb-dap] Migrate disassemble request to structured
handler
@@ -627,6 +627,60 @@ struct InstructionBreakpoint {
bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &,
llvm::json::Path);
+/// Properties of a single disassembled instruction, returned by `disassemble`
+/// request.
+struct DisassembledInstruction
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions,
condition=None, hitCondition=None)
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.w
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/140466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -782,4 +785,89 @@ bool fromJSON(const llvm::json::Value &Params,
InstructionBreakpoint &IB,
O.mapOptional("mode", IB.mode);
}
+bool fromJSON(const llvm::json::Value &Params,
+ DisassembledInstruction::PresentationHint &PH,
+ llvm::json::P
labath wrote:
I think I've found a(nother) problem with this change. One of the arguments of
the launch request is `sourceMap`, which sets the `target.source-map` setting.
The setting is necessary to correctly resolve file+line breakpoints in case the
file's path on the host system does not ma
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/140466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-05-19T06:18:37-07:00
New Revision: 25da043c55e25d066a5aa8af6ca14cf82a845eb2
URL:
https://github.com/llvm/llvm-project/commit/25da043c55e25d066a5aa8af6ca14cf82a845eb2
DIFF:
https://github.com/llvm/llvm-project/commit/25da043c55e25d066a5aa8af6ca14cf82a845eb2.diff
L
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/139554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference):
}
return self.send_recv(command_dict)
-def request_testGetTargetBreakpoints(self):
+def request_testGetTargetBreakpoints(self, only_resolved=False):
eronnen wrote:
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/140256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
FWIW, https://github.com/llvm/llvm-project/pull/140331 fixes this. I was
looking at the test coverage, and it seems that the only test making use of
this is TestDAP_setBreakpoints.py. It superficially looks like it should catch
this, but after trying it out, it seems that it does
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 01/11] [lldb]Make `list` command work with headers when
possible.
-
@@ -1113,17 +1123,25 @@ class CommandObjectSourceList : public
CommandObjectParsed {
ModuleSpec module_spec(module_file_spec);
matching_modules.Clear();
target.GetImages().FindModules(module_spec, matching_modules);
-num_matches
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 01/11] [lldb]Make `list` command work with headers when
possible.
-
Author: Vy Nguyen
Date: 2025-05-19T11:04:01-04:00
New Revision: dc25ab389c2d441ba378d4db56a4a61e3eedb889
URL:
https://github.com/llvm/llvm-project/commit/dc25ab389c2d441ba378d4db56a4a61e3eedb889
DIFF:
https://github.com/llvm/llvm-project/commit/dc25ab389c2d441ba378d4db56a4a61e3eedb889.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/3] [lldb-dap] Migrate disassemble request to structured
handler
@@ -99,15 +99,15 @@ class InputChunk {
// the beginning of the output section this chunk was assigned to.
int32_t outSecOff = 0;
- uint8_t sectionKind : 3;
+ uint32_t sectionKind : 3;
sbc100 wrote:
Can you explain why `uint32_t` is better than `uint8_t`
@@ -99,15 +99,15 @@ class InputChunk {
// the beginning of the output section this chunk was assigned to.
int32_t outSecOff = 0;
- uint8_t sectionKind : 3;
+ uint32_t sectionKind : 3;
sbc100 wrote:
(Perhaps some background in the PR description would be
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference):
}
return self.send_recv(command_dict)
-def request_testGetTargetBreakpoints(self):
+def request_testGetTargetBreakpoints(self, only_resolved=False):
ashgti wrote:
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -726,6 +726,41 @@ struct SetDataBreakpointsResponseBody {
};
llvm::json::Value toJSON(const SetDataBreakpointsResponseBody &);
+/// Arguments to `disassemble` request.
+struct DisassembleArguments {
+ /// Memory reference to the base location containing the instructions to
@@ -782,4 +785,89 @@ bool fromJSON(const llvm::json::Value &Params,
InstructionBreakpoint &IB,
O.mapOptional("mode", IB.mode);
}
+bool fromJSON(const llvm::json::Value &Params,
+ DisassembledInstruction::PresentationHint &PH,
+ llvm::json::P
@@ -782,4 +785,89 @@ bool fromJSON(const llvm::json::Value &Params,
InstructionBreakpoint &IB,
O.mapOptional("mode", IB.mode);
}
+bool fromJSON(const llvm::json::Value &Params,
+ DisassembledInstruction::PresentationHint &PH,
+ llvm::json::P
@@ -782,4 +785,89 @@ bool fromJSON(const llvm::json::Value &Params,
InstructionBreakpoint &IB,
O.mapOptional("mode", IB.mode);
}
+bool fromJSON(const llvm::json::Value &Params,
+ DisassembledInstruction::PresentationHint &PH,
+ llvm::json::P
@@ -726,6 +726,41 @@ struct SetDataBreakpointsResponseBody {
};
llvm::json::Value toJSON(const SetDataBreakpointsResponseBody &);
+/// Arguments to `disassemble` request.
+struct DisassembleArguments {
+ /// Memory reference to the base location containing the instructions to
@@ -132,19 +56,14 @@ void DisassembleRequestHandler::operator()(
}
}
- lldb::SBInstructionList insts =
- dap.target.ReadInstructions(addr, inst_count, flavor_string.c_str());
+ lldb::SBInstructionList insts = dap.target.ReadInstructions(
+ addr, args.instruct
ashgti wrote:
I'll take a look at the currently disabled DAP tests and see if we can enable
more of them.
https://github.com/llvm/llvm-project/pull/138219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140566
Add a simple unit test for the ContinueRequestHandler that checks that it
returns an error when the (dummy process) is not stopped.
>From bf60439a35bb339d706efec7a3e78dc238d71cf6 Mon Sep 17 00:00:00 2001
F
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add a simple unit test for the ContinueRequestHandler that checks that it
returns an error when the (dummy process) is not stopped.
---
Full diff: https://github.com/llvm/llvm-project/pull/140566.di
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/140142
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
I'll close this for now. We can revisit this in the future if we think
listening more broadly for events is beneficial.
https://github.com/llvm/llvm-project/pull/140142
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
@@ -782,4 +785,89 @@ bool fromJSON(const llvm::json::Value &Params,
InstructionBreakpoint &IB,
O.mapOptional("mode", IB.mode);
}
+bool fromJSON(const llvm::json::Value &Params,
+ DisassembledInstruction::PresentationHint &PH,
+ llvm::json::P
https://github.com/da-viper requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,16 @@
+#include
da-viper wrote:
```suggestion
```
not needed to reduce test times
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -34,26 +36,22 @@ SourceRequestHandler::Run(const protocol::SourceArguments
&args) const {
return llvm::make_error(
"invalid arguments, expected source.sourceReference to be set");
- lldb::SBProcess process = dap.target.GetProcess();
- // Upper 32 bits is the
@@ -0,0 +1,55 @@
+"""
+Test lldb-dap setBreakpoints request
+"""
+
+
+import dap_server
+import shutil
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import line_number
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class Test
https://github.com/ashgti approved this pull request.
LGTM.
Is there anyway we can make a mock or something for the SBProcess? That would
be helpful for these tests, but I am not sure if we have that somewhere in the
lldb testing utilities or not already.
https://github.com/llvm/llvm-project/
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/140566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Is there anyway we can make a mock or something for the SBProcess? That would
> be helpful for these tests, but I am not sure if we have that somewhere in
> the lldb testing utilities or not already.
We have a few unit tests that inherit from `lldb_private::Process` for m
@@ -955,6 +955,13 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"""
(dir, base) = os.path.split(file_path)
source_dict = {"name": base, "path": file_path}
+return self.request_setBreakpoints_with_source(source_dict,
lin
@@ -0,0 +1,55 @@
+"""
+Test lldb-dap setBreakpoints request
ashgti wrote:
`Test lldb-dap setBreakpoints in assembly source references`?
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lld
@@ -452,6 +475,9 @@ struct DAP {
std::mutex m_active_request_mutex;
const protocol::Request *m_active_request;
+
+ llvm::StringMap m_source_breakpoints;
+ llvm::DenseMap m_source_assembly_breakpoints;
ashgti wrote:
If we made `protocol::Source` work in
@@ -33,13 +35,42 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap,
m_line(breakpoint.line),
m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {}
-void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) {
+void SourceBreakpoint::SetBreak
@@ -0,0 +1,55 @@
+"""
+Test lldb-dap setBreakpoints request
+"""
+
+
+import dap_server
+import shutil
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import line_number
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class Test
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/140065
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/140585
…tion doesn't work properly
>From a694c9b4a249ec541115cebdd9a88e75ce8aceb7 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 19 May 2025 13:38:37 -0400
Subject: [PATCH] [lldb][nfc]Temporarily disable test on
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
…tion doesn't work properly
---
Full diff: https://github.com/llvm/llvm-project/pull/140585.diff
1 Files Affected:
- (modified) lldb/test/Shell/Commands/list-header.test (+2)
``diff
diff --git a/lld
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/140585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-05-19T13:40:38-04:00
New Revision: 1b44eb2f6b862fb171629321bf2f5ec231899c71
URL:
https://github.com/llvm/llvm-project/commit/1b44eb2f6b862fb171629321bf2f5ec231899c71
DIFF:
https://github.com/llvm/llvm-project/commit/1b44eb2f6b862fb171629321bf2f5ec231899c71.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/140585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/140150
>From 86ec6c076b9cf8e7afeb7d6bb0e334434f6e0d9e Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 15 May 2025 13:57:11 -0700
Subject: [PATCH 1/9] Update ThreadElfCore
---
lldb/include/lldb/Target/UnixSign
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/140443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: nerix
Date: 2025-05-19T11:13:49-07:00
New Revision: 3bae8e2ef2ff02dcba745cb47ea1264fd08885cc
URL:
https://github.com/llvm/llvm-project/commit/3bae8e2ef2ff02dcba745cb47ea1264fd08885cc
DIFF:
https://github.com/llvm/llvm-project/commit/3bae8e2ef2ff02dcba745cb47ea1264fd08885cc.diff
LOG: [l
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/140588
None
>From 8bf781af04e046076de1e5d6ebcfcf1f508be211 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 19 May 2025 14:26:36 -0400
Subject: [PATCH] [lldb][nfc]Make test "xfail" on windows
---
lldb/test/Shell/
Author: Vy Nguyen
Date: 2025-05-19T14:28:18-04:00
New Revision: fe1c4827b77a8d39bb1462cb4df08f6fe572097a
URL:
https://github.com/llvm/llvm-project/commit/fe1c4827b77a8d39bb1462cb4df08f6fe572097a
DIFF:
https://github.com/llvm/llvm-project/commit/fe1c4827b77a8d39bb1462cb4df08f6fe572097a.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/140588.diff
1 Files Affected:
- (modified) lldb/test/Shell/Commands/list-header.test (+3-1)
``diff
diff --git a/lldb/test/Shell/Commands/lis
Author: Jonas Devlieghere
Date: 2025-05-19T11:39:19-07:00
New Revision: d8665bb76788790b107c2ed455d691c89987f3f3
URL:
https://github.com/llvm/llvm-project/commit/d8665bb76788790b107c2ed455d691c89987f3f3
DIFF:
https://github.com/llvm/llvm-project/commit/d8665bb76788790b107c2ed455d691c89987f3f3.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/140566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM if @ashgti is happy.
https://github.com/llvm/llvm-project/pull/140162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
@@ -99,15 +99,15 @@ class InputChunk {
// the beginning of the output section this chunk was assigned to.
int32_t outSecOff = 0;
- uint8_t sectionKind : 3;
+ uint32_t sectionKind : 3;
ojhunt wrote:
Unfortunately I can :(
The MS ABI only packs bit-field
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/140493
>From 7bf3ebaa15bdabdef20a2b15933fbb66fa0aaa2c Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Sun, 18 May 2025 20:31:43 -0700
Subject: [PATCH] [NFC] Address more bit-field storage sizes
Follow on work from #13
https://github.com/ojhunt edited
https://github.com/llvm/llvm-project/pull/140493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ojhunt wrote:
Force push with no PR changes other than attaching more information to the
commit message.
https://github.com/llvm/llvm-project/pull/140493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -99,15 +99,15 @@ class InputChunk {
// the beginning of the output section this chunk was assigned to.
int32_t outSecOff = 0;
- uint8_t sectionKind : 3;
+ uint32_t sectionKind : 3;
sbc100 wrote:
By MS ABI I assume you mean mircrosoft?
I guess this
@@ -132,19 +56,14 @@ void DisassembleRequestHandler::operator()(
}
}
- lldb::SBInstructionList insts =
- dap.target.ReadInstructions(addr, inst_count, flavor_string.c_str());
+ lldb::SBInstructionList insts = dap.target.ReadInstructions(
+ addr, args.instruct
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/4] [lldb-dap] Migrate disassemble request to structured
handler
eronnen wrote:
Fixed comments
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,16 @@
+#include
eronnen wrote:
fixed, for some reason I'm getting a warning `ISO C requires a translation unit
to contain at least one declarationclang(-Wempty-translation-unit)` but I can
ignore
https://github.com/llvm/llvm-project/pull/139969
___
@@ -0,0 +1,55 @@
+"""
+Test lldb-dap setBreakpoints request
+"""
+
+
+import dap_server
+import shutil
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import line_number
+from lldbsuite.test import lldbutil
+import lldbdap_testcase
+import os
+
+
+class Test
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/5542 is broken.
Probably you must use `XFAIL: target-windows` instead of `XFAIL:
system-windows`.
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-
@@ -34,26 +36,22 @@ SourceRequestHandler::Run(const protocol::SourceArguments
&args) const {
return llvm::make_error(
"invalid arguments, expected source.sourceReference to be set");
- lldb::SBProcess process = dap.target.GetProcess();
- // Upper 32 bits is the
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
fixing now. thanks!
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 178 matches
Mail list logo
