[Lldb-commits] [lldb] [lldb] Use llvm::replace (NFC) (PR #140343)

2025-05-17 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 68e4f60 - [lldb] Use llvm::replace (NFC) (#140343)

2025-05-17 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-17T09:09:10-07:00 New Revision: 68e4f6090b369c14da8c6ef1f614664b9e0427e1 URL: https://github.com/llvm/llvm-project/commit/68e4f6090b369c14da8c6ef1f614664b9e0427e1 DIFF: https://github.com/llvm/llvm-project/commit/68e4f6090b369c14da8c6ef1f614664b9e0427e1.diff L

[Lldb-commits] [lldb] [lldb] Use llvm::replace (NFC) (PR #140343)

2025-05-17 Thread Tim Gymnich via lldb-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/140343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Member variable cleanup in DAP.{cpp, h} (NFC) (PR #140390)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/140390 - Use in-class member initialization to simplify the constructor. - Remove unimplemented SetConfigurationDone. - Consistently use Doxygen-style comments. >From c546c86ac849f316c9b31b881e92d8683aa5 Mon S

[Lldb-commits] [lldb] [lldb-dap] Member variable cleanup in DAP.{cpp, h} (NFC) (PR #140390)

2025-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes - Use in-class member initialization to simplify the constructor. - Remove unimplemented SetConfigurationDone. - Consistently use Doxygen-style comments. --- Full diff: https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (NFC) (PR #140393)

2025-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Move the Variables struct out of DAP.h and into its own file to reduce the complexity of the latter. This PR also makes the members that are implementation details private. --- Full diff: https://g

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (NFC) (PR #140393)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/140393 Move the Variables struct out of DAP.h and into its own file to reduce the complexity of the latter. This PR also makes the members that are implementation details private. >From 82cd419423f74777e24874353

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (NFC) (PR #140393)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/140393 >From 82cd419423f74777e248743534f2da48ae6b72c9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sat, 17 May 2025 11:34:48 -0700 Subject: [PATCH 1/2] [lldb-dap] Move the Variables struct into its own f

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/140393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/140393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Move the Variables struct into its own file (PR #140393)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/140393 >From 82cd419423f74777e248743534f2da48ae6b72c9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sat, 17 May 2025 11:34:48 -0700 Subject: [PATCH 1/3] [lldb-dap] Move the Variables struct into its own f

[Lldb-commits] [lldb] [lldb-dap] Move the command plugins out of the DAP header (PR #140396)

2025-05-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/140396 Move the command plugins out of the DAP header and into their file. This PR also renames the classes from "RequestHandler" to "Command". Although they are implemented in terms of sending requests, they are

[Lldb-commits] [lldb] [lldb-dap] Move the command plugins out of the DAP header (PR #140396)

2025-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Move the command plugins out of the DAP header and into their file. This PR also renames the classes from "RequestHandler" to "Command". Although they are implemented in terms of sending requests, t

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-17 Thread via lldb-commits
cmtice wrote: I believe I have addressed all the review comments so far. Please take another look. Thanks! https://github.com/llvm/llvm-project/pull/138093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-17 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/138093 >From fe9ac0fa05bb43ea718214746f0ea9b7eefc929a Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 1 May 2025 00:05:57 -0700 Subject: [PATCH 1/4] [LLDB] Add field member operators to DIL Add the arrow and pe