https://github.com/cor3ntin approved this pull request.
The clang parts look like a nice improvement, thanks!
Please wait for a few other people to review it though.
https://github.com/llvm/llvm-project/pull/139584
___
lldb-commits mailing list
lldb-c
@@ -0,0 +1,71 @@
+//===-- NativeThreadAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -107,6 +107,7 @@ class ASTUnit {
private:
std::unique_ptr LangOpts;
+ std::shared_ptr DiagOpts;
cor3ntin wrote:
Can that be unique_ptr ?
https://github.com/llvm/llvm-project/pull/139584
___
lldb-commits maili
@@ -0,0 +1,71 @@
+//===-- NativeThreadAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr FileMgr;
+ std::unique_ptr DiagOpts;
ojhunt wrote:
I don't
@@ -1243,303 +1243,285 @@ bool RegisterContextUnwind::IsTrapHandlerSymbol(
return false;
}
-// Answer the question: Where did THIS frame save the CALLER frame ("previous"
-// frame)'s register value?
-
-enum UnwindLLDB::RegisterSearchResult
-RegisterContextUnwind::SavedLocat
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/102601
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
labath wrote:
> I think our tests are not fully specifying their expected state. For example,
> lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
> `TestDAP_console.test_diagnositcs` was performing an evaluate and then using
> `get_important` to fetch output events with category 'importa
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/nd created https://github.com/llvm/llvm-project/pull/139862
Lock ensures modules don't change during iteration.
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,Blin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (nd)
Changes
Lock ensures modules don't change during iteration.
---
Full diff: https://github.com/llvm/llvm-project/pull/139862.diff
1 Files Affected:
- (modified) lldb/source/Target/Target.cpp (+1)
``diff
diff --git a/l
Author: Pavel Labath
Date: 2025-05-14T11:16:55+02:00
New Revision: 97aa01bef770ec651c86978d137933e09221dd00
URL:
https://github.com/llvm/llvm-project/commit/97aa01bef770ec651c86978d137933e09221dd00
DIFF:
https://github.com/llvm/llvm-project/commit/97aa01bef770ec651c86978d137933e09221dd00.diff
labath wrote:
I'm very much in favor of removing this dependence on the setting value, as I
think it should be handled at a higher level. *However*, I fear this is going
to make printing large std::forward_list very slow. Since computing the size of
the list requires iterating through all the
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/138892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Looks good to me, we should clear them on both attach & launch which is what
> the Darwin DynamicLoader plugin was doing.
>
> I was a little surprised that Minidump is picking up the host native
> DyanmicLoader plugin at all - seems like the static dynamic loader might make
>
Author: Pavel Labath
Date: 2025-05-14T11:29:56+02:00
New Revision: adabc83a92130e556d4d16adaee6e81e09fdf570
URL:
https://github.com/llvm/llvm-project/commit/adabc83a92130e556d4d16adaee6e81e09fdf570
DIFF:
https://github.com/llvm/llvm-project/commit/adabc83a92130e556d4d16adaee6e81e09fdf570.diff
labath wrote:
> Nice unification, thanks. I'm sure the pc=lr rule was me not trusting the
> algorithms over in RegisterContextUnwind to do the right thing if the rule
> wasn't listed. Having just pushed all that code around for a day, I know this
> kind of thing is unneeded, but harmless if it
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/139545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Yeah, this is kind of my fault as I introduced this way back when. I think at
that point we didn't have test-specific headers, which made this option more
appealing.
https://github.com/llvm/llvm-project/pull/138892
___
lldb-commits mail
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/139875
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issue
@@ -111,7 +111,42 @@ ASTNodeUP DILParser::ParseUnaryExpression() {
llvm_unreachable("invalid token kind");
}
}
- return ParsePrimaryExpression();
+ return ParsePostfixExpression();
+}
+
+// Parse a postfix_expression.
+//
+// postfix_expression:
+//primary_ex
https://github.com/labath commented:
I'm sorry, I put this off because it wasn't clear how to respond immediately --
and then it dropped off my radar.
I have a bunch of comments, but overall, I think this could work.
My main objection is to the use of the APInt class. If you want to use it
(w
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
@@ -108,6 +110,26 @@ class UnaryOpNode : public ASTNode {
ASTNodeUP m_operand;
};
+class ArraySubscriptNode : public ASTNode {
+public:
+ ArraySubscriptNode(uint32_t location, ASTNodeUP base, llvm::APInt index)
+ : ASTNode(location, NodeKind::eArraySubscriptNode),
+
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
@@ -81,21 +100,28 @@ llvm::Expected DILLexer::Lex(llvm::StringRef expr,
return Token(Token::eof, "", (uint32_t)expr.size());
uint32_t position = cur_pos - expr.begin();
+ std::optional maybe_number = IsNumber(expr, remainder);
+ if (maybe_number) {
+std::string num
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
@@ -111,7 +111,36 @@ ASTNodeUP DILParser::ParseUnaryExpression() {
llvm_unreachable("invalid token kind");
}
}
- return ParsePrimaryExpression();
+ return ParsePostfixExpression();
+}
+
+// Parse a postfix_expression.
+//
+// postfix_expression:
+//primary_ex
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/138551
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/139875
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Ari
labath wrote:
> Okay, I see the problem, I didn't really think that retrieving the type
> system when debugging Swift code would return C type system. Why is it like
> this though?
It depends on how you retrieve the type system. You were iterating through the
type systems of the target, which
https://github.com/hapee updated
https://github.com/llvm/llvm-project/pull/139278
>From 30318b28b158950b0f8d6c2732831eceb7cefc41 Mon Sep 17 00:00:00 2001
From: hapee <623151...@qq.com>
Date: Fri, 9 May 2025 22:53:03 +0800
Subject: [PATCH] [lldb][test] Fix beginning/end of file test faile
hapee wrote:
> Seems fine, my only question is does the source actually need to be doing
> this much?
>
> Or in other words: the example should be as complex as it needs to be to show
> the bug. If that means just calling the same do-nothing function over and
> over to create more lines,
https://github.com/hapee updated
https://github.com/llvm/llvm-project/pull/139278
>From d1b295748d5bb4666140f37ec6896d8503239cf6 Mon Sep 17 00:00:00 2001
From: hapee <623151...@qq.com>
Date: Fri, 9 May 2025 22:53:03 +0800
Subject: [PATCH] [lldb][test] Fix beginning/end of file test faile
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const ArraySubscriptNode *node) {
+ auto lhs_or_err = Evaluate(node->GetBase());
+ if (!lhs
Author: Pavel Labath
Date: 2025-05-14T15:38:10+02:00
New Revision: 7e7871d3f58b9da72ca180fcd7f0d2da3f92ec4a
URL:
https://github.com/llvm/llvm-project/commit/7e7871d3f58b9da72ca180fcd7f0d2da3f92ec4a
DIFF:
https://github.com/llvm/llvm-project/commit/7e7871d3f58b9da72ca180fcd7f0d2da3f92ec4a.diff
oontvoo wrote:
@labath Hi, do you have any other comment on this? thanks!
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/139817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -837,6 +838,7 @@ class ASTUnit {
static std::unique_ptr LoadFromCommandLine(
const char **ArgBegin, const char **ArgEnd,
std::shared_ptr PCHContainerOps,
+ std::shared_ptr DiagOpts,
cor3ntin wrote:
We probably can pass by reference here
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/139537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1243,303 +1243,285 @@ bool RegisterContextUnwind::IsTrapHandlerSymbol(
return false;
}
-// Answer the question: Where did THIS frame save the CALLER frame ("previous"
-// frame)'s register value?
-
-enum UnwindLLDB::RegisterSearchResult
-RegisterContextUnwind::SavedLocat
DavidSpickett wrote:
> I also needed to remove the brk #0xf000 instruction because lldb is not able
> to step over it -- it just ends up spinning forever. FWICS, it's not actually
> necessary now that you're stepping through the test. Nonetheless, this is a
> bug -- one that @DavidSpickett mig
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/139910
While I am at it, this patch removes the "if" statement.
std::vector::erase(first, last) doesn't do anything when
first == last.
Rate limit · GitHub
body {
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
While I am at it, this patch removes the "if" statement.
std::vector::erase(first, last) doesn't do anything when
first == last.
---
Full diff: https://github.com/llvm/llvm-project/pull/139910.diff
1
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr FileMgr;
+ std::unique_ptr DiagOpts;
jansvoboda11 wrote:
I
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Host/common/TCPSocket.cpp
``
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/139584
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
Author: Jonas Devlieghere
Date: 2025-05-14T09:10:49-07:00
New Revision: 998dca42351f3292512af56207b603dc2fef565b
URL:
https://github.com/llvm/llvm-project/commit/998dca42351f3292512af56207b603dc2fef565b
DIFF:
https://github.com/llvm/llvm-project/commit/998dca42351f3292512af56207b603dc2fef565b.d
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139926
This adds basic support for testing the Transport class and includes tests for
'Read'.
>From 506e8107a397e2ae88d8b952c0a5351cda9fa161 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 09:13:32
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds basic support for testing the Transport class and includes tests for
'Read'.
---
Full diff: https://github.com/llvm/llvm-project/pull/139926.diff
2 Files Affected:
- (modified) lldb/unittests/DAP
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139926
>From 506e8107a397e2ae88d8b952c0a5351cda9fa161 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 09:13:32 -0700
Subject: [PATCH 1/2] [lldb-dap] Adding unittests for Transport.
This adds basic s
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138032
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/139932
None
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/139932.diff
1 Files Affected:
- (modified) lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp
(+1-2)
``diff
diff --
ashgti wrote:
I added a few extra tests here and some extra base classes to help setup tests.
LMKWYT
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
>From 6f947e38ad4f744754cf13c1094c4e5e3fd249b6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 10:31:40 -0700
Subject: [PATCH 1/5] [lldb-dap] Setup DAP for unit testing.
This is a very simple
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/139934
>From 7dbd5f7467cf1ab31caf935633062a7a66a49757 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Wed, 14 May 2025 17:32:47 +0100
Subject: [PATCH 1/4] [lldb][lldb-dap] clarify the todo.
---
lldb/tools/lldb-dap/
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
>From e63e53adc0909f481a165eca958a3ac2ca4374ee Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 13 May 2025 17:11:08 -0700
Subject: [PATCH 1/7] [lldb][NFC] Split
RegisterContextUnwind::SavedLocation
@@ -0,0 +1,35 @@
+//===-- DisconnectRequestHandlerTest.cpp
--===//
JDevlieghere wrote:
```suggestion
//===-- DisconnectTest.cpp ===//
```
https://github.com/llvm/llvm-project/pull/1
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/139817
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -107,6 +107,7 @@ class ASTUnit {
private:
std::unique_ptr LangOpts;
+ std::shared_ptr DiagOpts;
jansvoboda11 wrote:
I was hoping it could be, but the situation is a bit weird. The documentation
for `ASTUnit::LoadFromCommandLine()` says the `Diagnostics
@@ -837,6 +838,7 @@ class ASTUnit {
static std::unique_ptr LoadFromCommandLine(
const char **ArgBegin, const char **ArgEnd,
std::shared_ptr PCHContainerOps,
+ std::shared_ptr DiagOpts,
jansvoboda11 wrote:
Explained above.
https://github.com
https://github.com/JDevlieghere approved this pull request.
LGTM modulo (pre-existing) typo.
https://github.com/llvm/llvm-project/pull/139916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -169,7 +169,8 @@ Status TCPSocket::Connect(llvm::StringRef name) {
return error;
}
- error = Status::FromErrorString("Failed to connect port");
+ error = Status::FromErrorStringWithFormatv(
+ "Failed to connect {0}:{1}", host_port->hostname, host_port->port);
-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/139848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138612
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/139926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/139584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
quic-akaryaki wrote:
@anjenner : an alternative way to report error would be to pass a "diagnostic
object" to CachedFileStream that would collect errors happening during calling
its destructors, report them later, and fail the compilation if any. That might
have been a less intrusive way.
htt
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/139916
Before:
```
(lldb) r
error: connect remote failed (Failed to connect port)
error: Failed to connect port
```
After the patch:
```
(lldb) r
error: connect remote failed (Failed to connect localhost:47140)
error: F
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
Before:
```
(lldb) r
error: connect remote failed (Failed to connect port)
error: Failed to connect port
```
After the patch:
```
(lldb) r
error: connect remote failed (Failed to connect localhost:47140)
error: Failed
@@ -107,6 +107,7 @@ class ASTUnit {
private:
std::unique_ptr LangOpts;
+ std::shared_ptr DiagOpts;
cor3ntin wrote:
Ouch, this is not great :smile:
Can you leave a FIXME comment in the source? Thanks
https://github.com/llvm/llvm-project/pull/139584
__
@@ -714,6 +714,8 @@ uint32_t ModuleList::ResolveSymbolContextsForFileSpec(
const FileSpec &file_spec, uint32_t line, bool check_inlines,
SymbolContextItem resolve_scope, SymbolContextList &sc_list) const {
std::lock_guard guard(m_modules_mutex);
+ // If we're looking
Author: Pavel Labath
Date: 2025-05-14T18:22:02+02:00
New Revision: 5fb9dca14aeaf12219ff149bf3a4f94c8dc58d8b
URL:
https://github.com/llvm/llvm-project/commit/5fb9dca14aeaf12219ff149bf3a4f94c8dc58d8b
DIFF:
https://github.com/llvm/llvm-project/commit/5fb9dca14aeaf12219ff149bf3a4f94c8dc58d8b.diff
labath wrote:
Jason, could you take a look at this as well?
https://github.com/llvm/llvm-project/pull/137155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Pushed again to address David's comments and remove most of the FIXMEs. There's
one FIXME I've kept in for now:
```
// FIXME: SB class server references are stored as non-const references so
// that we can actually change them as needed. If a parameter is marked
// const, we
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/139934
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr FileMgr;
+ std::unique_ptr DiagOpts;
ojhunt wrote:
@jansvo
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,70 @@
+//===-- TestBase.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
JDevlieghere wrote:
I somewhat regret the naming of the request handlers (*). Learning from our
mistakes, maybe here we should just call it `Handler/Disconne
https://github.com/JDevlieghere approved this pull request.
I like the test base classes.
https://github.com/llvm/llvm-project/pull/139937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -0,0 +1,70 @@
+//===-- TestBase.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1,8 +1,11 @@
add_lldb_unittest(DAPTests
+ DAPTest.cpp
+ Handler/DisconnectRequestHandlerTest.cpp
ashgti wrote:
I renamed the file to `Handler/DisconnectTest.cpp` but should the test be
`DisconnectTest` or should it be `DisconnectRequestHandlerTest` since
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139937
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
Author: John Harrison
Date: 2025-05-14T10:00:01-07:00
New Revision: 441d382f9350c134c958244f252c00923824
URL:
https://github.com/llvm/llvm-project/commit/441d382f9350c134c958244f252c00923824
DIFF:
https://github.com/llvm/llvm-project/commit/441d382f9350c134c958244f252c00923824.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/139926
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
What it now looks like.
It is a good idea to remove the, symbol status and name from the tree children
?.
---
Full
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/139934
What it now looks like.
It is a good idea to remove the, symbol status and name from the tree children
?.
chelcassanova wrote:
@bulbazord @JDevlieghere Is it possible to take another pass over at this? I
think this should be good to land now.
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/139926
>From 506e8107a397e2ae88d8b952c0a5351cda9fa161 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 14 May 2025 09:13:32 -0700
Subject: [PATCH 1/3] [lldb-dap] Adding unittests for Transport.
This adds basic s
1 - 100 of 142 matches
Mail list logo
