https://github.com/labath created
https://github.com/llvm/llvm-project/pull/139545
The macos and sysv ABIs return functionally equivalent unwind plans, so they
can be implemented in the base AArch64 class. The only difference between them
was that the macos plan provided a "pc=lr" rule whereas
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
lld
Author: Dhruv Srivastava
Date: 2025-05-12T17:52:02+05:30
New Revision: 39f5a420b6801c0cb6035ec77c53154674786a60
URL:
https://github.com/llvm/llvm-project/commit/39f5a420b6801c0cb6035ec77c53154674786a60
DIFF:
https://github.com/llvm/llvm-project/commit/39f5a420b6801c0cb6035ec77c53154674786a60.di
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/131304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/102601
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Ari
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/139554
A contrived performance measurement on my local machine:
1. Attach LLDB to LLDB
2. Measure how much time it takes to run `b operator[]`
Without this patch, we would spend a total of 400ms (which was ~4-5% of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
A contrived performance measurement on my local machine:
1. Attach LLDB to LLDB
2. Measure how much time it takes to run `b operator[]`
Without this patch, we would spend a total of 400ms (which was ~4-5% o
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
oontvoo wrote:
> When setting a breakpoint, we pass eSymbolContextLineEntry to the function so
> that it returns a line entry matching the query. In this case, we're not
> really interested in the entire line entry, but I think it should be possible
> the line entry as a carrier for the file
JDevlieghere wrote:
> tiny nit for concrete types
@da-viper I don't see your comment, is it possible it wasn't submitted?
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
@@ -1114,15 +1115,15 @@ class CommandObjectSourceList : public
CommandObjectParsed {
matching_modules.Clear();
target.GetImages().FindModules(module_spec, matching_modules);
num_matches += matching_modules.ResolveSymbolContextForFilePath(
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
@@ -1170,10 +1171,41 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
Attempt an ObjC incomplete type fix even if `GetDereferencedType` returns an
error.
---
Full diff: https://github.com/llvm/llvm-project/pull/139567.diff
1 Files Affected:
- (modified) lldb/source/ValueObject
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/139567
Attempt an ObjC incomplete type fix even if `GetDereferencedType` returns an
error.
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
kuilpd wrote:
@felipepiovezan
I don't have a machine to run ObjC tests on, could you apply this patch and see
if it fixes the issue in #135843 ?
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
labath wrote:
> Leaving the line-number as `0` somehow result in it couldn't find the file!
> (Changing it to the right line number - or anything non-zero, on the other
> hand works). Any idea why?
Line zero means "I don't know", so it's possible that it's treated specially
(you could step th
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/139554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
FWIW, I completely agree @royitaqi. I'm not saying inter-plugin dependencies
should be a free-for-all (*), but I think that some kinds of dependencies make
sense and I definitely think this is one of them. The debug map format is
intimately tied to the MachO and darwin ecosystems
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/139554
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-05-12T17:32:26+01:00
New Revision: 74a588464c133447b2d644cee7910084f4f57065
URL:
https://github.com/llvm/llvm-project/commit/74a588464c133447b2d644cee7910084f4f57065
DIFF:
https://github.com/llvm/llvm-project/commit/74a588464c133447b2d644cee7910084f4f57065.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/139552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
ashgti wrote:
Hmm after a sync, this started causing my cmake to fail to configure with:
```
$ cmake --fresh -B ~/Projects/lldb-build -G Ninja \
-C ~/Projects/llvm-project/lldb/cmake/caches/Apple-lldb-macOS.cmake \
-DCMAKE_EXPORT_COMPILE_COMMANDS=
JDevlieghere wrote:
I'll take a look. I see it failing here too:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/1688/
https://github.com/llvm/llvm-project/pull/139402
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/138093
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139669
Refactor lldp-dap to use a `lldb_private::MainLoop` to handle events and
protocol messages.
This should ensure more uniform handling of debugger state by ensuring only one
action is being performed at a time. T
ashgti wrote:
Okay, I got this working with a RunLoop instead in PR
https://github.com/llvm/llvm-project/pull/139669. All the macOS tests are
passing for me, but I'll let the CI run to check linux and fix any issues with
that before making the PR ready for review.
https://github.com/llvm/llvm
@@ -4211,6 +4211,9 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+if (m_objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
https://github.com/labath approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/139252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I added @labath as a reviewer since he's the MainLoop architect and because we
briefly discussed this at EuroLLVM.
I only glanced at this and I'll take a more in-depth look tomorrow. One thing I
remember form reading the MainLoop docs is that the class itself is not thread
101 - 137 of 137 matches
Mail list logo
