JDevlieghere wrote:
Attaching the bot output before it gets recycled:
[stdio-3.txt](https://github.com/user-attachments/files/20111424/stdio-3.txt)
https://github.com/llvm/llvm-project/pull/138791
___
lldb-commits mailing list
lldb-commits@lists.llvm
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/139166
This patch allows lldb to step in across "branch islands" which is the Darwin
linker's way of dealing with immediate branches to targets that are too far
away for the immediate slot to make the jump.
I submi
Author: John Harrison
Date: 2025-05-08T14:12:49-07:00
New Revision: 03896403d3bf330c8163aa9ae3fe2aa284e273be
URL:
https://github.com/llvm/llvm-project/commit/03896403d3bf330c8163aa9ae3fe2aa284e273be
DIFF:
https://github.com/llvm/llvm-project/commit/03896403d3bf330c8163aa9ae3fe2aa284e273be.diff
felipepiovezan wrote:
It may be a coincidence, but a DAP test failed in green dragon right after this
patch was applied:
https://ci.swift.org/view/all/job/llvm.org/job/as-lldb-cmake/25465/console
TestDAP_repl_mode_detection.py
DAP tasks have been flaky though, so maybe unrelated, I don't full
@@ -302,6 +302,74 @@ struct Source {
// unsupported keys: origin, sources, adapterData, checksums
};
bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path);
+llvm::json::Value toJSON(const Source &);
+
+/// A `Scope` is a named container for variables. Optionall
@@ -302,6 +302,74 @@ struct Source {
// unsupported keys: origin, sources, adapterData, checksums
};
bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path);
+llvm::json::Value toJSON(const Source &);
+
+/// A `Scope` is a named container for variables. Optionall
https://github.com/JDevlieghere requested changes to this pull request.
Plugins shouldn't depend on each other. The correct way to do this would be to
have a method in ObjectFile, something like `ObjectFile::SupportsDebugMap()`
which returns false for all implementations except the `ObjectFileM
@@ -98,9 +83,15 @@ void ScopesRequestHandler::operator()(const
llvm::json::Object &request) const {
/*statics=*/true,
/*in_scope_only=*/true);
dap.variables.registers = frame.GetRegiste
@@ -294,6 +294,19 @@ bool fromJSON(const llvm::json::Value &,
LaunchRequestArguments &,
/// field is required.
using LaunchResponseBody = VoidResponse;
+struct ScopesArguments {
+ /// Retrieve the scopes for the stack frame identified by `frameId`. The
+ /// `frameId` must
@@ -275,9 +275,7 @@ struct DAP {
lldb::SBThread GetLLDBThread(lldb::tid_t id);
lldb::SBThread GetLLDBThread(const llvm::json::Object &arguments);
- lldb::SBFrame GetLLDBFrame(const llvm::json::Object &arguments);
ashgti wrote:
We may want to leave this h
https://github.com/ashgti approved this pull request.
Makes sense to me
https://github.com/llvm/llvm-project/pull/139167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -246,6 +247,8 @@ llvm::StringRef
SymbolFileDWARFDebugMap::GetPluginDescriptionStatic() {
}
SymbolFile *SymbolFileDWARFDebugMap::CreateInstance(ObjectFileSP objfile_sp) {
+ if (objfile_sp->GetPluginName() != ObjectFileMachO::GetPluginNameStatic())
+return nullptr;
Author: jimingham
Date: 2025-05-08T16:22:39-07:00
New Revision: 6bb30196912daeaa92babc39519b2ae0bfce9771
URL:
https://github.com/llvm/llvm-project/commit/6bb30196912daeaa92babc39519b2ae0bfce9771
DIFF:
https://github.com/llvm/llvm-project/commit/6bb30196912daeaa92babc39519b2ae0bfce9771.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/139166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
The failure seems to be that `stackTrace` returned an empty list:
```
15:36:48 1746743807.491051912 --> (stdin/stdout)
{"command":"stackTrace","type":"request","arguments":{"threadId":1744343,"startFrame":0,"levels":1},"seq":13}
15:36:48 1746743807.491221905 <-- (stdin/stdout)
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/139187
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/139187
I suspect the test may be failing because lld doesn't behave the same way the
native Darwin linker does. Trying that theory here...
>From 3198c53fbf642694fde0a99a29ad779208ea8b08 Mon Sep 17 00:00:00 2001
Fro
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
I suspect the test may be failing because lld doesn't behave the same way the
native Darwin linker does. Trying that theory here...
---
Full diff: https://github.com/llvm/llvm-project/pull/139187.diff
3 Files Af
Author: jimingham
Date: 2025-05-08T18:00:52-07:00
New Revision: b80c3c576f169326f55956985706816cf7b170eb
URL:
https://github.com/llvm/llvm-project/commit/b80c3c576f169326f55956985706816cf7b170eb
DIFF:
https://github.com/llvm/llvm-project/commit/b80c3c576f169326f55956985706816cf7b170eb.diff
LOG
https://github.com/felipepiovezan approved this pull request.
Fingers crossed this will give us enough info!
https://github.com/llvm/llvm-project/pull/139166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
bulbazord wrote:
+1 to Jonas's comment. Plugins ideally don't depend on each other and they
should strive to fail gracefully if they depend on a specific plugin instance
that's not available. I recognize that many plugins depend on each other today,
but I don't think we should be adding more d
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/139178
failing but only on the bot.
>From 3198c53fbf642694fde0a99a29ad779208ea8b08 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 8 May 2025 16:59:10 -0700
Subject: [PATCH] Add more logging so I can figure out
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
failing but only on the bot.
---
Full diff: https://github.com/llvm/llvm-project/pull/139178.diff
2 Files Affected:
- (modified)
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp (+9)
- (mod
Author: jimingham
Date: 2025-05-08T17:03:21-07:00
New Revision: b6922b717045d3d1bd136b96f672533a498fd5aa
URL:
https://github.com/llvm/llvm-project/commit/b6922b717045d3d1bd136b96f672533a498fd5aa
DIFF:
https://github.com/llvm/llvm-project/commit/b6922b717045d3d1bd136b96f672533a498fd5aa.diff
LOG
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/macosx/branch-islands/TestBranchIslands.py
``
Vie
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/Dynamic
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/139196
Motivation example:
```
> lldb -c altmain2.core
...
(lldb) var F
(const char *) F = 0x0804a000 ""
```
The variable `F` points to a read-only memory page not dumped to the core file,
so `Process::ReadMemory(
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/139197
In a Debug build on Windows, printing inline diagnostics resulted in an error,
for example:
```
> cd llvm-project\lldb\test\API\functionalities\postmortem\elf-core
> lldb.exe -c altmain.core
> p dummy
LLDB d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
Motivation example:
```
> lldb -c altmain2.core
...
(lldb) var F
(const char *) F = 0x0804a000 ""
```
The variable `F` points to a read-only memory page not dumped to the core file,
so `Process::ReadMemory
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
In a Debug build on Windows, printing inline diagnostics resulted in an error,
for example:
```
> cd llvm-project\lldb\test\API\functionalities\postmortem\elf-core
> lldb.exe -c altmain.core
> p dummy
LLDB
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/138977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 131 of 131 matches
Mail list logo
