@@ -349,6 +349,10 @@ TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) {
ASSERT_FALSE(EC);
llvm::sys::path::append(name, "test");
+ // Skip the test if the $TMPDIR is too long to hold a domain socket.
+ if (name.size() > 107u)
+return;
JDevlieghe
https://github.com/emrekultursay updated
https://github.com/llvm/llvm-project/pull/137405
>From 65de31524033192d1c14af29b70b8f32bac3be55 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Fri, 25 Apr 2025 22:04:28 +
Subject: [PATCH 1/2] Skip tests if socket name is longer than 107 bytes
T
slydiman wrote:
Note DomainSocket is not supported on Windows, so removing the following code
broke the Windows build!
```
#if LLDB_ENABLE_POSIX
socket = new DomainSocket(sockfd, /*should_close=*/true);
#else
WithColor::error() << "lldb-platform child: Unix domain sockets are not "
https://github.com/emrekultursay created
https://github.com/llvm/llvm-project/pull/137414
Windows doesn't have domain sockets, so we must properly #ifdef the code that
touches DomainSocket.
>From fb1ced0cd73fbd3844a887d064cf319b27d2a237 Mon Sep 17 00:00:00 2001
From: Emre Kultursay
Date: Fri,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Emre Kultursay (emrekultursay)
Changes
Windows doesn't have domain sockets, so we must properly #ifdef the code that
touches DomainSocket.
---
Full diff: https://github.com/llvm/llvm-project/pull/137414.diff
1 Files Affected:
- (modifie
emrekultursay wrote:
Thanks. Are the following patches good enough, or do we prefer a revert?
- Test fix: https://github.com/llvm/llvm-project/pull/137405
- Windows fix: https://github.com/llvm/llvm-project/pull/137414
https://github.com/llvm/llvm-project/pull/136466
__
https://github.com/emrekultursay edited
https://github.com/llvm/llvm-project/pull/137414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/137414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Emre Kultursay
Date: 2025-04-25T16:14:18-07:00
New Revision: 935bc84158e933239047de69b9edc77969b5c70c
URL:
https://github.com/llvm/llvm-project/commit/935bc84158e933239047de69b9edc77969b5c70c
DIFF:
https://github.com/llvm/llvm-project/commit/935bc84158e933239047de69b9edc77969b5c70c.diff
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/137415
The buildbot lldb-remote-linux-win is broken after #136466. This patch should
make it green.
>From 53d84b5113c4d7398694a0e0ff7e07f2cc77451b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sat, 26 Apr 202
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The buildbot lldb-remote-linux-win is broken after #136466. This patch
should make it green.
---
Full diff: https://github.com/llvm/llvm-project/pull/137415.diff
1 Files Affected:
- (modified) lldb/too
Author: Emre Kultursay
Date: 2025-04-25T16:16:53-07:00
New Revision: 6c78dedc14e7431aa0dd92b9dd8d35bed3e0ed7d
URL:
https://github.com/llvm/llvm-project/commit/6c78dedc14e7431aa0dd92b9dd8d35bed3e0ed7d
DIFF:
https://github.com/llvm/llvm-project/commit/6c78dedc14e7431aa0dd92b9dd8d35bed3e0ed7d.diff
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/137405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Duplicate of #137414.
https://github.com/llvm/llvm-project/pull/137415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/137415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/137365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/129728
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/137426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM but please wait for @ashgti to sign off too.
https://github.com/llvm/llvm-project/pull/137426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
adrian-prantl wrote:
Not to derail this too much, but I'm also thinking if we should _stop_ coloring
the column number. Happy to open a patch if people think this is a good idea?
https://github.com/llvm/llvm-project/pull/137301
___
lldb-commits mailin
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137426
>From 85c1e0de0a5cb8dd09b6f84b2514c7eb06aadac2 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 01:22:05 +0200
Subject: [PATCH] Migrating breakpointLocations request to use typed
RequestHandler
adrian-prantl wrote:
That sounds useful!
Another way to spell `||` would be `?:` which might be more intuitive to C
programmers?
https://github.com/llvm/llvm-project/pull/137408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137426
>From 1cc60c125a69c4a84c263db6845714f1c320b696 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 01:22:05 +0200
Subject: [PATCH] Migrating breakpointLocations request to use typed
RequestHandler
Author: Vy Nguyen
Date: 2025-04-26T02:19:29+02:00
New Revision: a74e4ac9d52029f9c9fe80654acd9fdd34d2a4cd
URL:
https://github.com/llvm/llvm-project/commit/a74e4ac9d52029f9c9fe80654acd9fdd34d2a4cd
DIFF:
https://github.com/llvm/llvm-project/commit/a74e4ac9d52029f9c9fe80654acd9fdd34d2a4cd.diff
LOG
adrian-prantl wrote:
I think this works.
https://github.com/llvm/llvm-project/pull/137301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Not to derail this too much, but I'm also thinking if we should _stop_
> coloring the column number. Happy to open a patch if people think this is a
> good idea?
I don't have a strong opinion on this but I'm curious on why coloring the
column number is bothering you spec
JDevlieghere wrote:
I agree with @medismailben, the line number is super helpful (I copy/paste this
into vim all the time) and visually it looks a bit weird without the column
even thought it's not useful.
https://github.com/llvm/llvm-project/pull/137301
__
Author: Michael Buch
Date: 2025-04-26T01:00:17+01:00
New Revision: 5137587fb1dc878e2dca31c4b929a3ca99f70ace
URL:
https://github.com/llvm/llvm-project/commit/5137587fb1dc878e2dca31c4b929a3ca99f70ace
DIFF:
https://github.com/llvm/llvm-project/commit/5137587fb1dc878e2dca31c4b929a3ca99f70ace.diff
@@ -245,6 +245,23 @@ bool fromJSON(const json::Value &Params, Configuration &C,
json::Path P) {
parseSourceMap(Params, C.sourceMap, P);
}
+bool fromJSON(const json::Value &Params, BreakpointLocationsArguments &BLA,
+ json::Path P) {
+ json::ObjectMapper
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/137380
>From 681beb0f851d20896456b53c51b8ee84382a1254 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 25 Apr 2025 10:40:45 -0700
Subject: [PATCH 1/2] [lldb-dap] Support the Module Event
The module eve
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/137446
This patch changes the progress count formatting show thousands separator
making it easier to read big numbers.
>From a293b8b3cd50037998db82b4cd2298489b8b5499 Mon Sep 17 00:00:00 2001
From: Med Ismail Benn
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch changes the progress count formatting show thousands separator
making it easier to read big numbers.
---
Full diff: https://github.com/llvm/llvm-project/pull/137446.diff
1 Files Affect
201 - 233 of 233 matches
Mail list logo
