[Lldb-commits] [lldb] 9147569 - [lldb][test] Rename reverse-execution/TestReverseContinueNotSupported.py

Author: Michael Buch Date: 2025-04-25T14:26:50+01:00 New Revision: 9147569c7fc996555af81916ce81a53ad7625d7d URL: https://github.com/llvm/llvm-project/commit/9147569c7fc996555af81916ce81a53ad7625d7d DIFF: https://github.com/llvm/llvm-project/commit/9147569c7fc996555af81916ce81a53ad7625d7d.diff

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

@@ -319,3 +320,255 @@ TEST(MangledTest, NameIndexes_FindFunctionSymbols) { EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeBase)); EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeMethod)); } + +TEST(MangledTest, DemangledNameInfo_SetMangledResets) { + Mangled mangl

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

kuilpd wrote: @labath Should I move the check for `void *` to `TypeSystemClang::GetDereferencedType` in the other PR? https://github.com/llvm/llvm-project/pull/134428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The function was always trying to dereference both the synthetic and non-synthetic view of the object. This is wrong as the caller should be able to determine which view of the object it wants to access, as is

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/137311 The function was always trying to dereference both the synthetic and non-synthetic view of the object. This is wrong as the caller should be able to determine which view of the object it wants to access, as is d

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Target/StackFrame.cpp lldb/source/ValueOb

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

slydiman wrote: Still failed https://lab.llvm.org/buildbot/#/builders/195/builds/8109 https://lab.llvm.org/buildbot/#/builders/197/builds/4470 https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137311 >From a295fdb31c59050f9b6d9fc9ba4e0156a7e35c1b Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 25 Apr 2025 11:21:52 +0200 Subject: [PATCH] [lldb] Make ValueObject::Dereference less aggressive The function

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

da-viper wrote: @labath this is what it looks like at the bottom right  https://github.com/llvm/llvm-project/pull/137280 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

labath wrote: I see, so it's one of those popups that don't require interaction and disappear on their own after a while. I'm still somewhat worried, as these errors tend to be bursty. Like, if there's something wrong with the debug info, we could get dozens (or more) of errors of the kind I

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

labath wrote: I kinda like how the (highlighted) PC value creates a column. What would you say to highlighting both? (I know I can change this locally if I want to, so this is really a question what's a better default => don't change this just because I said so) https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

da-viper wrote: this does not catch https://github.com/llvm/llvm-project/blob/d775b911c90e631f5cc332c07474f7121564e25b/lldb/tools/lldb-dap/DAP.cpp#L215-L219 for example if you add the initcommand of `breakpoint set --file=main.c --line=2 --command "bogus"` it is not sent to the important categ

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

da-viper wrote: Maybe we limit it to only Errors. as on linux if lldb is not built with lzma support it will spam warning messages like. ``` warning: 45F7FBFE-9455-A458-4A50-347C4A5BC883/libsync.so No LZMA support found for reading .gnu_debugdata section warning: 8E2F4272-9D82-2CEF-A46D-C69D

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

Michael137 wrote: > I kinda like how the (highlighted) PC value creates a column. What would you > say to highlighting both? > > (I know I can change this locally if I want to, so this is really a question > what's a better default => don't change this just because I said so) This is what it

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/137301 >From eac7bbaa47715c053c711ed6469f4dd9d3b55b4a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 25 Apr 2025 10:25:51 +0100 Subject: [PATCH] [lldb] Highlight basenames in backtraces instead of PC value

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

adrian-prantl wrote: > > I kinda like how the (highlighted) PC value creates a column. What would > > you say to highlighting both? > Maybe we could use a different color? Don't have strong opinions on this. We could try a less aggressive color like the one used for the file names. I'm wonder

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

tromey wrote: Thank you for the test case. I sent a gdb fix: https://sourceware.org/pipermail/gdb-patches/2025-April/217513.html https://github.com/llvm/llvm-project/pull/137123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

eronnen wrote: @JDevlieghere any chance to merge? https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

oontvoo wrote: Thanks all, for the feedback! I'll merge this EOD today, if there's no objection! :) https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -156,6 +158,52 @@ uint32_t GetLLDBFrameID(uint64_t dap_frame_id); lldb::SBEnvironment GetEnvironmentFromArguments(const llvm::json::Object &arguments); +/// Helper for sending telemetry to lldb server, if client-telemetry is enabled. +#ifndef SWIG oontvoo

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

@@ -117,6 +118,9 @@ static void EventThreadFunction(DAP &dap) { lldb::SBEvent event; lldb::SBListener listener = dap.debugger.GetListener(); dap.broadcaster.AddListener(listener, eBroadcastBitStopEventThread); + dap.debugger.GetBroadcaster().AddListener( + listener,

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

Michael137 wrote: Here's a version where the PC value is cyan (like the filename): https://github.com/user-attachments/assets/d9e90fc7-9f06-4044-8500-2a6f5a4926d2"; /> You still get the colored column, but it feels less difficult on the eyes than having both yellow https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

DavidSpickett wrote: You could adapt commands from https://github.com/llvm/llvm-project/tree/main/lldb/scripts/lldb-test-qemu, if you have an existing Ubuntu system of some other architecture. https://lldb.llvm.org/resources/qemu-testing.html https://github.com/llvm/llvm-project/pull/115408 _

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

https://github.com/DavidSpickett approved this pull request. Also noticed this trying to reproduce a failure on Windows with lldb-dotest.py, LGTM. https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

DavidSpickett wrote: > The instruction emulation plugins are used to implement software > single-stepping on architectures without (reliably present) hardware support. > AFAIK aarch64 is not one of those. I think it's also used in unwinding for some basic prologue/epilogue instructions, but I

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

slydiman wrote: Ok, thanks. Then I will close this PR. https://github.com/llvm/llvm-project/pull/137267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/137267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -156,6 +158,52 @@ uint32_t GetLLDBFrameID(uint64_t dap_frame_id); lldb::SBEnvironment GetEnvironmentFromArguments(const llvm::json::Object &arguments); +/// Helper for sending telemetry to lldb server, if client-telemetry is enabled. +#ifndef SWIG labath w

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a267225 - [lldb][Mangled] Retrieve and cache demangled name info (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: a2672250be871bdac18c1a955265a98704434218 URL: https://github.com/llvm/llvm-project/commit/a2672250be871bdac18c1a955265a98704434218 DIFF: https://github.com/llvm/llvm-project/commit/a2672250be871bdac18c1a955265a98704434218.diff

[Lldb-commits] [lldb] 8b91b44 - [lldb][Format] Introduce new frame-format variables for function parts (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: 8b91b44a3be680788f914af72f38f90d35925c23 URL: https://github.com/llvm/llvm-project/commit/8b91b44a3be680788f914af72f38f90d35925c23 DIFF: https://github.com/llvm/llvm-project/commit/8b91b44a3be680788f914af72f38f90d35925c23.diff

[Lldb-commits] [lldb] d555b9f - [lldb][CPlusPlus] Add plugin.cplusplus.display.function-name-format setting (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: d555b9f9a01705097edf2434cf897e351095e5c9 URL: https://github.com/llvm/llvm-project/commit/d555b9f9a01705097edf2434cf897e351095e5c9 DIFF: https://github.com/llvm/llvm-project/commit/d555b9f9a01705097edf2434cf897e351095e5c9.diff

[Lldb-commits] [lldb] 9c830ce - [lldb] Implement TrackingOutputBuffer to track demangled name information (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: 9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05 URL: https://github.com/llvm/llvm-project/commit/9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05 DIFF: https://github.com/llvm/llvm-project/commit/9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05.diff

[Lldb-commits] [lldb] f220ea2 - [lldb][Mangled] Add API to force re-demangling a Mangled object (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: f220ea2947b9c8b1e33db65b008086d47fa72af3 URL: https://github.com/llvm/llvm-project/commit/f220ea2947b9c8b1e33db65b008086d47fa72af3 DIFF: https://github.com/llvm/llvm-project/commit/f220ea2947b9c8b1e33db65b008086d47fa72af3.diff

[Lldb-commits] [lldb] 5a64510 - [lldb] Remove redundant DemangledNameInfo::operator==

Author: Michael Buch Date: 2025-04-25T10:18:33+01:00 New Revision: 5a645109c3a965dcaab08e3485f2fa505e44cde3 URL: https://github.com/llvm/llvm-project/commit/5a645109c3a965dcaab08e3485f2fa505e44cde3 DIFF: https://github.com/llvm/llvm-project/commit/5a645109c3a965dcaab08e3485f2fa505e44cde3.diff

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

Michael137 wrote: > > Feel free to ping on this PR if any issues pop up > > https://lab.llvm.org/buildbot/#/builders/195/builds/8106 > > ``` > 14.009 [1092/66/4173] Building CXX object > tools/lldb/source/Core/CMakeFiles/lldbCore.dir/DemangledNameInfo.cpp.o > FAILED: > tools/lldb/source/Core/

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of PC value (PR #137301)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Before: After: [Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

2025-04-25 Thread Michael Buch via lldb-commits

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-25 Thread Dmitry Vasilyev via lldb-commits

slydiman wrote: > Feel free to ping on this PR if any issues pop up https://lab.llvm.org/buildbot/#/builders/195/builds/8106 ``` 14.009 [1092/66/4173] Building CXX object tools/lldb/source/Core/CMakeFiles/lldbCore.dir/DemangledNameInfo.cpp.o FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.di

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of PC value (PR #137301)

2025-04-25 Thread Michael Buch via lldb-commits

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/137301 Before: https://github.com/user-attachments/assets/1ec35ba3-a3d9-4e5b-bac9-fc738bfe6d25"; /> After: https://github.com/user-attachments/assets/9358a8bc-5f8d-45f3-8f11-6b06954cc75e"; /> >From ac3116c225d59

[Lldb-commits] [lldb] da14f6d - [lldb] Fix MangledTest build failure

2025-04-25 Thread Michael Buch via lldb-commits

Author: Michael Buch Date: 2025-04-25T11:25:59+01:00 New Revision: da14f6d4b9d8c2b1fde37cd766688ce5e26b2984 URL: https://github.com/llvm/llvm-project/commit/da14f6d4b9d8c2b1fde37cd766688ce5e26b2984 DIFF: https://github.com/llvm/llvm-project/commit/da14f6d4b9d8c2b1fde37cd766688ce5e26b2984.diff

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread Ebuka Ezike via lldb-commits

@@ -164,3 +164,20 @@ def test_exit_status_message_ok(self): console_output, "Exit status does not contain message 'exited with status'", ) + +def test_diagnositcs(self): +program = self.getBuildArtifact("a.out") +self.build_an

[Lldb-commits] [lldb] 2d1b5a2 - [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (#137002)

2025-04-25 Thread via lldb-commits

Author: Ebuka Ezike Date: 2025-04-25T12:43:40+01:00 New Revision: 2d1b5a269b85c1a6174c1988f43acbb7bc1ba8f2 URL: https://github.com/llvm/llvm-project/commit/2d1b5a269b85c1a6174c1988f43acbb7bc1ba8f2 DIFF: https://github.com/llvm/llvm-project/commit/2d1b5a269b85c1a6174c1988f43acbb7bc1ba8f2.diff L

[Lldb-commits] [lldb] [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (PR #137002)

2025-04-25 Thread Ebuka Ezike via lldb-commits

https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/137002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread Pavel Labath via lldb-commits

labath wrote: > this does not catch > > https://github.com/llvm/llvm-project/blob/d775b911c90e631f5cc332c07474f7121564e25b/lldb/tools/lldb-dap/DAP.cpp#L215-L219 > > for example if you add the initcommand of `breakpoint set --file=main.c > --line=2 --command "bogus"` it is not sent to the impor

[Lldb-commits] [lldb] [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (PR #137002)

2025-04-25 Thread Ebuka Ezike via lldb-commits

https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/137002 >From 8838b06036fb3420ab39491b23500b18066f2f28 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 23 Apr 2025 15:49:01 +0100 Subject: [PATCH 1/2] [lldb][lldb-dap] Redirect LLDB's messages to the right outpu

[Lldb-commits] [lldb] 320ec7f - [Documentation] Always use SVG for dot-generated doxygen images. (#136843)

2025-04-25 Thread via lldb-commits

Author: cor3ntin Date: 2025-04-25T14:13:17+02:00 New Revision: 320ec7fa7f2ca9385e355d3e031e601a9e331e3e URL: https://github.com/llvm/llvm-project/commit/320ec7fa7f2ca9385e355d3e031e601a9e331e3e DIFF: https://github.com/llvm/llvm-project/commit/320ec7fa7f2ca9385e355d3e031e601a9e331e3e.diff LOG:

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-25 Thread via lldb-commits

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/136843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-04-25 Thread Pavel Labath via lldb-commits

labath wrote: I'm not sure what the deal, but I just noticed I don't see the "Manually Indexing DWARF" messages even though I'm certain that's what lldb is doing. It's possible they are being shadowed by another progress event or something... https://github.com/llvm/llvm-project/pull/121860 __

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-25 Thread Michael Buch via lldb-commits

Michael137 wrote: Pushed this to HEAD directly in order to preserve the commits. I linked the PR in those commit message: * 9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05 * f220ea2947b9c8b1e33db65b008086d47fa72af3 * a2672250be871bdac18c1a955265a98704434218 * 8b91b44a3be680788f914af72f38f90d35925c23 *

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-25 Thread Michael Buch via lldb-commits

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-25 Thread Pavel Labath via lldb-commits

labath wrote: > > Why does it need to do that? Is it so to control which error message gets > > printed? If so, I think we could tweak that text so that we don't need > > that. The string "not a pointer or reference type" is not correct anymore > > anyway since we don't know what is the criter

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137280 >From c2eab3f2f09fd771cbd8c18f141de1fa7664af49 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 24 Apr 2025 17:59:29 -0700 Subject: [PATCH 1/3] [lldb] Emit diagnostics as "important" output Hand

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (PR #106271)

2025-04-25 Thread Jan Svoboda via lldb-commits

https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/106271 >From 4431265f6be2b989b63e4562fa8def4448d336ab Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 27 Aug 2024 09:34:01 -0700 Subject: [PATCH 1/7] [clang] `TargetInfo` does not own `TargetOptions` --- c

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

2025-04-25 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/137351 The new test added in https://github.com/llvm/llvm-project/pull/132783 was failing on Windows because it created a new error to say it did not support the feature, but then returned the existing, default

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

2025-04-25 Thread David Spickett via lldb-commits

DavidSpickett wrote: @rocallahan FYI. https://github.com/llvm/llvm-project/pull/137351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

2025-04-25 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes The new test added in https://github.com/llvm/llvm-project/pull/132783 was failing on Windows because it created a new error to say it did not support the feature, but then returned the existing, defa

[Lldb-commits] [lldb] [lldb-dap] Correcting the types for launch and attach requests. (PR #137365)

2025-04-25 Thread John Harrison via lldb-commits

https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137365 There were a few types that were incorrectly specified in the lldb-dap/package.json. The 'timeout' field was set to 'string' but is interpreted as an integer number of seconds and 'args' for launch is handled as

[Lldb-commits] [lldb] [lldb-dap] Correcting the types for launch and attach requests. (PR #137365)

2025-04-25 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes There were a few types that were incorrectly specified in the lldb-dap/package.json. The 'timeout' field was set to 'string' but is interpreted as an integer number of seconds and 'args' for launch is handled

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-25 Thread David Spickett via lldb-commits

@@ -979,8 +967,8 @@ lldb::SBError DAP::WaitForProcessToStop(uint32_t seconds) { } std::this_thread::sleep_for(std::chrono::microseconds(250)); } - error.SetErrorStringWithFormat("process failed to stop within %u seconds", - seconds); +

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

2025-04-25 Thread Dave Lee via lldb-commits

https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/137262 >From 83d011739ba3a03058474922428c341b9333056f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 24 Apr 2025 15:53:00 -0700 Subject: [PATCH 1/2] [lldb] Rename reverse-continue/TestReverseContinueNotSupport

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-25 Thread Michael Buch via lldb-commits

@@ -319,3 +320,255 @@ TEST(MangledTest, NameIndexes_FindFunctionSymbols) { EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeBase)); EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeMethod)); } + +TEST(MangledTest, DemangledNameInfo_SetMangledResets) { + Mangled mangl

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-25 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a0aa5f8 - [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (#133624)

2025-04-25 Thread via lldb-commits

Author: John Harrison Date: 2025-04-25T09:50:42-07:00 New Revision: a0aa5f8933043c0939c3a8f301fed655be2a3732 URL: https://github.com/llvm/llvm-project/commit/a0aa5f8933043c0939c3a8f301fed655be2a3732 DIFF: https://github.com/llvm/llvm-project/commit/a0aa5f8933043c0939c3a8f301fed655be2a3732.diff

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-25 Thread John Harrison via lldb-commits

https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/133624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating the 'stepOut' request to use typed RequestHandler. (PR #137362)

2025-04-25 Thread John Harrison via lldb-commits

https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137362 This moves the 'stepOut' request to the typed RequestHandler. >From 853cbbaf00f80ef42f916d72ed5a0e14b7c848be Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 25 Apr 2025 09:46:43 -0700 Subject: [PATCH] [l

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

2025-04-25 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/137351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating the 'stepOut' request to use typed RequestHandler. (PR #137362)

2025-04-25 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This moves the 'stepOut' request to the typed RequestHandler. --- Full diff: https://github.com/llvm/llvm-project/pull/137362.diff 4 Files Affected: - (modified) lldb/tools/lldb-dap/Handler/RequestHandler.h

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-25 Thread Emre Kultursay via lldb-commits

@@ -455,37 +455,33 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; - + Log *log = GetLog(LLDBLog::Platform);

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

2025-04-25 Thread John Harrison via lldb-commits

https://github.com/ashgti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/137280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-25 Thread Michael Buch via lldb-commits

Michael137 wrote: > https://lab.llvm.org/buildbot/#/builders/197/builds/4470 is still broken > > ``` > > FAILED: > tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj > > > ccache > C:\PROGRA~1\MICROS~1\2022\COMMUN~

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits

@@ -374,6 +374,15 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits

https://github.com/dmpots requested changes to this pull request. https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

2025-04-25 Thread Ebuka Ezike via lldb-commits

@@ -692,7 +692,9 @@ void DAP::SetTarget(const lldb::SBTarget target) { lldb::SBListener listener = this->debugger.GetListener(); listener.StartListeningForEvents( this->target.GetBroadcaster(), -lldb::SBTarget::eBroadcastBitBreakpointChanged); +l

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

2025-04-25 Thread Ebuka Ezike via lldb-commits

https://github.com/da-viper requested changes to this pull request. https://github.com/llvm/llvm-project/pull/137380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-04-25 Thread via lldb-commits

dyung wrote: > Hmm... perhaps I have misunderstood the LLVM contribution process here. I had > assumed that once all the review feedback had been addressed, some time had > passed to allow reviewers to comment on the modifications resulting from > review feedback, and the "merge" button was av

[Lldb-commits] [lldb] 77f8335 - Add symbol locator time for each module in statistics (#137379)

2025-04-25 Thread via lldb-commits

Author: GeorgeHuyubo Date: 2025-04-25T11:48:31-07:00 New Revision: 77f8335a07e65f88a2c2925f175f48c458911cee URL: https://github.com/llvm/llvm-project/commit/77f8335a07e65f88a2c2925f175f48c458911cee DIFF: https://github.com/llvm/llvm-project/commit/77f8335a07e65f88a2c2925f175f48c458911cee.diff

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-25 Thread Dmitry Vasilyev via lldb-commits

slydiman wrote: https://lab.llvm.org/buildbot/#/builders/197/builds/4470 is still broken ``` FAILED: tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj ccache C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.34

[Lldb-commits] [lldb] [lldb-dap] Fix formatting chrono::seconds warning. (PR #137371)

2025-04-25 Thread Jonas Devlieghere via lldb-commits

JDevlieghere wrote: FWIW I (also) prefer the formatv approach. https://github.com/llvm/llvm-project/pull/137371 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-25 Thread Alex Langford via lldb-commits

@@ -1,6 +1,8 @@ add_custom_target(lldb-shell-test-deps) set_target_properties(lldb-shell-test-deps PROPERTIES FOLDER "LLDB/Tests") add_dependencies(lldb-shell-test-deps lldb-test-depends) +get_target_property(clang_resource_headers_dir clang-resource-headers INTERFACE_INCLUDE_

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

2025-04-25 Thread LLVM Continuous Integration via lldb-commits

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/18362 Here is the relevant

[Lldb-commits] [lldb] Complete ToJSON for OptionValues (PR #137375)

2025-04-25 Thread Ebuka Ezike via lldb-commits

https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/137375 Completes the ToJSON for `OptionValueArch` and `OptionValueFileColumnLine` and make the interface function pure virtual >From a87d7be70ce0d82b159c163b1b319a349cb162ea Mon Sep 17 00:00:00 2001 From: Ebuka Ezik

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-25 Thread David Peixotto via lldb-commits

https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 01/14] Add commands to list/enable/disable plugins This commit a

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

2025-04-25 Thread LLVM Continuous Integration via lldb-commits

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/builds/17867 Here is the r

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-25 Thread David Peixotto via lldb-commits

dmpots wrote: @clayborg @JDevlieghere @jimingham I updated the PR to include plugin info in the stats. Please take a look when you get a chance. Thanks! https://github.com/llvm/llvm-project/pull/134418 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] bc716a7 - Revert "Add symbol locator time for each module in statistics (#134563)"

2025-04-25 Thread Kazu Hirata via lldb-commits

Author: Kazu Hirata Date: 2025-04-25T11:01:19-07:00 New Revision: bc716a755a9bd0e5f0b5de0da0ffcc77374690db URL: https://github.com/llvm/llvm-project/commit/bc716a755a9bd0e5f0b5de0da0ffcc77374690db DIFF: https://github.com/llvm/llvm-project/commit/bc716a755a9bd0e5f0b5de0da0ffcc77374690db.diff L

[Lldb-commits] [lldb] Complete ToJSON for OptionValues (PR #137375)

2025-04-25 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Completes the ToJSON for `OptionValueArch` and `OptionValueFileColumnLine` and make the interface function pure virtual --- Patch is 22.40 KiB, truncated to 20.00 KiB below, full version: https://github.co

[Lldb-commits] [lldb] [lldb-dap] Fix formatting chrono::seconds warning. (PR #137371)

2025-04-25 Thread John Harrison via lldb-commits

https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/137371 >From b509831348617bb67298b5dbcdfad9bcf8f0ca55 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 25 Apr 2025 10:31:18 -0700 Subject: [PATCH] [lldb-dap] Fix formatting chrono::seconds. --- lldb/tools/lldb-

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread via lldb-commits

https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From 951b49b11f958b68b65a480be3cb12eb8feb2dcf Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

2025-04-25 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes Identical PR to: https://github.com/llvm/llvm-project/pull/134563 Previous PR was approved and landed but broke the build due to bad merge. Manually resolve the merge conflict and try to land again. --- Patch is

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

2025-04-25 Thread via lldb-commits

https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/137379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-25 Thread Dmitry Vasilyev via lldb-commits

https://github.com/slydiman approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

2025-04-25 Thread David Peixotto via lldb-commits

https://github.com/dmpots approved this pull request. LGTM! I'm not too familiar with the dap protocol, so would be good to get another approver. https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

2025-04-25 Thread via lldb-commits

https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/137379 Identical PR to: https://github.com/llvm/llvm-project/pull/134563 Previous PR landed but broke the build due to bad merge. Manually resolve the merge conflict and try to land again. >From 8c8f89347c4b17e04c

[Lldb-commits] [lldb] [lldb-dap] Fix formatting chrono::seconds warning. (PR #137371)

2025-04-25 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137371 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   >