[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-24 Thread Alexey Merzlyakov via lldb-commits
AlexeyMerzlyakov wrote: @JDevlieghere, to get coredump file, I've used [make-core.sh](https://github.com/llvm/llvm-project/blob/main/lldb/test/API/functionalities/postmortem/elf-core/make-core.sh) script on the target H/W. Generated file should be minimal, so you can set `coredump_filter` (htt

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-04-24 Thread via lldb-commits
dyung wrote: Maybe I'm missing something, but was either this change or the original one approved for submit by someone? I don't see any review/approval in this commit, and the original PR doesn't seem to have been approved. https://github.com/llvm/llvm-project/pull/136121

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Likely won't find the fix today, but I suspect that the Windows process class just doesn't know that it doesn't support reverse execution: ``` (lldb) process continue --reverse Process 3108 resuming (lldb) process status Process 5360 stopped ``` The process being stopped is

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,64 @@ +""" +Test lldb-dap stack trace containing x86 assembly +""" + +import lldbdap_testcase +from lldbsuite.test.decorators import skipUnlessArch, skipUnlessPlatform +from lldbsuite.test.lldbtest import line_number + + +class TestDAP_stacktrace_x86(lldbdap_testcase.DA

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-24 Thread Leandro Lupori via lldb-commits
luporl wrote: It seems this broke lldb-aarch64-windows bot: https://lab.llvm.org/buildbot/#/builders/141/builds/8149 https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/DataFormatters/TypeSynthetic.h l

[Lldb-commits] [lldb] Ptrace seize dead process (PR #137041)

2025-04-24 Thread Pavel Labath via lldb-commits
labath wrote: We already have one piece of "status" parsing code in `source/Host/linux/Host.cpp`. I think it'd be better to reuse that one. I'm slightly torn as to whether reuse Host::GetProcessInfo for this (and add a new field to ProcessInstanceInfo -- or possibly expand on IsZombie), or whe

[Lldb-commits] [lldb] bcdafc1 - [lldb] Disable reverse continue command test on Windows

2025-04-24 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-04-24T12:16:29Z New Revision: bcdafc107e1fb68893036cfba14e761c7b37b0e9 URL: https://github.com/llvm/llvm-project/commit/bcdafc107e1fb68893036cfba14e761c7b37b0e9 DIFF: https://github.com/llvm/llvm-project/commit/bcdafc107e1fb68893036cfba14e761c7b37b0e9.diff LOG

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/23] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb] Fix crash after second run when set a previous watchpoint. (PR #136682)

2025-04-24 Thread via lldb-commits
https://github.com/hapee updated https://github.com/llvm/llvm-project/pull/136682 >From 2b8cce2ca76287d4620801878079f5dad453cc9a Mon Sep 17 00:00:00 2001 From: hapee <623151...@qq.com> Date: Tue, 22 Apr 2025 11:34:38 +0800 Subject: [PATCH] [lldb] Fix crash after second run when set a pre

[Lldb-commits] [lldb] [lldb] Fix crash after second run when set a previous watchpoint. (PR #136682)

2025-04-24 Thread via lldb-commits
https://github.com/hapee updated https://github.com/llvm/llvm-project/pull/136682 >From 563cbddfe9b7da394c818a03e05924c0f7d39d5f Mon Sep 17 00:00:00 2001 From: hapee <623151...@qq.com> Date: Tue, 22 Apr 2025 11:34:38 +0800 Subject: [PATCH 1/3] [lldb] Fix crash after second run when set a

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-24 Thread John Harrison via lldb-commits
@@ -0,0 +1,64 @@ +""" +Test lldb-dap stack trace containing x86 assembly +""" + +import lldbdap_testcase +from lldbsuite.test.decorators import skipUnlessArch, skipUnlessPlatform +from lldbsuite.test.lldbtest import line_number + + +class TestDAP_stacktrace_x86(lldbdap_testcase.DA

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-24 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman commented: I think the changes LG, but please wait for our CMake experts (@petrhosek and @Ericson2314) to review before landing. https://github.com/llvm/llvm-project/pull/136843 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-24 Thread Aaron Ballman via lldb-commits
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN) set(bolt_doxygen_qhp_cust_filter_attrs "") endif() - option(LLVM_DOXYGEN_SVG AaronBallman wrote: Awesome, thanks! https://github.com/llvm/llvm-project/pull/136843

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Charles Zablit via lldb-commits
@@ -1202,13 +1225,16 @@ lldb_private::formatters::Foundation1100:: m_data_64 = nullptr; } -size_t -lldb_private::formatters::Foundation1100:: - NSDictionaryMSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { +llvm::Expected lldb_private::formatters::Foundation11

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-24 Thread Pavel Labath via lldb-commits
labath wrote: > The problem I encountered is that Dereference has 2 separate checks: the > first one checks if the type is a pointer or a reference, the second is done > if the first one succeeds and checks if a child with a type is actually found > by GetChildCompilerTypeAtIndex Why does it

[Lldb-commits] [lldb] [lldb] Fix offset computation in RegisterContextUnwind (PR #137155)

2025-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/137155 AddressFunctionScope was always returning the first address range of the function (assuming it was the only one). This doesn't work for RegisterContextUnwind (it's only caller), when the function doesn't start at

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Charles Zablit via lldb-commits
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public SyntheticChildrenFrontEnd { GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib); - size_t GetIndexOfChildWithName(ConstString name) override { + llvm::Expected GetIndexOfChildWithName(ConstString name) override

[Lldb-commits] [lldb] [lldb] Fix offset computation in RegisterContextUnwind (PR #137155)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes AddressFunctionScope was always returning the first address range of the function (assuming it was the only one). This doesn't work for RegisterContextUnwind (it's only caller), when the function doesn't start a

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit edited https://github.com/llvm/llvm-project/pull/136693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -319,40 +319,49 @@ ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name, bool can_create) { UpdateValueIfNeeded(); - uint32_t index = GetIndexOfChildWithName(name); + auto index_or_err = GetIndexOfChildWithName(

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -319,40 +319,49 @@ ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name, bool can_create) { UpdateValueIfNeeded(); - uint32_t index = GetIndexOfChildWithName(name); + auto index_or_err = GetIndexOfChildWithName(

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -316,8 +316,10 @@ lldb_private::formatters::LibcxxSharedPtrSyntheticFrontEnd:: return 0; if (name == "$$dereference$$") return 1; - return llvm::createStringError("Cannot find index of child '%s'", - name.AsCString()); + return ll

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -103,9 +103,20 @@ lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::Update() { llvm::Expected lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd:: GetIndexOfChildWithName(ConstString name) { - if (!m_start) -return UINT32_MAX; - retur

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM I left some remaining comments. Should be good to go once those are addressed https://github.com/llvm/llvm-project/pull/136693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -418,8 +420,10 @@ lldb_private::formatters::LibcxxUniquePtrSyntheticFrontEnd:: return 1; if (name == "$$dereference$$") return 2; - return llvm::createStringError("Cannot find index of child '%s'", - name.AsCString()); + return ll

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -107,7 +107,14 @@ class ListIterator { class AbstractListFrontEnd : public SyntheticChildrenFrontEnd { public: llvm::Expected GetIndexOfChildWithName(ConstString name) override { -return ExtractIndexFromString(name.GetCString()); +size_t idx = ExtractIndexFromStrin

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -1202,13 +1225,16 @@ lldb_private::formatters::Foundation1100:: m_data_64 = nullptr; } -size_t -lldb_private::formatters::Foundation1100:: - NSDictionaryMSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { +llvm::Expected lldb_private::formatters::Foundation11

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/136693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e35cc2d - [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::DeclGetMangledName to LLVM-style

2025-04-24 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-04-24T12:45:19+01:00 New Revision: e35cc2d387e170d0e1f6ef647f17423262feb1ea URL: https://github.com/llvm/llvm-project/commit/e35cc2d387e170d0e1f6ef647f17423262feb1ea DIFF: https://github.com/llvm/llvm-project/commit/e35cc2d387e170d0e1f6ef647f17423262feb1ea.diff

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -123,11 +123,22 @@ lldb_private::formatters::LibcxxStdValarraySyntheticFrontEnd::Update() { return ChildCacheState::eRefetch; } -size_t lldb_private::formatters::LibcxxStdValarraySyntheticFrontEnd:: +llvm::Expected +lldb_private::formatters::LibcxxStdValarraySyntheticFro

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -259,14 +272,23 @@ lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEnd::Update() { return lldb::ChildCacheState::eRefetch; } -size_t lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEnd:: +llvm::Expected +lldb_private::formatters::LibcxxVectorBoolSynthetic

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -163,11 +163,24 @@ lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() { return lldb::ChildCacheState::eRefetch; } -size_t lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd:: +llvm::Expected +lldb_private::formatters::LibcxxStdVectorSyntheticFro

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-24 Thread Tom Tromey via lldb-commits
tromey wrote: > `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available > and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not > exist or is set to zero. So I decided to change lldb to match gdb's behavior > :( Can you file a gdb bug report with an execu

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-04-24 Thread via lldb-commits
anjenner wrote: The original PR (https://github.com/llvm/llvm-project/pull/115331) was approved and merged, but later reverted due an unstable test. The only difference in this version of the PR was a fix to make the test stable on Windows, so I thought it would be ok to merge by the approval

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-04-24 Thread via lldb-commits
dyung wrote: > The original PR (#115331) was approved and merged, but later reverted due an > unstable test. The only difference in this version of the PR was a fix to > make the test stable on Windows, so I thought it would be ok to merge by the > approval of the original PR. Apologies if I w

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-04-24 Thread via lldb-commits
anjenner wrote: Hmm... perhaps I have misunderstood the LLVM contribution process here. I had assumed that once all the review feedback had been addressed, some time had passed to allow reviewers to comment on the modifications resulting from review feedback, and the "merge" button was availab

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Host/posix/ProcessLauncherPosixFork.cpp

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Sod's law that the supposedly simple test would be the problem. I'll figure this out, I've disabled it on Windows for now. https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-24 Thread Yingwei Zheng via lldb-commits
dtcxzyw wrote: > > `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available > > and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not > > exist or is set to zero. So I decided to change lldb to match gdb's > > behavior :( > > Can you file a gdb bug report

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: I have got Arm's Foundation Model to boot with SME only, and the cpuinfo is: ``` Features: fp asimd evtstrm crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop asimddp asimdfhm dit uscat ilrcpc flagm sb paca pacg gcs dcpodp flagm2 frint i8mm bf16 dgh rn

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-04-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Therefore, this situation should only be an issue with older kernels, so > perhaps it not something that regular user mode applications should need to > worry about (unless specifically wanting to run with older kernels). I will test this PR with an older kernel as well.

[Lldb-commits] [lldb] [lldb] Fix crash after second run when set a previous watchpoint. (PR #136682)

2025-04-24 Thread via lldb-commits
https://github.com/hapee updated https://github.com/llvm/llvm-project/pull/136682 >From 563cbddfe9b7da394c818a03e05924c0f7d39d5f Mon Sep 17 00:00:00 2001 From: hapee <623151...@qq.com> Date: Tue, 22 Apr 2025 11:34:38 +0800 Subject: [PATCH 1/2] [lldb] Fix crash after second run when set a

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -174,6 +175,9 @@ int main(int argc, char **argv) { //% self.expect("expr (new struct C[1]); side_effect", endstr=" = 4\n") //% self.expect("expr delete c2; side_effect", endstr=" = 1\n") //% self.expect("expr delete[] c3; side_effect", endstr=" = 2\n") + //% self.expe

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-24 Thread Michael Buch via lldb-commits
Michael137 wrote: > Yeah, getting some numbers would be nice. Maybe just repeating the benchmark > in that diff. It might be a good idea to do it with and without the > accelerator tables, just to rule out any effect from those. Will do On Darwin (without accelerator tables and statically lin

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX +TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { + // Generate a name for the domain socket. + llvm::SmallString<64> name; + std::error_code EC = llvm::sys::fs::createUniq

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
@@ -455,37 +455,33 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; - + Log *log = GetLog(LLDBLog::Platform);

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX +TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { + // Generate a name for the domain socket. + llvm::SmallString<64> name; + std::error_code EC = llvm::sys::fs::createUniq

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX +TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { + // Generate a name for the domain socket. + llvm::SmallString<64> name; + std::error_code EC = llvm::sys::fs::createUniq

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
@@ -182,3 +191,20 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +llvm::Expected> +DomainSocket::FromBoundNativeSocket(NativeSocket sockfd, bool should_close) { +#ifdef __linux__ + // Check

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX labath wrote: ```suggestion ``` https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,10 @@ +#include +#include da-viper wrote: we could remove the includes as it is not really used in tests. as adding them increases the test times. https://github.com/llvm/llvm-project/pull/136494 ___ lld

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -1383,6 +1383,14 @@ enum CommandReturnObjectCallbackResult { eCommandReturnObjectPrintCallbackHandled = 1, }; +// Used to determine when to show disassembly eronnen wrote: :100: https://github.com/llvm/llvm-project/pull/136494 _

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-24 Thread David Spickett via lldb-commits
@@ -0,0 +1,76 @@ +//===-- RegisterInfoPOSIX_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-24 Thread David Spickett via lldb-commits
@@ -0,0 +1,76 @@ +//===-- RegisterInfoPOSIX_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 05d605e3add0461b12ddfbb24349e20be4259060 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/6] fallback to assembly when source code is not available --- ll

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-24 Thread via lldb-commits
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN) set(bolt_doxygen_qhp_cust_filter_attrs "") endif() - option(LLVM_DOXYGEN_SVG cor3ntin wrote: The couple of projects I found on Github (which sets it to "on" might get ``` CMake Warning: Manually-specified

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere Fixed comments and conflicts with `main`, from my part it's ready to merge https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-24 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,195 @@ +""" +Test lldb-dap stack trace when some of the source paths are missing +""" + +from lldbsuite.test.decorators import skipIfWindows +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +from contextlib import contextmanager +import os + + +

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()( llvm::json::Array stack_frames; llvm::json::Object body; + lldb::SBFormat frame_format = dap.frame_format; + + if (const auto *format = arguments->getObject("format")) { +const bool parameters = GetBool

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-24 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()( llvm::json::Array stack_frames; llvm::json::Object body; + lldb::SBFormat frame_format = dap.frame_format; + + if (const auto *format = arguments->getObject("format")) { ashgti wrote: Anot

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()( llvm::json::Array stack_frames; llvm::json::Object body; + lldb::SBFormat frame_format = dap.frame_format; + + if (const auto *format = arguments->getObject("format")) { +const bool parameters = GetBool

[Lldb-commits] [lldb] Ptrace seize dead process (PR #137041)

2025-04-24 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > I think the tricky part is that (in both cases) the user might legitimately > want to let the process exit, and "continue" is the normal way to do that, so > I don't think we'd want to just error out of the continue command (or from > the vCont packet). I think what we'd want

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-24 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137113 >From 21681616560eceb9b46ef4c370817099fe149701 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 23 Apr 2025 20:05:19 -0700 Subject: [PATCH 1/4] [lldb-dap] Support StackFrameFormat The debug adap

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-24 Thread Petr Hosek via lldb-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/136843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-04-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/137041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-24 Thread Adrian Prantl via lldb-commits
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString name) { } } } - return UINT32_MAX; + return llvm::createStringError( + "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'", adrian-prantl wro

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/24] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -102,3 +103,23 @@ def test_stackTrace(self): self.assertGreaterEqual( totalFrames, i, "total frames should include a pagination offset" ) + +@skipIfWindows da-viper wrote: should skip linux https://github.com/ll

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Ebuka Ezike via lldb-commits
@@ -217,3 +216,30 @@ def test_functionNameWithArgs(self): self.continue_to_next_stop() frame = self.get_stackFrames()[0] self.assertEqual(frame["name"], "recurse(x=1)") + +@skipIfWindows da-viper wrote: LGTM But I could not see why

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()( llvm::json::Array stack_frames; llvm::json::Object body; + lldb::SBFormat frame_format = dap.frame_format; + + if (const auto *format = arguments->getObject("format")) { +const bool parameters = GetBool

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/136748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/packa

[Lldb-commits] [lldb] 7a276c8 - [lldb] Fix logic error in AppleObjCTypeEncodingParser (#137067)

2025-04-24 Thread via lldb-commits
Author: Dave Lee Date: 2025-04-24T10:09:05-07:00 New Revision: 7a276c8acfc3977de8c3ceb0af67fcf603834946 URL: https://github.com/llvm/llvm-project/commit/7a276c8acfc3977de8c3ceb0af67fcf603834946 DIFF: https://github.com/llvm/llvm-project/commit/7a276c8acfc3977de8c3ceb0af67fcf603834946.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/137067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Host] Enable inheriting "non-inheritable" FDs (PR #126935)

2025-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/126935 >From ac748d0911fb1ccf7bb70955da2d70d7f9d9117e Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Sun, 20 Oct 2024 02:55:02 +0200 Subject: [PATCH] [lldb/Host] Enable inheriting "non-inheritable" FDs Currently we'

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread John Harrison via lldb-commits
@@ -180,44 +184,53 @@ void StackTraceRequestHandler::operator()( llvm::json::Object body; lldb::SBFormat frame_format = dap.frame_format; + bool include_all = false; ashgti wrote: Should this default to `dap.configuration.displayExtendedBacktrace` and th

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/5] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/115408 >From fc24e6cfed5f93f700a92618459365f2e320f2b1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 7 Nov 2024 17:18:50 -0800 Subject: [PATCH] [lldb] Support riscv32 corefiles --- .../Plugins/Proce

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-24 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/135843 >From 08834d47602b0df46e43678c08b3902d45145871 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Wed, 16 Apr 2025 00:30:51 +0500 Subject: [PATCH 1/3] [lldb][TypeSystemClang] Add a function `IsValidDereferenceType

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137113 >From 21681616560eceb9b46ef4c370817099fe149701 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 23 Apr 2025 20:05:19 -0700 Subject: [PATCH 1/3] [lldb-dap] Support StackFrameFormat The debug adap

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow arrays to be dereferenced in C/C++. (PR #135843)

2025-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes Add a function `IsValidDereferenceType` to TypeSystem. TypeSystemClang now allows arrays to be dereferenced. --- Full diff: https://github.com/llvm/llvm-project/pull/135843.diff 7 Files Affected: - (modified)

  1   2   >