[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread Pavel Labath via lldb-commits
labath wrote: > > We have a tests for this function in `unittests/Host/linux/HostTest.cpp` > > and it looks like at least some of it should apply to other systems as > > well. We could move it to the "posix" folder so that it applies to your > > code as well. Depending on the size of linux-spe

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/134354 >From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Fri, 4 Apr 2025 00:59:17 -0500 Subject: [PATCH 1/3] [lldb][AIX] get host info for AIX --- lldb/source/Hos

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-10 Thread Pavel Labath via lldb-commits
labath wrote: > > I'm also not very convinced by this "FlowAnalysis" thingy. Is it supposed > > to be a performance optimization (collapsing *&foo to foo) or does it do > > something more? > > FlowAnalysis is also used in subscript operator, to short-circuit getting an > address of an element

[Lldb-commits] [lldb] [lldb] Small refactor of eh_frame parsing (PR #134806)

2025-04-10 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/134806 >From f16fb6541556f5e82825207064f5f7bb6b3cd343 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Apr 2025 11:37:34 +0200 Subject: [PATCH 1/4] [lldb] Support negative function offsets in UnwindPlans These

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-10 Thread Pavel Labath via lldb-commits
labath wrote: I can push the button for you if you could just update the patch description to what you'd like the commit message to say (in particular, I think the last paragraph is no longer correct). As for cherry-picking, is this related to the lldb-server platform refactor in any way, or

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134956 >From 390942ce3a1cf6c51f95e8e2893f88807a48e745 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Apr 2025 17:33:41 -0700 Subject: [PATCH 1/2] [lldb] Handle signals in a separate thread in the dr

[Lldb-commits] [lldb] [lldb] Small refactor of eh_frame parsing (PR #134806)

2025-04-10 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/134806 >From eeaad560a727ea2b113ab3eff218f66a46e30c83 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Apr 2025 13:36:06 +0200 Subject: [PATCH 1/2] [lldb] Small refactor of eh_frame parsing .. which prepares us

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-10 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131609 >From 6f2d070facaced221295a5b0c48ccb3a41a5048d Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Mon, 17 Mar 2025 14:37:26 +0200 Subject: [PATCH 1/2] [lldb] Use correct path for debugserver ---

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread Hemang Gadhavi via lldb-commits
@@ -141,6 +141,7 @@ else() add_host_subdirectory(aix aix/Host.cpp aix/HostInfoAIX.cpp + linux/Support.cpp HemangGadhavi wrote: @labath This is a great suggestion. Thanks for suggestion. we will create the new PR for the same and create the

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Host/aix/Host.cpp `` View th

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Please re-run clang-format on the changes. https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > We have a tests for this function in `unittests/Host/linux/HostTest.cpp` and > it looks like at least some of it should apply to other systems as well. We > could move it to the "posix" folder so that it applies to your code as well. > Depending on the size of linux-spec

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-10 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: With the last commit, I observe no test regressions on macOS (on my pretty default build config). https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
https://github.com/youngd007 edited https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-10 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Yeah, I'm afraid this isn't the right way to use the MainLoop with signals. `AddPendingCallback` is not signal-safe. You need to actually let the main loop handle the signals (MainLoopPosix::RegisterSignal), as it knows how to do that safely. The function i

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-10 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM, thanks for fixing this! https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-10 Thread Pavel Labath via lldb-commits
@@ -141,6 +141,7 @@ else() add_host_subdirectory(aix aix/Host.cpp aix/HostInfoAIX.cpp + linux/Support.cpp labath wrote: This PR is small enough, so I think you can just do it here. At least it will have context for why you're doing this.

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-10 Thread Greg Clayton via lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-10 Thread via lldb-commits
kusmour wrote: > I wonder if we should add a test about the things we DON'T hand out when a > process is running just so we claim the behavior concretely. Unit tests on the SB API or DAP API tests? I am happy to add tests as follow-ups https://github.com/llvm/llvm-project/pull/134339 _

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-10 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 17 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/3684 Here is the relevant piece of

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-10 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: I'm looking on it. https://github.com/llvm/llvm-project/pull/132274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:21:25 +0100 Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to OutputB

[Lldb-commits] [lldb] [llvm] [dsymutil] Avoid copying binary swiftmodules built from textual (PR #134719)

2025-04-10 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `polly-x86_64-linux-shared` running on `polly-x86_64-gce2` while building `lldb,llvm` at step 5 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/97/builds/5912 Here is the relevant piece of the

[Lldb-commits] [lldb] 8877b91 - [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips target (#132688)

2025-04-10 Thread via lldb-commits
Author: yingopq Date: 2025-04-09T10:53:47+02:00 New Revision: 8877b913ae88c6ae43e859316489fe0469293131 URL: https://github.com/llvm/llvm-project/commit/8877b913ae88c6ae43e859316489fe0469293131 DIFF: https://github.com/llvm/llvm-project/commit/8877b913ae88c6ae43e859316489fe0469293131.diff LOG:

[Lldb-commits] [lldb] 6493345 - [lldb] Handle signals in a separate thread in the driver (#134956)

2025-04-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-10T11:04:05-07:00 New Revision: 6493345c5ab96f60ab5ee38272fb6635f2083318 URL: https://github.com/llvm/llvm-project/commit/6493345c5ab96f60ab5ee38272fb6635f2083318 DIFF: https://github.com/llvm/llvm-project/commit/6493345c5ab96f60ab5ee38272fb6635f2083318.d

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-10 Thread Greg Clayton via lldb-commits
clayborg wrote: Signals can be listened for via a file descriptor as well. Not sure if this improves the ability to do things in signal handlers as the default way of catching signals has all sorts of limitations. If it does improve the safety and ability to do things in the signal handler, we

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-10 Thread via lldb-commits
jimingham wrote: That code has been there at least since the dread reformatting. I have no idea why past one of us thought it was a good idea to return the previous number of threads or the old thread list when you weren't stopped. We don't do that with most anything else you ask about thre

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-10 Thread Pavel Labath via lldb-commits
labath wrote: > Is it a general consensus that people shouldn't use unit tests anymore? They shouldn't use unit tests for building debug subjects. https://github.com/llvm/llvm-project/pull/134428 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [llvm] [dsymutil] Avoid copying binary swiftmodules built from textual (PR #134719)

2025-04-10 Thread Jan Patrick Lehr via lldb-commits
jplehr wrote: Hi @adrian-prantl can this be forward fixed or better revert in the meantime? Thanks! https://github.com/llvm/llvm-project/pull/134719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebased on top of https://github.com/llvm/llvm-project/pull/134956 which means we can now safely lock everywhere we access `m_statusline`. https://github.com/llvm/llvm-project/pull/134759 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/134759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134759 >From 9fcc1c89ff0361d9262abefe951b43dd37555fea Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Apr 2025 11:13:12 -0700 Subject: [PATCH] [lldb] Synchronize access to m_statusline in the Debugg

[Lldb-commits] [lldb] [lldb] Support programmatically setting the statusline format (NFC) (PR #135250)

2025-04-10 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Seems reasonable to me. https://github.com/llvm/llvm-project/pull/135250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -345,6 +347,10 @@ llvm::json::Value DebuggerStats::ReportStatistics( ++debug_index_saved; module_stat.debug_index_time = sym_file->GetDebugInfoIndexTime().count(); module_stat.debug_parse_time = sym_file->GetDebugInfoParseTime().count(); + module_sta

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -72,6 +72,12 @@ FileSpec::FileSpec(llvm::StringRef path, Style style) : m_style(style) { SetFile(path, style); } +FileSpec::FileSpec(llvm::StringRef path, const double download_time, + Style style) +: m_download_time(download_time) { + SetFile(path

[Lldb-commits] [lldb] [lldb] Support programmatically setting the statusline format (NFC) (PR #135250)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/135250 Support programmatically setting the statusline format. I want to use this API downstream, to change the statusline format for the Swift REPL. >From 30b5cfbce089ffccec1e2519c6cd4dd21a9d0b79 Mon Sep 17 00:0

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM! :) https://github.com/llvm/llvm-project/pull/134759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a62b9b3 - [lldb] Calling Debugger::SetStatuslineFormat should redraw the statusline

2025-04-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-10T16:55:59-07:00 New Revision: a62b9b387fab85ae8ad63992b002c333069d87ae URL: https://github.com/llvm/llvm-project/commit/a62b9b387fab85ae8ad63992b002c333069d87ae DIFF: https://github.com/llvm/llvm-project/commit/a62b9b387fab85ae8ad63992b002c333069d87ae.d

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-04-10 Thread Greg Clayton via lldb-commits
@@ -969,6 +969,64 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +lldb_private::DataBufferHeap &data_buffer, +const lldb_private::CoreFileMemoryRange &range, uint64_t &bytes_read) { + +

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FormatEntity][NFCI] Refactor FunctionNameWithArgs into helper functions and use LLVM style (PR #135031)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/135031 I've always found this hard to read. Some upcoming changes make similar computations, so I thought it's a good time to factor out this logic into re-usable helpers and clean it up using LLVM's preferred earl

[Lldb-commits] [lldb] [lldb] Make sure the process is stopped when computing the symbol context (PR #134757)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks for the report, @cmtice. I haven't seen this issue and I'm pretty baffled. I wonder if it has something to do with the implementation of GetRunLock: ``` ProcessRunLock &Process::GetRunLock() { if (m_private_state_thread.EqualsThread(Host::GetCurrentThread())) r

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/135296 This reapplies commit 232525f06942adb3b9977632e38dcd5f08c0642d. The original commit triggered a sanitizer failure when Target was destroyed. In Target::Destroy, `DeleteCurrentProcess` was called, but i

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This reapplies commit 232525f06942adb3b9977632e38dcd5f08c0642d. The original commit triggered a sanitizer failure when Target was destroyed. In Target::Destroy, `DeleteCurrentProcess` w

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/135296 >From b24dc5da70443eb15819c6134ddd38c84f86a5e5 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 9 Apr 2025 07:38:13 -0700 Subject: [PATCH] Reland "[lldb] Clear thread-creation breakpoi

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Nice debugging on this one, it can be a little unclear of the intended jobs for each of the reset/clear/terminate methods. This looks good to me. https://github.com/llvm/llvm-project/pull/135296 ___

[Lldb-commits] [lldb] Reland "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)" (PR #135296)

2025-04-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/135296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -111,7 +111,7 @@ struct ModuleStats { std::string uuid; std::string triple; // Path separate debug info file, or empty if none. - std::string symfile_path; + std::vector symfile_path; GeorgeHuyubo wrote: removed https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -4267,6 +4269,8 @@ const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile() { // find the correct DWP file, as the Debuginfod plugin uses *only* this // data to correctly match the DWP file with the binary. module_spec.GetUUID() = m_objfile_sp->GetUUID()

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -355,6 +355,8 @@ class SymbolFile : public PluginInterface { virtual const ObjectFile *GetObjectFile() const = 0; virtual ObjectFile *GetMainObjectFile() = 0; + virtual std::vector GetAllObjectFiles(); + GeorgeHuyubo wrote: removed https://github.com

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -4267,6 +4269,8 @@ const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile() { // find the correct DWP file, as the Debuginfod plugin uses *only* this // data to correctly match the DWP file with the binary. module_spec.GetUUID() = m_objfile_sp->GetUUID()

[Lldb-commits] [lldb] [lldb] Support programmatically setting the statusline format (NFC) (PR #135250)

2025-04-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Support programmatically setting the statusline format. I want to use this API downstream, to change the statusline format for the Swift REPL. --- Full diff: https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From 85bee8e66fcbc7b2001e2c06499b3458a197be25 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 8 Apr 2025 18:12:29 -0700 Subject: [PATCH 1/2] Add locate time for each module in statistics --- lldb/inc

[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

2025-04-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/134922.diff 1 Files Affected: - (modified) lldb/include/lldb/Core/Telemetry.h (+2-1) ``diff diff --git a/lldb/include/lldb/Core/Telemetry.h

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: We should talk about the new API you want to add: ``` virtual std::vector SymbolFile::GetAllObjectFiles(); ``` https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [LLDB] Fix warnings in DIL. (PR #134778)

2025-04-10 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/134778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-10 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/132274 >From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Thu, 20 Mar 2025 21:50:51 +0400 Subject: [PATCH 1/3] [LLDB] Refactored CPlusPlusLanguage::MethodName to break

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:21:25 +0100 Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to OutputB

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. https://github.com/llvm/llvm-project/pull/134759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-10 Thread Pavel Labath via lldb-commits
@@ -824,5 +834,11 @@ int main(int argc, char const *argv[]) { future.wait(); } + // Stop the signal handler thread. Do this after calling SBDebugger::Terminate + // so that impatient users can send a SIGSTOP if they don't want to wait for labath wrote

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-10 Thread Michael Buch via lldb-commits
Michael137 wrote: FYI, this also broke the `TestObjCBreakpoints.py` test on `arm64` macOS: ``` FAIL: LLDB (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb-build/bin/clang-arm64) :: test_break_dwarf (TestObjCBreakpoints.TestObjCBreakpoints) UNSUPPORTED: LLDB (/Users/ec2-user/jenki

[Lldb-commits] [compiler-rt] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:21:25 +0100 Subject: [PATCH 1/6] [ItaniumDemangle] Add printLeft/printRight APIs to OutputB

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-10 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Maybe rename `CPlusPlusLanguage::CPPMethodName` to `CPlusPlusLanguage::CxxMethodName`? Any preferences? https://github.com/llvm/llvm-project/pull/132274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] e84a804 - [lldb] Make sure the process is stopped when computing the symbol context (#134757)

2025-04-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-08T11:06:05-07:00 New Revision: e84a80408523a48d6eaacd795f1615e821ffb233 URL: https://github.com/llvm/llvm-project/commit/e84a80408523a48d6eaacd795f1615e821ffb233 DIFF: https://github.com/llvm/llvm-project/commit/e84a80408523a48d6eaacd795f1615e821ffb233.d

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From 65aab6b727cc430a9e826c7eeda67259e041a462 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:21:25 +0100 Subject: [PATCH 1/5] [ItaniumDemangle] Add printLeft/printRight APIs to OutputB

[Lldb-commits] [lldb] [llvm] Revert "[dsymutil] Avoid copying binary swiftmodules built from textual" (PR #134872)

2025-04-10 Thread Jan Patrick Lehr via lldb-commits
jplehr wrote: Already reverted. https://github.com/llvm/llvm-project/pull/134872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-10 Thread via lldb-commits
@@ -52,8 +64,14 @@ void ConfigurationDoneRequestHandler::operator()( dap.configuration_done_sent = true; if (dap.stop_at_entry) SendThreadStoppedEvent(dap); - else + else { +// Client requests the baseline of currently existing threads after +// a successful l

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-10 Thread via lldb-commits
@@ -52,8 +64,14 @@ void ConfigurationDoneRequestHandler::operator()( dap.configuration_done_sent = true; if (dap.stop_at_entry) SendThreadStoppedEvent(dap); - else + else { +// Client requests the baseline of currently existing threads after +// a successful l

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-10 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/134339 >From 0c4f6ca21ba6ae37e3a884f4bcc356b6f741ede7 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 3 Apr 2025 22:29:13 -0700 Subject: [PATCH 1/2] [lldb] Make SBProcess thread related actions listen to StopLocker

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-10 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/134339 >From 0c4f6ca21ba6ae37e3a884f4bcc356b6f741ede7 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 3 Apr 2025 22:29:13 -0700 Subject: [PATCH 1/2] [lldb] Make SBProcess thread related actions listen to StopLocker

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-10 Thread Pavel Labath via lldb-commits
labath wrote: I kinda like signalfd(2), although the implementation makes it kinda hard to use in environments you don't fully control. For one, it requires that the signal you're listening to is blocked on *all* threads in the process. If any thread unblocks it for any reason, you will miss t

[Lldb-commits] [lldb] [lldb] Support negative function offsets in UnwindPlans (PR #134662)

2025-04-10 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/134662 These are needed for functions whose entry point is not their lowest address. >From 10a1029d776bf5dcae5fe69a72883916de7c4b5f Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Apr 2025 11:37:34 +0200 Subje

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-10 Thread Greg Clayton via lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
@@ -246,6 +246,8 @@ class Mangled { /// for s, otherwise the enumerator for the mangling scheme detected. static Mangled::ManglingScheme GetManglingScheme(llvm::StringRef const name); + static bool IsCPPMangledName(llvm::StringRef name); JDevlieghere

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-10 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/7267 Here is the relevant piece

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: I do like the ability to enable/disable any plug-in, but we should only add support for enabling and disabling plug-ins that are optional. This patch adds the ability to enable/disable system runtime plug-ins so that is good. A few things to think about:

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-10 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15581 Here is the relevant piece of the b

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
@@ -422,6 +424,11 @@ class SymbolFile : public PluginInterface { /// hasn't been indexed yet, or a valid duration if it has. virtual StatsDuration::Duration GetDebugInfoIndexTime() { return {}; } + /// Return the time it took to locate any extra symbol files. + /// + //

[Lldb-commits] [lldb] [lldb] Remove unused UnwindPlan functions (PR #134630)

2025-04-10 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/134630 `GetLSDAAddress` and `GetPersonalityRoutinePtrAddress` are unused and they create a bit of a problem for discontinuous functions, because the unwind plan for these consists of multiple eh_frame descriptors and (

[Lldb-commits] [lldb] 369c773 - Revert "[lldb][debugserver] Fix an off-by-one error in watchpoint identification (#134314)"

2025-04-10 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-07T11:21:58-07:00 New Revision: 369c7739d0853b7931410037843d5a63f50bc0a1 URL: https://github.com/llvm/llvm-project/commit/369c7739d0853b7931410037843d5a63f50bc0a1 DIFF: https://github.com/llvm/llvm-project/commit/369c7739d0853b7931410037843d5a63f50bc0a1.diff

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-10 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/132274 >From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Thu, 20 Mar 2025 21:50:51 +0400 Subject: [PATCH 1/3] [LLDB] Refactored CPlusPlusLanguage::MethodName to break

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-10 Thread Greg Clayton via lldb-commits
@@ -46,12 +49,333 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] [llvm] Revert "[dsymutil] Avoid copying binary swiftmodules built from textual" (PR #134872)

2025-04-10 Thread Jan Patrick Lehr via lldb-commits
https://github.com/jplehr created https://github.com/llvm/llvm-project/pull/134872 Reverts llvm/llvm-project#134719 This broke many buildbots >From d96389666d37d0bdd898e2f1812e89b277a3fb74 Mon Sep 17 00:00:00 2001 From: Jan Patrick Lehr Date: Tue, 8 Apr 2025 17:52:11 +0200 Subject: [PATCH] =?

[Lldb-commits] [lldb] df28c81 - [lldb][debugserver] Fix an off-by-one error in watchpoint identification (#134314)

2025-04-10 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-04-07T13:50:31-07:00 New Revision: df28c81f5a2b61a3b5ad1e6274dd27697a9367ac URL: https://github.com/llvm/llvm-project/commit/df28c81f5a2b61a3b5ad1e6274dd27697a9367ac DIFF: https://github.com/llvm/llvm-project/commit/df28c81f5a2b61a3b5ad1e6274dd27697a9367ac.diff

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips target (PR #132688)

2025-04-10 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/132688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-10 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > We are now seeing non-determinism in `.pcm` files that root-causes to this > commit. > > @mizvekov - might it be something obvious, like pointer-keyed containers or > similar? I don't see anything obvious. The only parts of the patch which touch anything similar to pointer-

[Lldb-commits] [lldb] 2b984fd - [lldb] Support programmatically setting the statusline format (NFC) (#135250)

2025-04-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-10T15:36:28-07:00 New Revision: 2b984fd0e396fe6ab30cd823ea2f65f33f75409c URL: https://github.com/llvm/llvm-project/commit/2b984fd0e396fe6ab30cd823ea2f65f33f75409c DIFF: https://github.com/llvm/llvm-project/commit/2b984fd0e396fe6ab30cd823ea2f65f33f75409c.d

[Lldb-commits] [lldb] [lldb] Support programmatically setting the statusline format (NFC) (PR #135250)

2025-04-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/135250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-10 Thread Arthur Eubanks via lldb-commits
aeubanks wrote: @mizvekov we're seeing pcm non-determinism after this reland, does anything jump out at you? https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-10 Thread Ilia Kuklin via lldb-commits
@@ -18,6 +18,22 @@ namespace lldb_private::dil { +static lldb::ValueObjectSP +ArrayToPointerConversion(lldb::ValueObjectSP valobj, + std::shared_ptr ctx) { + assert(valobj->IsArrayType() && + "an argument to array-to-pointer conversion must be

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
https://github.com/GeorgeHuyubo reopened https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-10 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From 4c4a2bf0883fee1939ed6dd4c55826688d75466c Mon Sep 17 00:00:00 2001 From: George Hu Date: Thu, 10 Apr 2025 13:03:43 -0700 Subject: [PATCH] Add download time for each module in statistics --- lldb/incl

  1   2   >