[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread Michael Buch via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); Michael137 wrote: Thanks! https://github.com/llvm/llvm-project/pull/134097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath requested changes to this pull request. I think this is too mechanical and has too many layers of abstraction. SystemInitializer was supposed to be the customizable part of the initialization machinery. Please try to find a way to move this call there. https://github.

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134397 Currently, these breakpoints are being accumulated every time a new process if created (e.g. through a `run`). Depending on the circumstances, the old breakpoints are even left enabled, interfering with

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/134397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/134397 >From e7689b631d898e4f2a6f2cff6e60c1a05a65c7ea Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 4 Apr 2025 07:56:38 -0700 Subject: [PATCH] [lldb] Clear thread-creation breakpoints in

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes Currently, these breakpoints are being accumulated every time a new process if created (e.g. through a `run`). Depending on the circumstances, the old breakpoints are even left enabled, i

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. I wanted to make this point in #132274, but it fits here as well. I understand the need to reduce the binary size of `lldb-server` and I'm totally supportive of it. Moving some code around to avoid pulling in some symbols m

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/134383 >From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 4 Apr 2025 17:49:07 +0400 Subject: [PATCH 1/2] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeM

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/134383 >From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 4 Apr 2025 17:49:07 +0400 Subject: [PATCH 1/2] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeM

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > It seems like we should address this issue by first fixing the existing > layering violations, then introducing more layering for `lldb-server` so that > we bring the granularity to the library level, not the individual object file > (i.e. source file) level which is too gran

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-04 Thread via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I don't see much difference between using libraries or a number of object > file. It's easier to reason about libraries and library dependencies. Not counting the plugins, we have ~10 libraries and ~1000 object files. The difference is knowing what can depend on what. E

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/134339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. +1 on what Jim said. https://github.com/llvm/llvm-project/pull/134397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); DavidSpickett wrote: Sorry yes it is building now but failing: ``` FAIL: test (TestExprFromNonZeroFrame.ExprFromNonZeroFrame.test) Tests that we can use SBFrame::EvaluateExpression on a fram

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/134418 This commit adds three new commands for managing plugins. The `list` command will show which plugins are currently registered and their enabled state. The `enable` and `disable` commands can be used to enable or

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) Changes This commit adds three new commands for managing plugins. The `list` command will show which plugins are currently registered and their enabled state. The `enable` and `disable` commands can be used to enabl

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Reading the description, it seems like the third option would be the right one: ``` 3. Improve the run lock. This is a synchronize issue where process was in the middle of resuming while lldb-dap attempts to interrupt it. ``` and this patch is working around that while and

[Lldb-commits] [lldb] 232525f - [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (#134397)

2025-04-04 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-04T10:05:44-07:00 New Revision: 232525f06942adb3b9977632e38dcd5f08c0642d URL: https://github.com/llvm/llvm-project/commit/232525f06942adb3b9977632e38dcd5f08c0642d DIFF: https://github.com/llvm/llvm-project/commit/232525f06942adb3b9977632e38dcd5f0

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/134397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
jeffreytan81 wrote: `lost connection ` usually indicates lldb-server crasing. Is it what happening in this situation? If so, we should harden lldb-server to not crash. https://github.com/llvm/llvm-project/pull/134339 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
@@ -73,9 +73,11 @@ void AttachRequestHandler::operator()(const llvm::json::Object &request) const { llvm::StringRef core_file = GetString(arguments, "coreFile").value_or(""); const uint64_t timeout_seconds = GetInteger(arguments, "timeout").value_or(30); - dap.stop_

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
kusmour wrote: > `lost connection ` usually indicates lldb-server crasing. Is it what > happening in this situation? If so, we should harden lldb-server to not crash. I have debugged lldb-server and it didn't crash. Instead it finished the and exit with status 0. From my investigation this is

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
@@ -73,9 +73,11 @@ void AttachRequestHandler::operator()(const llvm::json::Object &request) const { llvm::StringRef core_file = GetString(arguments, "coreFile").value_or(""); const uint64_t timeout_seconds = GetInteger(arguments, "timeout").value_or(30); - dap.stop_

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: @labath now that we've fixed the other issue, can you weigh in on my solution for this one? If you don't have time and want to deal with this next week, that's also fine, just making sure this PR didn't get forgotten https://github.com/llvm/llvm-project/pull/131609

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb] Return *const* UnwindPlan pointers from FuncUnwinders " (PR #134246)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/134246 This reverts commit 094904303d50e0ab14bc5f2586a602f79af95953, reapplying d7afafdbc464e65c56a0a1d77bad426aa7538306 (#133247). The failure ought to be fixed by 0509932bb6a291ba11253f30c465ab3ad164ae08. >From f8d2

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread via lldb-commits
jimingham wrote: Either no one is going to use this except experts, or people will start cargo-culting "turn off plugin X and lldb will be faster" and then we get "Why doesn't " work, to which the answer would be "turn on plugin X" but people may not even know they have this off (a surprising

[Lldb-commits] [lldb] [lldb] Make lldbassert fire only once per instance (PR #134343)

2025-04-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/134343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/134428.diff 9 Files Affected: - (modified) lldb/docs/dil-expr-lang.ebnf (+3-1) - (modified) lldb/include/lldb/ValueObject/DILAST.h (+32) - (modified

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-04 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/134428 None >From 2b85f5a42d3ba8e8544ddeb0b578c82c02f8de0c Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Fri, 4 Apr 2025 22:13:02 +0500 Subject: [PATCH] Add unary operators Dereference and AddressOf --- lldb/docs/

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-04 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/134428 >From 58c4f082452bc0600dcf72ba89cbfeafc109cc54 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Fri, 4 Apr 2025 22:13:02 +0500 Subject: [PATCH] Add unary operators Dereference and AddressOf --- lldb/docs/dil-ex

[Lldb-commits] [lldb] [lldb-dap] Creating a common configuration structure for launch and attach requests. (PR #133960)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133960 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/134160 >From 48150d4bb0daf57b708f4fa86285f028eeff0da6 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 2 Apr 2025 09:28:56 -0700 Subject: [PATCH 1/2] [lldb][NFC] Move ShouldShow/ShouldSelect

[Lldb-commits] [lldb] ff21b50 - Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (#132043)

2025-04-04 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-03-20T18:05:06-04:00 New Revision: ff21b50509c88606a8220002865c3e42e825a3b3 URL: https://github.com/llvm/llvm-project/commit/ff21b50509c88606a8220002865c3e42e825a3b3 DIFF: https://github.com/llvm/llvm-project/commit/ff21b50509c88606a8220002865c3e42e825a3b3.diff LOG

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix use-after-free in SBMutexTest (PR #133840)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/133840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add enable/disable api for SystemRuntime plugins (PR #133794)

2025-04-04 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/7555 Here is the relevant piece of t

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -58,3 +59,45 @@ def test_platform_process_launch_gdb_server(self): self.runCmd("target create {}".format(self.getBuildArtifact("a.out"))) self.expect("run", substrs=["unable to launch a GDB server on"], error=True) + +@skipIfRemote +@skipUnlessPlatf

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-04 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/134184 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-04 Thread via lldb-commits
@@ -468,7 +468,23 @@ class CommandObjectProcessContinue : public CommandObjectParsed { case 'b': m_run_to_bkpt_args.AppendArgument(option_arg); m_any_bkpts_specified = true; - break; +break; jimingham wrote: This isn't how y

[Lldb-commits] [lldb] dca7e03 - [lldb] add --platform-available-ports option to the dotest.py (#112555)

2025-04-04 Thread via lldb-commits
Author: dlav-sc Date: 2025-04-01T10:07:44+01:00 New Revision: dca7e0370e9684c00d95fb810c4efd31af0a3a9f URL: https://github.com/llvm/llvm-project/commit/dca7e0370e9684c00d95fb810c4efd31af0a3a9f DIFF: https://github.com/llvm/llvm-project/commit/dca7e0370e9684c00d95fb810c4efd31af0a3a9f.diff LOG:

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
kusmour wrote: > Reading the description, it seems like the third option would be the right > one: > > ``` > 3. Improve the run lock. This is a synchronize issue where process was in the > middle of resuming while lldb-dap attempts to interrupt it. > ``` > > and this patch is working around t

[Lldb-commits] [lldb] control Darwin parallel image loading with target.parallel-module-load (PR #134437)

2025-04-04 Thread Tom Yang via lldb-commits
https://github.com/zhyty created https://github.com/llvm/llvm-project/pull/134437 A requested follow-up from https://github.com/llvm/llvm-project/pull/130912 by @JDevlieghere to control Darwin parallel image loading with the same `target.parallel-module-load` that controls the POSIX dyld paral

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] Fix typos: paramter, parametr, parametere (PR #134092)

2025-04-04 Thread Jay Foad via lldb-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/134092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This NFC patch simplifies the main loop in HandleProcessStateChanged event by moving duplicated code into the StopInfo class, also allowing StopInfo subclasses to override behavior. More

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: I have updated this patch. But it seems we can keep Language.h, ObjCLanguage.* and Module.cpp untouched, because `a proper way` is useless for our purpose. `CPlusPlusLanguage::MethodName`, `CPlusPlusLanguage::IsCPPMangledName` and `CPlusPlusLanguage::ExtractContextAndIdentifier

[Lldb-commits] [lldb] control Darwin parallel image loading with target.parallel-module-load (PR #134437)

2025-04-04 Thread Tom Yang via lldb-commits
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/134437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] control Darwin parallel image loading with target.parallel-module-load (PR #134437)

2025-04-04 Thread Tom Yang via lldb-commits
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/134437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/132884 >From 6edc108199044d30eed396145aab463db40d6351 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Thu, 13 Mar 2025 16:13:45 -0700 Subject: [PATCH 1/2] Remove raw access to PluginInstances vector This commit mod

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -229,136 +230,45 @@ static void EventThreadFunction(DAP &dap) { } } -// "InitializeRequest": { -// "allOf": [ { "$ref": "#/definitions/Request" }, { -// "type": "object", -// "description": "Initialize request; value of command field is -// '

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Commands/CommandObjectPlugin.cpp lldb/so

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/4] Add commands to list/enable/disable plugins This commit add

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-04 Thread David Peixotto via lldb-commits
dmpots wrote: > LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` > running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 > "test". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/59/builds/15362 > > Here is the relevant

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread John Harrison via lldb-commits
@@ -778,28 +817,121 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) { return ToError(error); } +bool DAP::IsCancelled(const protocol::Request &req) { + std::lock_guard lock(m_cancelled_requests_mutex); + return m_cancelled_requests.contains(req.seq); +} + +void DAP:

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-04 Thread Mikhail Zakharov via lldb-commits
https://github.com/real-mikhail updated https://github.com/llvm/llvm-project/pull/129092 >From 1d2da22bceb83cbda54567e5f819e5eef4e6 Mon Sep 17 00:00:00 2001 From: Mikhail Zakharov Date: Thu, 27 Feb 2025 18:43:33 +0100 Subject: [PATCH 01/10] [lldb] Do not bump memory modificator ID when "in

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
@@ -46,12 +49,344 @@ class CommandObjectPluginLoad : public CommandObjectParsed { } }; +namespace { +#define LLDB_OPTIONS_plugin_list +#include "CommandOptions.inc" + +// These option definitions are shared by the plugin list/enable/disable +// commands. +class PluginListCo

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132234)

2025-04-04 Thread Matheus Izvekov via lldb-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/132234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB] Expose checking if the symbol file exists/is loaded via SBModule" (PR #134341)

2025-04-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/134341 Reverts llvm/llvm-project#134163 Reverting while @clayborg and I come up with a better API >From e789e78d20c0dfe70d4e977b259460f1c8008515 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 3 Apr 2025 20:4

[Lldb-commits] [lldb] [lldb-dap] Enable runInTerminal tests on macOS. (PR #133824)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/133824 These tests are currently filtered on macOS if your on an M1 (or newer) device. These tests do work on macOS, for me at least on M1 Max with macOS 15.3.2 and Xcode 16.2. Enabling them again, but if we have CI p

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-04 Thread Vy Nguyen via lldb-commits
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] [lldb] Change test paths to resolve symlinks (PR #132053)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/132053 This commit modifes the `getSourceDir()` and `getBuildDir()` functions to use os.path.realpath to resolve symlinks in the Base test class used for API tests. A few tests were failing when the build and source di

[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/131979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-04 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: CI bots showed a fail in lldb-api.tools/lldb-server.TestGdbRemoteRegisterState.py , will debug and update. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/23305/ https://github.com/llvm/llvm-project/pull/134184 __

[Lldb-commits] [lldb] [lldb/DWARF] Remove "range lower than function low_pc" check (PR #132395)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The check is not correct for discontinuous functions, as one of the blocks could very well begin before the function entry point. To catch dead-stripped ranges, I check whether the functions is after the first

[Lldb-commits] [lldb] [lldb] Make lldbassert fire only once per instance (PR #134343)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 03604a7 - [lldb] Make lldbassert fire only once per instance (#134343)

2025-04-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-04T12:53:10-07:00 New Revision: 03604a784011bec2292f900b118d825f34f8cf89 URL: https://github.com/llvm/llvm-project/commit/03604a784011bec2292f900b118d825f34f8cf89 DIFF: https://github.com/llvm/llvm-project/commit/03604a784011bec2292f900b118d825f34f8cf89.d

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show the path to the .o instead of the containing .a in progress events (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133370 >From 8af1b715a2d2dd19f8ff374c1fcc4c513a2e6fed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 4 Apr 2025 13:02:57 -0700 Subject: [PATCH] [lldb] Add a {ObjectFile,SymbolFile}::GetObjectName meth

[Lldb-commits] [lldb] 12cf6d3 - [lldb] Fix missing semicolon in lldbassert macro

2025-04-04 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-04T13:37:12-07:00 New Revision: 12cf6d3b9e0b4983d609576b15dc37ceb7d1d8d7 URL: https://github.com/llvm/llvm-project/commit/12cf6d3b9e0b4983d609576b15dc37ceb7d1d8d7 DIFF: https://github.com/llvm/llvm-project/commit/12cf6d3b9e0b4983d609576b15dc37ceb7d1d8d7.d

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134314 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes This fixes an uncommon bug with debugserver controlling an inferior process that is hitting an internal breakpoint & continuing when multiple interrupts are sent by SB API to lldb. In the reproducing s

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-04 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: There is another Pull Request for the same functionality #108036. The other PR seems to be outdated, though, and this PR seems to be further along (e.g. it also has test cases). CC @jennphilqc @walter-erquinigo @clayborg since you commented on the other PR and might also be

[Lldb-commits] [lldb] d535554 - [lldb] Prefer PointerType::get with LLVMContext over Type (NFC) (#133869)

2025-04-04 Thread via lldb-commits
Author: Mats Jun Larsen Date: 2025-04-01T23:27:29Z New Revision: d53555499f85b7aedb765c66d6f3850c7bc6126d URL: https://github.com/llvm/llvm-project/commit/d53555499f85b7aedb765c66d6f3850c7bc6126d DIFF: https://github.com/llvm/llvm-project/commit/d53555499f85b7aedb765c66d6f3850c7bc6126d.diff LO

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130169 >From c183231db80d6c97bdd5e9bd0b21d041189146e8 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 18 Mar 2025 14:05:38 -0700 Subject: [PATCH 01/12] [lldb-dap] Adding support for cancelling a request. Adding

[Lldb-commits] [lldb] [lldb][NFC] use platform independent path separator in testSettings.py. (PR #132392)

2025-04-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/132392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
@@ -36,35 +42,59 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() - -self.runCmd( -"env Sanitizer

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Stop the process for the threads request (PR #134456)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/134456 None >From 621a5f78b72232e3f76dc2c6162bffc8051045ae Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 4 Apr 2025 15:07:21 -0700 Subject: [PATCH] [lldb-dap] Stop the process for the threads reques

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-04-04 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer edited https://github.com/llvm/llvm-project/pull/130516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Mariusz Borsa via lldb-commits
@@ -10,22 +10,28 @@ from lldbsuite.test import lldbutil from lldbsuite.test_event.build_exception import BuildError -class AsanTestCase(TestBase): +class MemoryHistoryTestCase(TestBase): wrotki wrote: 👍 https://github.com/llvm/llvm-project/pull/134323 __

[Lldb-commits] [lldb] 5286511 - [lldb][NFC] use platform independent path separator in testSettings.py. (#132392)

2025-04-04 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-03-21T14:02:52Z New Revision: 5286511adc94529c2d0ee9ea37c121ff7eaea223 URL: https://github.com/llvm/llvm-project/commit/5286511adc94529c2d0ee9ea37c121ff7eaea223 DIFF: https://github.com/llvm/llvm-project/commit/5286511adc94529c2d0ee9ea37c121ff7eaea223.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -15,17 +15,23 @@ class AsanTestCase(TestBase): @expectedFailureNetBSD @skipUnlessAddressSanitizer def test(self): -self.build(make_targets=["asan"]) +self.build(make_targets=["compiler_rt-asan"]) self.asan_tests() yln wro

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
dmpots wrote: > Another way to do this would be to have the list of disabled plugins show in > the result of the `version` command, since that's a commonly provided bit of > info for bug reports. Thanks for the suggestion. Let me work on this and update the PR. https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -778,28 +817,121 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) { return ToError(error); } +bool DAP::IsCancelled(const protocol::Request &req) { + std::lock_guard lock(m_cancelled_requests_mutex); + return m_cancelled_requests.contains(req.seq); +} + +void DAP:

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -9,127 +9,66 @@ #include "DAP.h" #include "EventHelper.h" #include "JSONUtils.h" +#include "Protocol/ProtocolRequests.h" #include "RequestHandler.h" #include "llvm/Support/FileSystem.h" namespace lldb_dap { -// "LaunchRequest": { -// "allOf": [ { "$ref": "#/definiti

<    1   2   3   >