[Lldb-commits] [lldb] [lldb][RISCV] fix LR/SC atomic sequence handling in lldb-server (PR #127505)

2025-04-04 Thread Alex Bradbury via lldb-commits
asb wrote: My apologies for missing this before. It is indeed completely valid to have a compressed branch immediately after the lr.w or sc.w and remain compliant with the forward progress guarantee. I feel I'm lacking a bit of higher level understanding of what this code is trying to do it, b

[Lldb-commits] [lldb] [LLDB] Fix tests on Windows (PR #131600)

2025-04-04 Thread Aleksandr Korepanov via lldb-commits
@@ -201,8 +201,15 @@ def test_watch_address_with_invalid_watch_size(self): value.GetValueAsUnsigned(), 365, wp_opts, error ) self.assertFalse(watchpoint) -self.expect( -error.GetCString(), -exe=

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/2] Add commands to list/enable/disable plugins This commit add

[Lldb-commits] [lldb] control Darwin parallel image loading with target.parallel-module-load (PR #134437)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Tom Yang (zhyty) Changes A requested follow-up from https://github.com/llvm/llvm-project/pull/130912 by @JDevlieghere to control Darwin parallel image loading with the same `target.parallel-module-load` that controls the POSIX dyld paralle

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-04 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: @nico thanks, that's landed. Let me know if it's all green now, otherwise we proceed with the revert. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] 52de49e - [lldb][debugserver][MacOSX] Work around sanitizer misaligned address errors when reading exception data (#132193)

2025-04-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-03-21T11:21:29Z New Revision: 52de49e4b9cd69957b7dc50a5fed061ecd0b0d77 URL: https://github.com/llvm/llvm-project/commit/52de49e4b9cd69957b7dc50a5fed061ecd0b0d77 DIFF: https://github.com/llvm/llvm-project/commit/52de49e4b9cd69957b7dc50a5fed061ecd0b0d77.diff LOG:

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132234)

2025-04-04 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Will need to revert a dependent commit, this needs to revert as well so it goes cleanly. https://github.com/llvm/llvm-project/pull/132234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-04-04 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/132043 >From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Mar 2025 10:44:12 -0400 Subject: [PATCH 1/5] Reapply "[LLDB][Telemetry]Define TargetInfo for collecting data

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/134097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-04 Thread John Harrison via lldb-commits
@@ -671,11 +693,25 @@ void DAP::SetTarget(const lldb::SBTarget target) { } } -bool DAP::HandleObject(const protocol::Message &M) { - if (const auto *req = std::get_if(&M)) { +bool DAP::HandleObject(const Message &M) { + if (const auto *req = std::get_if(&M)) { +{ +

[Lldb-commits] [lldb] [lldb] Make ELF files able to load section headers from memory. (PR #129166)

2025-04-04 Thread Greg Clayton via lldb-commits
@@ -1477,32 +1506,32 @@ size_t ObjectFileELF::GetSectionHeaderInfo(SectionHeaderColl §ion_headers, } if (idx < section_headers.size()) section_headers.resize(idx); + // Sometimes we are able to read the section header memory from an in memory clayborg

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/134418 >From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 11 Mar 2025 13:02:14 -0700 Subject: [PATCH 1/3] Add commands to list/enable/disable plugins This commit add

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Alex Langford via lldb-commits
bulbazord wrote: > That said, I don't think this code should be here (and I think Alex would > agree). I do agree with this. > > I was referring more to the other items on the list. I assumed, it seems > > incorrectly, that Alex's patch would fix the dependency in the mangler. It > > seems l

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/5] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
jimingham wrote: Note, the current stop locker is a `pthread_rwlock_t`. These locks according to the docs I could find are recursive for reading, but not recursive for writing. We need them to be recursive for reading because you want to do: locker = process.GetStopLocker() process.GetThread

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Pavel Labath via lldb-commits
labath wrote: I think it's a good start (thanks for helping out, David), but I don't get the removal part. What you actually want to test that it *succeeds* in launching the llgs persona, is it not? Wouldn't it be better to *not* remove the lldb-server and check that the "run" command actually

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Mariusz Borsa via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,57 @@ +//===-- SBMutexTest.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/132274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/132274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Disabling asserts locally solved the problem with LLVM_DUMP_METHOD. This patch works again. I have refactored CPlusPlusLanguage::MethodName and RichManglingContext. I got the lldb-server size 6MB. Please review. Thanks https://github.com/llvm/llvm-project/pull/132274 __

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/132274 >From a4d62ca1dfaca8eb29ce7d2809c28137d22416b9 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Thu, 20 Mar 2025 21:50:51 +0400 Subject: [PATCH 1/2] [LLDB] Refactor Module::LookupInfo constructor and move

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/4] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,35 +42,59 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() - -self.runCmd( -"env Sanitizer

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133370 >From 8af1b715a2d2dd19f8ff374c1fcc4c513a2e6fed Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 4 Apr 2025 13:02:57 -0700 Subject: [PATCH 1/2] [lldb] Add a {ObjectFile,SymbolFile}::GetObjectName

[Lldb-commits] [lldb] [lldb-dap] Replace GetBreakpointLabel with kDAPBreakpointLabel constant (NFC) (PR #133746)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Replace GetBreakpointLabel with kDAPBreakpointLabel constant to avoid an unnecessary function call. --- Full diff: https://github.com/llvm/llvm-project/pull/133746.diff 5 Files Affected: - (modif

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: Yea, these tests only test the `lldb` binary, as evident from lit: https://github.com/yuvald-sweet-security/llvm-project/blob/main/lldb/test/API/lit.cfg.py#L247-L248 Do you know if there are any tests that run lldb-server? I couldn't find anything by grepping the r

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/asan/TestMemoryHistory.py lldb/test/API/funct

[Lldb-commits] [lldb] [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (PR #133370)

2025-04-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5271dea - [lldb] Add a {ObjectFile, SymbolFile}::GetObjectName method (#133370)

2025-04-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-04T16:33:40-07:00 New Revision: 5271dead61dca30f4a6db0f0df8da00f8987449e URL: https://github.com/llvm/llvm-project/commit/5271dead61dca30f4a6db0f0df8da00f8987449e DIFF: https://github.com/llvm/llvm-project/commit/5271dead61dca30f4a6db0f0df8da00f8987449e.d

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes The UpdateRegisterContext method can be called from multiple threads. --- Full diff: https://github.com/llvm/llvm-project/pull/134469.diff 2 Files Affected: - (modified) lldb/source/Pl

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) Changes This is an attempt to fix a test failure from #133794 when running on windows builds. I suspect we are running into a case where the [ICF](https://learn.microsoft.com/en-us/cpp/build/reference/opt-optimizati

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6272e1f - [lldb] Make `RegisterContextThreadMemory` thread safe (#134469)

2025-04-04 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-04T18:43:31-07:00 New Revision: 6272e1f37e0710b51d38cb98b905a3f2ffea7966 URL: https://github.com/llvm/llvm-project/commit/6272e1f37e0710b51d38cb98b905a3f2ffea7966 DIFF: https://github.com/llvm/llvm-project/commit/6272e1f37e0710b51d38cb98b905a3f2f

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/134469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-04 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131609 >From 6f2d070facaced221295a5b0c48ccb3a41a5048d Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Mon, 17 Mar 2025 14:37:26 +0200 Subject: [PATCH 1/2] [lldb] Use correct path for debugserver ---

[Lldb-commits] [lldb] [lldb] Make `RegisterContextThreadMemory` thread safe (PR #134469)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134469 The UpdateRegisterContext method can be called from multiple threads. >From ef59ad0f6522e5ca35cfeed562fc528b4732fb22 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 4 Apr 2025 18:28:

[Lldb-commits] [lldb] 554f4d1 - [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (#134097)

2025-04-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-04-03T11:10:16+01:00 New Revision: 554f4d1a5769357ee8438c23f572d595c720ff3c URL: https://github.com/llvm/llvm-project/commit/554f4d1a5769357ee8438c23f572d595c720ff3c DIFF: https://github.com/llvm/llvm-project/commit/554f4d1a5769357ee8438c23f572d595c720ff3c.diff

[Lldb-commits] [lldb] [LLDB] Fix tests on Windows (PR #131600)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -63,7 +63,7 @@ def execute(self, test, litConfig): try: out, err, exitCode = lit.util.executeCommand( cmd, -env=test.config.environment, +env={**os.environ, **test.config.environment}, labat

[Lldb-commits] [lldb] [lldb][debugserver] remove g/G packet handling from debugserver (PR #132127)

2025-04-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/132127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -40,6 +35,31 @@ class DWARFUnit; /// location expression or a location list and interprets it. class DWARFExpression { public: + class Delegate { + public: +Delegate() = default; +virtual ~Delegate() = default; + +virtual uint16_t GetVersion() const = 0; +v

[Lldb-commits] [lldb] [lldb][AIX] Support for XCOFF Sections (PR #131304)

2025-04-04 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/131304 >From 106e137fea7d4b420ce3d97a8df16c3a91400997 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Fri, 14 Mar 2025 02:51:21 -0500 Subject: [PATCH 1/3] Support for XCOFF Sections --- .../ObjectFile/

[Lldb-commits] [lldb] [lldb-dap] Stop the process for the threads request (PR #134456)

2025-04-04 Thread via lldb-commits
kusmour wrote: Thanks a lot for the comments and draft. I will go a head with the option 3! https://github.com/llvm/llvm-project/pull/134456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Dhruv Srivastava via lldb-commits
@@ -141,6 +141,7 @@ else() add_host_subdirectory(aix aix/Host.cpp aix/HostInfoAIX.cpp + linux/Support.cpp DhruvSrivastavaX wrote: In the original draft PR, we have a copy file from linux for aix as well. Shall we use the linux version to

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Dhruv Srivastava via lldb-commits
@@ -6,18 +6,172 @@ // //===--===// +#include +#include +#include + DhruvSrivastavaX wrote: You can remove this blank line and run clang format once to keep all the includes together in o

[Lldb-commits] [lldb] [RFC][lldb-dap] Always stop on enrty for attaching (PR #134339)

2025-04-04 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/134339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Pavel Labath via lldb-commits
labath wrote: I'm not sure what has changed. This code has been here since 2022, so I suspect it's one of those "perfectly reasonable" changes I mentioned earlier. That said, I don't think this code should be here (and I think Alex would agree). It should probably go into some kind of a plugin

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Pavel Labath via lldb-commits
labath wrote: > are used in the following files except Module.cpp: > > ``` > source/Core/RichManglingContext.cpp > source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp > source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp > source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp > ``` The q

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > I was referring more to the other items on the list. I assumed, it seems > incorrectly, that Alex's patch would fix the dependency in the mangler. It > seems like that part still needs to be pluginized, somehow. Note Module.cpp still uses `CPlusPlusLanguage::MethodName` in `

[Lldb-commits] [lldb] Add DAP tests for initialized event to be sure stats are present (PR #134266)

2025-04-04 Thread via lldb-commits
https://github.com/youngd007 edited https://github.com/llvm/llvm-project/pull/134266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e4f76e3 - Reapply "[lldb] Return *const* UnwindPlan pointers from FuncUnwinders " (#134246)

2025-04-04 Thread via lldb-commits
Author: Pavel Labath Date: 2025-04-04T09:49:27+02:00 New Revision: e4f76e3a3335dda608c661d76efacc70e607a5e4 URL: https://github.com/llvm/llvm-project/commit/e4f76e3a3335dda608c661d76efacc70e607a5e4 DIFF: https://github.com/llvm/llvm-project/commit/e4f76e3a3335dda608c661d76efacc70e607a5e4.diff

[Lldb-commits] [lldb] Reapply "[lldb] Return *const* UnwindPlan pointers from FuncUnwinders " (PR #134246)

2025-04-04 Thread Pavel Labath via lldb-commits
labath wrote: > I wasn't able to reproduce the problem locally either, but I've got the same > failing tests with the same stack traces by setting > > ``` > const UnwindPlan::Row *active_row = (const UnwindPlan::Row *) 0x1; > ``` Good idea. Thanks for trying it out. https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi created https://github.com/llvm/llvm-project/pull/134354 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issues/

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Hemang Gadhavi (HemangGadhavi) Changes This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/iss

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Hi Team, @HemangGadhavi from my ibm aix team will be helping me out in some of the merging process, as per our decided guidelines. Please provide your review. Thanks! Dhruv Srivastava https://github.com/llvm/llvm-project/pull/134354 ___

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Pavel Labath via lldb-commits
labath wrote: > > The question here is who is using those files and why. These are all > > plugins, so they shouldn't be pulled in unless they are `Initialized`. > > RichManglingContext.cpp is not a plugin and it uses `m_cxx_method_parser = > new CPlusPlusLanguage::MethodName(demangled);`, inc

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -141,6 +141,7 @@ else() add_host_subdirectory(aix aix/Host.cpp aix/HostInfoAIX.cpp + linux/Support.cpp labath wrote: I'd move those functions into the `posix` folder given that other systems have similar functionality (besides AIX, fre

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/115245 >From 63ca211312cd9dcbf28d30866a429262b504bdb3 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 5 Nov 2024 00:22:07 + Subject: [PATCH] Init --- clang/include/clang/Basic/Attr.td | 7

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Dhruv Srivastava via lldb-commits
@@ -6,18 +6,172 @@ // //===--===// +#include +#include +#include + #include "lldb/Host/Host.h" +#include "lldb/Host/linux/Support.h" +#include "lldb/Utility/LLDBLog.h" +#include "lldb/Utility/Log.h" +#inc

[Lldb-commits] [lldb] a2e888f - [LLDB][NFC]Fix stack-use-after free bug. (#134296)

2025-04-04 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-04-04T08:00:46-04:00 New Revision: a2e888f5b49113c66b055290cb7069ae88c9d2e1 URL: https://github.com/llvm/llvm-project/commit/a2e888f5b49113c66b055290cb7069ae88c9d2e1 DIFF: https://github.com/llvm/llvm-project/commit/a2e888f5b49113c66b055290cb7069ae88c9d2e1.diff LOG

[Lldb-commits] [lldb] [LLDB][NFC]Fix stack-use-after free bug. (PR #134296)

2025-04-04 Thread Vy Nguyen via lldb-commits
oontvoo wrote: I think this is a trivial enough fix - i'm going to just merge it. https://github.com/llvm/llvm-project/pull/134296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb] Return *const* UnwindPlan pointers from FuncUnwinders " (PR #134246)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/134246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: We have a tests for this function in `unittests/Host/linux/HostTest.cpp` and it looks like at least some of it should apply to other systems as well. We could move it to the "posix" folder so that it applies to your code as well. Depending on the size of li

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -6,18 +6,172 @@ // //===--===// +#include +#include +#include + #include "lldb/Host/Host.h" +#include "lldb/Host/linux/Support.h" +#include "lldb/Utility/LLDBLog.h" +#include "lldb/Utility/Log.h" +#inc

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Pavel Labath via lldb-commits
@@ -6,18 +6,172 @@ // //===--===// +#include +#include +#include + #include "lldb/Host/Host.h" +#include "lldb/Host/linux/Support.h" +#include "lldb/Utility/LLDBLog.h" +#include "lldb/Utility/Log.h" +#inc

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

2025-04-04 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Parallelize module loading in POSIX dyld code (PR #130912)

2025-04-04 Thread Tom Yang via lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/130912 >From fbf25b1cd4f6d527944fb85fc4d2d03498755a05 Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Mon, 10 Mar 2025 17:58:17 -0700 Subject: [PATCH 1/5] Add option for enabling/disabling parallel load Add a setting to g

[Lldb-commits] [lldb] d4002b4 - [lldb] Skip Expression NonZeroFrame test on Windows

2025-04-04 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-04-04T14:32:48Z New Revision: d4002b43f517fea0292bf71dccaa3d0f6dd798b9 URL: https://github.com/llvm/llvm-project/commit/d4002b43f517fea0292bf71dccaa3d0f6dd798b9 DIFF: https://github.com/llvm/llvm-project/commit/d4002b43f517fea0292bf71dccaa3d0f6dd798b9.diff LOG

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Note currently I see the following Debugger dependencies in lldb-server: ``` std::__1::__throw_bad_weak_ptr[abi:nn21](): referenced by Section.cpp lldb_private::Section::GetLoadBaseAddress(lldb_private::Target*) const lldb_private::Debugger::GetCurrentProgressReport() const:

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > The question here is who is using those files and why. These are all plugins, > so they shouldn't be pulled in unless they are `Initialized`. RichManglingContext.cpp is not a plugin and it uses `m_cxx_method_parser = new CPlusPlusLanguage::MethodName(demangled);`, including c

[Lldb-commits] [lldb] [LLDB][NFC]Fix stack-use-after free bug. (PR #134296)

2025-04-04 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/134296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 87bebd3 - [LLDB][NFC]Move fields that might be referenced in scope-exit to beginning (#133785)

2025-04-04 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-04-02T10:19:12-04:00 New Revision: 87bebd37ffe08c4911d9636ab09cb1406d7ac677 URL: https://github.com/llvm/llvm-project/commit/87bebd37ffe08c4911d9636ab09cb1406d7ac677 DIFF: https://github.com/llvm/llvm-project/commit/87bebd37ffe08c4911d9636ab09cb1406d7ac677.diff LOG

[Lldb-commits] [lldb] [SBProgress] Add swig support for `with` statement in Python (PR #133527)

2025-04-04 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > > @JDevlieghere @bulbazord Is there a Discourse on the recent changes to the > > terminal colors? On Linux I'm getting this white bar that crosses the whole > > terminal. I think this is part of your reverse video change Jonas? > > ![image](https://private-user-images.githubus

[Lldb-commits] [lldb] [lldb] Convert Breakpoint & Watchpoints structs to classes (NFC) (PR #133780)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/133780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-04-04 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: @JDevlieghere @labath how do I get this PR merged? I don't think I have access to merge on my own; will one of you merge it, or am I missing something here? https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commit

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-04-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots closed https://github.com/llvm/llvm-project/pull/132884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/134383 It reduces the memory usage in lldb-server. Later I will try to remove the rest Debugger dependencies to reduce lldb-server size. >From 629601c6c1e974e7981d2e61583c69540bf1cd5c Mon Sep 17 00:00:00 2001 From: D

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes It reduces the memory usage in lldb-server. Later I will try to remove the rest Debugger dependencies to reduce lldb-server size. --- Full diff: https://github.com/llvm/llvm-project/pull/134383.diff 5 F

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > I'm actually very much opposed to that. lldb-server not need/use a Debugger, > nor a thread pool nor any IO handling present in that file. I wouldn't want > to create a Debugger "plugin" for the sake of lldb-server. It should be cut > off above that. #134383 https://github.

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/134383 >From 590d5b47b9f98a8e5f19945334b2a1c34248f9d8 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 4 Apr 2025 17:49:07 +0400 Subject: [PATCH] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManag

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); DavidSpickett wrote: This fails to compile on Windows: https://lab.llvm.org/buildbot/#/builders/141/builds/7573 ``` lld-link: error: undefined symbol: printf >>> referenced by main.o:(func) c

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From d7e112ed0bc8d5ca3297e3c7b7d7afadd2d79e2d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 11 Mar 2025 08:57:13 + Subject: [PATCH 1/4] [llvm][ItaniumDemangle] Add function name location tracki

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread David Spickett via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); DavidSpickett wrote: Skipped for now: https://github.com/llvm/llvm-project/commit/d4002b43f517fea0292bf71dccaa3d0f6dd798b9 It could be another case where we link with link.exe which can't hand

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add option to highlight function names in backtraces (PR #131836)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-04 Thread Michael Buch via lldb-commits
@@ -0,0 +1,6 @@ +int func(void) { + __builtin_printf("Break here"); Michael137 wrote: Oh I fixed this in a follow-up commit. Is the test still failing? Yea not exactly sure about why the builtin doesnt link. Your theory sounds plausible https://github.com/llv

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @labath > I'm not sure what has changed. This code has been here since 2022, so I > suspect it's one of those "perfectly reasonable" changes I mentioned earlier. https://github.com/llvm/llvm-project/commit/d2a7a249c567cb170f22fe6e932896f9298b581d Changed the definition of LLV

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-04-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/115245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-04-04 Thread via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (PR #134397)

2025-04-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. I agree these don't belong in ProcessGDBRemote, but this is a small and obvious change so it's fine to fix the status quo for now. https://github.com/llvm/llvm-project/pull/134397 ___ lldb-commi

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-04 Thread Vy Nguyen via lldb-commits
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-04-04 Thread via lldb-commits
@@ -185,6 +185,8 @@ def setUpServerLogging(self, is_llgs): ] def get_next_port(self): +if available_ports := self.getPlatformAvailablePorts(): +return int(random.choice(available_ports)) dlav-sc wrote: I haven't encountered

[Lldb-commits] [lldb] [lldb-dap] Add a -v/--version command line argument (PR #134114)

2025-04-04 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/134114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/include/lldb/Initialization/SystemLifetimeMana

[Lldb-commits] [lldb] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManager (PR #134383)

2025-04-04 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/134383 >From a6ad0039015bdd3d387e8a4f0762961cdf8db50f Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 4 Apr 2025 17:49:07 +0400 Subject: [PATCH] [LLDB][NFC] Remove Debugger dependency in SystemLifetimeManag

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [WIP][lldb] Alternative implementation of more reliable function call infrastructure (PR #115245)

2025-04-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/lib/AST/Mangle.cpp clang/lib/Sema/SemaDeclAtt

  1   2   3   >