Author: Ebuka Ezike
Date: 2025-03-17T07:58:55Z
New Revision: 3af6c9fa832ac29125cad76acb397d6235c371e9
URL:
https://github.com/llvm/llvm-project/commit/3af6c9fa832ac29125cad76acb397d6235c371e9
DIFF:
https://github.com/llvm/llvm-project/commit/3af6c9fa832ac29125cad76acb397d6235c371e9.diff
LOG: [
@@ -0,0 +1,64 @@
+//===-- SBLockTest.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,35 @@
+//===-- SBLock.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
yuvald-sweet-security wrote:
> I'm wondering if the right fix isn't to call
> `FileSystem::ResolveExecutableLocation` on `argv[0]`. That should should give
> us more-or-less the same algorithm that the shell used when starting
> lldb-server.
Perhaps, but note that technically argv[0] doesn't
https://github.com/AlexK0 created
https://github.com/llvm/llvm-project/pull/131600
Hello,
I'm working on LLDB on Windows and have encountered some issues with the tests.
1) Many tests fail to start on Windows due to an import exception:
```
Traceback (most recent call last):
File "D:\Project
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Aleksandr Korepanov (AlexK0)
Changes
Hello,
I'm working on LLDB on Windows and have encountered some issues with the tests.
1) Many tests fail to start on Windows due to an import exception:
```
Traceback (most recent call last):
File "D
https://github.com/AlexK0 edited
https://github.com/llvm/llvm-project/pull/131600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7dcea28bf92e49737fa285e93621cfa814323524...959c86f9cee6bedadc32bb99574b4fdfac37f0fd
lldb/
https://github.com/AlexK0 updated
https://github.com/llvm/llvm-project/pull/131600
>From 9734adfcca5d1d5cfdba85dc0bfe76d230106c11 Mon Sep 17 00:00:00 2001
From: Aleksandr Korepanov
Date: Mon, 17 Mar 2025 11:03:57 +0100
Subject: [PATCH 1/2] [LLDB][tests] Use original env for running tests
On Wi
@@ -81,6 +81,20 @@ using namespace lldb_private::telemetry;
class TelemetryTest : public testing::Test {
public:
lldb_private::SubsystemRAII subsystems;
+ std::vector>
+ received_entries;
+
+ void SetUp() override {
+// This would have been called by the plugin reg
https://github.com/yuvald-sweet-security updated
https://github.com/llvm/llvm-project/pull/131609
>From a4e2c9f4fca115cc52ee69abfa584795b7102716 Mon Sep 17 00:00:00 2001
From: Yuval Deutscher
Date: Mon, 17 Mar 2025 14:37:26 +0200
Subject: [PATCH] [lldb] Use correct path for debugserver
---
ll
yuvald-sweet-security wrote:
Well, looks like the tests really do check a case where lldb and lldb-server
are not in the same directory. Should we just try both paths? maybe make
`GetShlibDir` return false if it is linked statically?
https://github.com/llvm/llvm-project/pull/131609
___
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/131645
This patch addresses the issue #129543.
After this patch DWARFExpression does not call DWARFUnit directly and does not
depend on lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp and a
lot of clang
rocallahan wrote:
The logs show the problem here:
```
AssertionError: Ran command:
"thread list"
Got output:
Process 79916 stopped
* thread #1: tid = 0x4870aa, 0x000100e0ff94 a.out`trigger_watchpoint at
main.c:7:60, stop reason = instruction step into
Expecting sub string: "stopped" (was f
rocallahan wrote:
My reverse-execution proxy code implements watchpoints during reverse execution
more or less by reversing the x86 behavior: if we execute a sequence of
instructions and instruction #N in the sequence modifies a watched memory
location, then when reverse-executing, we stop whe
@@ -540,9 +537,9 @@ class EntityVariableBase : public Materializer::Entity {
return;
}
-if (data.GetByteSize() <
+if (data_or_err->GetByteSize() <
adrian-prantl wrote:
I like to add a
```
auto data = *data_or_err;
```
than t
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/130516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -207,15 +207,13 @@ lldb::ValueObjectSP lldb_private::formatters::
return lldb::ValueObjectSP();
StreamString stream;
stream.Printf("[%" PRIu64 "]", (uint64_t)idx);
- DataExtractor data;
- Status error;
- val_hash.first->GetData(data, error);
- if (error.Fail())
+
@@ -523,13 +522,11 @@ class EntityVariableBase : public Materializer::Entity {
return;
}
} else {
-DataExtractor data;
-Status extract_error;
-valobj_sp->GetData(data, extract_error);
-if (!extract_error.Success()) {
+
@@ -1205,13 +1205,11 @@ bool lldb_private::formatters::ObjCSELSummaryProvider(
valobj_sp = ValueObject::CreateValueObjectFromAddress("text", data_address,
exe_ctx, charstar);
} else {
-DataExtractor data;
-
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130104
>From ab4e9d8a6f7146a5f9cee519f4d9787194b12b31 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 14:13:58 +0100
Subject: [PATCH] [lldb-dap] Adding support for well typed events.
This adds a mech
adrian-prantl wrote:
>I was also curious to know if I'd have to change any test code too, I've tried
>to unit test but got error relating to "expected" values. Would I need to
>change something in DumpValueObjectOptionsTests.cpp?
Usually wrapping calls in `llvm::expectedToOptional()` is the ch
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl commented:
Looks like a great start! I made a couple of suggestions inline.
https://github.com/llvm/llvm-project/pull/130516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
After https://reviews.llvm.org/D116539, when `m_gdb_client_up` in
`PlatformRemoteGDBServer` is not null, the connection to a server is expected
to exist. However, `PlatformRemoteGDBServer::DisconnectRemote(
@@ -273,15 +273,13 @@ ValueObjectSP
ForwardListFrontEnd::GetChildAtIndex(uint32_t idx) {
// we need to copy current_sp into a new object otherwise we will end up with
// all items named __value_
- DataExtractor data;
- Status error;
- current_sp->GetData(data, error);
yuvald-sweet-security wrote:
Ah, turns out there's a `HostInfo::GetProgramFileSpec()` function which solves
both these issues.
https://github.com/llvm/llvm-project/pull/131519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
https://github.com/yuvald-sweet-security updated
https://github.com/llvm/llvm-project/pull/131519
>From bf755daf57a0255157f0b8ccec2372d2ef9e2ef3 Mon Sep 17 00:00:00 2001
From: Yuval Deutscher
Date: Sun, 16 Mar 2025 14:08:57 +
Subject: [PATCH] [lldb] Use correct path for lldb-server executab
https://github.com/yuvald-sweet-security edited
https://github.com/llvm/llvm-project/pull/131519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/131388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/131597
When searching for the end of prologue, I'm only iterating through the address
range (~basic block) which contains the function entry point. The reason for
that is that even if some other range somehow contained
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
When searching for the end of prologue, I'm only iterating through the address
range (~basic block) which contains the function entry point. The reason for
that is that even if some other range somehow contain
@@ -0,0 +1,47 @@
+//===-- SBLock.h
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,35 @@
+//===-- SBLock.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1692,6 +1692,20 @@ class Target : public
std::enable_shared_from_this,
}
};
+/// The private implementation backing SBLock.
+struct APILock {
+ APILock(std::recursive_mutex &mutex) : lock(mutex) {}
+ std::lock_guard lock;
+};
+
+/// The private implementation used by
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/131544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I'm wondering if the right fix isn't to call
`FileSystem::ResolveExecutableLocation` on `argv[0]`. That should should give
us more-or-less the same algorithm that the shell used when starting
lldb-server.
https://github.com/llvm/llvm-project/pull/131519
_
https://github.com/yuvald-sweet-security created
https://github.com/llvm/llvm-project/pull/131609
Hello,
This solves an issue that arises when running lldb-server through a symlink
which is not named exactly `lldb-server`. For example, in many distros
lldb-server is packaged as e.g. `/usr/lib
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Yuval Deutscher (yuvald-sweet-security)
Changes
Hello,
This solves an issue that arises when running lldb-server through a symlink
which is not named exactly `lldb-server`. For example, in many distros
lldb-server is packaged as e.g. `/us
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/131203
>From cff4bbc4ff68e77e3093a880f55d2e17116e6f37 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 13 Mar 2025 15:57:48 -0400
Subject: [PATCH 1/2] [LLDB][NFC]Refactor common test setup into SetUp method
---
ll
https://github.com/Jlalond approved this pull request.
Left one comment on the unused template. Otherwise LGTM, I'd wait for Jeffrey
to give you a final sign off
https://github.com/llvm/llvm-project/pull/130841
___
lldb-commits mailing list
lldb-commi
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
a6463f41135d7d96e92cefeeffa84d0955f934f9...23a710ff81fbd9ab9d5c96b086d96b9300567625
lldb/
JDevlieghere wrote:
@DavidSpickett does this LGTY?
https://github.com/llvm/llvm-project/pull/121860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
LGTM. I wondered for a second whether there now should be separate flags for
substrings & patterns, but I can't think of a reason why you would want to
provide both substrings and patterns and for one to be ordered and the other
not.
h
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/131475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1692,6 +1692,20 @@ class Target : public
std::enable_shared_from_this,
}
};
+/// The private implementation backing SBLock.
+struct APILock {
+ APILock(std::recursive_mutex &mutex) : lock(mutex) {}
+ std::lock_guard lock;
+};
+
+/// The private implementation used by
@@ -1,12 +1,12 @@
-//===-- Protocol.cpp
--===//
+//===-- ProtocolBase.cpp
--===//
JDevlieghere wrote:
Oh right, I didn't make the connection. Sounds good.
http
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/130090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,12 +1,12 @@
-//===-- Protocol.cpp
--===//
+//===-- ProtocolBase.cpp
--===//
ashgti wrote:
I used the names of the categories from the spec for the files,
@@ -162,4 +162,13 @@ GetEnvironmentFromArguments(const llvm::json::Object
&arguments) {
return envs;
}
+llvm::Error takeError(const lldb::SBError &error) {
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/130090
__
@@ -663,58 +671,64 @@ void DAP::SetTarget(const lldb::SBTarget target) {
}
bool DAP::HandleObject(const protocol::Message &M) {
- // FIXME: Directly handle `Message` instead of serializing to JSON.
- llvm::json::Value v = toJSON(M);
- llvm::json::Object object = *v.getAsObj
sga-sc wrote:
@labath Addressed
https://github.com/llvm/llvm-project/pull/131293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Can confirm that the arm64 bots are failing again:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/22265
```
TestReverseContinueWatchpoints.py
--
Exit Code: 1
Command Output (stdout):
--
lldb version 21.0.99git (https://github.com/llvm/llvm-project.git revi
@@ -392,9 +391,57 @@ struct DAP {
void SetThreadFormat(llvm::StringRef format);
- InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
+ template
+ BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) {
+// Check to see if h
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131404
>From 5ea2ad6ecb388818b009fa89c4aebe1e0e4213df Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 14 Mar 2025 15:19:58 -0700
Subject: [PATCH 1/3] [lldb] Expose the Target API lock through the SB AP
JDevlieghere wrote:
The unit tests are crashing because the new test correctly initializes and
terminates the debugger and there's a double free in the
`SBCommandInterpreterTest` (which conveniently wasn't doing that). I'll put up
a separate PR to fix that.
https://github.com/llvm/llvm-proje
https://github.com/yuvald-sweet-security updated
https://github.com/llvm/llvm-project/pull/131519
>From df4b4e2a0361eaeaace3f8578f4f30d95fee059a Mon Sep 17 00:00:00 2001
From: Yuval Deutscher
Date: Sun, 16 Mar 2025 14:08:57 +
Subject: [PATCH] [lldb] Use correct path for lldb-server executab
labath wrote:
Submitting per
https://github.com/llvm/llvm-project/pull/123945#issuecomment-2672913953
https://github.com/llvm/llvm-project/pull/128156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
Author: Pavel Labath
Date: 2025-03-17T16:06:25+01:00
New Revision: 1b237198dc9d308c6d589e01637ec7496b48b3e0
URL:
https://github.com/llvm/llvm-project/commit/1b237198dc9d308c6d589e01637ec7496b48b3e0
DIFF:
https://github.com/llvm/llvm-project/commit/1b237198dc9d308c6d589e01637ec7496b48b3e0.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/128156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This patch addresses the issue #129543.
After this patch DWARFExpression does not call DWARFUnit directly and does not
depend on lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp and a
lot of
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/130841
>From e949d2ee19408c43d9067075d2436f8549132830 Mon Sep 17 00:00:00 2001
From: satya janga
Date: Tue, 11 Mar 2025 13:39:08 -0700
Subject: [PATCH 1/4] Make breakpoint stop reason more accurate
---
.../test/to
Author: John Harrison
Date: 2025-03-17T10:13:11-07:00
New Revision: fbb8929c9d15fdc0001205ee4a7b42a78edc5213
URL:
https://github.com/llvm/llvm-project/commit/fbb8929c9d15fdc0001205ee4a7b42a78edc5213
DIFF:
https://github.com/llvm/llvm-project/commit/fbb8929c9d15fdc0001205ee4a7b42a78edc5213.diff
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/131658
The class was taking ownership of the SBCommandPluginInterface pointer it was
passed in, by wrapping it in a shared pointer. This causes a double free in the
unit test when the object is destroyed and the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The class was taking ownership of the SBCommandPluginInterface pointer it was
passed in, by wrapping it in a shared pointer. This causes a double free in the
unit test when the object is destroyed a
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/9] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
DanielCChen wrote:
@arichardson I found the way to override the cache file. Thanks for the
suggestion!
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/8] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
@@ -1187,16 +1187,19 @@ endif()
# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to
# break things. In this case we need to enable the large-file API as well.
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
- add_compile_definitions(_XOPEN_S
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/7] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/130841
>From e949d2ee19408c43d9067075d2436f8549132830 Mon Sep 17 00:00:00 2001
From: satya janga
Date: Tue, 11 Mar 2025 13:39:08 -0700
Subject: [PATCH 1/4] Make breakpoint stop reason more accurate
---
.../test/to
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/130090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
arichardson wrote:
> @arichardson I found the way to override the cache file. Thanks for the
> suggestion!
Thanks this looks good to me.
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
@@ -1187,16 +1187,19 @@ endif()
# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to
# break things. In this case we need to enable the large-file API as well.
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
- add_compile_definitions(_XOPEN_S
76 matches
Mail list logo
