[Lldb-commits] [lldb] 2af0e2f - Revert "Push down the swig module to avoid an import cycle" (#129714)

2025-03-04 Thread via lldb-commits
Author: David Spickett Date: 2025-03-04T14:24:02Z New Revision: 2af0e2f3e6c761ecd3f2dd31d0ae844572fcdce0 URL: https://github.com/llvm/llvm-project/commit/2af0e2f3e6c761ecd3f2dd31d0ae844572fcdce0 DIFF: https://github.com/llvm/llvm-project/commit/2af0e2f3e6c761ecd3f2dd31d0ae844572fcdce0.diff LOG

[Lldb-commits] [lldb] 7b596ce - [lldb] Fix ObjectFileJSON to section addresses. (#129648)

2025-03-04 Thread via lldb-commits
Author: Greg Clayton Date: 2025-03-04T14:35:42-08:00 New Revision: 7b596ce362829281ea73b576774ce90bb212138d URL: https://github.com/llvm/llvm-project/commit/7b596ce362829281ea73b576774ce90bb212138d DIFF: https://github.com/llvm/llvm-project/commit/7b596ce362829281ea73b576774ce90bb212138d.diff

[Lldb-commits] [lldb] 6e28700 - [lldb-dap] Improving EOF handling on stream input and adding new unit tests (#129581)

2025-03-04 Thread via lldb-commits
Author: John Harrison Date: 2025-03-04T10:09:28-08:00 New Revision: 6e28700ab1d876a9b01647782ce3c0ed4d8e0bb4 URL: https://github.com/llvm/llvm-project/commit/6e28700ab1d876a9b01647782ce3c0ed4d8e0bb4 DIFF: https://github.com/llvm/llvm-project/commit/6e28700ab1d876a9b01647782ce3c0ed4d8e0bb4.diff

[Lldb-commits] [lldb] 27901ce - Add subsection and permissions support to ObjectFileJSON. (#129801)

2025-03-04 Thread via lldb-commits
Author: Greg Clayton Date: 2025-03-04T16:19:20-08:00 New Revision: 27901cec0e76d2cbf648b3b63d5b2fec1d46bb9c URL: https://github.com/llvm/llvm-project/commit/27901cec0e76d2cbf648b3b63d5b2fec1d46bb9c DIFF: https://github.com/llvm/llvm-project/commit/27901cec0e76d2cbf648b3b63d5b2fec1d46bb9c.diff

[Lldb-commits] [lldb] [lldb] Upgrade CompilerType::GetBitSize to return llvm::Expected (PR #129601)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/129601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upgrade CompilerType::GetBitSize to return llvm::Expected (PR #129601)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. TIL about `llvm::expectedToOptional`. LGTM! https://github.com/llvm/llvm-project/pull/129601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb] Upgrade CompilerType::GetBitSize to return llvm::Expected (PR #129601)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
@@ -769,19 +771,20 @@ CompilerType::GetBasicTypeFromAST(lldb::BasicType basic_type) const { } // Exploring the type -std::optional +llvm::Expected CompilerType::GetBitSize(ExecutionContextScope *exe_scope) const { if (IsValid()) if (auto type_system_sp = GetTypeSyste

[Lldb-commits] [lldb] [lldb-dap] Replace Get{Signed, Unsigned} with GetInteger (NFC) (PR #129823)

2025-03-04 Thread John Harrison via lldb-commits
@@ -131,11 +131,13 @@ void BreakpointLocationsRequestHandler::operator()( auto *arguments = request.getObject("arguments"); auto *source = arguments->getObject("source"); std::string path = GetString(source, "path").str(); - uint64_t start_line = GetUnsigned(arguments, "

[Lldb-commits] [lldb] [lldb-dap] Replace Get{Signed, Unsigned} with GetInteger (NFC) (PR #129823)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/129823 Replace Get{Signed,Unsigned} with GetInteger and return std::optional so you can distinguish between the value not being present and it being explicitly set to the previous fail_value. All existing uses ar

[Lldb-commits] [lldb] [lldb-dap] Creating well defined structures for DAP messages. (PR #129155)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/129155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Return a std::optional from GetBoolean (NFC) (PR #129818)

2025-03-04 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/129818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating the logging of lldb-dap to use existing LLDBLog. (PR #129294)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The more I think about it, the less I like the idea of using `LLDBLog` in `lldb-dap`. Initially, I liked the idea of reusing our existing logging implementation, although I have expressed my concern about relying on `liblldb` in other PRs. But the issues and workarounds we'

[Lldb-commits] [lldb] 3f12155 - [lldb-dap] Creating well defined structures for DAP messages. (#129155)

2025-03-04 Thread via lldb-commits
Author: John Harrison Date: 2025-03-04T21:45:37-08:00 New Revision: 3f121558705ac7c9ae2398baca5a2d764ce022fd URL: https://github.com/llvm/llvm-project/commit/3f121558705ac7c9ae2398baca5a2d764ce022fd DIFF: https://github.com/llvm/llvm-project/commit/3f121558705ac7c9ae2398baca5a2d764ce022fd.diff

[Lldb-commits] [lldb] [lldb-dap] Updating the logging of lldb-dap to use existing LLDBLog. (PR #129294)

2025-03-04 Thread John Harrison via lldb-commits
@@ -0,0 +1,30 @@ +//===-- DAPLog.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/129307 >From 2f77beefb752ffdae908101d75381268203311d6 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 28 Feb 2025 11:38:35 -0800 Subject: [PATCH 1/4] Update MinidumpFileBuilder to read and write in chunks ---

[Lldb-commits] [lldb] [lldb-dap] Replace Get{Signed, Unsigned} with GetInteger (NFC) (PR #129823)

2025-03-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Replace Get{Signed,Unsigned} with GetInteger and return std::optional so you can distinguish between the value not being present and it being explicitly set to the previous fail_value. All existi

[Lldb-commits] [lldb] [lldb-dap] Replace Get{Signed, Unsigned} with GetInteger (NFC) (PR #129823)

2025-03-04 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/129823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating the logging of lldb-dap to use existing LLDBLog. (PR #129294)

2025-03-04 Thread John Harrison via lldb-commits
ashgti wrote: > The more I think about it, the less I like the idea of using `LLDBLog` in > `lldb-dap`. Initially, I liked the idea of reusing our existing logging > implementation, although I have expressed my concern about relying on > `liblldb` in other PRs. But the issues and workarounds w

[Lldb-commits] [lldb] [lldb-dap] Replace Get{Signed, Unsigned} with GetInteger (NFC) (PR #129823)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
@@ -131,11 +131,13 @@ void BreakpointLocationsRequestHandler::operator()( auto *arguments = request.getObject("arguments"); auto *source = arguments->getObject("source"); std::string path = GetString(source, "path").str(); - uint64_t start_line = GetUnsigned(arguments, "

[Lldb-commits] [lldb] [lldb-dap] Implement a MemoryMonitor for macOS & Linux (PR #129332)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/129332 >From c63350db79ac6bcc6f180cc84a37e829d1c8b2a8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 28 Feb 2025 14:54:42 -0600 Subject: [PATCH 1/5] [lldb-dap] Implement a MemoryMonitor for macOS & Li

[Lldb-commits] [lldb] [lldb-dap] Implement a MemoryMonitor for macOS & Linux (PR #129332)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/129332 >From c63350db79ac6bcc6f180cc84a37e829d1c8b2a8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 28 Feb 2025 14:54:42 -0600 Subject: [PATCH 1/6] [lldb-dap] Implement a MemoryMonitor for macOS & Li

[Lldb-commits] [lldb] [lldb-dap] Implement a MemoryMonitor for macOS & Linux (PR #129332)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > This looks very nice. Just out of curiosity, is something printed on the > terminal/console whenever one of these low memory events happen? No, this should be transparent to the user. Removing the orphaned modules might not be enough to get out of this situation, so the c

[Lldb-commits] [lldb] [lldb-dap] Implement a MemoryMonitor (PR #129332)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/129332 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Return a std::optional from GetBoolean (NFC) (PR #129818)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/129818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c7dbf20 - [lldb-dap] Test: disable children return test for all arm architectures (#129409)

2025-03-04 Thread via lldb-commits
Author: Da-Viper Date: 2025-03-04T15:46:26+05:00 New Revision: c7dbf20e66606e7e26a28ad567ff75f3a493d3bd URL: https://github.com/llvm/llvm-project/commit/c7dbf20e66606e7e26a28ad567ff75f3a493d3bd DIFF: https://github.com/llvm/llvm-project/commit/c7dbf20e66606e7e26a28ad567ff75f3a493d3bd.diff LOG:

[Lldb-commits] [lldb] 77a8770 - Reland "[lldb][HostInfoMacOSX] Try to use DW_AT_LLVM_sysroot instead of xcrun when looking up SDK" (#129621)"

2025-03-04 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-03-04T10:24:08Z New Revision: 77a8770d4976e086f36004a6b8bf09e76d981451 URL: https://github.com/llvm/llvm-project/commit/77a8770d4976e086f36004a6b8bf09e76d981451 DIFF: https://github.com/llvm/llvm-project/commit/77a8770d4976e086f36004a6b8bf09e76d981451.diff LOG:

[Lldb-commits] [lldb] [LLDB][Telemetry]Defind telemetry::CommandInfo (PR #129354)

2025-03-04 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129354 >From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Fri, 28 Feb 2025 23:03:35 -0500 Subject: [PATCH 01/15] [LLDB][Telemetry]Defind telemetry::CommandInfo and collect te

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/129593 >From bca07d83152df179f7784d0003262fa54834 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Wed, 26 Feb 2025 13:55:35 -0800 Subject: [PATCH 1/3] Avoid force loading symbol files in statistics collection T

[Lldb-commits] [lldb] [lldb] Support expectedFlakey decorator in dotest (PR #129817)

2025-03-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) Changes The dotest framework had an existing decorator to mark flakey tests. It was not implemented and would simply run the underlying test. This commit modifies the decorator to run the test multiple times in the

[Lldb-commits] [lldb] [lldb] Support expectedFlakey decorator in dotest (PR #129817)

2025-03-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 11b9466c04db4da7439fc1d9d8ba7241a9d68705...1d1c3a6bf52ba47a4ff4c13e99209a6ae3d983b3 lldb/

[Lldb-commits] [lldb] [lldb-dap] Return a std::optional from GetBoolean (NFC) (PR #129818)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/129818 Return a std::optional from GetBoolean so you can distinguish between the value not being present and it being explicitly set to true or false. All existing uses are replaced by calling `value_or(fail_valu

[Lldb-commits] [lldb] [lldb-dap] Return a std::optional from GetBoolean (NFC) (PR #129818)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: CC @Da-Viper (I can't add you as a reviewer because you're not part of the LLVM organization) https://github.com/llvm/llvm-project/pull/129818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-04 Thread David Peixotto via lldb-commits
@@ -0,0 +1,31 @@ +# RUN: %clang_host -g %S/Inputs/main.c -o %t-main.exe + +# When we enable symbol preload and dump stats there should be a non-zero +# time for parsing symbol tables for the main module. +# RUN: %lldb %t-main.exe \ +# RUN: -O "settings set plugin.jit-loader.

[Lldb-commits] [lldb] [lldb] Support expectedFlakey decorator in dotest (PR #129817)

2025-03-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/129817 >From 1d1c3a6bf52ba47a4ff4c13e99209a6ae3d983b3 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Tue, 4 Mar 2025 11:39:03 -0800 Subject: [PATCH 1/2] [lldb] Support expectedFlakey decorator in dotest The dotest

[Lldb-commits] [lldb] [lldb] Support expectedFlakey decorator in dotest (PR #129817)

2025-03-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/129817 The dotest framework had an existing decorator to mark flakey tests. It was not implemented and would simply run the underlying test. This commit modifies the decorator to run the test multiple times in the case

[Lldb-commits] [lldb] [lldb-dap] Return a std::optional from GetBoolean (NFC) (PR #129818)

2025-03-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Return a std::optional from GetBoolean so you can distinguish between the value not being present and it being explicitly set to true or false. All existing uses are replaced by calling `value

[Lldb-commits] [lldb] [lldb-dap] Return a std::optional from GetBoolean (NFC) (PR #129818)

2025-03-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/129818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits