https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/124931
>From 7e4fa296561789ae95980ac0c1468573e80ef0cc Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 29 Jan 2025 16:15:44 +0100
Subject: [PATCH 1/3] [lldb] Fix Block::GetRangeIndexContainingAddress for
disconti
Author: Pavel Labath
Date: 2025-02-13T09:05:19+01:00
New Revision: 70b994bcfaafadd649818d2a7f90f8f5989ec6c1
URL:
https://github.com/llvm/llvm-project/commit/70b994bcfaafadd649818d2a7f90f8f5989ec6c1
DIFF:
https://github.com/llvm/llvm-project/commit/70b994bcfaafadd649818d2a7f90f8f5989ec6c1.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/126902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/127138
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2025-02-13T16:01:29-08:00
New Revision: 3c2ba68915b268fd3b7d39bf62e19199b2cb8995
URL:
https://github.com/llvm/llvm-project/commit/3c2ba68915b268fd3b7d39bf62e19199b2cb8995
DIFF:
https://github.com/llvm/llvm-project/commit/3c2ba68915b268fd3b7d39bf62e19199b2cb8995.diff
https://github.com/rchamala edited
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rchamala created
https://github.com/llvm/llvm-project/pull/127153
Current state in scripted process expects [_all the
modules_](https://github.com/llvm/llvm-project/blob/912b154f3a3f8c3cebf5cc5731fd8b0749762da5/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp#L498)
p
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
ff79d83caeeea8457f69406f38801fe8893bbfd8...a4fdb2d54e76aefb771fe8ad8399494bb5fa8b70
lldb/
jasonmolenda wrote:
I wanted to add a new `eBinaryType` enum from the ObjectFile to describe what
address is being returned. But within ProcessMachCore, there was no need to
add the distinction between the existing `m_dyld_addr` and the new
`m_dyld_all_image_infos_addr`, I did it to keep the
https://github.com/rchamala updated
https://github.com/llvm/llvm-project/pull/127153
>From a4fdb2d54e76aefb771fe8ad8399494bb5fa8b70 Mon Sep 17 00:00:00 2001
From: rchamala
Date: Thu, 13 Feb 2025 15:00:37 -0800
Subject: [PATCH 1/3] Allow option to ignore module load errors in
ScriptedProcess
-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (rchamala)
Changes
Current state in scripted process expects [_all the
modules_](https://github.com/llvm/llvm-project/blob/912b154f3a3f8c3cebf5cc5731fd8b0749762da5/lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp#L498)
passed
https://github.com/rchamala ready_for_review
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106907
>From aeb8854bbe7695e576257c8403e04d4b8268b679 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 13:48:41 +0100
Subject: [PATCH 1/9] Add: show return value on step out
---
lldb/tools/lldb-dap/l
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/127156
Mach-O corefiles have LC_NOTE metadata, one LC_NOTE that lldb recognizes is
`main bin spec` which can specify that this is a kernel corefile, userland
corefile, or firmware/standalone corefile. With a user
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Mach-O corefiles have LC_NOTE metadata, one LC_NOTE that lldb recognizes is
`main bin spec` which can specify that this is a kernel corefile, userland
corefile, or firmware/standalone corefile. With a u
labath wrote:
I agree with Jonas and Michał. I think we should take a step back. Can you
explain where exactly does this BrokenPipeError come from (an exception
backtrace for example)?
The code here assumes that we get a "connection refused" error if the port
wasn't open. Maybe we need to cat
Author: Pavel Labath
Date: 2025-02-14T08:40:45+01:00
New Revision: 2818df38c133cf7278b0174d01fe99c9c558fa2c
URL:
https://github.com/llvm/llvm-project/commit/2818df38c133cf7278b0174d01fe99c9c558fa2c
DIFF:
https://github.com/llvm/llvm-project/commit/2818df38c133cf7278b0174d01fe99c9c558fa2c.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/127060
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3801,6 +3801,23 @@ void request_variables(const llvm::json::Object
&request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+// Show return value if there is any ( in the top frame )
Da-Viper wrote:
I am not sure where the Re
https://github.com/Da-Viper edited
https://github.com/llvm/llvm-project/pull/106907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475
>From 7d97df1b70d6d648992f9af2f4211768d3a14aa5 Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Sun, 26 Jan 2025 17:34:17 +
Subject: [PATCH] lldb: Extended if conditions to support alias names for
registers
---
kper wrote:
@DavidSpickett unfortunately, I did not manage to test it with the test suite.
Both `ninja check-lldb-shell` and `ninja check-llvm` do not list my risc-v test
as supported and run it.
I manually compiled and tested it with lldb remotely and it works.
However, why the pipeline is no
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
I like this. Now it's so simple that a test might not have even been necessary,
but since you've already started it, let's keep it, and we can later extend it
to test sending of telemetry events.
https://github.com/llvm/llvm-project/pull/126588
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
labath
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,45 @@
+//===-- FakePlugin.cpp --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,45 @@
+//===-- FakePlugin.cpp --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Michael137 approved this pull request.
Looks great! Thank you for moving all this functionality into Clang
LGTM (just one minor comment left)
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commit
@@ -8476,27 +8476,20 @@ bool TypeSystemClang::CompleteTagDeclarationDefinition(
clang::ASTContext &ast = lldb_ast->getASTContext();
- /// TODO This really needs to be fixed.
+ unsigned NumNegativeBits = 0;
Michael137 wrote:
Can we move this block back in
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/126925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
labath
Author: Pavel Labath
Date: 2025-02-13T11:23:38+01:00
New Revision: 499d6da3bb2c967abda298518dc22b7baf084a9e
URL:
https://github.com/llvm/llvm-project/commit/499d6da3bb2c967abda298518dc22b7baf084a9e
DIFF:
https://github.com/llvm/llvm-project/commit/499d6da3bb2c967abda298518dc22b7baf084a9e.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/126925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -663,6 +663,41 @@ def do_test_indexedVariables(self,
enableSyntheticChildDebugging: bool):
]["variables"]
self.verify_variables(verify_children, children)
+def test_return_variables(self):
Da-Viper wrote:
I am a little bit confused abo
@@ -3801,6 +3801,23 @@ void request_variables(const llvm::json::Object
&request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+// Show return value if there is any ( in the top frame )
Da-Viper wrote:
Not sure
https://github.c
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/127059
Function was merging equal data even if they weren't adjecant. This caused a
problem in command-disassemble.s test because the two ranges describing the
function would be merged and "swallow" the function betwee
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127059
>From 450371c5fd3ecce3ec54237379fef751fba45751 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 13 Feb 2025 14:08:25 +0100
Subject: [PATCH] [lldb] Fix
RangeDataVector::CombineConsecutiveEntriesWithEqualDat
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Function was merging equal data even if they weren't adjecant. This caused a
problem in command-disassemble.s test because the two ranges describing the
function would be merged and "swallow" the function betw
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/127060
It's completely unnecessary right now, but having it present means that some
real unwanted dependencies could sneak in. (This also makes building the test
binary much faster.)
>From b5dc90a88c8a0d4182f28ebf4f98
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106907
>From aeb8854bbe7695e576257c8403e04d4b8268b679 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 13:48:41 +0100
Subject: [PATCH 1/6] Add: show return value on step out
---
lldb/tools/lldb-dap/l
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475
>From 0265d7e28d95d2dc2c06832b63ce7bd141429b99 Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Sun, 26 Jan 2025 17:34:17 +
Subject: [PATCH 01/12] lldb: Extended if conditions to support alias names for
registers
@@ -79,3 +79,7 @@ add_subdirectory(ValueObject)
if(LLDB_CAN_USE_DEBUGSERVER AND LLDB_TOOL_DEBUGSERVER_BUILD AND NOT
LLDB_USE_SYSTEM_DEBUGSERVER)
add_subdirectory(debugserver)
endif()
+
+if(LLVM_BUILD_TELEMETRY)
+ add_subdirectory(telemetry)
+endif()
oontvoo
@@ -0,0 +1,13 @@
+if (LLVM_BUILD_TELEMETRY)
+ add_lldb_library(lldbPluginTelemetryFakePlugin PLUGIN
+ FakePlugin.cpp
+
+ LINK_LIBS
+lldbCore
+lldbUtility
+lldbPluginProcessUtility
+ LINK_COMPONENTS
+Support
+Telemetry
+
@@ -59,11 +60,21 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
/// The base Telemetry manager instance in LLDB
/// This class declares additional instrumentation points
/// applicable to LLDB.
-class TelemetryManager : public llvm::telemetry::Manage
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/126352
>From 446b59bd47eb5356454665eeb82e75a77862350a Mon Sep 17 00:00:00 2001
From: Alex Bradbury
Date: Sat, 8 Feb 2025 06:27:26 +
Subject: [PATCH 1/2] [doc] Add Discord invite link alongside channel links
By far the
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/126972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-02-13T07:03:00-08:00
New Revision: 277cb60d9ab4335bcc6aef4366278e1500237d2c
URL:
https://github.com/llvm/llvm-project/commit/277cb60d9ab4335bcc6aef4366278e1500237d2c
DIFF:
https://github.com/llvm/llvm-project/commit/277cb60d9ab4335bcc6aef4366278e1500237d2c.diff
LOG:
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/127071
It's slower and it can fail in contexts where expression evaluation doesn't
work.
>From 0bed8bfb406208b1934a5dc2c538e40891d86e1d Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 13 Feb 2025 16:09:36 +0100
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
It's slower and it can fail in contexts where expression evaluation doesn't
work.
---
Full diff: https://github.com/llvm/llvm-project/pull/127071.diff
1 Files Affected:
- (modified) lldb/examples/synthetic/
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/127071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Bradbury
Date: 2025-02-13T15:00:21Z
New Revision: db2953d80148870ee22b0ffaed883a02174485c4
URL:
https://github.com/llvm/llvm-project/commit/db2953d80148870ee22b0ffaed883a02174485c4
DIFF:
https://github.com/llvm/llvm-project/commit/db2953d80148870ee22b0ffaed883a02174485c4.diff
LOG:
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From dd65babbf4c73a0b2fc2e4aa47a9a346bd5a9adf Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 01/15] [lldb] Analyze enum promotion type during parsing
---
clang/
kuilpd wrote:
@Michael137
Thank you for seeing this through!
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
Mostly yes. It's not as clean as I would have liked, though I suppose that is
to be expected of an attempt to retrofit a significant change like this. The
existence of Debugger::Get{Output,Error}File in particular is a very large hole
in the RAII locking sc
@@ -574,10 +581,10 @@ int Editline::GetCharacter(EditLineGetCharType *c) {
// indefinitely. This gives a chance for someone to interrupt us. After
// Read returns, immediately lock the mutex again and check if we were
// interrupted.
-m_output_mutex.unlock();
+
@@ -500,19 +502,16 @@ bool
CommandObjectExpression::EvaluateExpression(llvm::StringRef expr,
void CommandObjectExpression::IOHandlerInputComplete(IOHandler &io_handler,
std::string &line) {
io_handler.SetIsDone(true);
- S
@@ -700,12 +707,14 @@ unsigned char Editline::EndOrAddLineCommand(int ch) {
}
}
MoveCursor(CursorLocation::EditingCursor, CursorLocation::BlockEnd);
- fprintf(m_output_file, "\n");
+ LockedStreamFile locked_stream = m_output_stream_sp->Lock();
labath
@@ -193,10 +193,12 @@ are no syntax errors may indicate that a function was
declared but never called.
Options *GetOptions() override { return &m_all_options; }
void IOHandlerActivated(IOHandler &io_handler, bool interactive) override {
-StreamFileSP output_sp(io_hand
Author: Michael Buch
Date: 2025-02-13T09:53:17Z
New Revision: 3ad8657ff60b9967235ad65fdb8b767aae0e799d
URL:
https://github.com/llvm/llvm-project/commit/3ad8657ff60b9967235ad65fdb8b767aae0e799d
DIFF:
https://github.com/llvm/llvm-project/commit/3ad8657ff60b9967235ad65fdb8b767aae0e799d.diff
LOG:
Author: Pavel Labath
Date: 2025-02-13T10:08:16+01:00
New Revision: 298caebaadc38eadced7175c80ed6b2866755cb9
URL:
https://github.com/llvm/llvm-project/commit/298caebaadc38eadced7175c80ed6b2866755cb9
DIFF:
https://github.com/llvm/llvm-project/commit/298caebaadc38eadced7175c80ed6b2866755cb9.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/124931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,13 @@
+if (LLVM_BUILD_TELEMETRY)
+ add_lldb_library(lldbPluginTelemetryFakePlugin PLUGIN
+ FakePlugin.cpp
+
+ LINK_LIBS
+lldbCore
+lldbUtility
+lldbPluginProcessUtility
+ LINK_COMPONENTS
+Support
+Telemetry
+
@@ -0,0 +1,34 @@
+//===-- TestFakePlugin.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Michael137 wrote:
FYI on macOS CI this is failing with:
```
FAIL: test_dsym (TestCPPEnumPromotion.TestCPPEnumPromotion)
--
Traceback (most recent call last):
File
"/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-
kuilpd wrote:
> But only for dSYMs. Looking at the `dSYM`, none of the enums are actually
> preserved in the debug-info. You have to actually use the enum types in
> source to get dsymutil to preserve them. I'll fix it
Ah, I see. Thank you for handling this!
https://github.com/llvm/llvm-proje
https://github.com/DavidSpickett approved this pull request.
Correct according to
https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005fbuiltin.html, thanks for
the fix.
https://github.com/llvm/llvm-project/pull/127091
___
lldb-commits mailing list
ll
Author: John Harrison
Date: 2025-02-13T10:35:50-08:00
New Revision: c2e96778e04197dd266f7c540bf174b6ec28a434
URL:
https://github.com/llvm/llvm-project/commit/c2e96778e04197dd266f7c540bf174b6ec28a434
DIFF:
https://github.com/llvm/llvm-project/commit/c2e96778e04197dd266f7c540bf174b6ec28a434.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/126833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
> Based on the title of this PR I was expecting something slightly different,
> so maybe I'm missing something. But if we want to make this an LLDB plugin
> (which I agree we should ), I would expect the `PluginManager` to manage the
> instance rather than the plugin doing itsel
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475
>From 7d97df1b70d6d648992f9af2f4211768d3a14aa5 Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Sun, 26 Jan 2025 17:34:17 +
Subject: [PATCH] lldb: Extended if conditions to support alias names for
registers
---
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (sga-sc)
Changes
During testing of LLDB on RISC-V target, tests from the llgs category were
built with an error: `Error when building test subject.`
```
llvm-project/lldb/test/API/tools/lldb-server/main.cpp:151:40: error: missing
')'
Author: Georgiy Samoylov
Date: 2025-02-13T16:48:03Z
New Revision: 1138a4964adf76cc4af82b3f43dbc8db0b91cd46
URL:
https://github.com/llvm/llvm-project/commit/1138a4964adf76cc4af82b3f43dbc8db0b91cd46
DIFF:
https://github.com/llvm/llvm-project/commit/1138a4964adf76cc4af82b3f43dbc8db0b91cd46.diff
L
@@ -663,6 +663,41 @@ def do_test_indexedVariables(self,
enableSyntheticChildDebugging: bool):
]["variables"]
self.verify_variables(verify_children, children)
+def test_return_variables(self):
jimingham wrote:
lldb will do almost the right
https://github.com/jimingham approved this pull request.
LGTM
I left the question of whether this high-low index finding algorithm would be
useful elsewhere (it could be a method on Function from what you have & return).
If you don't think that's likely to be reusable, then this is fine as is.
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/123622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -970,19 +969,26 @@ class CommandObjectThreadUntil : public
CommandObjectParsed {
return;
}
-AddressRange fun_addr_range = sc.function->GetAddressRange();
-Address fun_start_addr = fun_addr_range.GetBaseAddress();
-line_table->FindL
Author: Michael Buch
Date: 2025-02-13T18:13:09Z
New Revision: 0feb00f17cbaac7428dcb7aed13d903b65974978
URL:
https://github.com/llvm/llvm-project/commit/0feb00f17cbaac7428dcb7aed13d903b65974978
DIFF:
https://github.com/llvm/llvm-project/commit/0feb00f17cbaac7428dcb7aed13d903b65974978.diff
LOG:
Michael137 wrote:
Fixed in `0feb00f17cbaac7428dcb7aed13d903b65974978`
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-02-13T23:13:46Z
New Revision: 050933b41f8de8498c95dfd0bacb10f3d495d62d
URL:
https://github.com/llvm/llvm-project/commit/050933b41f8de8498c95dfd0bacb10f3d495d62d
DIFF:
https://github.com/llvm/llvm-project/commit/050933b41f8de8498c95dfd0bacb10f3d495d62d.diff
LOG:
@@ -663,6 +663,41 @@ def do_test_indexedVariables(self,
enableSyntheticChildDebugging: bool):
]["variables"]
self.verify_variables(verify_children, children)
+def test_return_variables(self):
Da-Viper wrote:
I think understand it.
A func
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106907
>From aeb8854bbe7695e576257c8403e04d4b8268b679 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 13:48:41 +0100
Subject: [PATCH 1/7] Add: show return value on step out
---
lldb/tools/lldb-dap/l
JDevlieghere wrote:
> This was what we were doing in the [initial
> PR](https://github.com/llvm/llvm-project/pull/98528/files#diff-20a2060f8e87c6742d6f2c7ae97e919f8485995d7808bd9fccbfbede697a9ec7)
> but Pavel had correctly pointed out that the architecture was unnecessarily
> "baroque". GIven
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/127138
AppleObjCRuntimeV2 prints a warning when we read libobjc.A.dylib from memory,
as a canary to detect that we are reading system binaries out of memory (which
is slow, and we try hard to avoid). But with a c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
AppleObjCRuntimeV2 prints a warning when we read libobjc.A.dylib from memory,
as a canary to detect that we are reading system binaries out of memory (which
is slow, and we try hard to avoid). But with
https://github.com/JDevlieghere approved this pull request.
Makes sense. LGTM.
https://github.com/llvm/llvm-project/pull/127138
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
For the record, this PR was finally re-landed as
https://github.com/llvm/llvm-project/pull/126988 after four separate commits to
address issues found in CI testing when I originally merged this.
https://github.com/llvm/llvm-project/pull/96260
___
https://github.com/sga-sc created
https://github.com/llvm/llvm-project/pull/127091
During testing of LLDB on RISC-V target, tests from the llgs category were
built with an error: `Error when building test subject.`
```
llvm-project/lldb/test/API/tools/lldb-server/main.cpp:151:40: error: missin
Author: Ilia Kuklin
Date: 2025-02-13T22:08:31+05:00
New Revision: f30c891464debb4e0d47d27ea77dc2220d7cdf29
URL:
https://github.com/llvm/llvm-project/commit/f30c891464debb4e0d47d27ea77dc2220d7cdf29
DIFF:
https://github.com/llvm/llvm-project/commit/f30c891464debb4e0d47d27ea77dc2220d7cdf29.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
a1345eb240c9456ce1c339106f066217eb5e6984...8844cd67967e7a55682f2b0fd06e8bebe63dd604
lldb/
mgorny wrote:
I'm thoroughly confused by this. The idea is that if the port is not yet open,
then `Server` should fail to connect, and the test should retry, correct? If
you need to explicitly check if the port is already open, then it sounds like
the code doesn't work correctly.
https://gith
JDevlieghere wrote:
Based on the title of this PR I was expecting something slightly different, so
maybe I'm missing something. But if we want to make this an LLDB plugin (which
I agree we should ), I would expect the `PluginManager` to manage the instance
rather than the plugin doing itself.
@@ -0,0 +1,74 @@
+//===-- TelemetryTest.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
1 - 100 of 131 matches
Mail list logo
