https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From 0c22a94214e97146b2592b77ac96255bdee47b0f Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH 1/2] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi
Author: Jacob Lalonde
Date: 2025-02-03T11:26:03-08:00
New Revision: a3321ea5d60f10ee1abe03fa95b08095ced61c76
URL:
https://github.com/llvm/llvm-project/commit/a3321ea5d60f10ee1abe03fa95b08095ced61c76
DIFF:
https://github.com/llvm/llvm-project/commit/a3321ea5d60f10ee1abe03fa95b08095ced61c76.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/125557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
@puremourning Let me know if you need someone to press the Merge button for
you.
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
felipepiovezan wrote:
Turns out github has been stuck for ours without picking up my pushed fixup
commit :/
https://github.com/user-attachments/assets/ef97e7b5-acd2-4812-a258-f3030615d51c";
/>
https://github.com/llvm/llvm-project/pull/125300
___
ll
augusto2112 wrote:
Jim I updated the PR.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
What are the ownership rules for that reference to bytes that you are passing
out? Who's keeping it alive and for how long?
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
felipepiovezan wrote:
> Reference in new issue
> This creates a shared_pointer loop between the two objects, which doesn't
> sound like a good design. Maybe one of the pointers ought to be weak?
great catch!, I'll fix that
https://github.com/llvm/llvm-project/pull/125300
___
https://github.com/labath approved this pull request.
Thanks for the explanation. I understand what you mean now. The feature sounds
cool, and the implementation sort of makes sense (sort of, because the
HandleCommand idea is still "sort of" running around my head, but I do see how
it could be
Author: Zequan Wu
Date: 2025-02-03T14:34:20-05:00
New Revision: e269c2b5fa592498984cc381914bc65da377b08d
URL:
https://github.com/llvm/llvm-project/commit/e269c2b5fa592498984cc381914bc65da377b08d
DIFF:
https://github.com/llvm/llvm-project/commit/e269c2b5fa592498984cc381914bc65da377b08d.diff
LOG
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/4] [lldb] Implement bidirectional access fo
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/125347
>From 88134b8e891008715ca8ea90e809cac04f5b60f5 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 16 Nov 2024 19:01:12 +0100
Subject: [PATCH 1/3] [lldb-dap] Support column breakpoints (#113787)
Author: Adrian Vogelsgesang
Date: 2025-02-04T01:23:28+01:00
New Revision: 8e6fa15bc3e8a41553ffdc7fbd3d00285a250962
URL:
https://github.com/llvm/llvm-project/commit/8e6fa15bc3e8a41553ffdc7fbd3d00285a250962
DIFF:
https://github.com/llvm/llvm-project/commit/8e6fa15bc3e8a41553ffdc7fbd3d00285a250962
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/125557
My colleague, @lukejriddle made the SBMemoryRegionList object iterable in
#117358. This isn't documented anywhere and so I added a blurb about it to
SBProcess.
>From 9abe2bf9c55ecfb56ed7e46ddbdaa998be6e6fc7 Mo
Jlalond wrote:
@JDevlieghere You think I should also update the summary of the
SBMemoryRegionList type to note it's iterable?
https://github.com/llvm/llvm-project/pull/125557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
My colleague, @lukejriddle made the SBMemoryRegionList object iterable
in #117358. This isn't documented anywhere and so I added a blurb about
it to SBProcess.
---
Full diff: https://github.com/llvm/llvm-pr
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/125557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
This is ok for now, but we need to find the bug in lldb-server that causes
`qMemoryRegionInfo` to fail and return a `$#00` which means unsupported and
causes all future `qMemoryRegionInfo` to fail.
https://github.com/llvm/llvm-project/pul
vogelsgesang wrote:
@Michael137 Do you know if there is any way I could manually trigger the
lldb-aarch64-ubuntu and the MacOS CI before merging this, to get CI feedback
before merging this?
Also, from what I can tell, all test failures in Buildkite seem to be due to
Bolt and unrelated to my
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125132
>From ac8fe96328ce8e6d49bac5288278b853ecc2d65d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 3 Feb 2025 14:15:21 -0800
Subject: [PATCH] [lldb] Store the command in the CommandReturnObject
As
Michael137 wrote:
> @Michael137 Do you know if there is any way I could manually trigger the
> lldb-aarch64-ubuntu and the MacOS CI before merging this, to get CI feedback
> before merging this?
>
> Also, from what I can tell, all test failures in Buildkite seem to be due to
> Bolt and unrela
Michael137 wrote:
Feels a bit silly that we ran all LLVM/Clang/etc. tests just because you
amended the LLVM release notes
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
jimingham wrote:
> On Feb 3, 2025, at 3:48 PM, Augusto Noronha ***@***.***> wrote:
>
>
> What are the ownership rules for that reference to bytes that you are passing
> out? Who's keeping it alive and for how long?
>
> Since ValueObjectDynamicValue::UpdateValue immediately copies the buffer
augusto2112 wrote:
> What are the ownership rules for that reference to bytes that you are passing
> out? Who's keeping it alive and for how long?
Since `ValueObjectDynamicValue::UpdateValue` immediately copies the buffer over
I don't think that's a big concern...
I could change `ArrayRef` to
Author: Jacob Lalonde
Date: 2025-02-03T19:22:01-08:00
New Revision: ce7bca76917e6b72615f0f7f90a6e35e681b0d16
URL:
https://github.com/llvm/llvm-project/commit/ce7bca76917e6b72615f0f7f90a6e35e681b0d16
DIFF:
https://github.com/llvm/llvm-project/commit/ce7bca76917e6b72615f0f7f90a6e35e681b0d16.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/125323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cmtice wrote:
I've addressed all the remaining review comments (I think). Hopefully this is
ready for approval now? :-)
https://github.com/llvm/llvm-project/pull/123521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
puremourning wrote:
> @puremourning Let me know if you need someone to press the Merge button for
> you.
Yes please. I don't have commit rights.
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Author: Felipe de Azevedo Piovezan
Date: 2025-02-03T13:40:57-08:00
New Revision: 90a51a443a2fc900e514279fa6ea8882c48b10fa
URL:
https://github.com/llvm/llvm-project/commit/90a51a443a2fc900e514279fa6ea8882c48b10fa
DIFF:
https://github.com/llvm/llvm-project/commit/90a51a443a2fc900e514279fa6ea8882c
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125302
>From a2c624aad7e1fd931bba98f2086732bda5059ef7 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:28:45 -0800
Subject: [PATCH] [lldb] Improve isolation between Process plu
felipepiovezan wrote:
Rebased
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
One way to make the intent of the command string in the return object clear is
to ONLY set it after we've called HandleCommand (or HandleCommands). That way
it's explicitly NOT meant to help execute the command - after all, commands
really should NOT be operating on the un-al
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/cmtice edited
https://github.com/llvm/llvm-project/pull/123521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
> share more about the differences between the these cases and the actual logic
> between this patch and the previous attempt?
There are 3 separate commits in this PR. The first PR is literally the same as
the originally reverted one.
The other two commits show the additio
https://github.com/clayborg approved this pull request.
Thanks for fixing this!
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ben Jackson
Date: 2025-02-03T14:39:43-08:00
New Revision: c26bb4f095120ff4741b6530b6b3c0ac5a7dacad
URL:
https://github.com/llvm/llvm-project/commit/c26bb4f095120ff4741b6530b6b3c0ac5a7dacad
DIFF:
https://github.com/llvm/llvm-project/commit/c26bb4f095120ff4741b6530b6b3c0ac5a7dacad.diff
L
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/125312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Rebased and implemented @jimingham's latest suggestion.
https://github.com/llvm/llvm-project/pull/125132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> > There's currently no way to trigger the macOS CI unfortunately.
>
> Is a manual trigger possible for the `lldb-aarch64-ubuntu` build? Or is it
> same as for the macOS CI?
Not sure tbh. You can re-run failed runs, but not sure if you can trigger
specific test-suites to ru
jimingham wrote:
Is there's no way to test this with the languages supported by the upstream
lldb?
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -42,6 +42,8 @@ class LLDB_API SBCommandReturnObject {
bool IsValid() const;
+ const char *GetCommand();
jimingham wrote:
The docs currently in CommandReturnObject.h should certainly be here (or in
both places)...
https://github.com/llvm/llvm-project/
jimingham wrote:
Other that the comment comment, LGTM.
https://github.com/llvm/llvm-project/pull/125132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125132
>From ac8fe96328ce8e6d49bac5288278b853ecc2d65d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 3 Feb 2025 14:15:21 -0800
Subject: [PATCH 1/2] [lldb] Store the command in the CommandReturnObject
vogelsgesang wrote:
> There's currently no way to trigger the macOS CI unfortunately.
Is a manual trigger possible for the `lldb-aarch64-ubuntu` build? Or is it same
as for the macOS CI?
Is another round of "merge, pray, revert" our only option here, or is there
anything else I can do to merg
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/125132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick`
running on `linaro-clang-aarch64-quick` while building `lldb,llvm` at step 5
"ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/65/builds/11710
Here is the relevant
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From 0c22a94214e97146b2592b77ac96255bdee47b0f Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH 1/4] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6a05beeb2bed366f7e6e0056a758c6f8d385fdde
c6d65f18c647a06a4df9e36b766dce3edeaa4006 --e
augusto2112 wrote:
Unfortunately I wasn't able to construct a test case that would trigger this
with upstream lldb.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/125294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-02-03T14:54:51-08:00
New Revision: 79e804b478aafdb9f543c66c1cc9cca6908d6b8f
URL:
https://github.com/llvm/llvm-project/commit/79e804b478aafdb9f543c66c1cc9cca6908d6b8f
DIFF:
https://github.com/llvm/llvm-project/commit/79e804b478aafdb9f543c66c1cc9cca69
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Thanks!!
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Forcing push seems to have made it work
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
This idea has bothered me from the beginning, but I didn't want to say
anything, as it was mostly just a feeling. After seeing this patch, I think I
can put some words behind it.
The thing I don't like about this patch is the repetition/redundancy it
creat
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: Muhammad Omair Javaid
Date: 2025-02-03T15:17:08+05:00
New Revision: 5c065f01cee5dfca28d703983d0ebefa65128e09
URL:
https://github.com/llvm/llvm-project/commit/5c065f01cee5dfca28d703983d0ebefa65128e09
DIFF:
https://github.com/llvm/llvm-project/commit/5c065f01cee5dfca28d703983d0ebefa65128e
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/125294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -172,7 +172,4 @@ def test_ref_and_ptr(self):
# The pointer should just show the right number of elements:
-ptrAddr = self.findVariable("ptr").GetValue()
-self.expect_expr(
-"ptr", result_type="std::span *",
result_summary=f"{ptrAddr} si
@@ -10,22 +10,37 @@
class LibcxxVectorDataFormatterTestCase(TestBase):
-def check_numbers(self, var_name):
-self.expect(
-"frame variable " + var_name,
-substrs=[
-var_name + " = size=7",
-"[0] = 1",
-
Author: Michael Buch
Date: 2025-02-03T09:07:40Z
New Revision: f99e6df1415fa825b8329b381a23cd9c58d6edd4
URL:
https://github.com/llvm/llvm-project/commit/f99e6df1415fa825b8329b381a23cd9c58d6edd4
DIFF:
https://github.com/llvm/llvm-project/commit/f99e6df1415fa825b8329b381a23cd9c58d6edd4.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/122694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-02-03T09:10:20Z
New Revision: 5d738b2be051bf800445fb21df6de163af35695f
URL:
https://github.com/llvm/llvm-project/commit/5d738b2be051bf800445fb21df6de163af35695f
DIFF:
https://github.com/llvm/llvm-project/commit/5d738b2be051bf800445fb21df6de163af35695f.diff
LOG
labath wrote:
This creates a shared_pointer loop between the two objects, which doesn't sound
like a good design. Maybe one of the pointers ought to be weak?
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/125323
>From 973117aaa1d1bffe5a10a8c87edafec91dcd51bd Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 31 Jan 2025 17:37:46 -0800
Subject: [PATCH 1/2] Have custom ranges go through the same safety checks as
eve
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/125294
>From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Fri, 31 Jan 2025 13:05:14 -0800
Subject: [PATCH 1/4] [lldb] Show value for libcxx and libstdcxx summary and
remove
JDevlieghere wrote:
> I do have my doubts about embedding the command string into the return
> object, but it sounds like the thought had occurred to at least two of you
> independently, so if you all think that's the best direction, then I guess
> I'm outvoted.
I don't feel strongly about st
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
6a97897d5c159a52975bac19ac22c7913672c549...8bbb150ad7c7ed044d7ca30c745734938263b2d3
lldb
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/125323
>From 973117aaa1d1bffe5a10a8c87edafec91dcd51bd Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 31 Jan 2025 17:37:46 -0800
Subject: [PATCH 1/3] Have custom ranges go through the same safety checks as
eve
werat wrote:
I went through the thread to understand the current consensus and I see various
nice ideas flying around. Let me try to summarize the requirements and the
current status quo.
* DIL should support synthetic children, whose names can be arbitrary in
general case, even `a+b*c`
* A c
https://github.com/walter-erquinigo commented:
This LGTM, but before merging, could you share more about the differences
between the these cases and the actual logic between this patch and the
previous attempt?
https://github.com/llvm/llvm-project/pull/125347
_
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/125347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -140,6 +140,10 @@ Changes to LLDB
Therefore current implementation allows only 1 watchpoint, as tested with
Windows 11 on the Microsoft SQ2 and Snapdragon Elite X platforms.
+### Changes to lldb-dap
+
+* Breakpoints can now be set for specific columns within a line
jimingham wrote:
> This idea has bothered me from the beginning, but I didn't want to say
> anything, as it was mostly just a feeling. After seeing this patch, I think I
> can put some words behind it.
>
> The thing I don't like about this patch is the repetition/redundancy it
> creates. Like
labath wrote:
Thanks for the summary Andy.
> I went through the thread to understand the current consensus and I see
> various nice ideas flying around. Let me try to summarize the requirements
> and the current status quo.
>
> * DIL should support synthetic children, whose names can be arb
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/124931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
I've looked at this a couple of times and on a general level, it seems fine,
but all the address vs. file address stuff is confusing to me. I'm just
guessing what each one is really.
So I have added some questions about that, maybe I'll be able to ap
@@ -243,25 +243,15 @@ bool Block::GetRangeContainingAddress(const Address &addr,
AddressRange &range) {
Function *function = CalculateSymbolContextFunction();
if (function) {
-const AddressRange &func_range = function->GetAddressRan
@@ -6,15 +6,22 @@
# CHECK: Found 1 function(s).
# CHECK: foo: [input.o[0x0-0xe), input.o[0x14-0x1c)]
-# CHECK-NEXT: input.o[0x0]: cmpl $0x0, %edi
-# CHECK-NEXT: input.o[0x3]: je 0x14
-# CHECK-NEXT: input.o[0x5]: jmp0x7
-# CHECK-NEXT: input.o[0x7]: callq 0xe
-# CHECK
@@ -0,0 +1,38 @@
+# REQUIRES: native && target-riscv64
+# RUN: %clangxx_host -fomit-frame-pointer %p/Inputs/riscv64-gp-read.cpp -o %t
DavidSpickett wrote:
I'm guessing that `-fomit-frame-pointer` is to stop code after the inline asm
generating save/restore routi
jimingham wrote:
> On Feb 2, 2025, at 9:49 PM, cmtice ***@***.***> wrote:
>
>
> Apart from the (mainly stylistic) inline comments, the biggest problem I see
> is that the definition of an identifier is still too narrow. The restriction
> on the dollar sign is completely unnecessary as C wil
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From 88a8522f1b29b2ff392974322acdb722b7e00b70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH] [lldb-dap] Refactoring lldb-dap port listening mode to allow
mul
ashgti wrote:
> Overall, I like the StreamDescriptor changes, but I fear this patch is
> starting to lose focus again. Could you separate the refactor into a separate
> PR?
Reverted those changes, I kept running into clang (Xcode 16.0 release of clang)
crashes compiling lldb-dap for some reas
jimingham wrote:
> > To the best of my knowledge, all the languages that we want to support have
> > roughly the same definition of what a valid identifier is: a letter or
> > underscore, followed by a sequence of letters, digits and underscores,
> > where 'letters' are defined as 'a..z' and '
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> To the best of my knowledge, all the languages that we want to support have
> roughly the same definition of what a valid identifier is: a letter or
> underscore, followed by a sequence of letters, digits and underscores, where
> 'letters' are defined as 'a..z' and 'A..Z'. The
1 - 100 of 108 matches
Mail list logo
