Author: Pavel Labath
Date: 2025-01-31T09:07:11+01:00
New Revision: 13d0318a9848ec322ceea4f37fb6b421d70407b0
URL:
https://github.com/llvm/llvm-project/commit/13d0318a9848ec322ceea4f37fb6b421d70407b0
DIFF:
https://github.com/llvm/llvm-project/commit/13d0318a9848ec322ceea4f37fb6b421d70407b0.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/124733
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: kper
Date: 2025-01-31T10:01:35Z
New Revision: 614f1ab7575c83a28811fc6881eba512788101a0
URL:
https://github.com/llvm/llvm-project/commit/614f1ab7575c83a28811fc6881eba512788101a0
DIFF:
https://github.com/llvm/llvm-project/commit/614f1ab7575c83a28811fc6881eba512788101a0.diff
LOG: [lldb] A
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/124758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/labath commented:
Apart from the (mainly stylistic) inline comments, the biggest problem I see is
that the definition of an identifier is still too narrow. The restriction on
the dollar sign is completely unnecessary as C will let you put that
[anywhere](https://godbolt.org/
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/123521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,131 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,132 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
Author: Pavel Labath
Date: 2025-01-31T09:12:56+01:00
New Revision: 3736de2e3c20b4ed496a6590bc758ac0e033bd4c
URL:
https://github.com/llvm/llvm-project/commit/3736de2e3c20b4ed496a6590bc758ac0e033bd4c
DIFF:
https://github.com/llvm/llvm-project/commit/3736de2e3c20b4ed496a6590bc758ac0e033bd4c.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/124938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I added a "DEPRECATED" comment, which isn't quite as strong, but sort of
conveys the same thing. The function is called from a bunch of places, but I
don't think there's that much churn around it for backsliding to be a problem.
https://github.com/llvm/llvm-project/pull/124938
__
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/125125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,192 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
DavidSpickett wrote:
Please set a valid email address first -
https://llvm.org/docs/DeveloperPolicy.html#github-email-address
Then this can be merged.
https://github.com/llvm/llvm-project/pull/124758
___
lldb-commits mailing list
lldb-commits@lists.l
DavidSpickett wrote:
> I am not sure whether I will lose the approval if I rebase.
GitHub seems to let you do almost anything without losing existing approvals,
for better or worse :)
It would have been fine anyway, it's just doing the rebase onto main that
"squash and merge" will do anyway.
Author: John Harrison
Date: 2025-01-31T09:48:09Z
New Revision: 41910f72638354cfd27cf7c518dde47e9eb9deab
URL:
https://github.com/llvm/llvm-project/commit/41910f72638354cfd27cf7c518dde47e9eb9deab
DIFF:
https://github.com/llvm/llvm-project/commit/41910f72638354cfd27cf7c518dde47e9eb9deab.diff
LOG:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/125156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Omair Javaid
Date: 2025-01-31T14:11:39+05:00
New Revision: 2bffa5bf7abd4fc7b84f14d029a97c49f4b61130
URL:
https://github.com/llvm/llvm-project/commit/2bffa5bf7abd4fc7b84f14d029a97c49f4b61130
DIFF:
https://github.com/llvm/llvm-project/commit/2bffa5bf7abd4fc7b84f14d029a97c49f4b61130.diff
https://github.com/omjavaid closed
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124758
>From 4ea5df2aae805fab0ace107b6f9e4b9b9c19b2f3 Mon Sep 17 00:00:00 2001
From: Kevin Per
Date: Tue, 28 Jan 2025 14:44:44 +
Subject: [PATCH] lldb: Add RISCV for Makefile.rules
---
lldb/packages/Python/lldbsuite/
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125203
I tried using `CompleteEnumType` to replace some duplicated code in
`DWARFASTParserClang::ParseEnum` but tests started failing.
`CompleteEnumType` parse/attach the child enumerators using the signedness it
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125203
>From 620f30f73930a1a8b2edb298f67d555ff3b93e2c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 31 Jan 2025 11:18:28 +
Subject: [PATCH 1/3] [lldb][TypeSystemClang] Fix enum signedness in
CompleteEn
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2c934dc5e1a3ef7b717400f27d6b9ea21f4e20a0
23cd607c0c8130a783f80d94e98b7b89b70d45f0 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
I tried using `CompleteEnumType` to replace some duplicated code in
`DWARFASTParserClang::ParseEnum` but tests started failing.
`CompleteEnumType` parses/attaches the child enumerators using the signedness
jimingham wrote:
> On Jan 31, 2025, at 2:21 AM, Pavel Labath ***@***.***> wrote:
>
>
> @labath commented on this pull request.
>
> Apart from the (mainly stylistic) inline comments, the biggest problem I see
> is that the definition of an identifier is still too narrow. The restriction
> o
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-01-31T13:09:46Z
New Revision: ae570d5d77e806784064ee819211868e745d0fbe
URL:
https://github.com/llvm/llvm-project/commit/ae570d5d77e806784064ee819211868e745d0fbe
DIFF:
https://github.com/llvm/llvm-project/commit/ae570d5d77e806784064ee819211868e745d0fbe.diff
LOG:
@@ -8541,12 +8541,10 @@ clang::EnumConstantDecl
*TypeSystemClang::AddEnumerationValueToEnumerationType(
clang::EnumConstantDecl *TypeSystemClang::AddEnumerationValueToEnumerationType(
const CompilerType &enum_type, const Declaration &decl, const char *name,
-int64_t e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
The `DWARFASTParserClang` reads enum values as `int64_t`s regardless of the
enumerators signedness. Then we pass it to
`AddEnumerationValueToEnumerationType` and only then do we create an `APSInt`
from it
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/125244
The `DWARFASTParserClang` reads enum values as `int64_t`s regardless of the
enumerators signedness. Then we pass it to
`AddEnumerationValueToEnumerationType` and only then do we create an `APSInt`
from it.
jimingham wrote:
We have a bunch of other structured output that we could start decorating this
way. For instance if `image list` produced a a JSON-ified version of itself
(maybe only when there was a callback present) and had a way to "get JSON-ified
result" then it could render that list i
JDevlieghere wrote:
Jim & I have been discussing this offline. Thanks for adding the additional
context to the PR!
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
augusto2112 wrote:
> I worry a bit about the fact that in the host case, GetValueAsData is going
> to end up calling:
>
> ```
> memcpy(dst, reinterpret_cast(address), byte_size);
> ```
>
> where address is the host data buffer and byte_size is the size of the new
> dynamic type. But in the
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/4] [lldb] Use llvm::Error instead of CommandReturnObje
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/125203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Overall, I like the StreamDescriptor changes, but I fear this patch is starting
to lose focus again. Could you separate the refactor into a separate PR?
https://github.com/llvm/llvm-project/pull/116392
___
lldb-commits mailing list
lldb-
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/125242
This reverts commit a774de807e56c1147d4630bfec3110c11d41776e.
This is the same changes as last time, plus:
* We load the binary into the target object so that on Windows, we can resolve
the locations of t
DavidSpickett wrote:
Pull request just in case we have to discuss this more, going to merge right
now.
https://github.com/llvm/llvm-project/pull/125242
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
Author: David Spickett
Date: 2025-01-31T15:56:33Z
New Revision: 7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b
URL:
https://github.com/llvm/llvm-project/commit/7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b
DIFF:
https://github.com/llvm/llvm-project/commit/7e66cf74fb4e6a103f923e34700a7b6f20ac2a9b.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125242
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This reverts commit a774de807e56c1147d4630bfec3110c11d41776e.
This is the same changes as last time, plus:
* We load the binary into the target object so that on Windows, we can resolve
the locations
DavidSpickett wrote:
Back in again after fixing Windows testing -
https://github.com/llvm/llvm-project/pull/125242.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-01-31T12:38:07Z
New Revision: 8bd728180cadbab9fe11cd853670e488827ee302
URL:
https://github.com/llvm/llvm-project/commit/8bd728180cadbab9fe11cd853670e488827ee302
DIFF:
https://github.com/llvm/llvm-project/commit/8bd728180cadbab9fe11cd853670e488827ee302.diff
LOG:
@@ -743,3 +743,15 @@ void SBCommand::SetFlags(uint32_t flags) {
if (IsValid())
m_opaque_sp->GetFlags().Set(flags);
}
+
+void SBCommandInterpreter::SetPrintCallback(
+lldb::SBCommandPrintCallback callback, void *baton) {
+ LLDB_INSTRUMENT_VA(this, callback, baton);
+
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/125006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -17,6 +17,7 @@
namespace lldb_private {
class CommandPluginInterfaceImplementation;
+class CommandPrintCallbackBaton;
labath wrote:
I think these could go away too...
https://github.com/llvm/llvm-project/pull/125006
___
jimingham wrote:
There are other ways you could extend this that would be very fun. For
instance, we could make any command that conses up its result just by calling
the ValueObjectPrinter on some ValueObject to also stuff that ValueObject to
the command return. Then we could add
SBCommandR
Author: Dave Lee
Date: 2025-01-31T09:29:22-08:00
New Revision: 1b0becf739ace0e04c57b50ab701b5e3d009ccbb
URL:
https://github.com/llvm/llvm-project/commit/1b0becf739ace0e04c57b50ab701b5e3d009ccbb
DIFF:
https://github.com/llvm/llvm-project/commit/1b0becf739ace0e04c57b50ab701b5e3d009ccbb.diff
LOG:
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125006
>From d9c0b0e1e6c18b6710c5b15843e23a96ca0a9dc8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 28 Jan 2025 17:08:52 -0800
Subject: [PATCH 1/4] [lldb] Support CommandInterpreter print callbacks
https://github.com/felipepiovezan approved this pull request.
after staring at this long enough, I think this is fine, since the uint->int
conversion is done by apint
https://github.com/llvm/llvm-project/pull/125244
___
lldb-commits mailing list
lldb-
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/125270
Name and line number are part of different option groups and are not compatible.
(lldb) breakpoint set -n foo -l 10
error: invalid combination of options for the given command
The help output for `brea
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Name and line number are part of different option groups and are not compatible.
```
(lldb) breakpoint set -n foo -l 10
error: invalid combination of options for the given command
```
The help outpu
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/125270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1b0becf739ace0e04c57b50ab701b5e3d009ccbb...a33e43e56e8a58c1d53c566c0b9da7791254d68e
lldb/
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125270
>From a33e43e56e8a58c1d53c566c0b9da7791254d68e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 31 Jan 2025 11:10:40 -0800
Subject: [PATCH 1/2] [lldb] Use validation combination of options in
Te
https://github.com/dzhidzhoev approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/122694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/118986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/125294
This has two changes:
1. Set show value for libcxx and libstdcxx summary provider. This will print
the pointer value for both pointer type and reference type.
2. Remove pointer value printing in libcxx containe
adrian-prantl wrote:
This is breaking macOS bots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/19569/
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
adrian-prantl wrote:
I'm going to revert this for now, let me know if you need help understanding
the failure cause!
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This has two changes:
1. Set show value for libcxx and libstdcxx summary provider. This will print
the pointer value for both pointer type and reference type.
2. Remove pointer value printing in libcxx container
jimingham wrote:
I think it's worth making it as hard as possible to get the length you're
supposed to read from that buffer right.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
jimingham wrote:
This is a very common crash point. I suspect that in most of the cases it's
because we flub whether something is a load or a host address, but I still
don't want to add other mistakes we could make here.
https://github.com/llvm/llvm-project/pull/125143
__
clayborg wrote:
Seeing as you are working on watchpoints here, I found that `void
WatchpointList::RemoveAll(bool notify)` is sending the wrong event of
`Target::eBroadcastBitBreakpointChanged` instead of sending
`Target::eBroadcastBitWatchpointChanged`. Might be a good fix to get in to
ensure
jimingham wrote:
This looks good. I wonder if we ought to do something a little less ad hoc
about the cases where our command return objects are from HandleCommands, so
they won't necessarily have the result of a single command. In the case where
a UI is parsing these, it might very well nee
https://github.com/jimingham approved this pull request.
LGTM, better to be consistent, and the pointer value is useful.
https://github.com/llvm/llvm-project/pull/125294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -470,6 +470,18 @@ class Thread : public std::enable_shared_from_this,
virtual void ClearStackFrames();
+ /// Derived classes implementing SetBackingThread should use this to provide
+ /// bidirectional access to the Backing-Backed relationship.
+ void SetBackedThread(
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/2] [lldb] Implement bidirectional access fo
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/3] [lldb] Implement bidirectional access fo
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
> Yes, part of the requirement is that the output isn't printed by lldb itself,
> although the implementer is still in control with the return value.
Okay. I was afraid of that. :)
The code looks good, though I must admit that the functionality seems a bit.
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/125203
>From 620f30f73930a1a8b2edb298f67d555ff3b93e2c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 31 Jan 2025 11:18:28 +
Subject: [PATCH 1/4] [lldb][TypeSystemClang] Fix enum signedness in
CompleteEn
DavidSpickett wrote:
Windows on Arm passed, Arm and AArch64 Linux passed. No complaints so far.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
jimingham wrote:
> > Yes, part of the requirement is that the output isn't printed by lldb
> > itself, although the implementer is still in control with the return value.
>
> Okay. I was afraid of that. :)
>
> The code looks good, though I must admit that the functionality seems a bit..
> ran
puremourning wrote:
I think the issue is that... we just don't support read-only watchpoints on
intel because the [hardware doesn't support
it](https://en.wikipedia.org/wiki/X86_debug_register#cite_note-brkpt_type-19).
I guess I'll mark this test as "skip on x86"
https://github.com/llvm/llvm-
https://github.com/puremourning updated
https://github.com/llvm/llvm-project/pull/124847
>From 6b3ba3f6dcf11d8b18ff72bc736b24ac75231626 Mon Sep 17 00:00:00 2001
From: Ben Jackson
Date: Tue, 28 Jan 2025 21:47:24 +
Subject: [PATCH] LLDB: WatchAddress ignores modify option
The WatchAddress AP
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/125300
This enables finding the backed thread from the backing thread without going
through the thread list, and it will be useful for subsequent commits.
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/125125
>From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 30 Jan 2025 14:25:16 -0800
Subject: [PATCH 1/4] [lldb] Use llvm::Error instead of CommandReturnObje
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/125270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
I'm happy that you can make ResolveCommand fail on commands that aren't valid!
These tests clearly thought they were making up a legal command string, so this
change expresses better what the test intends anyway.
https://github.com/llvm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This enables finding the backed thread from the backing thread without going
through the thread list, and it will be useful for subsequent commits.
---
Full diff: https://github.com/llvm/
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/125302
Generally speaking, process plugins (e.g. ProcessGDBRemote) should not be aware
of OS plugin threads. However, ProcessGDBRemote attempts to check for the
existence of OS threads when calculating stop inf
felipepiovezan wrote:
Depends on https://github.com/llvm/llvm-project/pull/125300
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Can you write or modify a test? I glanced over `TestWatchpointEvents.py` and it
looks like it's listening to the wrong bit (even thought the test is passing
with your change).
https://github.com/llvm/llvm-project/pull/125312
___
@@ -72,12 +72,17 @@ class ThreadMemory : public lldb_private::Thread {
void ClearStackFrames() override;
- void ClearBackingThread() override { m_backing_thread_sp.reset(); }
+ void ClearBackingThread() override {
+if (m_backing_thread_sp)
+ m_backing_thread_sp->
1 - 100 of 142 matches
Mail list logo
