[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-30 Thread Michael Buch via lldb-commits
@@ -0,0 +1,37 @@ +""" +Test LLDB type promotion of unscoped enums. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestCPPEnumPromotion(TestBase): +@skipIf(debug_info=no_match([

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-30 Thread Michael Buch via lldb-commits
@@ -0,0 +1,37 @@ +""" +Test LLDB type promotion of unscoped enums. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestCPPEnumPromotion(TestBase): +@skipIf(debug_info=no_match([

[Lldb-commits] [lldb] [lldb] Use Function::GetAddress in Module::FindFunctions (PR #124938)

2025-01-30 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM. You might add a comment to GetAddressRange saying "I'm in the process of getting rid of this, don't use it in the meantime...". But presumably you are also watching PR's to make sure nobody reintroduces its use. https://github.co

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-30 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( clang_type, decl, name, enum_val

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a7e8bfe - [lldb] Fix CommandInterpreter.{h, cpp} formatting (NFC)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-30T09:53:57-08:00 New Revision: a7e8bfe5ad9a1c1e3f0bba886474f381ebc403a9 URL: https://github.com/llvm/llvm-project/commit/a7e8bfe5ad9a1c1e3f0bba886474f381ebc403a9 DIFF: https://github.com/llvm/llvm-project/commit/a7e8bfe5ad9a1c1e3f0bba886474f381ebc403a9.d

[Lldb-commits] [lldb] Only include necessary files in the lldb-dap VSIX (PR #124986)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice cleanup. Thank you! https://github.com/llvm/llvm-project/pull/124986 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Support CommandInterpreter print callbacks (PR #125006)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Alright, I have two follow-ups/action items: - Check if we can improve the breakpoint callback with a lambda. - Add the command string to `CommandReturnObject`. https://github.com/llvm/llvm-project/pull/125006 ___ lldb-commits ma

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/115005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/116392 >From f946fd70bb550320bb153a59b8acd702dc97e75d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Jan 2025 12:39:38 -0800 Subject: [PATCH 1/2] [lldb-dap] Refactoring lldb-dap port listening mode to allow

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) { auto terminate_debugger = llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); }); - StreamDescriptor input; - StreamDescriptor output; - std::FILE *redirectOut = nullptr; - std::FILE *redirectErr = n

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) { auto terminate_debugger = llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); }); - StreamDescriptor input; - StreamDescriptor output; - std::FILE *redirectOut = nullptr; - std::FILE *redirectErr = n

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
@@ -1167,21 +1168,61 @@ def __init__( if log_file: adaptor_env["LLDBDAP_LOG"] = log_file +args = [executable] + +if connection is not None: +args.append("--connection") +args.append(connection)

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
@@ -4952,6 +4930,28 @@ static int DuplicateFileDescriptor(int fd) { #endif } +static llvm::Expected> +parseConnection(llvm::StringRef conn) { + if (conn.contains("://")) { ashgti wrote: Updated this to validate the connection and used the URI Parser to parse

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/116392 >From f946fd70bb550320bb153a59b8acd702dc97e75d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Jan 2025 12:39:38 -0800 Subject: [PATCH 1/3] [lldb-dap] Refactoring lldb-dap port listening mode to allow

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-01-30 Thread John Harrison via lldb-commits
@@ -5058,72 +5053,148 @@ int main(int argc, char *argv[]) { auto terminate_debugger = llvm::make_scope_exit([] { lldb::SBDebugger::Terminate(); }); - StreamDescriptor input; - StreamDescriptor output; - std::FILE *redirectOut = nullptr; - std::FILE *redirectErr = n

[Lldb-commits] [lldb] 7469032 - [lldb] Constify methods in CommandReturnObject (NFC)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-30T10:37:23-08:00 New Revision: 74690327c8fb3b1bc8722b8ae40091b268100468 URL: https://github.com/llvm/llvm-project/commit/74690327c8fb3b1bc8722b8ae40091b268100468 DIFF: https://github.com/llvm/llvm-project/commit/74690327c8fb3b1bc8722b8ae40091b268100468.d

[Lldb-commits] [lldb] [lldb] Support CommandInterpreter print callbacks (PR #125006)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/125006 >From d9c0b0e1e6c18b6710c5b15843e23a96ca0a9dc8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 28 Jan 2025 17:08:52 -0800 Subject: [PATCH 1/3] [lldb] Support CommandInterpreter print callbacks

[Lldb-commits] [lldb] [lldb] Support CommandInterpreter print callbacks (PR #125006)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Landed the NFC changes and rebase the PR. https://github.com/llvm/llvm-project/pull/125006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c1e9b90 - [lldb] Remove unused CommandReturnObject stack variable (NFC)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-30T13:36:25-08:00 New Revision: c1e9b908d9c205970f025c188c6fbe6fb93be98d URL: https://github.com/llvm/llvm-project/commit/c1e9b908d9c205970f025c188c6fbe6fb93be98d DIFF: https://github.com/llvm/llvm-project/commit/c1e9b908d9c205970f025c188c6fbe6fb93be98d.d

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use `llvm::Error` instead of `CommandReturnObject` for error reporting. The command return objects were populated with errors but never displayed. With this patch they're at least logged. --- Full

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/125125 Use `llvm::Error` instead of `CommandReturnObject` for error reporting. The command return objects were populated with errors but never displayed. With this patch they're at least logged. >From 218db812d5

[Lldb-commits] [lldb] [NFC][lldb] Document a few ivars on the value object system. (PR #124971)

2025-01-30 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/124971 >From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Wed, 29 Jan 2025 10:53:23 -0800 Subject: [PATCH 1/3] [NFC][lldb] Document a few ivars on the value object

[Lldb-commits] [lldb] [NFC][lldb] Document a few ivars on the value object system. (PR #124971)

2025-01-30 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/124971 >From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Wed, 29 Jan 2025 10:53:23 -0800 Subject: [PATCH 1/2] [NFC][lldb] Document a few ivars on the value object

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/125125 >From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 30 Jan 2025 14:25:16 -0800 Subject: [PATCH] [lldb] Use llvm::Error instead of CommandReturnObject f

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-01-30 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/125143 …uffer ValueObjectDynamicValue::UpdateValue() assumes that the dynamic type found by GetDynamicTypeAndAddress() would return an address in the inferior. This commit makes it so it can deal with being pass

[Lldb-commits] [lldb] [lldb-dap] Partially reverting OutputRedirector changes. (PR #125136)

2025-01-30 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/125136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][lldb] Document a few ivars on the value object system. (PR #124971)

2025-01-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bda19768de03a0322c4094c8d0e00ad033268309 87eca7770ba2a747db1843a8abfdceaa2f4debf8 --e

[Lldb-commits] [lldb] 26c2da5 - [lldb] Remove another unused CommandReturnObject variable (NFC)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-30T14:21:37-08:00 New Revision: 26c2da5a122532035b8bf63af89208d6d799e40e URL: https://github.com/llvm/llvm-project/commit/26c2da5a122532035b8bf63af89208d6d799e40e DIFF: https://github.com/llvm/llvm-project/commit/26c2da5a122532035b8bf63af89208d6d799e40e.d

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-30 Thread Jonas Devlieghere via lldb-commits
@@ -590,13 +550,50 @@ void Options::GenerateOptionUsage(Stream &strm, CommandObject &cmd, strm.SetIndentLevel(save_indent_level); } +llvm::Error Options::VerifyOptions() { + bool options_are_valid = false; + + int num_levels = GetRequiredOptions().size(); + if (num_level

[Lldb-commits] [lldb] [NFC][lldb] Document a few ivars on the value object system. (PR #124971)

2025-01-30 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/124971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 26c2da5a122532035b8bf63af89208d6d799e40e 24ddc550e3ee61b863cbaea05ff49981bc20f7ad --e

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-30 Thread Pavel Labath via lldb-commits
labath wrote: > We would have to change how synthetic children are made currently for array > like things for this to work. If I have a std:vector called `foo` and I write: > > (lldb) v foo[0] > > and the DIL parses that it will either ask foo for a child named `0`, which > doesn't exist, or

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/123945 >From ecb1b90e109df650ef1b50cc3d07b56fd302e274 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 22 Jan 2025 10:52:16 + Subject: [PATCH 1/5] Reland "[lldb] Implement basic support for reverse-c

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: @labath you can append to the PR description if you want to explain the bit I committed from you about the x packet. https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb] Add support for gdb-style 'x' packet (PR #124733)

2025-01-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This patch looks good to me, thanks for the explanation in the discourse of the points I misunderstood initially. https://github.com/llvm/llvm-project/pull/124733 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb] Add support for gdb-style 'x' packet (PR #124733)

2025-01-30 Thread David Spickett via lldb-commits
@@ -218,7 +218,12 @@ class GDBRemoteCommunicationClient : public GDBRemoteClientBase { bool GetpPacketSupported(lldb::tid_t tid); - bool GetxPacketSupported(); + enum class xPacketState { +Unimplemented, +Prefixed, // Successful responses start with a 'b' charact

[Lldb-commits] [lldb] [lldb] Add support for gdb-style 'x' packet (PR #124733)

2025-01-30 Thread David Spickett via lldb-commits
@@ -0,0 +1,36 @@ +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase + + +class TestReadMemory(GDBRemoteTestBase): +def test_x_with

[Lldb-commits] [lldb] [lldb] Add support for gdb-style 'x' packet (PR #124733)

2025-01-30 Thread David Spickett via lldb-commits
@@ -0,0 +1,36 @@ +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase + + +class TestReadMemory(GDBRemoteTestBase): +def test_x_with

[Lldb-commits] [lldb] [lldb] Add support for gdb-style 'x' packet (PR #124733)

2025-01-30 Thread David Spickett via lldb-commits
@@ -0,0 +1,36 @@ +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test.gdbclientutils import * +from lldbsuite.test.lldbgdbclient import GDBRemoteTestBase + + +class TestReadMemory(GDBRemoteTestBase): +def test_x_with

<    1   2