[Lldb-commits] [lldb] [lldb] Enable the use of dladdr() on Android (PR #124187)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/124187 dladdr() was introduced 15 years ago. >From e70b8c1b451d40492b3b4b445ad503142d5b0838 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 23 Jan 2025 15:39:43 -0500 Subject: [PATCH] [lldb] Enable the use of dladd

[Lldb-commits] [lldb] [lldb][AArch64] Fix expression evaluation with Guarded Control Stacks (PR #123918)

2025-01-23 Thread Omair Javaid via lldb-commits
@@ -103,6 +156,9 @@ bool ABISysV_arm64::PrepareTrivialCall(Thread &thread, addr_t sp, return_addr)) return false; + if (GetProcessSP()->GetTarget().GetArchitecture().GetTriple().isOSLinux()) +PushToLinuxGuardedControlStack(return_addr, reg_ctx, thread); ---

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread via lldb-commits
@@ -644,32 +644,22 @@ void ABISysV_loongarch::AugmentRegisterInfo( std::vector ®s) { lldb_private::RegInfoBasedABI::AugmentRegisterInfo(regs); + static const std::unordered_map reg_aliases = { wangleiat wrote: Thanks. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread via lldb-commits
@@ -644,32 +644,22 @@ void ABISysV_loongarch::AugmentRegisterInfo( std::vector ®s) { lldb_private::RegInfoBasedABI::AugmentRegisterInfo(regs); + static const std::unordered_map reg_aliases = { + {"r0", "zero"}, {"r1", "ra"}, {"r2", "tp"}, {"r3", "sp"}, + {"r

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread via lldb-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/124059 >From f404df6b2ac7b7ab33e3baadd3830154904a Mon Sep 17 00:00:00 2001 From: Ray Wang Date: Thu, 23 Jan 2025 12:13:32 +0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-

[Lldb-commits] [lldb] WIP: Stop using replicated variable ids (PR #124232)

2025-01-23 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread via lldb-commits
wangleiat wrote: > ABI details are someone else's job but on generic things this is the right > idea. > > It needs tests, I suggest you find the tests that read general registers and > add aliased name reads to those. Though it's unlikely to break for just one > use case, I would add this to

[Lldb-commits] [lldb] WIP: Stop using replicated variable ids (PR #124232)

2025-01-23 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid updated https://github.com/llvm/llvm-project/pull/124232 >From e741fc75ccb6e2a725b3b26dd4c503cdea6c5fbb Mon Sep 17 00:00:00 2001 From: Anthony Eid Date: Fri, 24 Jan 2025 00:43:39 -0500 Subject: [PATCH] Stop using replicated variable ids --- lldb/tools/lldb-dap/D

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread via lldb-commits
@@ -644,32 +644,22 @@ void ABISysV_loongarch::AugmentRegisterInfo( std::vector ®s) { lldb_private::RegInfoBasedABI::AugmentRegisterInfo(regs); + static const std::unordered_map reg_aliases = { wangleiat wrote: Thanks https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb] Use the first address range as the function address (PR #122440)

2025-01-23 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Sorry I wasn't sure if Greg or David had further comments/questions so I didn't touch it. This looks good to me. The one question I had is in a few places where you construct a Function (`std::make_shared...`) we pass the base addre

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > If the objection is that's a pain to do for every formatter, we could have > the type matcher do the dereferencing and always pass the formatter the > ValueObject that is the type they registered the formatter for. Do you mean pass the formatter the ValueObject with type `T`

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: @labath What do you think? The solution above will still use the formatters for `T` when `T**` is printed. https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb] Check Android API for existence of getgrgid_r() introduced in 24 (PR #124182)

2025-01-23 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > > > How does this patch fit with the: > > > ``` > > >-p ( --skip-pointers ) > > > Don't use this format for pointers-to-type objects. > > > > > >-r ( --skip-references ) > > > Don't use this format for references-to-type objects. > > > ``` > > > > > >

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-23 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/122783 >From 425ef0b5d0755be581ce90b6f50b818f80ecdaf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 23 Jan 2025 10:41:45 -0800 Subject: [PATCH] Reapply "[lldb-dap] Ensure the IO forwarding threads are managed

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-23 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/122783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
@@ -83,3 +83,137 @@ def test_gcs_fault(self): "stop reason = signal SIGSEGV: control protection fault", ], ) + +@skipUnlessArch("aarch64") +@skipUnlessPlatform(["linux"]) +def test_gcs_registers(self): +if not self.isAArch

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. This look good. Just a minor nit to add more details about how GCS locking testing is being done. https://github.com/llvm/llvm-project/pull/123720 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/123720 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add Guarded Control Stack registers (PR #123720)

2025-01-23 Thread Omair Javaid via lldb-commits
@@ -2,8 +2,8 @@ #include #include -#ifndef HWCAP2_GCS -#define HWCAP2_GCS (1UL << 63) +#ifndef HWCAP_GCS +#define HWCAP_GCS (1UL << 32) omjavaid wrote: Apprently following entry is misleading "Support for GCS is reported to userspace via HWCAP_GCS in the

<    1   2