[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: ABI details are someone else's job but on generic things this is the right idea. It needs tests, I suggest you find the tests that read general registers and add aliased name reads to those. Though it's unlikely to break for just one use case, I woul

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread David Spickett via lldb-commits
@@ -644,32 +644,22 @@ void ABISysV_loongarch::AugmentRegisterInfo( std::vector ®s) { lldb_private::RegInfoBasedABI::AugmentRegisterInfo(regs); + static const std::unordered_map reg_aliases = { DavidSpickett wrote: There is `llvm/include/llvm/ADT/String

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/124096 LLDB deduces the CV-qualifiers and storage class of a C++ method from the object parameter. Currently it assumes that parameter is implicit (and is a pointer type with the name "this"). This isn't true anymo

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes LLDB deduces the CV-qualifiers and storage class of a C++ method from the object parameter. Currently it assumes that parameter is implicit (and is a pointer type with the name "this"). This isn't true any

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/123945 >From ecb1b90e109df650ef1b50cc3d07b56fd302e274 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 22 Jan 2025 10:52:16 + Subject: [PATCH 1/4] Reland "[lldb] Implement basic support for reverse-c

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: > can you add @skipIfRemote to the tests? Done > Another, simpler way to fix the memory read problem might be to just tolerate > failed memory writes --- log and continue. Log and continue is liable to be "triager forgets to look at logs, wastes days, disables the test a

[Lldb-commits] [lldb] Revert "[lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters" (PR #124100)

2025-01-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/124100 Reverts llvm/llvm-project#124096 Broke linux CI: ``` Note: This is test shard 7 of 42. [==] Running 1 test from 1 test suite. [--] Global test environment set-up. [--] 1 test from DWAR

[Lldb-commits] [lldb] a802093 - Revert "[lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters" (#124100)

2025-01-23 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-23T11:20:14Z New Revision: a8020930a8174d84da04fa91b6fef244207f42f5 URL: https://github.com/llvm/llvm-project/commit/a8020930a8174d84da04fa91b6fef244207f42f5 DIFF: https://github.com/llvm/llvm-project/commit/a8020930a8174d84da04fa91b6fef244207f42f5.diff LOG:

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/14712 Here is the relevant piece of the build log

[Lldb-commits] [lldb] Revert "[lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters" (PR #124100)

2025-01-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Reverts llvm/llvm-project#124096 Broke linux CI: ``` Note: This is test shard 7 of 42. [==] Running 1 test from 1 test suite. [--] Global test environment set-up. [--] 1 test from DW

[Lldb-commits] [lldb] Revert "[lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters" (PR #124100)

2025-01-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/124100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-23 Thread Michael Buch via lldb-commits
Michael137 wrote: Reverting for now to get CI green again https://github.com/llvm/llvm-project/pull/123393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb][test] Remove compiler version check and use regex" (PR #124101)

2025-01-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/124101 Reverts llvm/llvm-project#123393 This is causing `TestVectorOfVectorsFromStdModule.py` to fail on the the macOS clang-15 matrix bot. >From bb21661782242f931f3d04eb8fed9be792bd4ef8 Mon Sep 17 00:00:00 2001 F

[Lldb-commits] [lldb] Revert "[lldb][test] Remove compiler version check and use regex" (PR #124101)

2025-01-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Reverts llvm/llvm-project#123393 This is causing `TestVectorOfVectorsFromStdModule.py` to fail on the the macOS clang-15 matrix bot. --- Full diff: https://github.com/llvm/llvm-project/pull/124101.diff

[Lldb-commits] [lldb] 4bcdb26 - Revert "[lldb][test] Remove compiler version check and use regex" (#124101)

2025-01-23 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-23T11:29:06Z New Revision: 4bcdb26dac4cdadd7f8850a5f9b2e775b73aaf7f URL: https://github.com/llvm/llvm-project/commit/4bcdb26dac4cdadd7f8850a5f9b2e775b73aaf7f DIFF: https://github.com/llvm/llvm-project/commit/4bcdb26dac4cdadd7f8850a5f9b2e775b73aaf7f.diff LOG:

[Lldb-commits] [lldb] Revert "[lldb][test] Remove compiler version check and use regex" (PR #124101)

2025-01-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/124101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-01-23 Thread David Spickett via lldb-commits
@@ -644,32 +644,22 @@ void ABISysV_loongarch::AugmentRegisterInfo( std::vector ®s) { lldb_private::RegInfoBasedABI::AugmentRegisterInfo(regs); + static const std::unordered_map reg_aliases = { + {"r0", "zero"}, {"r1", "ra"}, {"r2", "tp"}, {"r3", "sp"}, + {"r

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-23 Thread Pavel Labath via lldb-commits
labath wrote: > > The reason this code looks the way it does is that we've had crashes when > > trying to read corrupted elf files from memory, where we load the size of > > the elf file from the process memory, find that out that it's size is > > 935872395 GB, try to allocate a host buffer of

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. I like the unit test, but why don't we (also) have an end-to-end for the explicit object parameter feature? Is there something still missing for the full support? https://github.com/llvm/llvm-project/pull/124096

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: So this is ready for anyone who is able to test on Mac x86_64. https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread Michael Buch via lldb-commits
Michael137 wrote: > I like the unit test, but why don't we (also) have an end-to-end for the > explicit object parameter feature? Is there something still missing for the > full support? Yea there's still a couple of issues with it. Particularly, expression evaluation in such methods currentl

[Lldb-commits] [lldb] ad6d808 - [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (#124096)

2025-01-23 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-23T11:16:02Z New Revision: ad6d808906075c3386bbeada3c37d8d3e6afe248 URL: https://github.com/llvm/llvm-project/commit/ad6d808906075c3386bbeada3c37d8d3e6afe248 DIFF: https://github.com/llvm/llvm-project/commit/ad6d808906075c3386bbeada3c37d8d3e6afe248.diff LOG:

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/124096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 636bc72 - Reland "[lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters" (#124100)"

2025-01-23 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-01-23T12:00:45Z New Revision: 636bc72f672712cb848729c0f130d8b42c86f1cb URL: https://github.com/llvm/llvm-project/commit/636bc72f672712cb848729c0f130d8b42c86f1cb DIFF: https://github.com/llvm/llvm-project/commit/636bc72f672712cb848729c0f130d8b42c86f1cb.diff LOG:

[Lldb-commits] [lldb] 3ea2b54 - [lldb/windows] Make "anonymous" pipe names more unique (#123905)

2025-01-23 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-23T13:03:29+01:00 New Revision: 3ea2b546a8d17014d3ecf05356ecfaadf26ed846 URL: https://github.com/llvm/llvm-project/commit/3ea2b546a8d17014d3ecf05356ecfaadf26ed846 DIFF: https://github.com/llvm/llvm-project/commit/3ea2b546a8d17014d3ecf05356ecfaadf26ed846.diff

[Lldb-commits] [lldb] 0236cb6 - [lldb] Enable "frame diagnose" on linux (#123217)

2025-01-23 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-23T13:04:36+01:00 New Revision: 0236cb689550ed2dac406443c652efb723cb2602 URL: https://github.com/llvm/llvm-project/commit/0236cb689550ed2dac406443c652efb723cb2602 DIFF: https://github.com/llvm/llvm-project/commit/0236cb689550ed2dac406443c652efb723cb2602.diff

[Lldb-commits] [lldb] [llvm] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/123217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/windows] Make "anonymous" pipe names more unique (PR #123905)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/123905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use the first address range as the function address (PR #122440)

2025-01-23 Thread Pavel Labath via lldb-commits
labath wrote: ping https://github.com/llvm/llvm-project/pull/122440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make C++ method parsing aware of explicit object parameters (PR #124096)

2025-01-23 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 15 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/3894 Here is the relevant piece

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-23 Thread Pavel Labath via lldb-commits
@@ -370,6 +370,31 @@ bool SymbolContext::GetAddressRange(uint32_t scope, uint32_t range_idx, return false; } +Address SymbolContext::GetAddress(uint32_t scope, + bool use_inline_block_range) const { + if ((scope & eSymbolContextLineEntry) &

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-23 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,156 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-23 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,205 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-23 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,205 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Pavel Labath via lldb-commits
@@ -222,14 +223,15 @@ void FormatManager::GetPossibleMatches( if (compiler_type.IsPointerType()) { CompilerType non_ptr_type = compiler_type.GetPointeeType(); -GetPossibleMatches(valobj, non_ptr_type, use_dynamic, entries, - current_flags.WithSt

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: This makes sense to me, but I'd like to hear what @jimingham thinks about this. > The current behaviour might cause crash on pretty printers. If the pretty > printer calls SBValue::GetChildMemberWithName when compute the synthetic > children or summary stri

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Pavel Labath via lldb-commits
labath wrote: I'm fine (and very happy) with this if @enh-google (or whoever he nominates) is. I guess this means the whole "single step workaround" (lldb/source/Plugins/Process/Linux/SingleStepCheck.h) could go away as well (maybe make a separate patch for that). https://github.com/llvm/llvm

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ brad0 wrote: The ptrace header issue and the bits from ar.h header I'll submit. SUN_LEN was only added 6 years ago so I figure keep it for a little bit longer. https://github.com/llvm/llvm-project/pull/124047

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/124176 >From 6753c51940bd947d1aac1b333f954daa80346a1c Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 23 Jan 2025 13:19:06 -0500 Subject: [PATCH] [lldb] Remove more workarounds for Android that have been fixed upst

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/124176 Issues that were fixed 10+ years ago with Bionic libc. >From 4e10a6b316a1562d96808db3d4447539b51e3179 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 23 Jan 2025 13:19:06 -0500 Subject: [PATCH] [lldb] Remove

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brad Smith (brad0) Changes Issues that were fixed 10+ years ago with Bionic libc. --- Full diff: https://github.com/llvm/llvm-project/pull/124176.diff 2 Files Affected: - (modified) lldb/source/Host/posix/ProcessLauncherPosixFork.cpp (-4

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > How does this patch fit with the: > > ``` >-p ( --skip-pointers ) > Don't use this format for pointers-to-type objects. > >-r ( --skip-references ) > Don't use this format for references-to-type objects. > ``` > > settings in `type add`? It seems like

[Lldb-commits] [lldb] 4cf1fe2 - [lldb] Add missing operations to GetOpcodeDataSize (#120163)

2025-01-23 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-23T10:37:11-08:00 New Revision: 4cf1fe240589d3f2a8a8332abf3f71a18bdba027 URL: https://github.com/llvm/llvm-project/commit/4cf1fe240589d3f2a8a8332abf3f71a18bdba027 DIFF: https://github.com/llvm/llvm-project/commit/4cf1fe240589d3f2a8a8332abf3f71a18bdba027.d

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/120163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ enh-google wrote: > The ptrace header issue and the bits from ar.h header I'll submit. SUN_LEN > was only added 6 years ago so I figure keep it for a little bit longer. but it's just a macro in a header, so a

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread via lldb-commits
jimingham wrote: > > How does this patch fit with the: > > ``` > >-p ( --skip-pointers ) > > Don't use this format for pointers-to-type objects. > > > >-r ( --skip-references ) > > Don't use this format for references-to-type objects. > > ``` > > > > > > > >

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread via lldb-commits
jimingham wrote: If anything, we should allow `--skip-pointers 1` for formatter writers that only want to handle one level of pointer to the type. https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ brad0 wrote: > > The ptrace header issue and the bits from ar.h header I'll submit. SUN_LEN > > was only added 6 years ago so I figure keep it for a little bit longer. > > but it's just a macro in a header, s

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/124176 >From 7c53e345b9264c9bd0ae16cddfb3c8066d43 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 23 Jan 2025 13:19:06 -0500 Subject: [PATCH] [lldb] Remove more workarounds for Android that have been fixed upst

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ brad0 wrote: ``` std::optional PosixUserIDResolver::DoGetGroupName(id_t gid) { #ifndef __ANDROID__ char group_buffer[PATH_MAX]; size_t group_buffer_size = sizeof(group_buffer); struct group group_info;

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ enh-google wrote: looking at the bionic headers, getgrgid_r() wasn't available until API 24... https://github.com/llvm/llvm-project/pull/124047 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb] Check Android API for existence of getgrgid_r() introduced in 24 (PR #124182)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/124182 None >From 394b06124cc49dfca54071ef6f19ec55914c0750 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 23 Jan 2025 15:15:50 -0500 Subject: [PATCH] [lldb] Check Android API for existence of getgrgid_r() introdu

[Lldb-commits] [lldb] [lldb] Check Android API for existence of getgrgid_r() introduced in 24 (PR #124182)

2025-01-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brad Smith (brad0) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/124182.diff 1 Files Affected: - (modified) lldb/source/Host/posix/HostInfoPosix.cpp (+1-1) ``diff diff --git a/lldb/source/Host/posix/HostInf

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ enh-google wrote: yeah, "if it confused you, it'll probably confuse the next person". either the comment or the more specific `#if` sgtm... https://github.com/llvm/llvm-project/pull/124047 ___

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ brad0 wrote: > looking at the bionic headers, getgrgid_r() wasn't available until API 24... Ok, thanks. https://github.com/llvm/llvm-project/pull/124047 ___ lldb-co

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ enh-google wrote: (getgrgid() has been around forever, though, so if anyone cared they could reduce the scope of this. but probably just `#if defined(__ANDROID__) && (__ANDROID_API__ >= 24)` is clearer, and g

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ brad0 wrote: > (getgrgid() has been around forever, though, so if anyone cared they could > reduce the scope of this. but probably just `#if defined(__ANDROID__) && > (__ANDROID_API__ >= 24)` is clearer, and

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124047 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ enh-google wrote: fwiw, you shouldn't need this with any current NDK (and current NDKs support API >= 21). looks like i added this in 2015 to support building gdb/gdbserver out of the box and didn't realize l

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/120163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: I found one bug, otherwise this looks good! https://github.com/llvm/llvm-project/pull/120163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Adrian Prantl via lldb-commits
@@ -327,27 +358,45 @@ static lldb::offset_t GetOpcodeDataSize(const DataExtractor &data, return offset - data_offset; } + case DW_OP_implicit_pointer: // 0xa0 4 + LEB128 + { +data.Skip_LEB128(&offset); +return 4 + offset - data_offset; adrian-

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/124047 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ enh-google wrote: looking around, i see a few others that aren't true either: ``` #ifdef __ANDROID__ // Android does not have SUN_LEN #ifndef SUN_LEN #define SUN_LEN(ptr)

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/124048 >From 1948805894e006d84fbb78299574b3c7618959d8 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 22 Jan 2025 18:32:11 -0800 Subject: [PATCH 1/2] [lldb][Formatters] Do not recursively dereference pointer type

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
@@ -222,14 +223,15 @@ void FormatManager::GetPossibleMatches( if (compiler_type.IsPointerType()) { CompilerType non_ptr_type = compiler_type.GetPointeeType(); -GetPossibleMatches(valobj, non_ptr_type, use_dynamic, entries, - current_flags.WithSt

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-01-23 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I'm in an awkward position where I'm not able to share the riscv32 core files I've been testing this against. @ita-sc & @AlexeyMerzlyakov, I know you two have worked on riscv64, is there any chance you could help me generate a riscv32 core file I can use to write a test for

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/120163 >From 21c9bbb7edab88caeb1b121dfe9090a6a3ef4404 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 22 Jan 2025 17:36:24 -0800 Subject: [PATCH 1/2] [lldb] Add missing operations to GetOpcodeDataSize

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/123981 >From 3929895879a226bf8f0e407fead4524597a429af Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 22 Jan 2025 08:18:36 -0800 Subject: [PATCH 1/3] [lldb] Add SBThread.selected_frame property --- lldb/bindin

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread via lldb-commits
jimingham wrote: How does this patch fit with the: -p ( --skip-pointers ) Don't use this format for pointers-to-type objects. -r ( --skip-references ) Don't use this format for references-to-type objects. settings in `type add`? It seems like we let the

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-23 Thread via lldb-commits
@@ -370,6 +370,31 @@ bool SymbolContext::GetAddressRange(uint32_t scope, uint32_t range_idx, return false; } +Address SymbolContext::GetAddress(uint32_t scope, + bool use_inline_block_range) const { + if ((scope & eSymbolContextLineEntry) &

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread Dave Lee via lldb-commits
@@ -51,6 +51,12 @@ STRING_EXTENSION_OUTSIDE(SBThread) for idx in range(self.GetStopReasonDataCount()) ] +def set_selected_frame(self, frame): +if isinstance(frame, SBFrame): +self.SetSelectedFrame(frame.idx) -

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread via lldb-commits
@@ -51,6 +51,12 @@ STRING_EXTENSION_OUTSIDE(SBThread) for idx in range(self.GetStopReasonDataCount()) ] +def set_selected_frame(self, frame): +if isinstance(frame, SBFrame): +self.SetSelectedFrame(frame.idx) -

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/123981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread via lldb-commits
enh-google wrote: > I guess this means the whole "single step workaround" > (lldb/source/Plugins/Process/Linux/SingleStepCheck.h) could go away as well > (maybe make a separate patch for that). from that file: ``` // The underlying issue has been fixed in android N and linux 4.4. This code can

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread via lldb-commits
jimingham wrote: I still think callers shouldn't have to do this, but to make the internal API good you'd really have to return a Status, so this is okay for now. https://github.com/llvm/llvm-project/pull/123981 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From b0cf540a08958ead1c7b9e38f30a2722fe780592 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/3] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)

2025-01-23 Thread Brad Smith via lldb-commits
@@ -25,13 +25,10 @@ #include #ifdef __ANDROID__ brad0 wrote: Ok, I will circle back with another set of diffs to clean up some of these other things too. Thanks. https://github.com/llvm/llvm-project/pull/124047 _

[Lldb-commits] [lldb] ff17a41 - [lldb] Remove support and workarounds for Android 4 and older (#124047)

2025-01-23 Thread via lldb-commits
Author: Brad Smith Date: 2025-01-23T12:54:35-05:00 New Revision: ff17a4136dedba004d901a571c4fae501affd051 URL: https://github.com/llvm/llvm-project/commit/ff17a4136dedba004d901a571c4fae501affd051 DIFF: https://github.com/llvm/llvm-project/commit/ff17a4136dedba004d901a571c4fae501affd051.diff LO

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #124077)

2025-01-23 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/124077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d050083 - [lldb] Avoid repeated map lookups (NFC) (#124077)

2025-01-23 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-01-23T08:45:59-08:00 New Revision: d05008363d4ed87b1350701831032ea5070d5b98 URL: https://github.com/llvm/llvm-project/commit/d05008363d4ed87b1350701831032ea5070d5b98 DIFF: https://github.com/llvm/llvm-project/commit/d05008363d4ed87b1350701831032ea5070d5b98.diff L

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread via lldb-commits
@@ -51,6 +51,12 @@ STRING_EXTENSION_OUTSIDE(SBThread) for idx in range(self.GetStopReasonDataCount()) ] +def set_selected_frame(self, frame): +if isinstance(frame, SBFrame): +self.SetSelectedFrame(frame.idx) -

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread Dave Lee via lldb-commits
@@ -51,6 +51,12 @@ STRING_EXTENSION_OUTSIDE(SBThread) for idx in range(self.GetStopReasonDataCount()) ] +def set_selected_frame(self, frame): +if isinstance(frame, SBFrame): +self.SetSelectedFrame(frame.idx) -

[Lldb-commits] [lldb] [lldb] Add SBThread.selected_frame property (PR #123981)

2025-01-23 Thread Dave Lee via lldb-commits
@@ -51,6 +51,12 @@ STRING_EXTENSION_OUTSIDE(SBThread) for idx in range(self.GetStopReasonDataCount()) ] +def set_selected_frame(self, frame): +if isinstance(frame, SBFrame): +self.SetSelectedFrame(frame.idx) -

[Lldb-commits] [lldb] [lldb] Handle improperly nested blocks differently (PR #117725)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/117725 >From db818448c238fe85f9bd3f322b620a4f4e171967 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 26 Nov 2024 16:12:40 +0100 Subject: [PATCH] [lldb] Handle improperly nested blocks differently In 6c7f56192fa

[Lldb-commits] [lldb] [lldb] Handle improperly nested blocks differently (PR #117725)

2025-01-23 Thread Pavel Labath via lldb-commits
labath wrote: ping :) https://github.com/llvm/llvm-project/pull/117725 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/124176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e289cb5 - [lldb] Remove more workrounds for Android that have been fixed upstream (#124176)

2025-01-23 Thread via lldb-commits
Author: Brad Smith Date: 2025-01-24T02:54:54-05:00 New Revision: e289cb545adabd8f7b72c0c4a023dcf640823767 URL: https://github.com/llvm/llvm-project/commit/e289cb545adabd8f7b72c0c4a023dcf640823767 DIFF: https://github.com/llvm/llvm-project/commit/e289cb545adabd8f7b72c0c4a023dcf640823767.diff LO

[Lldb-commits] [lldb] [lldb] Remove more workrounds for Android that have been fixed upstream (PR #124176)

2025-01-23 Thread Brad Smith via lldb-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/124176 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add Lexer (with tests) for DIL (Data Inspection Language). (PR #123521)

2025-01-23 Thread via lldb-commits
@@ -0,0 +1,156 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Enable the use of dladdr() on Android (PR #124187)

2025-01-23 Thread via lldb-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/124187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread via lldb-commits
jimingham wrote: I still feel like we should offer options here. If I as a formatter writer are interested in handling all the pointer types of the type I've registered my formatter for, I should be allowed to do that. If I say, my formatter is valid for all the pointer types as well as the

[Lldb-commits] [lldb] WIP: Stop using replicated variable ids (PR #124232)

2025-01-23 Thread Anthony Eid via lldb-commits
https://github.com/Anthony-Eid created https://github.com/llvm/llvm-project/pull/124232 Closes #119784 This is still a work in progress, but I've technically fixed the bug where lldb-dap would reuse variable IDs within the same stopped state. However, I found another bug that is still prohib

[Lldb-commits] [lldb] [lldb] Enable the use of dladdr() on Android (PR #124187)

2025-01-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brad Smith (brad0) Changes dladdr() was introduced 15 years ago. --- Full diff: https://github.com/llvm/llvm-project/pull/124187.diff 1 Files Affected: - (modified) lldb/source/Host/common/Host.cpp (-2) ``diff diff --git a/lld

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread via lldb-commits
jimingham wrote: It still sounds like this is a change to accommodate formatters that aren't correctly written. Regex formatters are slower than name match ones and more fallible to write, so I'm not sure "you can write a regex instead" is a good substitute. https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread via lldb-commits
jimingham wrote: It isn't that hard to have your formatter dereference the ValueObject it was provided till it's of the form that it wants to deal with (type or pointer) and then pass that to the main formatter. If the objection is that's a pain to do for every formatter, we could have the ty

  1   2   >