[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

2025-01-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I'm not clear what you're asking for feedback on here. Starting with a copy of the Linux platform, I understand that. However the final changes don't look that different so I assume you have: * Copied the Linux platform. * Updated it until it builds o

[Lldb-commits] [lldb] [llvm] [LLDB][Process] Add LSX and LASX register definitions and operations on the LoongArch64 (PR #120664)

2025-01-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I should have said this before you wrote out all these tests, so apologies for this up front, but - There's no reason these tests need to be native, host only, tests. Cross compiling them is not a problem. So I'd like to see these as API tests inste

[Lldb-commits] [lldb] [llvm] [LLDB][Process] Add LSX and LASX register definitions and operations on the LoongArch64 (PR #120664)

2025-01-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: Making the tests remote compatible also makes the changes to lit cpu id unnecessary. https://github.com/llvm/llvm-project/pull/120664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a return opcode to the formatter bytecode (PR #121602)

2025-01-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. https://github.com/llvm/llvm-project/pull/121602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ee1adc5 - [lldb] Add a return opcode to the formatter bytecode (#121602)

2025-01-03 Thread via lldb-commits
Author: Adrian Prantl Date: 2025-01-03T15:26:40-08:00 New Revision: ee1adc5aab4fb517314358ce03cfda426da9c4ce URL: https://github.com/llvm/llvm-project/commit/ee1adc5aab4fb517314358ce03cfda426da9c4ce DIFF: https://github.com/llvm/llvm-project/commit/ee1adc5aab4fb517314358ce03cfda426da9c4ce.diff

[Lldb-commits] [lldb] [lldb] Fix bad method call in `TestExprDiagnostics.py` (PR #120901)

2025-01-03 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Thanks for fixing this! https://github.com/llvm/llvm-project/pull/120901 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Proof of concept data formatter compiler for Python (PR #113734)

2025-01-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/113734 >From 57223942e91c47d0a61b148a65247cd9cbb16496 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 25 Oct 2024 12:56:00 -0700 Subject: [PATCH 1/2] [lldb] Proof of concept data formatter compiler for Python

[Lldb-commits] [lldb] [lldb] Add a return opcode to the formatter bytecode (PR #121602)

2025-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/121602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a return opcode to the formatter bytecode (PR #121602)

2025-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/121602 In LLVM we love our early exists and this opcode allows for simpler code generation. >From bffb3f827b2e2918cd6858728efbfefd319ae2dc Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 3 Jan 2025 12:5

[Lldb-commits] [lldb] [lldb] Add a return opcode to the formatter bytecode (PR #121602)

2025-01-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes In LLVM we love our early exists and this opcode allows for simpler code generation. --- Full diff: https://github.com/llvm/llvm-project/pull/121602.diff 5 Files Affected: - (modified) lldb/docs/res

[Lldb-commits] [lldb] [lldb] Add a return opcode to the formatter bytecode (PR #121602)

2025-01-03 Thread Dave Lee via lldb-commits
kastiglione wrote: Nested conditionals is where this will be helpful: Consider this python: ```python if first == 1: if second == 2: return "thing" return "other" ``` without a `return` op, the above code would have to be transformed to: ```python if first == 1: if second == 2

[Lldb-commits] [lldb] [llvm] Revert "[LLDB] Add a target.launch-working-dir setting" (PR #114973)

2025-01-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/commit/e952728f88c8b0e0208dc991dd9a04fe8c211cfb relanded this. https://github.com/llvm/llvm-project/pull/114973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] [lldb][AIX] HostInfoAIX Support (PR #117906)

2025-01-03 Thread David Spickett via lldb-commits
@@ -0,0 +1,154 @@ +//===-- HostInfoAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] HostInfoAIX Support (PR #117906)

2025-01-03 Thread David Spickett via lldb-commits
@@ -0,0 +1,154 @@ +//===-- HostInfoAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] HostInfoAIX Support (PR #117906)

2025-01-03 Thread David Spickett via lldb-commits
@@ -0,0 +1,154 @@ +//===-- HostInfoAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][Docs] Add equivalents of GDB's "skip" to command map (PR #120740)

2025-01-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/120740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add equivalents of GDB's "skip" to command map (PR #120740)

2025-01-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/120740 >From 65de95430fce9315a5d34aec589796818d5cd06f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Dec 2024 14:38:05 + Subject: [PATCH 1/3] [lldb][Docs] Add equivalent of GDB's "skip" to comman

[Lldb-commits] [lldb] [lldb][Docs] Add equivalents of GDB's "skip" to command map (PR #120740)

2025-01-03 Thread David Spickett via lldb-commits
@@ -235,6 +235,23 @@ Do a source level single step in the currently selected thread (lldb) step (lldb) s +Ignore a function when doing a source level single step in +~~ + +.. code-block:: shell + + (gdb) skip abc +

[Lldb-commits] [lldb] [lldb][Docs] Add equivalents of GDB's "skip" to command map (PR #120740)

2025-01-03 Thread David Spickett via lldb-commits
@@ -235,6 +235,40 @@ Do a source level single step in the currently selected thread (lldb) step (lldb) s +Ignore a function when doing a source level single step in +~~ + +.. code-block:: shell + + (gdb) skip abc +

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-03 Thread David Spickett via lldb-commits
@@ -1226,7 +1226,7 @@ bool lldb_private::formatters::ObjCSELSummaryProvider( time_t lldb_private::formatters::GetOSXEpoch() { static time_t epoch = 0; if (!epoch) { -#ifndef _WIN32 +#if !defined(_WIN32) && !defined(_AIX) DavidSpickett wrote: This would jus

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-03 Thread David Spickett via lldb-commits
@@ -715,7 +715,7 @@ ConnectionFileDescriptor::ConnectFD(llvm::StringRef s, ConnectionStatus ConnectionFileDescriptor::ConnectFile( llvm::StringRef s, socket_id_callback_type socket_id_callback, Status *error_ptr) { -#if LLDB_ENABLE_POSIX +#if LLDB_ENABLE_POSIX && !defin

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-03 Thread David Spickett via lldb-commits
@@ -16,6 +16,9 @@ #include #include #include +#ifdef _AIX +#include DavidSpickett wrote: First time I've heard that there is string.h and strings.h. What parts of strings.h were needed here? https://github.com/llvm/llvm-project/pull/120979 __