[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: LGTM. nit: I'd have called the API `SBError::GetStructuredError`. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 3113275ebe67a970ec01c380153fc6b9814ee939 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM module naming. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

2024-12-20 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/120655 >From 72d214dc2e6d9754ae5525a9161924f140d92e3c Mon Sep 17 00:00:00 2001 From: George Hu Date: Thu, 19 Dec 2024 15:38:12 -0800 Subject: [PATCH] [lldb] Fix address to read segment data --- lldb/source/Plugi

[Lldb-commits] [lldb] [lldb] Fix address to read segment data (PR #120655)

2024-12-20 Thread via lldb-commits
GeorgeHuyubo wrote: Updated the commit to address @labath's comment. https://github.com/llvm/llvm-project/pull/120655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Make workaround for the Dynamic loader issue (PR #120166)

2024-12-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/120166 >From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 16 Dec 2024 16:04:01 -0800 Subject: [PATCH 1/3] Make workaround for the Dynamic loader issue --- .../Minid

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2024-12-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 904849f2973eb8ab517f8a805cf8a747924220ef 68b8c34095430e65ce9d69e8fb4c7e70132b8f0c --e

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-12-20 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: I have created #120817 with those refactoring commits. https://github.com/llvm/llvm-project/pull/112079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2024-12-20 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan created https://github.com/llvm/llvm-project/pull/120817 These changes are designed to not change any behavior, but to make it easy to add code to choose the direction of execution after we've identified which thread(s) to run but before we add any `ThreadPlanStep

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2024-12-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Robert O'Callahan (rocallahan) Changes These changes are designed to not change any behavior, but to make it easy to add code to choose the direction of execution after we've identified which thread(s) to run but before we add any `ThreadP

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2024-12-20 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/120817 >From b021a56268c74010eae017d2d1169ab8b79978b3 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Tue, 17 Dec 2024 23:40:34 + Subject: [PATCH 1/7] [lldb] Move thread-notification setup to happen later

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Please fix the lldb-api::TestExprDiagnostics.py test ASAP. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Debuginfod cache use index cache settings and include real file name. (PR #120814)

2024-12-20 Thread via lldb-commits
https://github.com/GeorgeHuyubo ready_for_review https://github.com/llvm/llvm-project/pull/120814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2