[Lldb-commits] [lldb] [lldb] Remove lldbutil.get_stack_frames (NFC) (PR #117505)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/117505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0bfc951 - [lldb] Remove lldbutil.get_stack_frames (NFC) (#117505)

2024-11-24 Thread via lldb-commits
Author: Dave Lee Date: 2024-11-24T19:02:47-08:00 New Revision: 0bfc9514715b3beb967f1a245e9db310d2aafa50 URL: https://github.com/llvm/llvm-project/commit/0bfc9514715b3beb967f1a245e9db310d2aafa50 DIFF: https://github.com/llvm/llvm-project/commit/0bfc9514715b3beb967f1a245e9db310d2aafa50.diff LOG:

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/117500 When printing an ObjC object, which is a pointer, lldb has handled it like it treats any other pointer, printing only pointer address and class name. The object is not expanded, and its children are not sho

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2024-11-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes When printing an ObjC object, which is a pointer, lldb has handled it like it treats any other pointer, printing only pointer address and class name. The object is not expanded, and its children are not shown

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/117500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestLoadUnload.py (PR #117416)

2024-11-24 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman approved this pull request. I have tested this patch and can confirm that it fixes the issue. https://github.com/llvm/llvm-project/pull/117416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2024-11-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 0a6d797c20f6ab53bc09fb66129f603ed6e4b524...3199d3ee3817a8551cda1f5fce6083fef1c079d9 lldb/

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/113996 >From 75f96b84c9bd2b3211edb5fa8806092711133251 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Oct 2024 15:49:50 -0700 Subject: [PATCH 1/6] [lldb] Set return status to Failed when Python command raise

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-11-24 Thread Dave Lee via lldb-commits
@@ -642,6 +649,16 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject( pfunc(SWIGBridge::ToSWIGWrapper(std::move(debugger)), PythonString(args), SWIGBridge::ToSWIGWrapper(exe_ctx_ref_sp), cmd_retobj_arg.obj()); + if (PyErr_Occurred()) { +p

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-11-24 Thread Dave Lee via lldb-commits
@@ -592,6 +592,8 @@ void *lldb_private::python::LLDBSWIGPython_CastPyObjectToSBExecutionContext(PyOb return sb_ptr; } +#include "lldb/Interpreter/CommandReturnObject.h" kastiglione wrote: done https://github.com/llvm/llvm-project/pull/113996 _

[Lldb-commits] [lldb] [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (PR #117401)

2024-11-24 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117401 >From b6051edba2a1ecae144ead48712fb511c204131a Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Fri, 22 Nov 2024 15:33:42 -0800 Subject: [PATCH 1/2] [LLDB] Fix error returns in CastToBasicType and CastToEnumTy

[Lldb-commits] [lldb] c2ffb42 - [lldb] Fix TestLoadUnload.py (#117416)

2024-11-24 Thread via lldb-commits
Author: Kazuki Sakamoto Date: 2024-11-24T11:04:47-08:00 New Revision: c2ffb42893eb543f64169e32851e00352feaca69 URL: https://github.com/llvm/llvm-project/commit/c2ffb42893eb543f64169e32851e00352feaca69 DIFF: https://github.com/llvm/llvm-project/commit/c2ffb42893eb543f64169e32851e00352feaca69.dif

[Lldb-commits] [lldb] [lldb] Remove lldbutil.get_stack_frames (NFC) (PR #117505)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/117505 None >From eda4536f9e9edcb36c64592f4afd7820c81d65f3 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Sun, 24 Nov 2024 11:10:35 -0800 Subject: [PATCH] [lldb] Remove lldbutil.get_stack_frames (NFC) --- lldb/pa

[Lldb-commits] [lldb] [lldb] Remove lldbutil.get_stack_frames (NFC) (PR #117505)

2024-11-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes `SBThread.frames` can be used instead of `get_stack_frames`. --- Full diff: https://github.com/llvm/llvm-project/pull/117505.diff 2 Files Affected: - (modified) lldb/packages/Python/lldbsuite/test/lldbutil.

[Lldb-commits] [lldb] [lldb] Remove lldbutil.get_stack_frames (NFC) (PR #117505)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/117505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify DumpValueObjectOptions::PointerDepth (NFC) (PR #117504)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/117504 `Mode::Always` and `Mode::Default` are handled identically. `Mode::Never` is the same as having a count of 0. >From 92e1118f6f62aae0c98485fecc8598a95dc44ab7 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: S

[Lldb-commits] [lldb] [lldb] Simplify DumpValueObjectOptions::PointerDepth (NFC) (PR #117504)

2024-11-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/117504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestLoadUnload.py (PR #117416)

2024-11-24 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack closed https://github.com/llvm/llvm-project/pull/117416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify DumpValueObjectOptions::PointerDepth (NFC) (PR #117504)

2024-11-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes `Mode::Always` and `Mode::Default` are handled identically. `Mode::Never` is the same as having a count of 0. --- Full diff: https://github.com/llvm/llvm-project/pull/117504.diff 4 Files Affected: - (modi