[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: Thank you for your understanding. Before trying to split up the other large files (a fairly large undertaking), I'd still recommend doing the initial thing of dropping the file in a PR (which should be relatively fast) and getting some feedback. ObjectFile plugins are one of the

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: It seems #106885 fixed the issue for `deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py` and `list-dbg-info-content/TestDbgInfoContentListFromStdModule.py`, but not for `vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py`. The following 3 tests don'

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/112357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > I suggest @medismailben (or an Apple colleague he nominates), runs this test > locally and does their best to narrow down the problem. > > @rocallahan does `rr` work on Mac? Because one cross check here would be to > connect lldb to actual `rr` and see if that works. If i

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks @jmorse! https://github.com/llvm/llvm-project/pull/112307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 74eb079 - [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (#112307)

2024-10-15 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-15T08:25:28-07:00 New Revision: 74eb079e06ae052feda28e63f4f63303efc01236 URL: https://github.com/llvm/llvm-project/commit/74eb079e06ae052feda28e63f4f63303efc01236 DIFF: https://github.com/llvm/llvm-project/commit/74eb079e06ae052feda28e63f4f63303efc01236.d

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/112307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112315)

2024-10-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/112315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @Michael137 Thanks. I have updated the patch with both solutions to be sure. https://github.com/llvm/llvm-project/pull/112357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112357 >From 29326dedbc1c786e699fb30655d4105c867d1b84 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Tue, 15 Oct 2024 17:20:13 +0400 Subject: [PATCH 1/2] [lldb][test] Fix TestStdCXXDisassembly test The path #98

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/112384 Custom DAP events can be detected using https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent. This API allows an lldb python script to send custom events to the DAP

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Custom DAP events can be detected using https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent. This API allows an lldb python script to send custom events to the

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread Alex Langford via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. LGTM. For better or worse, I can reproduce the same behavior on linux when I put make in a path with spaces. @slydiman has recently proposed (and I pushed back) overriding some variables (including `$(MAKE)`) to include the quotes. I like

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Great, thanks. I will give this a try and if `functionalities/completion` keeps passing on the bots, I roll it out to the other Makefiles. https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread Pavel Labath via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/110822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I don't want a fix for AArch64 TLS to break TLS support elsewhere, so this needs testing and we may need to add new tests for the existing support. Could you: * Find out what TLS testing we have right now. (a really ugly way to do it is to delete the

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -790,9 +793,12 @@ DynamicLoaderPOSIXDYLD::GetThreadLocalData(const lldb::ModuleSP module_sp, LLDB_LOGF(log, "GetThreadLocalData error: fail to read modid"); return LLDB_INVALID_ADDRESS; } - + const llvm::Triple &triple_ref = + m_process->GetTarget().GetArchi

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -3557,6 +3560,12 @@ VariableSP SymbolFileDWARF::ParseVariableDIE(const SymbolContext &sc, } } + // If It's a declaration then symbol not present in this symbolfile + // return early to try other linked objects. + if (is_declaration) { +return nullptr; + } ---

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() { m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr); } } - + if (m_error.Fail() && variable->IsThreadLocal()) { +ExecutionContext exe_ctx(GetExecutionContextRef()); +Thread *thread

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -73,19 +73,20 @@ #undef DECLARE_REGISTER_INFOS_ARM64_STRUCT static lldb_private::RegisterInfo g_register_infos_pauth[] = { -DEFINE_EXTENSION_REG(data_mask), DEFINE_EXTENSION_REG(code_mask)}; +DEFINE_EXTENSION_REG(data_mask, KIND_ALL_INVALID), +DEFINE_EXTENSION_R

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() { m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr); } } - + if (m_error.Fail() && variable->IsThreadLocal()) { +ExecutionContext exe_ctx(GetExecutionContextRef()); Da

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
@@ -254,7 +254,38 @@ bool ValueObjectVariable::UpdateValue() { m_resolved_value.SetContext(Value::ContextType::Invalid, nullptr); } } - + if (m_error.Fail() && variable->IsThreadLocal()) { +ExecutionContext exe_ctx(GetExecutionContextRef()); +Thread *thread

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: I don't see any tests yet, I think `lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py` will be the place for those. There is a template program file you can use in that folder. If you need more functionality to get to the point you can add tests, please

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: Yeah, I have a feeling that Linux is too heterogeneous for something like this to make sense for everyone. Although, I'm not sure if it makes sense on Darwin outside of your use case. Like, if I wanted to (which I don't, but I understand some people do) ship a custom lldb to mac

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread Lu Weining via lldb-commits
@@ -0,0 +1,62 @@ +//===-- RegisterContextPOSIXCore_loongarch64.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifie

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Doing both seems fine, thanks! Can we change the Darwin case to `USE_LIBCPP` though? The less reliance on the system stdlib the better i think. Also lets check that the PR CI actually does run the test (aka doesn't trigger the skip add

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Michael Buch via lldb-commits
Michael137 wrote: Can you add in the PR description why the `--whole-archive and --allow-multiple-definition` fixes the issue? And paste the log of the CI test that's failing? https://github.com/llvm/llvm-project/pull/98701 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Brooks Davis via lldb-commits
https://github.com/brooksdavis created https://github.com/llvm/llvm-project/pull/112420 Fix a few bare Status() invocations that were missed in the conversion. This is sufficent to build lldb on FreeBSD/aaarch64. Fixes: 0642cd768b80 >From 1732a1841a24e411cb261d7ae3bff16af618268c Mon Sep 17 00

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brooks Davis (brooksdavis) Changes Fix a few bare Status() invocations that were missed in the conversion. This is sufficent to build lldb on FreeBSD/aaarch64. Fixes: 0642cd768b80 --- Full diff: https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 83368191a21340a6c3a8f88b01ecae6433640957 1732a1841a24e411cb261d7ae3bff16af618268c --e

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From be42193c499f28f8b078f1b443ad09d94e7ba2c5 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from ll

[Lldb-commits] [lldb] 224f62d - [lldb-dap] Improving the naming consistency of startDebugging reverse request. (#112396)

2024-10-15 Thread via lldb-commits
Author: John Harrison Date: 2024-10-15T12:19:21-07:00 New Revision: 224f62de9e34d537b1fd282b47b773b04bea34f1 URL: https://github.com/llvm/llvm-project/commit/224f62de9e34d537b1fd282b47b773b04bea34f1 DIFF: https://github.com/llvm/llvm-project/commit/224f62de9e34d537b1fd282b47b773b04bea34f1.diff

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/112396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from ll

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: I suggest @medismailben (or an Apple colleague he nominates), runs this test locally and does their best to narrow down the problem. @rocallahan does `rr` work on Mac? Because one cross check here would be to connect lldb to actual `rr` and see if that works. If it does th

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: See what @labath says since they commented there too. https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a4367d2 - [lldb] Support tests with nested make invocations on Windows 1/2 (#112342)

2024-10-15 Thread via lldb-commits
Author: Stefan Gränitz Date: 2024-10-15T14:22:12+02:00 New Revision: a4367d2d136420f562f64e7731b9393fb609f3fc URL: https://github.com/llvm/llvm-project/commit/a4367d2d136420f562f64e7731b9393fb609f3fc DIFF: https://github.com/llvm/llvm-project/commit/a4367d2d136420f562f64e7731b9393fb609f3fc.diff

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: >the Swift fork starts by logging the used lldb version to the system log. Oh so this is why the tests on Windows suddenly printed version numbers then :) > I'm starting to wonder if we should just make the system log a NOOP on Linux > too like we did on Windows. The pit

[Lldb-commits] [lldb] [lldb][LoongArch64] Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: I'm sorry for breaking the bot. I'm afraid I'm going to need some help to understand to problem though. This test is x86 specific, and I don't have access to an x86 mac machine (only arm), and the test works fine on linux. Could you (or whoever is responsible for that bot) provid

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/112357 The patch #98694 was not enough. This test is still failed on the buildbot https://lab.llvm.org/staging/#/builders/195/builds/4438 Use `USE_LIBSTDCPP := 1` instead. >From 29326dedbc1c786e699fb30655d4105c867d1

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The patch #98694 was not enough. This test is still failed on the buildbot https://lab.llvm.org/staging/#/builders/195/builds/4438 Use `USE_LIBSTDCPP := 1` instead. --- Full diff: https://github.com/llvm

[Lldb-commits] [lldb] [LLDB] Enable TLS Variable Debugging Without Location Info on AArch64 (PR #110822)

2024-10-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for working on this feature, I will find the time to review it properly today. I don't remember whether the Arm ABI specifies a way to represent TLS variables, or whether it's the compilers that aren't producing it. If it's the former, we (Arm that is) do take prop

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Michael Buch via lldb-commits
Michael137 wrote: So the problem is that because we statically link we fail to find a `libstdc++.so`? Won't setting `USE_LIBSTDCPP` be an issue on Darwin? Generally, why is this test trying to do disassembly on every STL symbol? Can't really tell if this was actually STL specific from the git

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Stefan Gränitz (weliveindetail) Changes Following up from https://github.com/llvm/llvm-project/pull/112342, we roll out the fix and quote nested `make` invocations in all API tests. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 1/2 (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail edited https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail created https://github.com/llvm/llvm-project/pull/112360 Following up from https://github.com/llvm/llvm-project/pull/112342, we roll out the fix and quote nested `make` invocations in all API tests. From 80688469060b8956a36797d2b75863545df75801 Mon Sep 17 00:0

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > maybe we could just skip the test if we can't locate the module? Can you suggest how to do that (locate the module)? > Won't setting USE_LIBSTDCPP be an issue on Darwin? I can't test on Darwin. Maybe the following? ``` ifneq ($(OS),Darwin) USE_LIBSTDCPP := 1 else USE_S

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Bots are fine and `functionalities/completion` kept passing: * https://lab.llvm.org/buildbot/#/builders/141/builds/3195 * https://lab.llvm.org/buildbot/#/builders/162/builds/8408 * https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/6753 It affects quite a numb

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Michael Buch via lldb-commits
Michael137 wrote: > > maybe we could just skip the test if we can't locate the module? > > Can you suggest how to do that (locate the module)? Instead of, ``` self.expect( lib_stdcxx, "Libraray StdC++ is located", exe=False, substr

[Lldb-commits] [lldb] 4d78881 - [LLDB]Provide clearer error message for invalid commands. (#111891)

2024-10-15 Thread via lldb-commits
Author: Vy Nguyen Date: 2024-10-15T10:14:48-04:00 New Revision: 4d788814061a1003f577e293f2cd74b30223e050 URL: https://github.com/llvm/llvm-project/commit/4d788814061a1003f577e293f2cd74b30223e050 DIFF: https://github.com/llvm/llvm-project/commit/4d788814061a1003f577e293f2cd74b30223e050.diff LOG

[Lldb-commits] [lldb] [LLDB]Provide clearer error message for invalid commands. (PR #111891)

2024-10-15 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/111891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Thanks for the quick feedback! Yes, the buildbot in https://lab.llvm.org/buildbot/#/builders/141 isn't affected. Debug output (in swiftlang lldb) is: ``` Reading makefiles... Updating goal targets File `all' does not exist. File `a.out' does not exist. File `l

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: If this approach is accepted, I'd like to roll it out to 32 more affected tests (upstream). I listed them here: https://gist.github.com/weliveindetail/9a3cfcfc698f8814f5924ead7ba68bf3 I only tested this on Windows so far, but I expect it be fine on all other platforms. S

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/98694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f035d9f - [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (#98694)

2024-10-15 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-10-15T14:22:59+04:00 New Revision: f035d9f061c3f54971f1baf3097989387dd511c1 URL: https://github.com/llvm/llvm-project/commit/f035d9f061c3f54971f1baf3097989387dd511c1 DIFF: https://github.com/llvm/llvm-project/commit/f035d9f061c3f54971f1baf3097989387dd511c

[Lldb-commits] [lldb] [LoongArch64]: Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread Lu Weining via lldb-commits
SixWeining wrote: > When using the lldb command 'target create -- core' on the LoongArch64 > architecture, this part of the code is required. Do you mean `--core` but not `-- core`? https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: I agree (and I don't think this is going to be very contentious) that we should not expand args from the lldb command line (precisely for the reason you mention). The trickiness comes from how this expansion is performed. The command line args are first copied into the `target.ru

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail created https://github.com/llvm/llvm-project/pull/112342 In recent PR https://github.com/llvm/llvm-project/pull/111531 for Windows support, we enabled tests that require the `make` tool. On Windows default install directories likely contain spaces, in this cas

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Stefan Gränitz (weliveindetail) Changes In recent PR https://github.com/llvm/llvm-project/pull/111531 for Windows support, we enabled tests that require the `make` tool. On Windows default install directories likely contain spaces, in this

[Lldb-commits] [lldb] [LoongArch64]: Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread Liu An via lldb-commits
lawn123 wrote: > > When using the lldb command 'target create -- core' on the LoongArch64 > > architecture, this part of the code is required. > > Do you mean `--core` but not `-- core`? Yes. use ' target create --core' to load dump files https://github.com/llvm/llvm-project/pull/112296 _

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
@@ -171,7 +171,7 @@ bool HexagonGenExtract::convert(Instruction *In) { // this value. if (!LogicalSR && (SR > SL)) return false; -APInt A = APInt(BW, ~0ULL).lshr(SR).shl(SL); +APInt A = APInt(BW, ~0ULL, true).lshr(SR).shl(SL); nikic wrote:

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse approved this pull request. LGTM, there are a couple of scenarios here which come close to needing to store-and-pass-around `BasicBlock::iterator`s to encode a position correctly, but in all these situations it's correct to just call `getIterator`. https://github.com/

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jeremy Morse via lldb-commits
https://github.com/jmorse edited https://github.com/llvm/llvm-project/pull/112307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jeremy Morse via lldb-commits
@@ -514,7 +513,8 @@ bool IRForTarget::RewriteObjCConstString(llvm::GlobalVariable *ns_str, m_CFStringCreateWithBytes, CFSCWB_arguments, "CFStringCreateWithBytes", llvm::cast( - m_entry_instruction_finder.GetValue(function))); +

[Lldb-commits] [lldb] [lldb] Use BasicBlock::iterator instead of InsertPosition (NFC) (PR #112307)

2024-10-15 Thread Jeremy Morse via lldb-commits
@@ -378,8 +378,8 @@ bool IRForTarget::CreateResultVariable(llvm::Function &llvm_function) { Constant *initializer = result_global->getInitializer(); -StoreInst *synthesized_store = -new StoreInst(initializer, new_result_global, first_entry_instruction); +

[Lldb-commits] [lldb] [LoongArch64]: Add support for LoongArch64 in elf-core for lldb (PR #112296)

2024-10-15 Thread Lu Weining via lldb-commits
https://github.com/SixWeining edited https://github.com/llvm/llvm-project/pull/112296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Yes, agree I think that both symlinking and Makefile templating make things worse, because they get even more complicated. We shortly discussed the dotest escape approach in https://github.com/llvm/llvm-project/pull/111531#review-thread-or-comment-id-1146601373, but back

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
nikic wrote: > `APInt::getAllOnes` will assert if `BitWidth == 0`. > > [snip] For the record, this is fixed by https://github.com/llvm/llvm-project/pull/112227. https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 96795194fc79359363bac0423516da2a06733047 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH 1/2] apint only --- clang/lib/AST/ByteCode/IntegralAP.h |

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
@@ -1159,7 +1159,9 @@ class ARMOperand : public MCParsedAsmOperand { if (!isImm()) return false; const MCConstantExpr *CE = dyn_cast(getImm()); if (!CE) return false; nikic wrote: Not quite, but this put me on the right path. I added a check for `i

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows (PR #112342)

2024-10-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Seems ok to me. I checked our bot and `make` is in a path without spaces, that's why we didn't see this problem there. https://github.com/llvm/llvm-project/pull/112342 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112357 >From 29326dedbc1c786e699fb30655d4105c867d1b84 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Tue, 15 Oct 2024 17:20:13 +0400 Subject: [PATCH 1/2] [lldb][test] Fix TestStdCXXDisassembly test The path #98

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] [llvm] [lldb] Move SBLanguages.h out of API tree (PR #111929)

2024-10-15 Thread via lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions { /// Set the language using a pair of language code and version as /// defined by the DWARF 6 specification. /// WARNING: These codes may change until DWARF 6 is finalized. - void SetLanguage(lldb::SBSourceLanguageNam

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel with preload (PR #110646)

2024-10-15 Thread Dmitrii Galimzianov via lldb-commits
@@ -642,26 +652,86 @@ ModuleSP DynamicLoaderDarwin::GetDYLDModule() { void DynamicLoaderDarwin::ClearDYLDModule() { m_dyld_module_wp.reset(); } +template +static std::vector parallel_map( +llvm::ThreadPoolInterface &threadPool, InputIterator first, +InputIterator las

[Lldb-commits] [lldb] a7b7af7 - [lldb] Avoid repeated map lookups (NFC) (#112315)

2024-10-15 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-10-15T07:37:00-07:00 New Revision: a7b7af7ad5c45fba87d9b423752601865cdfbee2 URL: https://github.com/llvm/llvm-project/commit/a7b7af7ad5c45fba87d9b423752601865cdfbee2 DIFF: https://github.com/llvm/llvm-project/commit/a7b7af7ad5c45fba87d9b423752601865cdfbee2.diff L

[Lldb-commits] [lldb] [lldb] Support tests with nested make invocations on Windows 2/2 (PR #112360)

2024-10-15 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/112360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 5ec5d350f78d284634ffbc7800d7f34a5017707a Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from ll

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > > I suggest @medismailben (or an Apple colleague he nominates), runs this > > test locally and does their best to narrow down the problem. > > @rocallahan does `rr` work on Mac? Because one cross check here would be to > > connect lldb to actual `rr` and see if that works.

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/112396 Adjusting the name from `lldb-dap startDebugging` to `lldb-dap start-debugging` to improve consistency with other names for commands in lldb/lldb-dap. >From 2aa7abfbdeaed07a5c46068ea2533c2d20613c5f Mon Sep 17 00

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Adjusting the name from `lldb-dap startDebugging` to `lldb-dap start-debugging` to improve consistency with other names for commands in lldb/lldb-dap. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-15 Thread Dmitrii Galimzianov via lldb-commits
https://github.com/DmT021 closed https://github.com/llvm/llvm-project/pull/110439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-15 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: I'm closing this in favor https://github.com/llvm/llvm-project/pull/110646 https://github.com/llvm/llvm-project/pull/110439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb-dap] Improving the naming consistency of startDebugging reverse request. (PR #112396)

2024-10-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. cool https://github.com/llvm/llvm-project/pull/112396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes depends on https://github.com/llvm/llvm-project/pull/112451 --- Full diff: https://github.com/llvm/llvm-project/pull/112466.diff 2 Files Affected: - (modified) lldb/source/Utility/DiagnosticsRenderin

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/112451 >From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH] [lldb] Fix a crash when two diagnostics are on the same c

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112466 None >From d400a1358678162df02c7cada2a66b837d3ff005 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 15 Oct 2024 16:20:33 -0700 Subject: [PATCH 1/2] [lldb] Fix a crash when two diagnostics are on t

[Lldb-commits] [lldb] [lldb] Fix offset calculation when printing diagnostics in multiple ranges (PR #112466)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/112466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112485 >From 4736ff60f79352f2f9f703eced07c3555fef8a63 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 16 Oct 2024 10:37:37 +0400 Subject: [PATCH 1/2] [lldb][test] Fix the test TestArrayFromStdModule.py This

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: I doubt those linker flags are going to work on windows. It might be more "portable" to ensure the symbols are present by using them from inside the program. https://github.com/llvm/llvm-project/pull/98701 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/112485 >From 4736ff60f79352f2f9f703eced07c3555fef8a63 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 16 Oct 2024 10:37:37 +0400 Subject: [PATCH 1/2] [lldb][test] Fix the test TestArrayFromStdModule.py This

[Lldb-commits] [lldb] [lldb][test] Fix tests Test*FromStdModule where called missing at(0) (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/112485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
@@ -16,12 +16,36 @@ std::string Render(std::vector details) { } // namespace TEST_F(ErrorDisplayTest, RenderStatus) { - DiagnosticDetail::SourceLocation inline_loc; - inline_loc.in_user_input = true; { +DiagnosticDetail::SourceLocation inline_loc; +inline_loc.in_u

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
@@ -16,12 +16,36 @@ std::string Render(std::vector details) { } // namespace TEST_F(ErrorDisplayTest, RenderStatus) { - DiagnosticDetail::SourceLocation inline_loc; - inline_loc.in_user_input = true; { +DiagnosticDetail::SourceLocation inline_loc; +inline_loc.in_u

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This patch fixes the error https://lab.llvm.org/staging/#/builders/195/builds/4464 ``` File "llvm-project/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py", line 55, in

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/112485 This patch fixes the error https://lab.llvm.org/staging/#/builders/195/builds/4464 ``` File "llvm-project/lldb/test/API/commands/expression/import-std-module/array/TestArrayFromStdModule.py", line 55, in test

  1   2   >