[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-07 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: @jasonmolenda I tried to reproduce your results but got drastically different numbers for parallel runs. Here's the setup: - Using this (the main) repository of llvm-project. - `cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lldb;lld" -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-10-07 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: @Michael137 I don't have merge rights, can you merge this pls? https://github.com/llvm/llvm-project/pull/102835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-07 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > As I understand it, Android Studio was setting `use-source-cache:=false` so > that users can continue to edit files on windows while lldb has them open. > > Judging by this patch, that may no longer be necessary. Or does that only > apply for certain situations (certain win

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-10-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/109477 >From 0beb848dcab2fb84d79dca126efaca3c5e2cffe7 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 16 Sep 2024 13:02:59 -0700 Subject: [PATCH 01/12] Add Process code to get the fs_base region and the .tdata

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-07 Thread Igor Kudrin via lldb-commits
igorkudrin wrote: > I don't see any relevant changes on those files, so I don't know the where > `openNativeFileInternal()` comes into the picture. `getFileAux()` calls `openNativeFileForRead()` first and then passes the file descriptor to `getOpenFileImpl()`. `openNativeFileForRead()` eventu

[Lldb-commits] [lldb] d2457e6 - Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (#102835)

2024-10-07 Thread via lldb-commits
Author: Dmitrii Galimzianov Date: 2024-10-07T13:45:27-07:00 New Revision: d2457e6d8f62a12b3b74791cfd3f5808168c8a71 URL: https://github.com/llvm/llvm-project/commit/d2457e6d8f62a12b3b74791cfd3f5808168c8a71 DIFF: https://github.com/llvm/llvm-project/commit/d2457e6d8f62a12b3b74791cfd3f5808168c8a71

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-10-07 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/102835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-10-07 Thread via lldb-commits
github-actions[bot] wrote: @DmT021 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-10-07 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: @augusto2112 Thank you! https://github.com/llvm/llvm-project/pull/102835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and re-enable TestUseSourceCache.py (PR #111237)

2024-10-07 Thread Emre Kultursay via lldb-commits
emrekultursay wrote: > it failed in this case because the source file is opened with the > `FILE_SHARE_DELETE` share mode, which allows the file to be removed, see > `llvm::sys::fs::openNativeFileInternal()` in > `llvm/lib/Support/Windows/Path.inc`. Was there an LLDB change about how it open

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I built the swiftlang `rebranch` sources clean, with the parallel patch, with the parallel plus preload patch. I ran them against the same Slack binary with 934 binary images, 10 of them outside the shared cache. I built them something like ``` swift/utils/build-script --

[Lldb-commits] [lldb] [lldb] Change SymbolContext::GetAddressRangeFromHereToEndLine to return Expected (NFC) (PR #110718)

2024-10-07 Thread AbdAlRahman Gad via lldb-commits
https://github.com/AbdAlRahmanGad updated https://github.com/llvm/llvm-project/pull/110718 >From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001 From: AbdAlRahman Gad Date: Tue, 1 Oct 2024 21:15:13 +0300 Subject: [PATCH 1/5] [lldb] Change SymbolContext::GetAddressRangeFromHer

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/111483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-07 Thread Pavel Labath via lldb-commits
@@ -111,6 +111,8 @@ def do_test(self, one_target, one_debugger): else: if one_target: new_debugger = lldb.SBDebugger().Create() +if lldb.selected_platform is not None: +new_debugger.SetSelectedPlatform(lldb

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes `SBDebugger().Create()` returns a debugger with only the host platform in its platform list. If the test suite is running for a remote platform, it should be explicitly added and selected in the new debugge

[Lldb-commits] [lldb] [lldb] Fix TestGlobalModuleCache.py for remote debugging (PR #111483)

2024-10-07 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/111483 `SBDebugger().Create()` returns a debugger with only the host platform in its platform list. If the test suite is running for a remote platform, it should be explicitly added and selected in the new debugger

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: This is interesting, sorry the uncached unwindplans made it harder to debug. I've seen cold function outlining in our libraries but I've never looked at the generated DWARF - does the function die have a location list with the main function body and the .cold.1 function b

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-07 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Let me just take a peek at some Darwin binaries with this codegen & their debuginfo, and then i'll approve unless there's something I've misunderstood about what we're looking at. It really makes me think that we are going to need discontiguous ranges in the unwind plans t

<    1   2