https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/110388
…tion expression.
This patch allows offsets to the DW_AT_frame_base to exceed 4GB. Prior to this,
for any .debug_info.dwo offset that exceeded 4GB, we would truncate the offset
to the DW_AT_frame_base express
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
…tion expression.
This patch allows offsets to the DW_AT_frame_base to exceed 4GB. Prior to this,
for any .debug_info.dwo offset that exceeded 4GB, we would truncate the offset
to the DW_AT_frame_base expre
@@ -246,6 +246,8 @@ static_assert(sizeof(Thread) == 48);
struct Exception {
static constexpr size_t MaxParameters = 15;
+ static constexpr size_t MaxParameterBytes = MaxParameters * sizeof(uint64_t);
+ static const uint32_t LLDB_FLAG = 0x8000;
clayborg
@@ -685,50 +684,42 @@ Status MinidumpFileBuilder::AddExceptions() {
Status error;
for (const ThreadSP &thread_sp : thread_list) {
StopInfoSP stop_info_sp = thread_sp->GetStopInfo();
-bool add_exception = false;
-if (stop_info_sp) {
- switch (stop_info_sp->G
clayborg wrote:
Since .dwp files can get large, it is ok for the `.debug_info.dwo` section to
exceed 4GB as we can parse the linked list of dwarf units in the
`.debug_info.dwo` and ignore the CU and TU indexes which are limited to 4GB. We
have work arounds already checked into LLVM's DWARF cod
https://github.com/clayborg commented:
LGTM. I will let others comment.
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
