labath wrote:
> @labath there have been no additional comments; is there anyone specifically
> you'd like me to seek feedback from?
No, this is fine. Thanks for reminding me.
https://github.com/llvm/llvm-project/pull/106443
___
lldb-commits mailing l
labath wrote:
Good find. Somewhat surprising, but I guess it's possible. I'll try to look
into whether this is some defensive coding or if this can legitimately happen
for some reason.
https://github.com/llvm/llvm-project/pull/108810
___
lldb-commits
https://github.com/labath converted_to_draft
https://github.com/llvm/llvm-project/pull/108810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-09-19T15:08:47+02:00
New Revision: 1f8e6624e5052d56244b28fef3eb64bd0408f75d
URL:
https://github.com/llvm/llvm-project/commit/1f8e6624e5052d56244b28fef3eb64bd0408f75d
DIFF:
https://github.com/llvm/llvm-project/commit/1f8e6624e5052d56244b28fef3eb64bd0408f75d.diff
@@ -682,17 +683,51 @@ PacketStatus DAP::GetNextObject(llvm::json::Object
&object) {
}
bool DAP::HandleObject(const llvm::json::Object &object) {
+ auto start_time = std::chrono::steady_clock::now();
const auto packet_type = GetString(object, "type");
if (packet_type ==
@@ -20,6 +23,47 @@
namespace lldb_private {
+/// A compiler-independent representation of a Diagnostic. Expression
+/// evaluation failures often have more than one diagnostic that a UI
+/// layer might want to render differently, for example to colorize
+/// it.
+///
+/// Ru
jennphilqc wrote:
> > I actually wrote this for a team that already has their own viewer. We've
> > suggested that they upstream that as well.
>
> Is that viewer in VS-Code or in some other editor? (Trying to avoid
> duplicating effort, so I don't accidentally implement the same thing)
It is
https://github.com/abhina-sree closed
https://github.com/llvm/llvm-project/pull/107906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From d2a4e7dac1fcbea87216048e8afd7754d39787ca Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an
llvm:
@@ -126,3 +126,62 @@ bool DWARFIndex::GetFullyQualifiedTypeImpl(
return callback(die);
return true;
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ GetNamespaces(name, [&](DWARFDIE
Michael137 wrote:
Is it worth splitting this into two PRs (one for the type lookup and one for
namespaces)?
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -254,14 +255,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 28 Aug 2024 10:04:33 -0700
Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an
llvm:
@@ -254,14 +255,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
101 - 114 of 114 matches
Mail list logo