@@ -0,0 +1,34 @@
+# REQUIRES: aarch64
DavidSpickett wrote:
Is this requiring the host to be aarch64 or that the aarch64 llvm target is
enabled, we should only need the latter for this.
https://github.com/llvm/llvm-project/pull/106478
___
@@ -254,9 +254,10 @@ RegisterInfoPOSIX_arm64::RegisterInfoPOSIX_arm64(
if (m_opt_regsets.AllSet(eRegsetMaskMTE))
AddRegSetMTE();
- // The TLS set always contains tpidr but only has tpidr2 when SME is
- // present.
- AddRegSetTLS(m_opt_regsets.AllSe
DavidSpickett wrote:
Interested in how you ended up with a file without it, perhaps there was some
era of kernels that produces that result.
But given we do a check whether to set the regset bit, we should use the result
of that later anyway, so this looks ok to me.
https://github.com/llvm/ll
DavidSpickett wrote:
And "don't crash on invalid input" is a good enough reason to fix this
regardless of how the core file was generated, even if the core file is
corrupted.
https://github.com/llvm/llvm-project/pull/106478
___
lldb-commits mailing l
Author: David Spickett
Date: 2024-08-29T07:37:02Z
New Revision: c954306ef763eb25f06432324889bde98735963d
URL:
https://github.com/llvm/llvm-project/commit/c954306ef763eb25f06432324889bde98735963d
DIFF:
https://github.com/llvm/llvm-project/commit/c954306ef763eb25f06432324889bde98735963d.diff
LOG
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/106505
This is so that we are consistent with other sanitizers. Importantly, this
makes the docs clearer.
Driver flags are left unchanged (We are not proposing to rename `sancov`
either). The good thing is that flag
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-libcxx
Author: cor3ntin (cor3ntin)
Changes
This is so that we are consistent with other sanitizers. Importantly, this
makes the docs clearer.
Driver flags are left unchanged (We are not proposing to rename `sancov`
either). T
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: cor3ntin (cor3ntin)
Changes
This is so that we are consistent with other sanitizers. Importantly, this
makes the docs clearer.
Driver flags are left unchanged (We are not proposing to rename `sancov`
either). The good thing is th
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ec9f36a624fa9f8fea6e40384ce513b6da8c08e4
adb4a0eb00972811343ff05eac6977512f01970a --e
labath wrote:
This seems like it could be problematic for IDEs, if they don't print the error
in the same window as the expression being evaluated. The arrows could end up
pointing to nowhere, or to the wrong place in the expression (if we don't get
the right offset).
I think this could be ma
Author: David Spickett
Date: 2024-08-29T08:33:34Z
New Revision: ae34257e9015a366ea63cd461535b35bc9837c57
URL:
https://github.com/llvm/llvm-project/commit/ae34257e9015a366ea63cd461535b35bc9837c57
DIFF:
https://github.com/llvm/llvm-project/commit/ae34257e9015a366ea63cd461535b35bc9837c57.diff
LOG
labath wrote:
The llvm::Error class already supports this kind of metadata (and in a much
better way IMO). Given that moving to llvm::Error is our long term goal, would
it be possible to port enough APIs so that it's possible to pass an unmodified
Error object from the producer to the place th
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104797
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
This looks great. I don't think anyone will object to removing old ndk support,
but let's leave this PR open for a while to give people a chance to notice.
https://github.com/llvm/llvm-project/pull/106443
___
lldb-
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/106443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,81 +1,55 @@
NDK_ROOT := $(shell dirname $(CC))/../../../../..
-ifeq "$(findstring 64, $(ARCH))" "64"
- # lowest 64-bit API level
- API_LEVEL := 21
-else ifeq "$(ARCH)" "i386"
- # clone(2) declaration is present only since this api level
- API_LEVEL
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104797
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,81 +1,55 @@
NDK_ROOT := $(shell dirname $(CC))/../../../../..
-ifeq "$(findstring 64, $(ARCH))" "64"
- # lowest 64-bit API level
- API_LEVEL := 21
-else ifeq "$(ARCH)" "i386"
- # clone(2) declaration is present only since this api level
- API_LEVEL
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/104193
>From 7b8b8b699902d2365ea43e5ae015546c4d20fac8 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 14 Aug 2024 19:58:27 +0200
Subject: [PATCH 1/5] [lldb] Fix and speedup the `memory find` command
This patch f
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cb9267f055156daabdbab87f4c1ca9064b0e7d7d
3fc95ce499d9e5d5691158fe0847afa8ec338106 --e
labath wrote:
> @labath
>
> > Having a single socket listen on multiple ports sounds like a bad idea to
> > me.
>
> Note that currently the class TCPSocket already contains a list of
> NativeSocket `m_listen_sockets`.
I am aware of that, and I'm not entirely happy with how the class implemen
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/106532
Previously, we were returning an error if we couldn't read the whole region.
This doesn't matter most of the time, because lldb caches memory reads, and in
that process it aligns them to cache line boundaries. A
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Previously, we were returning an error if we couldn't read the whole region.
This doesn't matter most of the time, because lldb caches memory reads, and in
that process it aligns them to cache line boundaries.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fdca2c33a1f33f4886d969ea0f0219764c7b6b59
610757ced98139d3d10451dcca195692b0c2d832 --e
@@ -0,0 +1,63 @@
+"""
+Test the memory commands operating on memory regions with holes
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
+
+
+class MemoryHolesTestCase(TestBase):
+NO_
@@ -2526,28 +2526,16 @@ GDBRemoteCommunicationServerLLGS::Handle_memory_read(
size_t bytes_read = 0;
Status error = m_current_process->ReadMemoryWithoutTrap(
read_addr, &buf[0], byte_count, bytes_read);
- if (error.Fail()) {
-LLDB_LOGF(log,
- "GDBRem
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/106532
>From 610757ced98139d3d10451dcca195692b0c2d832 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 29 Aug 2024 12:26:01 +0200
Subject: [PATCH 1/2] [lldb/linux] Make truncated reads work
Previously, we were re
labath wrote:
The linux read fix is in #106532.
https://github.com/llvm/llvm-project/pull/104193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-08-29T11:55:35Z
New Revision: b2a820faea960e99123f309d6a7bccb3cd1bcc12
URL:
https://github.com/llvm/llvm-project/commit/b2a820faea960e99123f309d6a7bccb3cd1bcc12
DIFF:
https://github.com/llvm/llvm-project/commit/b2a820faea960e99123f309d6a7bccb3cd1bcc12.diff
LOG
labath wrote:
Any more thoughts on this, @clayborg ?
https://github.com/llvm/llvm-project/pull/102111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/106433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/106433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
@labath
What exactly are you proposing?
We need some blocking method Accept() which can wait for connections from few
ports. The current implementation of TCPSocket class already contains this
functionality (a list of listening sockets).
It is possible to create a static method
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/102185
>From e40ca68a934d0595ebc6c07010a4f6a814fa026f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 27 Jul 2024 02:39:32 +0200
Subject: [PATCH 1/6] [lldb][test] Improve toolchain detection in
Makef
@@ -213,7 +229,7 @@ endif
LIMIT_DEBUG_INFO_FLAGS =
NO_LIMIT_DEBUG_INFO_FLAGS =
MODULE_DEBUG_INFO_FLAGS =
-ifneq (,$(findstring clang,$(CC)))
+ifeq ($(CCC), clang)
dzhidzhoev wrote:
Compiler type
https://github.com/llvm/llvm-project/pull/102185
___
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -257,7 +257,7 @@ General purpose options
A semicolon list of arguments to pass when running the libc++ benchmarks
using the
``check-cxx-benchmarks`` rule. By default we run the benchmarks for a very
short amount of time,
- since the primary use of ``check-cxx-benchma
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From b7f51237438285b1be922ae754618b8c6b0b0ea3 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI
Function call
https://github.com/andrurogerz edited
https://github.com/llvm/llvm-project/pull/106443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,119 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
https://github.com/labath commented:
Looks pretty good now, but I still have some questions.
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -213,7 +229,7 @@ endif
LIMIT_DEBUG_INFO_FLAGS =
NO_LIMIT_DEBUG_INFO_FLAGS =
MODULE_DEBUG_INFO_FLAGS =
-ifneq (,$(findstring clang,$(CC)))
+ifeq ($(CCC), clang)
labath wrote:
So the last `C` stands for "type" ? :)
Can we call it CC_TYPE/KIND (or similar) in
@@ -96,16 +98,119 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -96,16 +98,119 @@ def getArchSpec(self, architecture):
"""
return ["ARCH=" + architecture] if architecture else []
-def getCCSpec(self, compiler):
+def getToolchainSpec(self, compiler):
"""
-Helper function to return the key-value st
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
labath wrote:
Not really (although this might work as well). What I meant was that, AIUI
you're doing this so that you can plumb structured error information from one
place (clang expression parser?) to another place (the thing which generates
the expression errors -- I guess somewhere Command
https://github.com/andrurogerz updated
https://github.com/llvm/llvm-project/pull/106443
>From 476a0109d5889a80d90ae484a553cce058a6e5ce Mon Sep 17 00:00:00 2001
From: Andrew Rogers
Date: Mon, 26 Aug 2024 17:42:35 -0700
Subject: [PATCH 1/4] [android] get lldb tests working against newer Android
https://github.com/andrurogerz edited
https://github.com/llvm/llvm-project/pull/106443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Not really (although this might work as well). What I meant was that, AIUI
> you're doing this so that you can plumb structured error information from one
> place (clang expression parser?) to another place (the thing which generates
> the expression errors -- I guess so
Author: Jordan R AW
Date: 2024-08-29T10:16:17-07:00
New Revision: 0a00d32c5f88fce89006dcde6e235bc77d7b495e
URL:
https://github.com/llvm/llvm-project/commit/0a00d32c5f88fce89006dcde6e235bc77d7b495e
DIFF:
https://github.com/llvm/llvm-project/commit/0a00d32c5f88fce89006dcde6e235bc77d7b495e.diff
L
https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/106433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ajordanr-google wrote:
Thanks for the review and merge!
https://github.com/llvm/llvm-project/pull/106433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/106609
My build of LLDB is all the time loading targets with a version of libc++ that
was built with gcc that uses the DW_FORM 0x1e that is not implemented by LLVM,
and I doubt it'll ever implement it. It's u
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
My build of LLDB is all the time loading targets with a version of libc++ that
was built with gcc that uses the DW_FORM 0x1e that is not implemented by LLVM,
and I doubt it'll ever implement it.
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oltolm wrote:
Can you backport it into llvm-19 branch? This bug makes lldb-dap almost
impossible to use on Windows.
https://github.com/llvm/llvm-project/pull/104874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/106478
>From 6854730d45a2c119d2b8f71df6e22ead1c7ad5a8 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Wed, 28 Aug 2024 17:57:38 -0700
Subject: [PATCH 1/2] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing
[D15
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/7] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
ashgti wrote:
Reverted the removal of `enableDisplayExtendedBacktrace` and added
`enableDisplayExtendedBacktrace` to the documentation and package.json
description of the lldb-dap debugger.
https://github.com/llvm/llvm-project/pull/105905
___
lldb-co
nicovank wrote:
Thanks! I have no commit access, please click the merge button :)
https://github.com/llvm/llvm-project/pull/106500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3106,80 +3235,109 @@ void request_stackTrace(const llvm::json::Object
&request) {
llvm::json::Array stackFrames;
llvm::json::Object body;
+ // Threads stacks may contain runtime specific extended backtraces, when
+ // constructing a stack trace first report the full
https://github.com/jeffreytan81 approved this pull request.
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106639
To support detecting MD5 checksum mismatches, store a SupportFile rather than a
plain FileSpec in SourceManager::File.
>From 64b6c6419722ecd5865cdf3e734b63ed51763174 Mon Sep 17 00:00:00 2001
From: Jonas De
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
To support detecting MD5 checksum mismatches, store a SupportFile rather than a
plain FileSpec in SourceManager::File.
---
Full diff: https://github.com/llvm/llvm-project/pull/106639.diff
5 Files
https://github.com/adrian-prantl commented:
I was skeptical that a SupportFile would be the right choice, but it's
documented as a:
> Wraps either a
> [FileSpec](https://lldb.llvm.org/cpp_reference/classlldb__private_1_1FileSpec.html)
> that represents a local file or a source file whose cont
@@ -70,15 +73,17 @@ class SourceManager {
protected:
/// Set file and update modification time.
-void SetFileSpec(FileSpec file_spec);
+void SetSupportFile(lldb::SupportFileSP support_file_sp);
bool CalculateLineOffsets(uint32_t line = UINT32_MAX);
-
@@ -70,15 +73,17 @@ class SourceManager {
protected:
/// Set file and update modification time.
-void SetFileSpec(FileSpec file_spec);
+void SetSupportFile(lldb::SupportFileSP support_file_sp);
bool CalculateLineOffsets(uint32_t line = UINT32_MAX);
-
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/106640
This is the prerequisite for #104238.
>From b0dffc5aa9212432f29344eda3ad0b4914f4df35 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:29:58 +0400
Subject: [PATCH] [lldb][NFC] Move few s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This is the prerequisite for #104238.
---
Full diff: https://github.com/llvm/llvm-project/pull/106640.diff
3 Files Affected:
- (modified) lldb/include/lldb/Host/Socket.h (+10-6)
- (modified) lldb/sourc
clayborg wrote:
Sorry for the delay, feel free to ping sooner next time! Lets start with this
and we can iterate on it!
https://github.com/llvm/llvm-project/pull/102111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/102111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 22209660e732f2101fd40d613bef7a506b402a74 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen t
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/106532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
I have updated the patch.
Note all changes in Socket.* and TCPSocket.cpp will go away after merging
#106640.
The class Acceptor uses the MainLoop and contains the own list of listen
sockets.
Please review. Thanks.
https://github.com/llvm/llvm-project/pull/104238
___
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From d0674017bb80a4abea9a7ad4a98ada2794e77221 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 30 Aug 2024 01:08:24 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen t
83 matches
Mail list logo
