https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105604
>From 54dcc78eace39c197f1fb762880746b569980955 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 21 Aug 2024 18:22:17 -0700
Subject: [PATCH] Skip the lldb-dap output test on windows, it seems all the
lldb-
Author: John Harrison
Date: 2024-08-21T18:52:48-07:00
New Revision: 8e0b9c85924ca22a65d57988ea2c5c22a5181ed9
URL:
https://github.com/llvm/llvm-project/commit/8e0b9c85924ca22a65d57988ea2c5c22a5181ed9
DIFF:
https://github.com/llvm/llvm-project/commit/8e0b9c85924ca22a65d57988ea2c5c22a5181ed9.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -14,10 +14,52 @@ export class LLDBDapDescriptorFactory
this.lldbDapOptions = lldbDapOptions;
}
+ public static async validateDebugAdapterPath(pathUri: vscode.Uri) {
+try {
+ const fileStats = await vscode.workspace.fs.stat(pathUri);
+ if (!(fileStats.ty
vogelsgesang wrote:
> @vogelsgesang , the $__lldb_extensions.declaration is used by the Mojo
> extension. Once this change gets it, I'll update the Mojo extension to use
> the new declaration info and remove $__lldb_extensions.declaration.
Is that extension's source code available? I wonder ho
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 5bdcb821527bf67eead6c42825ea6e559ec749c3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH 1/3] [lldb-dap] Implement declaration locations
This
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
vogelsgesang wrote:
> @vogelsgesang , can you show a screenshot of the variables pane after this
> change? I want to make sure that simple types, like ints, are not displayed
> as having children.
**With this commit (and also with the changes from #104589)**
https://github.com/user-attachment
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux`
running on `fuchsia-debian-64-us-central1-a-1` while building `lldb` at step 4
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/11/builds/3754
Here is the relevant pie
walter-erquinigo wrote:
> > @vogelsgesang , the $__lldb_extensions.declaration is used by the Mojo
> > extension. Once this change gets it, I'll update the Mojo extension to use
> > the new declaration info and remove $__lldb_extensions.declaration.
>
> Is that extension's source code availabl
https://github.com/walter-erquinigo approved this pull request.
This LGTM considering that the screenshot looks right and this passes all the
tests.
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm
vogelsgesang wrote:
> I'll explain what I do [...]
Thanks for that context! I don't currently have a LSP in mind. Let's see which
UI VS-Code will be providing for this (if any). I hope it will not conflict
with your existing UI
https://github.com/llvm/llvm-project/pull/102928
vogelsgesang wrote:
> This LGTM considering that the screenshot looks right and this passes all the
> tests.
Thanks! I assume you still want me to wait for @clayborg's review before
merging?
https://github.com/llvm/llvm-project/pull/102928
___
lldb-
walter-erquinigo wrote:
If @clayborg takes too long to review, I'd suggest merging this and then acting
on any late feedback. But give him a few days for sure if possible. He's a
better reviewer than me.
https://github.com/llvm/llvm-project/pull/102928
_
DhruvSrivastavaX wrote:
Ok Alex, Thanks for approving.
https://github.com/llvm/llvm-project/pull/105523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 121 of 121 matches
Mail list logo
