[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-08-19 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: @clayborg @jimingham I think the issues you have raised so far are satisfactorily addressed by the current code. Can you confirm that is true? And if so, can we proceed with the actual code review? Thanks. https://github.com/llvm/llvm-project/pull/99736 __

[Lldb-commits] [lldb] [llvm-lit][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-19 Thread via lldb-commits
https://github.com/connieyzhu created https://github.com/llvm/llvm-project/pull/104878 This patch changes the test that uses the `cat -e` option to `cat -v` so that the test can be run using lit's internal shell. This is an alternative patch to https://github.com/llvm/llvm-project/pull/102061,

[Lldb-commits] [lldb] [llvm-lit][test] Change unsupported cat -e to cat -v to work with lit internal shell (PR #104878)

2024-08-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Connie (connieyzhu) Changes This patch changes the test that uses the `cat -e` option to `cat -v` so that the test can be run using lit's internal shell. This is an alternative patch to https://github.com/llvm/llvm-project/pull/102061, opt

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > When we were talking about this originally I thought that StackFrames would > get an "ImplementationFrame" property, and we would use that to determine > whether to hide the frame in bt (when not passing --unfiltered). Then the > frame recognizers when they are run on th

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/104523 >From 665332171ea0251c39eed5a737d014c061412f1d Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 15 Aug 2024 16:18:33 -0700 Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from backt

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/104523 >From 8f6af48316f834ffe2e2ddd8d0a75df22955e9fb Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 15 Aug 2024 16:18:33 -0700 Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from backt

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I uploaded a new version of the patch that addresses all outstanding feedback, except for `finish` (I haven't looked at how that is implemented yet): - correctly caching recognized frames - hiding the recognizer API behind Frame::IsHidden() - exposing it via the SBAPI - exte

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @medismailben I copied&pasted the python interface code from the function above; could you review that code extra carefully? https://github.com/llvm/llvm-project/pull/104523 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Med Ismail Bennani via lldb-commits
@@ -123,8 +126,12 @@ class StackFrameRecognizerManager { lldb::StackFrameRecognizerSP GetRecognizerForFrame(lldb::StackFrameSP frame); lldb::RecognizedStackFrameSP RecognizeFrame(lldb::StackFrameSP frame); + /// Quick way to determine whether the list of recognizers has b

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM modulo comment. https://github.com/llvm/llvm-project/pull/104523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-19 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/104523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-19 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Hey David, The code format test passed but, I see some new failures (mostly in lldb-api and some in lldb-shell), which were not there in the previous run. Could it be because my branch is not up to date? How can I avoid such failures for future PRs? https://github.

[Lldb-commits] [lldb] [lldb][AIX] 1. Avoid namespace collision on other platforms (PR #104679)

2024-08-19 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/104679 >From e72ceaada170354aa322b4c6a1787152ac72c65b Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 17 Aug 2024 12:16:09 -0500 Subject: [PATCH 1/2] Using lldb's internal typedefs to avoid namespac

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

2024-08-19 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw updated https://github.com/llvm/llvm-project/pull/104831 >From 264d96482efa889ec0f7329519755033b3ea172c Mon Sep 17 00:00:00 2001 From: Will Hawkins Date: Mon, 19 Aug 2024 14:43:45 -0400 Subject: [PATCH] [lldb][test] Workaround older systems that lack gettid Older gl

[Lldb-commits] [lldb] WIP: [lldb][test] Workaround older systems that lack gettid (PR #104831)

2024-08-19 Thread Will Hawkins via lldb-commits
hawkinsw wrote: @petrhosek Hope that looks better! https://github.com/llvm/llvm-project/pull/104831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2