https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/101237
>From f0cd3ef613b2da145b14a3d79d6810cc19e9b198 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 30 Jul 2024 13:37:44 -0700
Subject: [PATCH 1/7] Impove ObjectFileELF's .dynamic parsing and usage.
This pat
Jlalond wrote:
> I saw the msan failure when integrating LLVM into our internal codebase, it
> is a msan-build lldb.
>
> The second error `AssertionError: launching (4) != stopped (5)` occurred in a
> non-msan-build lldb from the upstream repository. And I ran `llvm-lit -sv
> lldb/test/API/fu
mizvekov wrote:
> We keep track of propagated and inferred nullability annotations in a [side
> data
> structure](https://github.com/google/crubit/blob/main/nullability/type_nullability.h#L185).
> Our approach allows us to save on memory by not actually re-instantiating
> everything with new
jimingham wrote:
It does seem worthwhile to have a test explicitly testing this ordering that
exists among the tests for the command interpreter, rather than having it be a
side-effect test in an unrelated test case.
Other than that, this is fine.
https://github.com/llvm/llvm-project/pull/101
@@ -192,6 +192,10 @@ TargetStats::ToJSON(Target &target,
}
target_metrics_json.try_emplace("sourceMapDeduceCount",
m_source_map_deduce_count);
+ target_metrics_json.try_emplace("sourceRealpathAttemptCount",
jimingham wrote
https://github.com/jimingham deleted
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -192,6 +192,10 @@ TargetStats::ToJSON(Target &target,
}
target_metrics_json.try_emplace("sourceMapDeduceCount",
m_source_map_deduce_count);
+ target_metrics_json.try_emplace("sourceRealpathAttemptCount",
jimingham wrote
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jimingham wrote:
> @jimingham
>
> > Have you checked to make sure this also works when there is a source-path
> > mapping in place for the files that also differ by realpath vrs. symlink in
> > the part past the part the source-path mapping substitutes? That might
> > "just work" but it also
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/102375
This commit fully namespaces callback function pointer parameters that are SB
types in `SBDefines` and `lldb-types`.
>From 6525ca91f6ef49b06613ec6e947f54d3faf73efe Mon Sep 17 00:00:00 2001
From: Chelsea C
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This commit fully namespaces callback function pointer parameters that are SB
types in `SBDefines` and `lldb-types`.
---
Full diff: https://github.com/llvm/llvm-project/pull/102375.diff
2 Files A
https://github.com/medismailben approved this pull request.
LGTM! Are these the only callbacks that need to be fully qualified ?
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
> LGTM! Are these the only callbacks that need to be fully qualified ?
Yes they are, if new callback function pointers are added in the future that
use SB types in their parameter list or as their return type then ideally those
should also be fully namespaced.
https://git
Author: Chelsea Cassanova
Date: 2024-08-07T15:05:31-07:00
New Revision: aeb1989bb585e216a13fddeaf28887bdf8623075
URL:
https://github.com/llvm/llvm-project/commit/aeb1989bb585e216a13fddeaf28887bdf8623075
DIFF:
https://github.com/llvm/llvm-project/commit/aeb1989bb585e216a13fddeaf28887bdf8623075.d
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-08-07T23:09:45+01:00
New Revision: c178fea62d3999acd42f3ddfcc8bd436b574cfed
URL:
https://github.com/llvm/llvm-project/commit/c178fea62d3999acd42f3ddfcc8bd436b574cfed
DIFF:
https://github.com/llvm/llvm-project/commit/c178fea62d3999acd42f3ddfcc8bd436b574cfed.diff
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/102223
>From c629defe38a510ffdd23122b2e9cfac68933cf34 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Fri, 2 Aug 2024 06:35:45 -0700
Subject: [PATCH 1/5] [lldb] Allow realpathing support files when resolving
file/line b
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 396343f17b1182ff8ed698beac3f9b93b1d9dabd
6011b7ebfaa3717086251dc61cd0ba32a6b0c3fd --e
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
royitaqi wrote:
> No, I wanted to make sure that scenario worked and that it had a test (since
> we want it to keep working). Looks like you did show that it works, but I
> didn't see a test for that scenario so that it will keep working. Did I miss
> that?
Thanks for confirming the scenario.
jimingham wrote:
> > I'd also love to hear other people opinion on extending platforms through
> > ScriptedPlatform (cc @labath @jimingham @JDevlieghere )
>
> I think that having the ability to forward operations to existing platform
> instances would be very useful. If you look at PlatformQem
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/85260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> This really isn't the right approach. `BuiltinHeadersInSystemModules` isn't
> the only important default that the driver sets up. Can we change the
> invocation setup to use clang::createInvocation or
> clang::CompilerInvocation::CreateFromArgs or clang::BuildCompilation? O
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
Michael137 wrote:
I already accounted for the version check changes
https://github.com/llvm/llvm-project/pull/1023
@@ -0,0 +1,66 @@
+//===-- RealpathPrefixes.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Michael Buch
Date: 2024-08-07T23:59:58+01:00
New Revision: 1cbcf74083e92021472ec9644b88418f377ce550
URL:
https://github.com/llvm/llvm-project/commit/1cbcf74083e92021472ec9644b88418f377ce550
DIFF:
https://github.com/llvm/llvm-project/commit/1cbcf74083e92021472ec9644b88418f377ce550.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/102309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
ian-twilightcoder wrote:
But you didn't pick up the environment check
https://github.com/llvm/llvm-project/pull/102
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/101934
>From e5a9e2187bf1b5db2c45bb3efafb57b90aab309b Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 7 Aug 2024 16:33:02 -0700
Subject: [PATCH] [lldb/Interpreter] Fix ambiguous partial command resolu
@@ -259,6 +259,27 @@ bool XcodeSDK::SupportsSwift() const {
}
}
+bool XcodeSDK::SDKSupportsBuiltinModules(const llvm::Triple &target_triple,
Michael137 wrote:
Don't think we really want to support this for non-native environments tbh
https://github.com/llv
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
To extend on Pavel's modification of my idea:
```
class ScriptedPlatform:
def extends_platform_name(self):
'''Get the name of the internal platform this class extends.'''
return "iPhoneOS.platform"
```
Then every function would have 3 variants:
```
def pre_XXX(...):
def
jasonmolenda wrote:
> // Mark the thread as stopped at breakpoint.
> thread.SetStoppedByBreakpoint();
> FixupBreakpointPCAsNeeded(thread);
>
> if (m_threads_stepping_with_breakpoint.find(thread.GetID()) !=
> m_threads_stepping_with_breakpoint.end())
> thread.SetStoppedByTrace()
Author: Jason Molenda
Date: 2024-08-07T17:35:17-07:00
New Revision: cf56e265e4b74799aee72a04b634fcc261078084
URL:
https://github.com/llvm/llvm-project/commit/cf56e265e4b74799aee72a04b634fcc261078084
DIFF:
https://github.com/llvm/llvm-project/commit/cf56e265e4b74799aee72a04b634fcc261078084.diff
jasonmolenda wrote:
David, no need to test this latest fix unless you'd like to - I'll make sure it
compiles on an aarch64 ubuntu VM but the fix is obvious once we were looking at
the right place, and explains the behavior you saw earlier, I'm pretty
confident. I need to figure out the debugi
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
101 - 139 of 139 matches
Mail list logo
