[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-31 Thread Pavel Labath via lldb-commits
labath wrote: > @labath Does your ✅ mean the > [debian](https://lab.llvm.org/buildbot/#/builders/68) bot has this package > installed? Affirmative. > Did a bit of digging around; it looks like at the very least the Arch Linux > python package and the Python docker container don't contain the

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/93883 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/93883 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Pavel Labath via lldb-commits
@@ -40,7 +40,9 @@ def getMake(self, test_subdir, test_name): """Returns the invocation for GNU make. The first argument is a tuple of the relative path to the testcase and its filename stem.""" -if platform.system() == "FreeBSD" or platform.syste

[Lldb-commits] [lldb] [lldb][test] Add --target-os argument to dotest.py (PR #93887)

2024-05-31 Thread Pavel Labath via lldb-commits
labath wrote: Would it be possible to pass this automatically from the python process? Basically set `OS` to the value of `lldbplatformutil.getPlatform()` ? We could keep the existing exception for Android, although I don't think that anyone tests Android these days (your PRs sort of demonstra

[Lldb-commits] [lldb] [lldb][test] Add --sysroot argument to dotest.py (PR #93885)

2024-05-31 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/93885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-31 Thread Pavel Labath via lldb-commits
labath wrote: Ok, I see now. It's an ld.bfd vs ld.lld thing. You probably have your clang configured to use lld. LLD does not put relocation addends into the data section (on both arm and intel). ld.bfd does, which is why this sort of happens to work there. Was your intention to test with LLD?

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93946 For some data formatters, even getting the number of children can be an expensive operations (e.g., needing to walk a linked list to determine the number of elements). This is then wasted work when we know we wil

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes For some data formatters, even getting the number of children can be an expensive operations (e.g., needing to walk a linked list to determine the number of elements). This is then wasted work when we know we

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a2bcb932f3130c3c18ceb06872da9002f6845c4b...957f0a85a0e0d2de9f34d00e28ba932e5affce86 lldb

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread Alexey Merzlyakov via lldb-commits
AlexeyMerzlyakov wrote: No, I have no rights to do this https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/93946 >From 1e25ef1cc5ff4d12a3e5b85c8ea7cd30a3e0908e Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 31 May 2024 10:06:19 + Subject: [PATCH] [lldb] Avoid (unlimited) GetNumChildren calls when printing values

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
DavidSpickett wrote: Corefiles can be debugged anywhere, so you should add a test case to `lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py`. There is a way to minimise the size of the core file, see https://man7.org/linux/man-pages/man5/core.5.html "Controlling which mapping

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-31 Thread David Spickett via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/93880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM assuming you can make the formatter happy. https://github.com/llvm/llvm-project/pull/93880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Ok, I see now. It's an ld.bfd vs ld.lld thing. You probably have your clang > configured to use lld. LLD does not put relocation addends into the data > section (on both arm and intel). ld.bfd does, which is why this sort of > happens to work there. Was your intention to te

[Lldb-commits] [lldb] [lldb] Fix 'session save' command on Windows (PR #93833)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/93833 >From 15acc7cdf26c06c2be0d52d8341bce2870a55606 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 10 May 2024 22:59:31 + Subject: [PATCH] [lldb] Fix 'session save' command on Windows 1. Use da

[Lldb-commits] [lldb] [lldb] Fix 'session save' command on Windows (PR #93833)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/93833 >From c5e417a812d86226b087346cadb05d3aae9fe1d0 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 10 May 2024 22:59:31 + Subject: [PATCH] [lldb] Fix 'session save' command on Windows 1. Use da

[Lldb-commits] [lldb] c5e417a - [lldb] Fix 'session save' command on Windows

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-05-31T17:18:21+02:00 New Revision: c5e417a812d86226b087346cadb05d3aae9fe1d0 URL: https://github.com/llvm/llvm-project/commit/c5e417a812d86226b087346cadb05d3aae9fe1d0 DIFF: https://github.com/llvm/llvm-project/commit/c5e417a812d86226b087346cadb05d3aae9fe1d

[Lldb-commits] [lldb] [lldb] Fix 'session save' command on Windows (PR #93833)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/93833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5e423f1 - [lldb][test] Add --sysroot argument to dotest.py

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-05-31T17:24:14+02:00 New Revision: 5e423f1c5119387879c04069f048d6dbfc2c90d6 URL: https://github.com/llvm/llvm-project/commit/5e423f1c5119387879c04069f048d6dbfc2c90d6 DIFF: https://github.com/llvm/llvm-project/commit/5e423f1c5119387879c04069f048d6dbfc2c90d

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/93880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
@@ -442,16 +443,19 @@ lldb::Format FormatManager::GetSingleItemFormat(lldb::Format vector_format) { } bool FormatManager::ShouldPrintAsOneLiner(ValueObject &valobj) { + TargetSP target_sp = valobj.GetTargetSP(); // if settings say no oneline whatsoever - if (valobj.GetTa

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/93946 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/93946 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add --target-os argument to dotest.py (PR #93887)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Would it be possible to pass this automatically from the python process? > Basically set `OS` to the value of `lldbplatformutil.getPlatform()` ? We > could keep the existing exception for Android, although I don't think that > anyone tests Android these days (your PRs sor

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/93883 >From 01fb7af6eabac1df410e117e5a0ccafb149dc2cb Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 13 Apr 2024 23:55:25 + Subject: [PATCH 1/2] [lldb][test] Add --make argument to dotest.py This

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -40,7 +40,9 @@ def getMake(self, test_subdir, test_name): """Returns the invocation for GNU make. The first argument is a tuple of the relative path to the testcase and its filename stem.""" -if platform.system() == "FreeBSD" or platform.syste

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/93883 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 419d363385c7fa8bd969a817f95ab025ae94277c...60032f8510b7086e36a86172fbaa090e4d7ef66f lldb/

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > That said, using a package designed (AIUI) for python versions for parsing > versions of gcc/clang does strike me as somewhat... unusual, even if it does > work, so _**maybe**_ there is case to be made for writing something custom > (I'm not sure if we really need anythin

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > FWIW, there appears to be an actual arch package for this > https://archlinux.org/packages/extra/any/python-packaging/, so it shouldn't > be (I think -- I'm not an Arch user) necessary to install `pip`. Homebrew on macOS works similarly, it has a [python-packaging](https

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/93883 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add --make argument to dotest.py (PR #93883)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: LGTM with the formatting fixed. https://github.com/llvm/llvm-project/pull/93883 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread via lldb-commits
jimingham wrote: > LGTM assuming you can make the formatter happy. This change says "If a ValueObject has no target, don't try to find a formatter for it". If it doesn't have a target, it's either an error or stale, and isn't going to have a value to format, so any more work we did here would

[Lldb-commits] [lldb] 1e81b67 - [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (#93880)

2024-05-31 Thread via lldb-commits
Author: jimingham Date: 2024-05-31T10:43:05-07:00 New Revision: 1e81b67925fdd77a3d65ba2a7f652d1e840512f4 URL: https://github.com/llvm/llvm-project/commit/1e81b67925fdd77a3d65ba2a7f652d1e840512f4 DIFF: https://github.com/llvm/llvm-project/commit/1e81b67925fdd77a3d65ba2a7f652d1e840512f4.diff LOG

[Lldb-commits] [lldb] [lldb] FormatManager::GetPossibleMatches assumes all ValueObjects have targets. (PR #93880)

2024-05-31 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/93880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
jimingham wrote: This seems reasonable. However, I note that on the page where we show how to write synthetic child providers, we say: def num_children(self): this call should return the number of children that you want your object to have That's actually not true - we pass the max_

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 01/10] Add resolvedCommand to transcript, add transcript to statistics

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
@@ -1425,4 +1425,6 @@ let Command = "statistics dump" in { Desc<"Dump the total possible debug info statistics. " "Force loading all the debug information if not yet loaded, and collect " "statistics with those.">; + def statistics_dump_transcript: Option<"transcri

[Lldb-commits] [lldb] [lldb] Avoid (unlimited) GetNumChildren calls when printing values (PR #93946)

2024-05-31 Thread via lldb-commits
jimingham wrote: BTW, because the max number of children is probably getting ignored in the wild, this has to be advisory, you can't require that: val.GetNumChildren(max_children) <= max_children I don't think you do that but it might be good to note the fact. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5a02a9a - [lldb] Improve identification of Dlang mangled names (#93881)

2024-05-31 Thread via lldb-commits
Author: Dave Lee Date: 2024-05-31T11:20:23-07:00 New Revision: 5a02a9a2e6794f086dfe1cd6f15ba2210bc0 URL: https://github.com/llvm/llvm-project/commit/5a02a9a2e6794f086dfe1cd6f15ba2210bc0 DIFF: https://github.com/llvm/llvm-project/commit/5a02a9a2e6794f086dfe1cd6f15ba2210bc0.diff LOG:

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/92843 >From 8499f16ad46b3268f35da2bfcbfa02a10aab935a Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Mon, 20 May 2024 22:30:40 -0400 Subject: [PATCH 01/11] Add resolvedCommand to transcript, add transcript to statistics

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/94007 The IsValid API is actually quite weak - it means "this value can't answer any questions meaningfully." But I've run into a couple cases where people thought it meant "was able to reconstruct the value on this

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The IsValid API is actually quite weak - it means "this value can't answer any questions meaningfully." But I've run into a couple cases where people thought it meant "was able to reconstruct the value on this stop

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91857 >From 8379b042ef389e7c032e1bc3b32957bd386e2411 Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH 1/2] fix(python): fix comparison to None from PEP8 (https://pep

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-31 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: > We have other packages the test suite relies on (pexpect, psutil, etc) so it > seemed reasonable, but if folks feel strongly about it we can maintain our > own "version parsing". Notably the other packages are optional; the lion's share of the test suite can be run withou

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to None (PR #94017)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm created https://github.com/llvm/llvm-project/pull/94017 from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, > never the equality operators. >From 3142b6184498b133866

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to None (PR #94017)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to None (PR #94017)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. --- Full diff: https

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
e-kwsm wrote: broken into - #94012 - #94013 - #94014 - #94015 - #94016 - #94017 - #94018 - #94019 - #94020 - #94021 - #94022 https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94026 We received a bug report where someone was trying to print a global variable without a process. This would succeed in a debug build but fail in a on optimized build. We traced the issue back to the location

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes We received a bug report where someone was trying to print a global variable without a process. This would succeed in a debug build but fail in a on optimized build. We traced the issue back to the

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm created https://github.com/llvm/llvm-project/pull/94034 None >From 5c7ba6c7d95cced5d8acc609a40a6b8307bc7fed Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 02:39:21 +0900 Subject: [PATCH] fix(lldb/**.py): fix invalid escape sequences --- lldb/

[Lldb-commits] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/94026 >From 3aaf98ebce78fd376d33bd0aeb4d4c57762ea63a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 31 May 2024 12:21:28 -0700 Subject: [PATCH] [lldb] Support reading DW_OP_piece from file address We

[Lldb-commits] [lldb] fix(lldb/**.py): fix invalid escape sequences (PR #94034)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 94.92 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/94034.diff 73 Files Affected: - (modified) lldb/examples/python/crashlog.py (+4-4) - (mod

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
e-kwsm wrote: broken into - #94028 - #94029 - #94030 - #94031 - #94032 - #94033 - #94034 - #94035 - #94036 - #94037 https://github.com/llvm/llvm-project/pull/91856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
@@ -1615,7 +1615,7 @@ class Target : public std::enable_shared_from_this, TargetStats &GetStatistics() { return m_stats; } -private: +protected: JDevlieghere wrote: If you're wondering, this is so the unit test can access the private constructor. https

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/94026 >From 72844ebd5cf8f74f6db5d1c52d1f557ca942dbee Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 31 May 2024 12:21:28 -0700 Subject: [PATCH] [lldb] Support reading DW_OP_piece from file address We

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Adrian Prantl via lldb-commits
@@ -2153,26 +2152,41 @@ bool DWARFExpression::Evaluate( } break; - case Value::ValueType::FileAddress: - case Value::ValueType::HostAddress: -if (error_ptr) { - lldb::addr_t addr = curr_piece_source_value.GetS

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
@@ -2153,26 +2152,41 @@ bool DWARFExpression::Evaluate( } break; - case Value::ValueType::FileAddress: - case Value::ValueType::HostAddress: -if (error_ptr) { - lldb::addr_t addr = curr_piece_source_value.GetS

[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91858 >From cdc6e7c4ee2238e82fb9bf1754962d0aff10422b Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sun, 12 May 2024 00:06:53 +0900 Subject: [PATCH 1/2] fix(python): fix comparison to True/False from PEP8 (https

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Alex Langford via lldb-commits
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) { testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit); } + +TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) { + struct MockTarget : Target { +MockTarget(Debugger &debugger, const ArchSpec

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to True/False (PR #94039)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm created https://github.com/llvm/llvm-project/pull/94039 from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, > never the equality operators. >From 7b8df11972495daf31e

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to True/False (PR #94039)

2024-05-31 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] fix(lldb/**.py): fix comparison to True/False (PR #94039)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. --- Full diff: https

[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-31 Thread Eisuke Kawashima via lldb-commits
e-kwsm wrote: Broken into - #94038 - #94039 - #94040 - #94041 - #94042 https://github.com/llvm/llvm-project/pull/91858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) { testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit); } + +TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) { + struct MockTarget : Target { +MockTarget(Debugger &debugger, const ArchSpec

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/94026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread Alex Langford via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread Alex Langford via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread Alex Langford via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] Add doc strings for SBValue::IsValid and SBValue::GetError. (PR #94007)

2024-05-31 Thread Alex Langford via lldb-commits
@@ -45,6 +45,36 @@ SBValue instance which interprets the value object as representing the head of a linked list." ) lldb::SBValue; +%feature("docstring", " +Returns true if the SBValue holds any useful state +and false otherwise. +IsValid is a very weak API, lldb will only re

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-31 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Thanks for providing the context, Lang! Inside of LLDB we use llvm::Expected often in completely closed environments where the expectation is always that all errors are handled internally and we never would exit the process with an error code, so this would be useful here.

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/94046 None >From a783b4c189d3c5387418e58156667ecc8382b5ce Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 31 May 2024 13:47:24 -0700 Subject: [PATCH] [lldb] Fix Dlang symbol test breakage --- lldb/source/Core

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread via lldb-commits
gulfemsavrun wrote: We started seeing test failures in `LLDBCoreTests`: ``` Script: -- /b/s/w/ir/x/w/llvm_build/tools/lldb/unittests/Core/./LLDBCoreTests --gtest_filter=MangledTest.EmptyForInvalidDLangName -- lldb/unittests/Core/MangledTest.cpp:89: Failure Expected equality of these values: ""

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94046.diff 2 Files Affected: - (modified) lldb/source/Core/Mangled.cpp (+3-2) - (modified) lldb/unittests/Core/MangledTest.cpp (+2-2) ``

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/94046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/94046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve identification of Dlang mangled names (PR #93881)

2024-05-31 Thread Dave Lee via lldb-commits
kastiglione wrote: @gulfemsavrun apologies, fix is here: #94046 https://github.com/llvm/llvm-project/pull/93881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 68fdc1c - [lldb] Fix Dlang symbol test breakage (#94046)

2024-05-31 Thread via lldb-commits
Author: Dave Lee Date: 2024-05-31T14:04:40-07:00 New Revision: 68fdc1cf87eb04686e079af27eaeec0f1c41f8cc URL: https://github.com/llvm/llvm-project/commit/68fdc1cf87eb04686e079af27eaeec0f1c41f8cc DIFF: https://github.com/llvm/llvm-project/commit/68fdc1cf87eb04686e079af27eaeec0f1c41f8cc.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix Dlang symbol test breakage (PR #94046)

2024-05-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/94046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ad884d9 - A few updates around "transcript" (#92843)

2024-05-31 Thread via lldb-commits
Author: royitaqi Date: 2024-05-31T14:42:00-07:00 New Revision: ad884d97288c752ba9088d01cf7ab80b20e4d2a6 URL: https://github.com/llvm/llvm-project/commit/ad884d97288c752ba9088d01cf7ab80b20e4d2a6 DIFF: https://github.com/llvm/llvm-project/commit/ad884d97288c752ba9088d01cf7ab80b20e4d2a6.diff LOG:

[Lldb-commits] [lldb] A few updates around "transcript" (PR #92843)

2024-05-31 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/92843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >