https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91931
>From 361cd689e3900c5ab542a5158807eb532879677e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 11:26:03 +0400
Subject: [PATCH] [lldb] Fixed the test TestGdbRemoteLaunch
Install `a.out` to
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91918
>From 4eee83a3a6b923075a9e6db217349726780c31f4 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 10:34:04 +0400
Subject: [PATCH] [lldb] Fix the test TestGdbRemotePlatformFile
It is necessary
@@ -108,6 +109,20 @@ def test_platform_file_wronly_fail(self):
)
self.expect_gdbremote_sequence()
+def remote_install(self, path, filename="test"):
+if lldb.remote_platform:
+remote_path = lldbutil.append_to_process_working_directory(sel
Author: Dmitry Vasilyev
Date: 2024-05-14T11:26:14+04:00
New Revision: e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f
URL:
https://github.com/llvm/llvm-project/commit/e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f
DIFF:
https://github.com/llvm/llvm-project/commit/e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92077
Windows path is case insensitive. Tests `test_QMemTags_packets` and
`test_qMemTags_packets` will use the same build dir and conflict. Added a
suffix to resolve conflicts.
>From 2b75da41ef3a0056375d01d45954d0ef
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Windows path is case insensitive. Tests `test_QMemTags_packets` and
`test_qMemTags_packets` will use the same build dir and conflict. Added a
suffix to resolve conflicts.
---
Full diff: https://github.co
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/92078
As we have debuginfod as symbol locator available in lldb now, we want to make
full use of it.
In case of post mortem debugging, we don't always have the main executable
available.
However, the .note.gnu.b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
As we have debuginfod as symbol locator available in lldb now, we want to make
full use of it.
In case of post mortem debugging, we don't always have the main executable
available.
However, the .note.gnu.build-
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f8063ffe73a3a1d704b9738169bb76ebb0f8a5e0
6a84c484070d53515c7cc473b4a0c1d566342b0f --
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92078
>From 4a360988cd7242736a9557463fe529c0eaf44dc2 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 13 May 2024 17:03:30 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
lldb/inc
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92080
Install a.out and libsignal_file.so to the remote target if necessary.
>From a5b005cbbfd25c9fb3e59f2cb0f98c2f6a3e405d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 14 May 2024 12:05:27 +0400
Subject
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92078
>From fa962b461d949cc26f09f8b4bdbd533d7b73131d Mon Sep 17 00:00:00 2001
From: George Hu
Date: Mon, 13 May 2024 17:03:30 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
lldb/inc
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Install a.out and libsignal_file.so to the remote target if necessary.
---
Full diff: https://github.com/llvm/llvm-project/pull/92080.diff
1 Files Affected:
- (modified)
lldb/test/API/functionalities/d
https://github.com/DavidSpickett approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: aabhinavg
Date: 2024-05-14T09:14:17+01:00
New Revision: c28529788955dbfada9f8a5092432f09eec2c3ab
URL:
https://github.com/llvm/llvm-project/commit/c28529788955dbfada9f8a5092432f09eec2c3ab
DIFF:
https://github.com/llvm/llvm-project/commit/c28529788955dbfada9f8a5092432f09eec2c3ab.diff
LOG
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c441aa51e16e2fa5f407191287f48d2b7c302ceb...a5b005cbbfd25c9fb3e59f2cb0f98c2f6a3e405d
lldb/
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
If this is split out from the other larger PR, should there be `clang/` changes
in here?
I've copied your commit message into the PR description, because with the way
llvm is setup, we use the PR's description as the commit message for a squashed
version of the changes.
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/91918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92086
self.wait_for_running_event(process) is always called after
self.runCmd("continue"). It is strange to expect eStateConnected here. This
test failed in case of a remote target. The correct state is eStateRunning
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
self.wait_for_running_event(process) is always called after
self.runCmd("continue"). It is strange to expect eStateConnected here. This
test failed in case of a remote target. The correct state is eStateR
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92088
The tests `test_file_permissions` and `test_file_permissions_fallback` are
disabled for Windows target. These tests use MockGDBServerResponder and do not
depend on the real target. These tests failed in case of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The tests `test_file_permissions` and `test_file_permissions_fallback` are
disabled for Windows target. These tests use MockGDBServerResponder and do not
depend on the real target. These tests failed in c
labath wrote:
Can we make this less brute force? I believe searching for the Build ID Note
should be a completely deterministic process, without the need for heuristics.
You start with the elf header, find the program headers, iterate to find the
PT_NOTE segment (there could be more of them),
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T10:15:03+01:00
New Revision: 429ce59bd0a7d93ef833939d4a92b56aae103a5a
URL:
https://github.com/llvm/llvm-project/commit/429ce59bd0a7d93ef833939d4a92b56aae103a5a
DIFF:
https://github.com/llvm/llvm-project/commit/429ce59bd0a7d93ef833939d4a92b56aae103a5a.dif
https://github.com/labath approved this pull request.
I like this new version, thanks for sticking with me.
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/92090
The tests TestPty and TestPtyServer use the Unix specific python builtin module
termios. They are failed in case of Windows host and Linux target. Disable them
for Windows host too.
>From b5b4b996bfa0cdba70f79
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The tests TestPty and TestPtyServer use the Unix specific python builtin module
termios. They are failed in case of Windows host and Linux target. Disable them
for Windows host too.
---
Full diff: https:
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I'm pretty sure lldb was sending these events at some point, but that could
have change since then. I slightly surprised that this wasn't caught before as
that would mean noone is running these tests remotely.
Jonas, are you running lldb tests in remote configurations?
https://g
labath wrote:
Given that the tests use a mock server, why is it a problem that they're
running on a windows host? What's the actual failure? Could they be adapted so
that they run everywhere?
https://github.com/llvm/llvm-project/pull/92088
___
lldb-c
labath wrote:
Maybe the `skipIfWindows` decorator can also be removed here? We haven't been
historically very good at distinguishing windows hosts and targets (nobody
cared until now), and from the looks of things, these tests could conceivably
work in a linux->windows remote scenario (althoug
Author: Dmitry Vasilyev
Date: 2024-05-14T13:57:37+04:00
New Revision: 7b1b1279414217ea7f2402a03dfb5a18ea5a5367
URL:
https://github.com/llvm/llvm-project/commit/7b1b1279414217ea7f2402a03dfb5a18ea5a5367
DIFF:
https://github.com/llvm/llvm-project/commit/7b1b1279414217ea7f2402a03dfb5a18ea5a5367.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T14:00:16+04:00
New Revision: ac42f7689d741feda2badc438101e7952db048f3
URL:
https://github.com/llvm/llvm-project/commit/ac42f7689d741feda2badc438101e7952db048f3
DIFF:
https://github.com/llvm/llvm-project/commit/ac42f7689d741feda2badc438101e7952db048f3.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-14T14:02:31+04:00
New Revision: f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe
URL:
https://github.com/llvm/llvm-project/commit/f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe
DIFF:
https://github.com/llvm/llvm-project/commit/f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/92093
The stack validation heuristic is counter-productive in this case, as the
unaligned address is most likely the thing that caused the signal in the first
place.
>From 391a4129d3da4c4730e50d6ebca23a3c36c3b462 Mon
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The stack validation heuristic is counter-productive in this case, as the
unaligned address is most likely the thing that caused the signal in the first
place.
---
Full diff: https://github.com/llvm/llvm-proj
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where = {{.*}
@@ -0,0 +1,26 @@
+# REQUIRES: (target-aarch64 || target-arm) && native
+# UNSUPPORTED: system-windows
+
+# RUN: %clang_host %S/Inputs/unaligned-pc-sigbus.c -o %t
+# RUN: %lldb -s %s -o exit %t | FileCheck %s
+
+breakpoint set -n sigbus_handler
+# CHECK: Breakpoint 1: where = {{.*}
labath wrote:
I'm currently optimizing our data formatters for some fairly complex data
structures, and I've ran into something I don't understand. My DAP packet
sequence for a hover request consists of two (mostly redundant) packets:
```
-->
Content-Length: 114
{
"arguments": {
"conte
@@ -242,6 +244,12 @@ class AddressRange {
lldb::addr_t m_byte_size = 0; ///< The size in bytes of this address range.
};
+// Forward-declarable wrapper.
+class AddressRanges : public std::vector {
+public:
+ using std::vector::vector;
+};
mbucko wrote:
I f
mbucko wrote:
> I forgot to ask, what is the motivation behind this change? Is there
> something you can't do with the SBAPI right now or that is better expressed
> with SBAddressRange and SBAddressRangeList?
Yes, I want to add the following API:
lldb::SBError SBProcess::FindInMemory(const SB
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/92124
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment so
I'v
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment so
labath wrote:
> Ah, so the problem here is that we're missing the eh_frame instructions for
> _sigtramp on arm64 with macOS 14. `signal_generating_add` is a frameless
> function (a great stress test in this instance), and _sigtramp is called with
> enough of a faked-up stack that a stack walk
https://github.com/JDevlieghere approved this pull request.
LGTM. TILL about `qSpeedTest`.
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-
JDevlieghere wrote:
> I'm pretty sure lldb was sending these events at some point, but that could
> have change since then. I slightly surprised that this wasn't caught before
> as that would mean noone is running these tests remotely.
>
> Jonas, are you running lldb tests in remote configurat
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Ah, that explains it. Ship it then.
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/92137
ResolveCommand will not succeed for an alias command with arguments, and the
code wasn't providing any. Replace that with explicit query(ies) for the
existence of a command with the given name.
>From 6d4df820e84
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
ResolveCommand will not succeed for an alias command with arguments, and the
code wasn't providing any. Replace that with explicit query(ies) for the
existence of a command with the given name.
---
Full diff:
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2b15c4a62be6ceab124cb2505ae8dc6a98ba6e7d...6d4df820e84e84a871a6d24a196608047470d7d7
lldb/
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/92090
>From b5b4b996bfa0cdba70f7935e452d6adde6b3cc15 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 14 May 2024 13:18:42 +0400
Subject: [PATCH 1/2] [lldb][Windows] Fixed tests TestPty and TestPtyServer
The
jimingham wrote:
Thanks!
Jim
> On May 13, 2024, at 6:39 PM, Zequan Wu ***@***.***> wrote:
>
>
> Can you take care of cleaning this up, this seems like a slightly complex
> patch and not in an area I'm familiar with.
>
> Yes, will do. Sorry for the mess without reverting it earlier.
>
> —
>
slydiman wrote:
Agreed. I have removed `@skipIfWindows`. @skipIfRemote is too much. These tests
are still usable for Linux->Linux and such.
https://github.com/llvm/llvm-project/pull/92090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
Author: Dmitry Vasilyev
Date: 2024-05-14T20:05:22+04:00
New Revision: 0f17d9a28c40eebd42c83956e2a7b5186c1814d7
URL:
https://github.com/llvm/llvm-project/commit/0f17d9a28c40eebd42c83956e2a7b5186c1814d7
DIFF:
https://github.com/llvm/llvm-project/commit/0f17d9a28c40eebd42c83956e2a7b5186c1814d7.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/92086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
The problem is that fstat() is fake on Windows. File::GetPermissions() returns
0 always.
The test got 'File permissions of /some/file.txt (remote): 0o' So any
permissions manipulations are useles on Windows and these tests cannot be
adapted.
https://github.com/llvm/llvm-pr
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/92088
>From 7dcfe773b6eef27aabbcc7fc68cd6448bc3c2e88 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 14 May 2024 13:08:35 +0400
Subject: [PATCH 1/2] [lldb][Windows] Fixed the test
gdb_remote_client/TestGDBR
slydiman wrote:
I have removed @skipIfWindows because these tests are host specific.
https://github.com/llvm/llvm-project/pull/92088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> The problem is that fstat() is fake on Windows. File::GetPermissions()
> returns 0 always. The test got 'File permissions of /some/file.txt (remote):
> 0o' So any permissions manipulations are useles on Windows and these
> tests cannot be adapted.
But who is calling File::
clayborg wrote:
> > I forgot to ask, what is the motivation behind this change? Is there
> > something you can't do with the SBAPI right now or that is better expressed
> > with SBAddressRange and SBAddressRangeList?
>
> Yes, I want to add the following API:
>
> lldb::SBError SBProcess::FindI
slydiman wrote:
The problem is here
lldb\source\Plugins\Process\gdb-remote\GDBRemoteCommunicationClient.cpp, line
3235
inside GDBRemoteCommunicationClient::GetFilePermissions()
```
file_permissions = mode & (S_IRWXU | S_IRWXG | S_IRWXO);
```
But S_IRWXU, S_IRWXG and S_IRWXO are 0 on Windows.
h
https://github.com/bulbazord requested changes to this pull request.
Hmm, actually, I'm not so sure about this change anymore. I went through PEP8
again and saw this:
```
Don’t compare boolean values to True or False using ==:
# Correct:
if greeting:
# Wrong:
if greeting == True:
Worse:
# Wron
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/92078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/92078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -158,6 +160,15 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
// Returns number of thread contexts stored in the core file
uint32_t GetNumThreadContexts();
+ // Populate gnu uuid for each NT_FILE entry
+ void UpdateBuildIdForNTFileEntries();
+
+
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -117,6 +117,8 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
lldb::addr_t end;
lldb::addr_t file_ofs;
std::string path;
+lldb_private::UUID
+uuid; // extracted from .note.gnu.build-id section from core file
claybo
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -3191,6 +3191,33 @@ Status Process::Halt(bool clear_thread_plans, bool
use_run_lock) {
return Status();
}
+lldb::addr_t Process::FastSearch(lldb::addr_t low, lldb::addr_t high,
clayborg wrote:
rename to `FindInMemory`
https://github.com/llvm/llvm-proje
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -977,35 +977,6 @@ class CommandObjectMemoryFind : public CommandObjectParsed
{
Options *GetOptions() override { return &m_option_group; }
protected:
- class ProcessMemoryIterator {
- public:
-ProcessMemoryIterator(ProcessSP process_sp, lldb::addr_t base)
-:
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
@@ -983,6 +995,44 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const NT_FILE_Entry entry) {
+ const uint8_t elf_header[4] = {0x7f, 0x45, 0x4c,
+ 0x46}; // ELF file begin with this 4 bytes
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/87815
>From cdee622a6646ba5c16a3c8156a5a50a938a14b57 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 5 Apr 2024 14:14:30 -0400
Subject: [PATCH 1/3] [lldb]POC implementation for telemetry in LLDB
---
lldb/include/
@@ -0,0 +1,13 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
https://github.com/clayborg commented:
We might want SBAddressRange and SBAddressRangeList to have methods:
```
bool GetDescription(lldb::SBStream &description);
```
Then make sure we add stuff to the .i files so python `str()` calls this.
We do this in many other classes.
https://github.com/
@@ -0,0 +1,13 @@
+%extend lldb::SBAddressRangeList {
clayborg wrote:
If we add a method to SBAddressRangeList:
```
bool GetDescription(lldb::SBStream &description);
```
Then we can add this to this file:
```
STRING_EXTENSION_OUTSIDE(SBAddressRangeList)
```
And
@@ -0,0 +1,13 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/91688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Keith Smiley
Date: 2024-05-14T13:43:04-07:00
New Revision: f918c056f06968763870bc3e6b9f9d7074e1f867
URL:
https://github.com/llvm/llvm-project/commit/f918c056f06968763870bc3e6b9f9d7074e1f867
DIFF:
https://github.com/llvm/llvm-project/commit/f918c056f06968763870bc3e6b9f9d7074e1f867.diff
@@ -0,0 +1,58 @@
+//===-- SBAddressRangeList.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,78 @@
+//===-- SBAddressRange.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
GeorgeHuyubo wrote:
> Can we make this less brute force? I believe searching for the Build ID Note
> should be a completely deterministic process, without the need for
> heuristics. You start with the elf header, find the program headers, iterate
> to find the PT_NOTE segment (there could be m
1 - 100 of 128 matches
Mail list logo
