[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC) (PR #85892)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/85892 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 556fe5f - [lldb] Reland: Store SupportFile in FileEntry (NFC) (#85892)

Author: Jonas Devlieghere Date: 2024-03-21T08:40:08-07:00 New Revision: 556fe5f290ea88dcbb7ced16b0f057dcebce1fd0 URL: https://github.com/llvm/llvm-project/commit/556fe5f290ea88dcbb7ced16b0f057dcebce1fd0 DIFF: https://github.com/llvm/llvm-project/commit/556fe5f290ea88dcbb7ced16b0f057dcebce1fd0.d

[Lldb-commits] [lldb] 6317c78 - [lldb][progress][NFC] Clarify Doxygen comments for `details` field (#86002)

Author: Chelsea Cassanova Date: 2024-03-21T08:49:43-07:00 New Revision: 6317c780d81327bd06701a6aa374fc92aa3d73ad URL: https://github.com/llvm/llvm-project/commit/6317c780d81327bd06701a6aa374fc92aa3d73ad DIFF: https://github.com/llvm/llvm-project/commit/6317c780d81327bd06701a6aa374fc92aa3d73ad.d

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/86002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 81bd799 - [lldb] Add missing initialization in LineEntry ctor

Author: Jonas Devlieghere Date: 2024-03-21T09:06:06-07:00 New Revision: 81bd799819f498a55e32599bce51fa98b2e73238 URL: https://github.com/llvm/llvm-project/commit/81bd799819f498a55e32599bce51fa98b2e73238 DIFF: https://github.com/llvm/llvm-project/commit/81bd799819f498a55e32599bce51fa98b2e73238.d

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

@@ -210,6 +210,12 @@ else ifeq "$(SPLIT_DEBUG_SYMBOLS)" "YES" DSYM = $(EXE).debug endif + + ifeq "$(MERGE_DWOS)" "YES" clayborg wrote: Is `MERGE_DWOS` new? If so, lets rename to `MAKE_DWP` https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

@@ -210,6 +210,12 @@ else ifeq "$(SPLIT_DEBUG_SYMBOLS)" "YES" DSYM = $(EXE).debug endif + + ifeq "$(MERGE_DWOS)" "YES" kevinfrei wrote: Updated. It also turns out that MAKE_DWP implies MAKE_DWO, so I removed it from the test

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

https://github.com/kevinfrei updated https://github.com/llvm/llvm-project/pull/85693 >From fc0eda99c7cceeaefd33477c9b08e7221a5a6e2a Mon Sep 17 00:00:00 2001 From: Kevin Frei Date: Fri, 15 Mar 2024 08:54:04 -0700 Subject: [PATCH 1/6] Tests (w/fixes) for initial DebugInfoD LLDB integration Summa

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/85693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/84854 >From 65d86e85ce27fa4b127bf80fceebf98215b19f64 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 6 Mar 2024 17:22:43 -0800 Subject: [PATCH] [lldb] Implement coalescing of disjoint progress events

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/85693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

JDevlieghere wrote: Rebased. @clayborg please take a look at my comment about the timeout setting and let me know if you consider this a blocker or have any other ideas. https://github.com/llvm/llvm-project/pull/84854 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/86159 This patch sets the necessary `ASTContext` flag to ensure that the various ASTs (i.e., symbolfile-backed ASTs, scratch AST and the expression AST) in LLDB are dumped using syntax highlighting (i.e., whenever

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/86159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/86159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/86159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch sets the necessary `ASTContext` flag to ensure that the various ASTs (i.e., symbolfile-backed ASTs, scratch AST and the expression AST) in LLDB are dumped using syntax highlighting (i.e., whenev

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/81196 >From 81a2034ff2b41e30a1f5b82c86b4d5d4c429ed52 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 8 Feb 2024 13:59:12 -0800 Subject: [PATCH 1/6] [lldb] Support custom printf formatting for variables --- lld

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 0572dabb71147fdc156d90a3ecd036d1652c2006...16b8dfab53008c657c82b0ae35510c7050481bdb lldb

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

bulbazord wrote: What happens if you have colors disabled in your terminal? Does this do nothing? Or does it start inserting ANSI escape codes in plain text? https://github.com/llvm/llvm-project/pull/86159 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

JDevlieghere wrote: > > What happens if you have colors disabled in your terminal? Does this do > > nothing? Or does it start inserting ANSI escape codes in plain text? > > Yea good question, was about to try this out. It does whatever clang's > `ast-dump` would do if colors aren't turned off

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

JDevlieghere wrote: Either way, we should add a comment explaining that (and why) this works. https://github.com/llvm/llvm-project/pull/86159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

Michael137 wrote: > What happens if you have colors disabled in your terminal? Does this do > nothing? Or does it start inserting ANSI escape codes in plain text? Yea good question, was about to try this out. It does whatever clang's `ast-dump` would do if colors aren't turned on https://gith

[Lldb-commits] [lldb] 6d939a6 - DebugInfoD tests + fixing issues exposed by tests (#85693)

Author: Kevin Frei Date: 2024-03-21T13:09:04-07:00 New Revision: 6d939a6ec69adf284cdbef2034b49fd02ba503fc URL: https://github.com/llvm/llvm-project/commit/6d939a6ec69adf284cdbef2034b49fd02ba503fc DIFF: https://github.com/llvm/llvm-project/commit/6d939a6ec69adf284cdbef2034b49fd02ba503fc.diff LO

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/85693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

https://github.com/clayborg approved this pull request. LGTM. I commented on the timeout, but we can implement a setting later if needed. We can always have the ProgressManager class start with 100ms, and then have its timeout updated if/when the settings get modified later. Since there is one

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/81196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

@@ -0,0 +1,18 @@ +import lldb +from lldbsuite.test.lldbtest import * +import lldbsuite.test.lldbutil as lldbutil + + +class TestCase(TestBase): + +def test_raw_bytes(self): +self.build() +lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("m

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/81196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

@@ -659,20 +660,24 @@ static char ConvertValueObjectStyleToChar( } static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options, -ValueObject &target) { +ValueObject &valobj) { std::string for

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

@@ -0,0 +1,18 @@ +import lldb +from lldbsuite.test.lldbtest import * +import lldbsuite.test.lldbutil as lldbutil + + +class TestCase(TestBase): + +def test_raw_bytes(self): +self.build() +lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("m

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

@@ -44,6 +44,25 @@ llvm::StringRef SymbolVendorELF::GetPluginDescriptionStatic() { "executables."; } +// If this is needed elsewhere, it can be exported/moved. +static bool IsDwpSymbolFile(const lldb::ModuleSP &module_sp, +const FileSpec &

[Lldb-commits] [lldb] [lldb] Handle clang::Language::CIR (PR #86234)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/86234 commit e66b670f3bf9312f696e66c31152ae535207d6bb Author: Nathan Lanza Date: Thu Mar 21 19:53:48 2024 -0400 triggers: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:478:16: error: enu

[Lldb-commits] [lldb] [lldb] Handle clang::Language::CIR (PR #86234)

https://github.com/lanza approved this pull request. https://github.com/llvm/llvm-project/pull/86234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle clang::Language::CIR (PR #86234)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes commit e66b670f3bf9312f696e66c31152ae535207d6bb Author: Nathan Lanza Date: Thu Mar 21 19:53:48 2024 -0400 triggers: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang

[Lldb-commits] [lldb] [lldb] Handle clang::Language::CIR (PR #86234)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/86234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 40beb9b - [lldb] Handle clang::Language::CIR (#86234)

Author: Kazu Hirata Date: 2024-03-21T20:14:18-07:00 New Revision: 40beb9b001a3c67c60b98fae9e999dcaa2d88717 URL: https://github.com/llvm/llvm-project/commit/40beb9b001a3c67c60b98fae9e999dcaa2d88717 DIFF: https://github.com/llvm/llvm-project/commit/40beb9b001a3c67c60b98fae9e999dcaa2d88717.diff L