https://github.com/svs-quic created
https://github.com/llvm/llvm-project/pull/83234
We weren't checking to see if the partial_path was empty before adding
completions and this led to crashes when the class object and a variable both
start with the same substring.
Fixes [#81536](https://githu
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From 87c442c0911fd4671da1ae03c5d967857fd363d1 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH] [LLDB] Fix crash when using tab completion on class varia
DavidSpickett wrote:
Test? I remember a file dedicated to completion tests somewhere.
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> This introduces a LLDB_TEST_USE_VENDOR_PACKAGES cmake param that can be
> enabled, and the tests will continue loading that tree.
I get the intent but doing it this way is actually going to be more of an
issue. As changes to our bot config have to go through zorg, a mas
DavidSpickett wrote:
Though maybe you intend this to break builds, that way obscure builders that we
don't know about will still hear about this?
I can understand that angle, in which case do we want to make sure all known
builders have pexpect installed before this commit goes in? I will sort
DavidSpickett wrote:
Also are there known compatible/incompatible versions of pexpect? Is `pip
install pexpect` going to install something with significant API differences to
the vendored copy?
https://github.com/llvm/llvm-project/pull/83191
___
lldb
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH] [LLDB] Fix crash when using tab completion on class varia
https://github.com/svs-quic ready_for_review
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sudharsan Veeravalli (svs-quic)
Changes
We weren't checking to see if the partial_path was empty before adding
completions and this led to crashes when the class object and a variable both
start with the same substring.
Fixes [#81536](ht
Michael137 wrote:
Change itself is fine. But could you please add a test in
`lldb/test/API/commands/expression/completion/TestExprCompletion.py` or
`lldb/test/API/functionalities/completion/TestCompletion.py`?
https://github.com/llvm/llvm-project/pull/83234
rupprecht wrote:
> Though maybe you intend this to break builds, that way obscure builders that
> we don't know about will still hear about this?
>
Yes, but I agree with your suggestion to land this with a default of `ON`,
which makes this change NFC. I can then switch it to `OFF` once known
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -209,25 +231,66 @@ class ThreadPool {
/// Number of threads active for tasks in the given group (only non-zero).
DenseMap ActiveGroups;
-#if LLVM_ENABLE_THREADS // avoids warning for unused variable
/// Signal for the destruction of the pool, asking thread to exit.
@@ -140,54 +142,74 @@ class ThreadPool {
},
std::move(F)};
}
+};
+
+/// A ThreadPool implementation using std::threads.
+///
+/// The pool keeps a vector of threads alive, waiting on a condition variable
+/// for some work to become available.
+class S
https://github.com/aganea approved this pull request.
LGTM with two minor comments.
https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeARM approved this pull request.
https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeARM edited
https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -227,7 +265,7 @@ class ThreadPool {
class ThreadPoolTaskGroup {
GeorgeARM wrote:
Thanks for explaining @joker-eph. Looks good to me.
https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lld
https://github.com/GeorgeARM edited
https://github.com/llvm/llvm-project/pull/82094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/83191
>From d21ac756226a364603acd0180f9a06c23600acb1 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 27 Feb 2024 13:25:12 -0800
Subject: [PATCH 1/2] [lldb][test] Exclude third_party packages by default
Th
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH 1/2] [LLDB] Fix crash when using tab completion on class
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9f99eda1208787364b1a381b2d4e146fc4868cd5
dab0c4b75bd07cc5fbad313311b6a747f985712d --
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH 1/3] [LLDB] Fix crash when using tab completion on class
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/83203
>From 3410fc7e0e9d73763e3edee6e008012ba571ad80 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Tue, 27 Feb 2024 17:59:20 -0500
Subject: [PATCH] [LLDB] Fix completion of space-only lines in the REPL
https://github.com/DavidSpickett approved this pull request.
You need to update the PR description but otherwise LGTM.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 63dded34a47dd161fa918e45aaeecf966ba08476 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
walter-erquinigo wrote:
@DavidSpickett I was able to write a test for this. PTAL :)
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
https://github.com/hawkinsw edited
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hawkinsw commented:
As I said before, I really appreciate you doing such in-depth documentation. I
hope these little suggestions help!
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
https://github.com/DavidSpickett approved this pull request.
I'd like to know if there's a good reason for the skip beyond machine load, but
this is fine as is. LGTM.
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-c
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
Author: Walter Erquinigo
Date: 2024-02-28T11:43:36-05:00
New Revision: cd344a4c20e295d49f8163ec9a0656c1061a6e42
URL:
https://github.com/llvm/llvm-project/commit/cd344a4c20e295d49f8163ec9a0656c1061a6e42
DIFF:
https://github.com/llvm/llvm-project/commit/cd344a4c20e295d49f8163ec9a0656c1061a6e42.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/83203
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83291
This patch moves the logic for copying the layout info of a `RecordDecl`s
origin into a target AST.
A follow-up patch re-uses the logic from within the `ClangASTImporter`, so the
natural choice was to move i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch moves the logic for copying the layout info of a `RecordDecl`s
origin into a target AST.
A follow-up patch re-uses the logic from within the `ClangASTImporter`, so the
natural choice was to mov
@@ -54,3 +55,16 @@ def test_basic_completion(self):
self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"])
self.quit()
+
+# PExpect uses many timeouts internally and doesn't play well
+# under ASAN on a loaded machine..
+@skipIfAsan
+@
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
JDevlieghere wrote:
This should t
@@ -97,27 +98,37 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// the progress manager.
+ struct ProgressData {
+
https://github.com/JDevlieghere approved this pull request.
LGTM with the nit addressed.
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/83295
Layout information for a record gets stored in the `ClangASTImporter`
associated with the `DWARFASTParserClang` that originally parsed the record.
LLDB sometimes moves clang types from one AST to another (in
Michael137 wrote:
relies on https://github.com/llvm/llvm-project/pull/83291
https://github.com/llvm/llvm-project/pull/83295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Layout information for a record gets stored in the `ClangASTImporter`
associated with the `DWARFASTParserClang` that originally parsed the record.
LLDB sometimes moves clang types from one AST to another (
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
chelcassanova wrote:
Yeah, the ti
https://github.com/rastogishubham created
https://github.com/llvm/llvm-project/pull/83312
The timeout for this test was set to 1.0s which is very low, it should be a
default of 10s and be increased by a factor of 10 if ASAN is enabled. This will
help reduce the falkiness of the test, especiall
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Shubham Sandeep Rastogi (rastogishubham)
Changes
The timeout for this test was set to 1.0s which is very low, it should be a
default of 10s and be increased by a factor of 10 if ASAN is enabled. This will
help reduce the falkiness of the t
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c1b8c6cf41df4a148e7a89c3a3c7e8049b0a47af...53c507046527e04b7faa70ea17cd59b45e724f55
lldb/
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 03268312834c61a16c4bc28efc442fcd027ec0a9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 40caaa80180d4845393fc4b80ee2dc09b7c87a7e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f01ed3bc8884223bf3edbaad8d3685622444cbf5
40caaa80180d4845393fc4b80ee2dc09b7c87a7e --
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From f38204941062691bf3e3f6e57d8171a5c0258f77 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83317
This specifically addresses the warnings:
$LLVM/lldb/include/lldb/API/SBCommandReturnObject.h:119: Warning 509:
Overloaded method lldb::SBCommandReturnObject::PutCString(char const *)
effectively ignored, $LLV
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
This specifically addresses the warnings:
$LLVM/lldb/include/lldb/API/SBCommandReturnObject.h:119: Warning 509:
Overloaded method lldb::SBCommandReturnObject::PutCString(char const *)
effectively ignored,
https://github.com/rupprecht approved this pull request.
https://github.com/llvm/llvm-project/pull/83192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/83192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-02-28T14:56:55-05:00
New Revision: 2cacc7a61095577ff42177373d46c8cb8df0cb1f
URL:
https://github.com/llvm/llvm-project/commit/2cacc7a61095577ff42177373d46c8cb8df0cb1f
DIFF:
https://github.com/llvm/llvm-project/commit/2cacc7a61095577ff42177373d46c8cb8df0cb1f.diff
LOG
https://github.com/walter-erquinigo requested changes to this pull request.
could you create instead a variable at the base test class level that can be
used by other DAP tests when setting timeouts? I'm pretty sure at least one
other test file uses timeouts.
https://github.com/llvm/llvm-proje
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/83312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jordan Rupprecht
Date: 2024-02-28T15:00:41-06:00
New Revision: 249cf356ef21d0b6ed0d1fa962f3fc5a9e3fcc9e
URL:
https://github.com/llvm/llvm-project/commit/249cf356ef21d0b6ed0d1fa962f3fc5a9e3fcc9e
DIFF:
https://github.com/llvm/llvm-project/commit/249cf356ef21d0b6ed0d1fa962f3fc5a9e3fcc9e.di
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83330
The -d(ebug) option broke 5 years ago when I migrated the driver to libOption.
Since then, we were never check if the option is set. We were incorrectly
toggling the internal variable (m_debug_mode) based o
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The -d(ebug) option broke 5 years ago when I migrated the driver to libOption.
Since then, we were never check if the option is set. We were incorrectly
toggling the internal variable (m_debug_mode)
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Yeay 🥳
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/83341
The help for the `-r` option to `image list` says:
-r[] ( --ref-count=[] )
Display the reference count if the module is still in the shared
module cache.
but that's not what it actually doe
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The help for the `-r` option to `image list` says:
-r[] ( --ref-count=[] )
Display the reference count if the module is still in the shared
module cache.
but that's not what it act
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e427e934f677567f8184ff900cb4cbdb8cf21a21
b95ffa364ecfc8593dc48a1986385d81cbeb05c2 --
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Does it make sense to have an image multiple times in the shared cache ? If
not, instead of saying `{Y/N count}` what about printing `{location(shared
cache/module collection)} and only print it ref count if it's not in the shared
cache ?
https://github.com/llvm/llvm-proje
https://github.com/bulbazord approved this pull request.
:)
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kovdan01 wrote:
> tbh I have no problems with the patch, but I think it's fixing something that
> I think should be reconsidered altogether, I'm interested to hear more about
> what the use case looks like that led to this being a problem.
@jasonmolenda The use case is very simple, describing
medismailben wrote:
> Does it make sense to have an image multiple times in the shared cache ? If
> not, instead of saying `{Y/N count}` what about printing `{location(shared
> cache/module collection)}` and only print it ref count if it's not in the
> shared cache ?
My bad, I thought you wer
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/83350
There was a think-o in a previous commit that made us only able to define 1
line commands when using command script add interactively.
There was also no test for this feature, so I fixed the think-o and added
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
There was a think-o in a previous commit that made us only able to define 1
line commands when using command script add interactively.
There was also no test for this feature, so I fixed the think-o and added a
te
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
4df364bc93af49ae413ec1ae8328f34ac70730c4...76eeb252b1f5fa71a68b439c84d13c8bcf042da7
lldb/
kovdan01 wrote:
> Would this change be observable by a test?
@adrian-prantl Theoretically, it should be: in
`ClangExpressionParser::ClangExpressionParser`, we try to hardcode sse and sse2
for both x86 and x86_64, while in `X86TargetInfo::initFeatureMap`, sse2
(implying sse) is only hardcoded
kovdan01 wrote:
> Can this code be hit when using an x86 core file?
Thanks for suggestion! I'll try that and notify here if such approach succeeded.
https://github.com/llvm/llvm-project/pull/82603
___
lldb-commits mailing list
lldb-commits@lists.llvm.
@@ -209,25 +231,66 @@ class ThreadPool {
/// Number of threads active for tasks in the given group (only non-zero).
DenseMap ActiveGroups;
-#if LLVM_ENABLE_THREADS // avoids warning for unused variable
/// Signal for the destruction of the pool, asking thread to exit.
Author: Jonas Devlieghere
Date: 2024-02-28T15:23:55-08:00
New Revision: d3173f4ab61c17337908eb7df3f1c515ddcd428c
URL:
https://github.com/llvm/llvm-project/commit/d3173f4ab61c17337908eb7df3f1c515ddcd428c
DIFF:
https://github.com/llvm/llvm-project/commit/d3173f4ab61c17337908eb7df3f1c515ddcd428c.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Thinkos are the most insidious bugs. Nice catch.
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -209,25 +231,66 @@ class ThreadPool {
/// Number of threads active for tasks in the given group (only non-zero).
DenseMap ActiveGroups;
-#if LLVM_ENABLE_THREADS // avoids warning for unused variable
/// Signal for the destruction of the pool, asking thread to exit.
1 - 100 of 132 matches
Mail list logo
