[Lldb-commits] [lldb] [lldb-dap] Do not write over the existing error if launchCommands fail during debugger launch. (PR #82051)

https://github.com/clayborg approved this pull request. Looks good. Always good to have a test. https://github.com/llvm/llvm-project/pull/82051 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest &request) { } } +void +CommandObject::HandleArgumentCompletion(CompletionRequest &request, + OptionElementVector &opt_element_vector) { + size_t num_arg_entries = GetNumAr

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/82085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest &request) { } } +void +CommandObject::HandleArgumentCompletion(CompletionRequest &request, + OptionElementVector &opt_element_vector) { + size_t num_arg_entries = GetNumAr

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

https://github.com/clayborg commented: Good fix. Just a few comments https://github.com/llvm/llvm-project/pull/82085 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Centralize the handling of completion for simple argument lists. (PR #82085)

@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest &request) { } } +void +CommandObject::HandleArgumentCompletion(CompletionRequest &request, + OptionElementVector &opt_element_vector) { + size_t num_arg_entries = GetNumAr

[Lldb-commits] [lldb] [lldb] Use PyBytes and PyByteArray in Python Data Objects unittest (PR #82098)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/82098 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more ways to find the .dwp file. (PR #81067)

https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/81067 >From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 7 Feb 2024 16:43:50 -0800 Subject: [PATCH 1/6] Add more ways to find the .dwp file. When using split DWARF w

[Lldb-commits] [lldb] 27f2908 - [lldb] Use PyBytes and PyByteArray in Python Data Objects unittest (#82098)

Author: Jonas Devlieghere Date: 2024-02-17T11:37:26-08:00 New Revision: 27f2908fbc8092f3567385a63676d623523b318b URL: https://github.com/llvm/llvm-project/commit/27f2908fbc8092f3567385a63676d623523b318b DIFF: https://github.com/llvm/llvm-project/commit/27f2908fbc8092f3567385a63676d623523b318b.d

[Lldb-commits] [lldb] [lldb] Use PyBytes and PyByteArray in Python Data Objects unittest (PR #82098)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82098 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 21ddd7f - Report only loaded debug info in statistics dump (#81706)

Author: Wanyi Date: 2024-02-17T14:38:18-05:00 New Revision: 21ddd7ff2b166c5e133b460b1a09ee8adb786ccd URL: https://github.com/llvm/llvm-project/commit/21ddd7ff2b166c5e133b460b1a09ee8adb786ccd DIFF: https://github.com/llvm/llvm-project/commit/21ddd7ff2b166c5e133b460b1a09ee8adb786ccd.diff LOG: Re

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/81706 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Call Import_AppendInittab before Py_Initialize (PR #82095)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/82095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fbce244 - [lldb] Call Import_AppendInittab before Py_Initialize (#82095)

Author: Jonas Devlieghere Date: 2024-02-17T15:10:09-08:00 New Revision: fbce244299524fc3d736cce9d25b4262303b45d5 URL: https://github.com/llvm/llvm-project/commit/fbce244299524fc3d736cce9d25b4262303b45d5 DIFF: https://github.com/llvm/llvm-project/commit/fbce244299524fc3d736cce9d25b4262303b45d5.d

[Lldb-commits] [lldb] [lldb] Call Import_AppendInittab before Py_Initialize (PR #82095)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

bulbazord wrote: > The downside of doing the initialization manually is that we do lose a bit of > test coverage. For example, issue #70453 also manifested itself in the unit > tests. I think this is an acceptable tradeoff. The unit tests are for testing LLDB's python internals, not for testi

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/82096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/82096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use PyBytes and PyByteArray in Python Data Objects unittest (PR #82098)

hawkinsw wrote: > Use a Python Bytes and ByteArray object instead of Integers for > TestOwnedReferences and TestBorrowedReferences. These two tests were failing > when building against Python 3.12 because these Integer objects had a > refcount of 4294967296 (-1). I didn't dig into it, but I su

[Lldb-commits] [lldb] [lldb] Migrate distutils.version.LooseVersion to packaging (PR #82066)

https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/82066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5c96e71 - [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (#82096)

Author: Jonas Devlieghere Date: 2024-02-17T20:55:33-08:00 New Revision: 5c96e71d0d49dd55711ccdb57a22d033fe7a8fae URL: https://github.com/llvm/llvm-project/commit/5c96e71d0d49dd55711ccdb57a22d033fe7a8fae DIFF: https://github.com/llvm/llvm-project/commit/5c96e71d0d49dd55711ccdb57a22d033fe7a8fae.d

[Lldb-commits] [lldb] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initialize in the unit tests (PR #82096)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "Report only loaded debug info in statistics dump (#81706)" (PR #82150)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/82150 This reverts commit 21ddd7ff2b166c5e133b460b1a09ee8adb786ccd because it breaks a bunch of tests: https://lab.llvm.org/buildbot/#/builders/68/builds/69018 https://green.lab.llvm.org/green/view/LLDB/job/as-ll

[Lldb-commits] [lldb] 339baae - Revert "Report only loaded debug info in statistics dump (#81706)" (#82150)

Author: Jonas Devlieghere Date: 2024-02-17T21:38:11-08:00 New Revision: 339baae3e223693a98f0f25e06147e4e6dde1254 URL: https://github.com/llvm/llvm-project/commit/339baae3e223693a98f0f25e06147e4e6dde1254 DIFF: https://github.com/llvm/llvm-project/commit/339baae3e223693a98f0f25e06147e4e6dde1254.d

[Lldb-commits] [lldb] Revert "Report only loaded debug info in statistics dump (#81706)" (PR #82150)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/82150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "Report only loaded debug info in statistics dump (#81706)" (PR #82150)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This reverts commit 21ddd7ff2b166c5e133b460b1a09ee8adb786ccd because it breaks a bunch of tests: https://lab.llvm.org/buildbot/#/builders/68/builds/69018 https://green.lab.llvm.org/green/view/LLDB/j

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

JDevlieghere wrote: I've reverted this because it breaks a bunch of tests: https://lab.llvm.org/buildbot/#/builders/68/builds/69018 https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/16273 Please keep an eye on the bots when relanding this. https://github.com/llvm/llvm-project/pull/