[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-02-13 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: I got one buildbot email: https://lab.llvm.org/buildbot/#/builders/68/builds/68776 Looks like lldb-dap crashes occasionally, and so the `disconnect` event doesn't get the response it was expecting. (The buildbot does not enable the dap request/response logging, but I have it

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/2] [lldb][progress] Add progress manager class Per dis

[Lldb-commits] [lldb] [lldb] Detect a Darwin kernel issue and work around it (PR #81573)

2024-02-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Thanks for all the feedback @bulbazord @jimingham , updated the PR with those issues addressed. https://github.com/llvm/llvm-project/pull/81573 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] Add comment on cross printing of summary/value (PR #81681)

2024-02-13 Thread Dave Lee via lldb-commits
kastiglione wrote: I'll fine tune the wording to match the code. https://github.com/llvm/llvm-project/pull/81681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandObjectProcessHandle::VerifyCommandOptionValue (PR #79901)

2024-02-13 Thread Alex Langford via lldb-commits
@@ -1666,33 +1646,52 @@ class CommandObjectProcessHandle : public CommandObjectParsed { // the user's options. ProcessSP process_sp = target.GetProcessSP(); -int stop_action = -1; // -1 means leave the current setting alone -int pass_action = -1; // -1 mea

[Lldb-commits] [lldb] 3647ff1 - Used std::vector::reserve when I meant std::vector::resize.

2024-02-13 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2024-02-13T16:12:20-08:00 New Revision: 3647ff159a2f2445c45d9cbb4f8791b5f30da16b URL: https://github.com/llvm/llvm-project/commit/3647ff159a2f2445c45d9cbb4f8791b5f30da16b DIFF: https://github.com/llvm/llvm-project/commit/3647ff159a2f2445c45d9cbb4f8791b5f30da16b.diff LO

[Lldb-commits] [lldb] 1ec8197 - Temporarily skip this test for Python 3.9.

2024-02-13 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2024-02-13T16:51:55-08:00 New Revision: 1ec81976e4937ea9a09cefd41f25b3c5d1394f2c URL: https://github.com/llvm/llvm-project/commit/1ec81976e4937ea9a09cefd41f25b3c5d1394f2c DIFF: https://github.com/llvm/llvm-project/commit/1ec81976e4937ea9a09cefd41f25b3c5d1394f2c.diff LO

[Lldb-commits] [lldb] [lldb-dap] Followup fixs for data breakpoints (PR #81680)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const llvm::json::Object &request) { body.try_emplace("description", error_cstr && error_cstr[0] ? std::string(error_cstr) : "evalu

[Lldb-commits] [lldb] [lldb-dap] Followup fixs for data breakpoints (PR #81680)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const llvm::json::Object &request) { body.try_emplace("description", error_cstr && error_cstr[0] ? std::string(error_cstr) : "evalu

[Lldb-commits] [lldb] [lldb-dap] Followup fixs for data breakpoints (PR #81680)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const llvm::json::Object &request) { body.try_emplace("description", error_cstr && error_cstr[0] ? std::string(error_cstr) : "evalu

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandObjectProcessHandle::VerifyCommandOptionValue (PR #79901)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -1666,33 +1646,52 @@ class CommandObjectProcessHandle : public CommandObjectParsed { // the user's options. ProcessSP process_sp = target.GetProcessSP(); -int stop_action = -1; // -1 means leave the current setting alone -int pass_action = -1; // -1 mea

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM with the Initialize/Terminate removed as they're not needed anymore. https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-13 Thread Jonas Devlieghere via lldb-commits
@@ -119,6 +120,32 @@ class Progress { bool m_complete = false; }; +/// A class used to group progress reports by category. This is done by using a +/// map that maintains a refcount of each category of progress reports that have +/// come in. Keeping track of progress repor

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 22d2f3a - Move the parsed_cmd conversion def's to module level functions.

2024-02-13 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2024-02-13T18:08:02-08:00 New Revision: 22d2f3aa3097feb9a91c6d7b8ef611a1cde6d0d5 URL: https://github.com/llvm/llvm-project/commit/22d2f3aa3097feb9a91c6d7b8ef611a1cde6d0d5 DIFF: https://github.com/llvm/llvm-project/commit/22d2f3aa3097feb9a91c6d7b8ef611a1cde6d0d5.diff LO

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-13 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/81703 Switching to modern `unittest` in 5b386158aacac4b41126983a5379d36ed413d0ea needs xfail annotations to be known prior to test running. In contrast, skipping can happen at any time, even during test execution.

[Lldb-commits] [lldb] [lldb][test] Remove expectedFailureIfFn (PR #81703)

2024-02-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes Switching to modern `unittest` in 5b386158aacac4b41126983a5379d36ed413d0ea needs xfail annotations to be known prior to test running. In contrast, skipping can happen at any time, even during test execu

[Lldb-commits] [lldb] [lldb] Add more ways to find the .dwp file. (PR #81067)

2024-02-13 Thread Greg Clayton via lldb-commits
clayborg wrote: > > I am fine with telling people what to do and giving them a golden path to > > what is easiest for our debuggers. And I will suggest to everyone that they > > use `.debug` and `.dwp`, but if we want to only support this, this leaves > > the downloading of the `.debug` file r

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/81706 Currently running `statistics dump` will trigger lldb to load debug info that's not yet loaded (eg. dwo files). Resulted in a delay in the command return, which, can be interrupting. This patch also added a new

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes Currently running `statistics dump` will trigger lldb to load debug info that's not yet loaded (eg. dwo files). Resulted in a delay in the command return, which, can be interrupting. This patch also added a new opt

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/81706 >From 8cfd1ee9629ce8069cc8fe8f4150e9fc0f5d5ee6 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Mon, 5 Feb 2024 11:33:03 -0800 Subject: [PATCH 1/3] Only report total currently loaded debug info --- lldb/include/ll

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 61c83e9491b2be71a54b255cdb11f65365245953 497b0a76501923afc169922c3aab9e92fb00c511 --

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 61c83e9491b2be71a54b255cdb11f65365245953...497b0a76501923afc169922c3aab9e92fb00c511 lldb/

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -24,6 +24,9 @@ class LLDB_API SBStatisticsOptions { void SetSummaryOnly(bool b); bool GetSummaryOnly(); + + void SetForceLoading(bool b); clayborg wrote: Need headerdoc for these. https://github.com/llvm/llvm-project/pull/81706

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -24,6 +24,9 @@ class LLDB_API SBStatisticsOptions { void SetSummaryOnly(bool b); bool GetSummaryOnly(); + + void SetForceLoading(bool b); + bool GetForceLoading(); clayborg wrote: The `SetForceLoading` name doesn't clearly indicate to us what we ar

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -186,7 +186,19 @@ class SymbolFileDWARF : public SymbolFileCommon { GetMangledNamesForFunction(const std::string &scope_qualified_name, std::vector &mangled_names) override; - uint64_t GetDebugInfoSize() override; + /// Get total currently l

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -132,6 +132,7 @@ struct ConstStringStats { struct StatisticsOptions { bool summary_only = false; + bool force_loading = false; clayborg wrote: Maybe `load_all_debug_info` is more clear? https://github.com/llvm/llvm-project/pull/81706 __

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -391,7 +392,14 @@ class SymbolFile : public PluginInterface { /// entire file should be returned. The default implementation of this /// function will iterate over all sections in a module and add up their /// debug info only section byte sizes. - virtual uint64_t Get

[Lldb-commits] [lldb] Report only loaded debug info in statistics dump (PR #81706)

2024-02-13 Thread Greg Clayton via lldb-commits
@@ -1419,6 +1419,10 @@ let Command = "statistics dump" in { def statistics_dump_all: Option<"all-targets", "a">, Group<1>, Desc<"Include statistics for all targets.">; def statistics_dump_summary: Option<"summary", "s">, Group<1>, -Desc<"Dump only high-level summary

[Lldb-commits] [lldb] [lldb] Add more ways to find the .dwp file. (PR #81067)

2024-02-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/81067 >From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 7 Feb 2024 16:43:50 -0800 Subject: [PATCH 1/5] Add more ways to find the .dwp file. When using split DWARF w

[Lldb-commits] [lldb] [lldb] Fix the flakey Concurrent tests on macOS (PR #81710)

2024-02-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/81710 The concurrent tests all do a pthread_join at the end, and concurrent_base.py stops after that pthread_join and sanity checks that only 1 thread is running. On macOS, after pthread_join() has completed, th

[Lldb-commits] [lldb] [lldb] Fix the flakey Concurrent tests on macOS (PR #81710)

2024-02-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/81710 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the flakey Concurrent tests on macOS (PR #81710)

2024-02-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The concurrent tests all do a pthread_join at the end, and concurrent_base.py stops after that pthread_join and sanity checks that only 1 thread is running. On macOS, after pthread_join() has completed

<    1   2