[Lldb-commits] [lldb] Support statistics dump summary only mode (PR #80745)

2024-02-06 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/80745 >From e5902abd4cd401f5e6a132d1fa5d0b2197512494 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Fri, 2 Feb 2024 15:42:01 -0800 Subject: [PATCH 1/5] Support statistics dump summary only mode Summary: Added a new --s

[Lldb-commits] [lldb] 2217837 - Support statistics dump summary only mode (#80745)

2024-02-06 Thread via lldb-commits
Author: Wanyi Date: 2024-02-06T19:47:34-05:00 New Revision: 2217837c3377c22bffb6c498a732ce4672b8b535 URL: https://github.com/llvm/llvm-project/commit/2217837c3377c22bffb6c498a732ce4672b8b535 DIFF: https://github.com/llvm/llvm-project/commit/2217837c3377c22bffb6c498a732ce4672b8b535.diff LOG: Su

[Lldb-commits] [lldb] Support statistics dump summary only mode (PR #80745)

2024-02-06 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/80745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support statistics dump summary only mode (PR #80745)

2024-02-06 Thread via lldb-commits
@@ -2687,7 +2687,7 @@ uint64_t SymbolFileDWARF::GetDebugInfoSize() { if (cu == nullptr) continue; -SymbolFileDWARFDwo *dwo = cu->GetDwoSymbolFile(); +SymbolFileDWARFDwo *dwo = cu->GetDwoSymbolFile(false); kusmour wrote: Will put a new PR to

[Lldb-commits] [lldb] Revert "Support statistics dump summary only mode" (PR #80915)

2024-02-06 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/80915 Reverts llvm/llvm-project#80745 Buildbots broke for linux >From 0542e00e3a5753fe7e724b2d0e75224f8aa4df1f Mon Sep 17 00:00:00 2001 From: Wanyi Date: Tue, 6 Feb 2024 20:04:15 -0500 Subject: [PATCH] Revert "Support

[Lldb-commits] [lldb] Revert "Support statistics dump summary only mode" (PR #80915)

2024-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes Reverts llvm/llvm-project#80745 Buildbots broke for linux --- Patch is 28.12 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/80915.diff 19 Files Affected: - (modified)

[Lldb-commits] [lldb] Revert "Support statistics dump summary only mode" (PR #80915)

2024-02-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 44767278650227b30cf969170dc139197ce4338d 0542e00e3a5753fe7e724b2d0e75224f8aa4df1f --

[Lldb-commits] [lldb] Revert "Support statistics dump summary only mode" (PR #80915)

2024-02-06 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/80915 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

2024-02-06 Thread David Blaikie via lldb-commits
dwblaikie wrote: Be great to see D101950 picked up again, so I'm glad to hear that's being looked at. Be nice to get some way to address this regression sooner rather than later... & yeah, I'd argue that classes derived from DWARF are not complete - nested types, member function templates, s

[Lldb-commits] [lldb] Fix the Docstring.i filename (PR #80917)

2024-02-06 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/80917 The typo DocStrings.i broke linux buildbots >From 521999b878916cb494ba318a669a5bc7196fdcb2 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Tue, 6 Feb 2024 17:22:21 -0800 Subject: [PATCH] Fix the Docstring.i filena

[Lldb-commits] [lldb] Fix the Docstring.i filename (PR #80917)

2024-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes The typo DocStrings.i broke linux buildbots --- Full diff: https://github.com/llvm/llvm-project/pull/80917.diff 1 Files Affected: - (renamed) lldb/bindings/interface/SBStatisticsOptionsDocstrings.i () `

[Lldb-commits] [lldb] Fix the Docstring.i filename (PR #80917)

2024-02-06 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/80917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6d26857 - Fix the Docstring.i filename (#80917)

2024-02-06 Thread via lldb-commits
Author: Wanyi Date: 2024-02-06T20:26:08-05:00 New Revision: 6d268577259071cb1d9cccd89006bae8570f6c51 URL: https://github.com/llvm/llvm-project/commit/6d268577259071cb1d9cccd89006bae8570f6c51 DIFF: https://github.com/llvm/llvm-project/commit/6d268577259071cb1d9cccd89006bae8570f6c51.diff LOG: Fi

[Lldb-commits] [lldb] Don't count all the frames just to skip the current inlined ones. (PR #80918)

2024-02-06 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/80918 The algorithm to find the DW_OP_entry_value requires you to find the nearest non-inlined frame. It did that by counting the number of stack frames so that it could use that as a loop stopper. That is unneces

[Lldb-commits] [lldb] Don't count all the frames just to skip the current inlined ones. (PR #80918)

2024-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The algorithm to find the DW_OP_entry_value requires you to find the nearest non-inlined frame. It did that by counting the number of stack frames so that it could use that as a loop stopper. That is unnecessary

[Lldb-commits] [lldb] Don't count all the frames just to skip the current inlined ones. (PR #80918)

2024-02-06 Thread via lldb-commits
jimingham wrote: I found this looking though a bunch of samples to see why some operation was slow, and a good bit of the time was this unnecessary counting the stack. Except for performance, this is not easily observable, I couldn't figure out how to write a robust test. https://github.com/l

[Lldb-commits] [lldb] Don't count all the frames just to skip the current inlined ones. (PR #80918)

2024-02-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2f490583c368627f552c71e340c39f2b55c0526c c76edeec5c7430cd352c4d0ca977445800c55666 --

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. I'm happy w/ the name. Thanks! https://github.com/llvm/llvm-project/pull/80890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] Don't count all the frames just to skip the current inlined ones. (PR #80918)

2024-02-06 Thread Alex Langford via lldb-commits
@@ -608,11 +608,10 @@ static bool Evaluate_DW_OP_entry_value(std::vector &stack, StackFrameSP parent_frame = nullptr; addr_t return_pc = LLDB_INVALID_ADDRESS; uint32_t current_frame_idx = current_frame->GetFrameIndex(); - uint32_t num_frames = thread->GetStackFrameCount

[Lldb-commits] [lldb] Don't count all the frames just to skip the current inlined ones. (PR #80918)

2024-02-06 Thread Greg Clayton via lldb-commits
@@ -608,11 +608,10 @@ static bool Evaluate_DW_OP_entry_value(std::vector &stack, StackFrameSP parent_frame = nullptr; addr_t return_pc = LLDB_INVALID_ADDRESS; uint32_t current_frame_idx = current_frame->GetFrameIndex(); - uint32_t num_frames = thread->GetStackFrameCount

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Greg Clayton via lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in { Global, DefaultTrue, Desc<"Control the use of external tools and repositories to locate symbol files. Directories listed in target.debug-file-search-paths and directory of the executable are always checked first

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Greg Clayton via lldb-commits
@@ -47,6 +47,26 @@ class UUID; class VariableList; struct ModuleFunctionSearchOptions; +static constexpr OptionEnumValueElement g_download_enum_values[] = { +{ +lldb::eSymbolDownloadOff, +"off", +"Disable downloading symbols.", +}, +{ +

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Greg Clayton via lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in { Global, DefaultTrue, Desc<"Control the use of external tools and repositories to locate symbol files. Directories listed in target.debug-file-search-paths and directory of the executable are always checked first

[Lldb-commits] [lldb] [lldb] DRAFT - Add `Status::Detail` type to hold information from diagnostics (PR #80936)

2024-02-06 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete created https://github.com/llvm/llvm-project/pull/80936 This is a work in progress that lets `Status` instances separately store multiple messages such as errors, warnings, and/or notes. This approach can help break the anti-pattern where code that creates or modi

[Lldb-commits] [lldb] [lldb] DRAFT - Print multiple messages with line art that goes from each indicator (PR #80938)

2024-02-06 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete created https://github.com/llvm/llvm-project/pull/80938 This changes the way `dwim` and `expr` commands display 1 or more errors, warnings, and remarks with line art in a style that inspires the name "pan flute". ### Before The way it looks today. https://github.

[Lldb-commits] [lldb] [lldb] DRAFT - Print multiple messages with line art that goes from each indicator (PR #80938)

2024-02-06 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/80938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] DRAFT - Print multiple messages with line art that goes from each indicator (PR #80938)

2024-02-06 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/80938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] DRAFT - Add `Status::Detail` type to hold information from diagnostics (PR #80936)

2024-02-06 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/80936 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in { Global, DefaultTrue, Desc<"Control the use of external tools and repositories to locate symbol files. Directories listed in target.debug-file-search-paths and directory of the executable are always checked first

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in { Global, DefaultTrue, Desc<"Control the use of external tools and repositories to locate symbol files. Directories listed in target.debug-file-search-paths and directory of the executable are always checked first

[Lldb-commits] [lldb] [lldb] Expand background symbol lookup (PR #80890)

2024-02-06 Thread Jason Molenda via lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in { Global, DefaultTrue, Desc<"Control the use of external tools and repositories to locate symbol files. Directories listed in target.debug-file-search-paths and directory of the executable are always checked first

<    1   2