@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -403,6 +403,22 @@ void GDBRemoteCommunicationClient::GetRemoteQSupported() {
x.split(compressions, ',');
if (!compressions.empty())
MaybeEnableCompression(compressions);
+ } else if (x.consume_front("SupportedWatchpointTypes=")) {
+llvm
DavidSpickett wrote:
> What happens now is that there is a ProcessGDBRemote that registers for
> gdb-remote and it is returned by Process::FindPlugin. > Then there is the new
> ProcessWasm which might also register for the same gdb-remote maybe.
> But the problem is that at the moment when we s
https://github.com/dstutt updated
https://github.com/llvm/llvm-project/pull/67104
>From 259138920126f09149b488fc54e8d2a7da969ca4 Mon Sep 17 00:00:00 2001
From: David Stuttard
Date: Thu, 24 Aug 2023 16:45:50 +0100
Subject: [PATCH 1/4] [AMDGPU] Add pal metadata 3.0 support to callable pal
funcs
xujuntwt95329 wrote:
> > On the other hand, as a managed language, I think most people won't need to
> > read specific local/global of an instance, just like most of the JavaScript
> > developer won't care about the value of a register in V8 during debugging,
> > they just care about the value
@@ -1127,10 +1131,16 @@ void AMDGPUAsmPrinter::emitPALFunctionMetadata(const
MachineFunction &MF) {
MD->setFunctionScratchSize(FnName, MFI.getStackSize());
const GCNSubtarget &ST = MF.getSubtarget();
- // Set compute registers
- MD->setRsrc1(CallingConv::AMDGPU_CS,
-
DavidSpickett wrote:
> I don't know specifically why we skip those tests on our bot. Could be that
> the Windows APIs are target specific like ptrace is, > and we just didn't
> implement it for Windows on Arm yet, could be that the hardware we have
> doesn't support it.
>
> I'll found out wha
DavidSpickett wrote:
Unlikely even that given the range breakpoint stuff is all on AArch64 anyway.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
xujuntwt95329 wrote:
> > I see, thanks for the clarification. In the patch, the WasmLocal and
> > WasmGlobal calls are done in ReadRegister, so it seems like those are being
> > presented as register values? `register read` should show them. BTW, we
> > shouldn't make a top level `wasm` comman
https://github.com/dstutt updated
https://github.com/llvm/llvm-project/pull/67104
>From 259138920126f09149b488fc54e8d2a7da969ca4 Mon Sep 17 00:00:00 2001
From: David Stuttard
Date: Thu, 24 Aug 2023 16:45:50 +0100
Subject: [PATCH 1/5] [AMDGPU] Add pal metadata 3.0 support to callable pal
funcs
@@ -1127,10 +1131,16 @@ void AMDGPUAsmPrinter::emitPALFunctionMetadata(const
MachineFunction &MF) {
MD->setFunctionScratchSize(FnName, MFI.getStackSize());
const GCNSubtarget &ST = MF.getSubtarget();
- // Set compute registers
- MD->setRsrc1(CallingConv::AMDGPU_CS,
-
@@ -1025,6 +1025,26 @@ void AMDGPUAsmPrinter::EmitProgramInfoSI(const
MachineFunction &MF,
OutStreamer->emitInt32(MFI->getNumSpilledVGPRs());
}
+// Helper function to add common PAL Metadata 3.0+
+static void EmitPALMetadataCommon(AMDGPUPALMetadata *MD,
+
@@ -1025,6 +1025,26 @@ void AMDGPUAsmPrinter::EmitProgramInfoSI(const
MachineFunction &MF,
OutStreamer->emitInt32(MFI->getNumSpilledVGPRs());
}
+// Helper function to add common PAL Metadata 3.0+
+static void EmitPALMetadataCommon(AMDGPUPALMetadata *MD,
+
@@ -1025,6 +1025,26 @@ void AMDGPUAsmPrinter::EmitProgramInfoSI(const
MachineFunction &MF,
OutStreamer->emitInt32(MFI->getNumSpilledVGPRs());
}
+// Helper function to add common PAL Metadata 3.0+
+static void EmitPALMetadataCommon(AMDGPUPALMetadata *MD,
+
@@ -1025,6 +1025,26 @@ void AMDGPUAsmPrinter::EmitProgramInfoSI(const
MachineFunction &MF,
OutStreamer->emitInt32(MFI->getNumSpilledVGPRs());
}
+// Helper function to add common PAL Metadata 3.0+
+static void EmitPALMetadataCommon(AMDGPUPALMetadata *MD,
+
https://github.com/dstutt updated
https://github.com/llvm/llvm-project/pull/67104
>From 259138920126f09149b488fc54e8d2a7da969ca4 Mon Sep 17 00:00:00 2001
From: David Stuttard
Date: Thu, 24 Aug 2023 16:45:50 +0100
Subject: [PATCH 1/6] [AMDGPU] Add pal metadata 3.0 support to callable pal
funcs
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 84ea236af9f36d409d2c45c66f8a8b6eb027935d
2f727b08b894bca7c0c8aec2fdaffe536f8348d6 --
@@ -862,14 +862,18 @@ static void instrumentOneFunc(
auto Name = FuncInfo.FuncNameVar;
auto CFGHash = ConstantInt::get(Type::getInt64Ty(M->getContext()),
FuncInfo.FunctionHash);
+ // Make sure that pointer to global is passed in with zero
https://github.com/dstutt updated
https://github.com/llvm/llvm-project/pull/67104
>From 259138920126f09149b488fc54e8d2a7da969ca4 Mon Sep 17 00:00:00 2001
From: David Stuttard
Date: Thu, 24 Aug 2023 16:45:50 +0100
Subject: [PATCH 1/7] [AMDGPU] Add pal metadata 3.0 support to callable pal
funcs
https://github.com/JMazurkiewicz updated
https://github.com/llvm/llvm-project/pull/74534
>From aaccb9e13618517803df1230741b02b4c5ee08c7 Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Tue, 5 Dec 2023 23:36:57 +0100
Subject: [PATCH 1/6] [libc++] P2602R2 Poison Pills are Too Toxic
---
l
Author: David Spickett
Date: 2024-02-05T15:25:16Z
New Revision: ae92f6e8aeb97e39b95a40fde8a176f6aff94063
URL:
https://github.com/llvm/llvm-project/commit/ae92f6e8aeb97e39b95a40fde8a176f6aff94063
DIFF:
https://github.com/llvm/llvm-project/commit/ae92f6e8aeb97e39b95a40fde8a176f6aff94063.diff
LOG
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/3] Add support for DW_OP_WASM_location to DWARFExpression
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo.
Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account.
https://github.com/llvm/llvm-project/pull/80567
@@ -45,15 +45,12 @@ class FormatCache {
void Set(lldb::TypeSummaryImplSP);
void Set(lldb::SyntheticChildrenSP);
};
- typedef std::map CacheMap;
- CacheMap m_map;
+ std::map m_entries;
adrian-prantl wrote:
Could this be a StringMap, or if we benefi
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/80375
>From 59e1499ec0afebb533c4952f079278341b957241 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 1 Feb 2024 18:07:51 -0800
Subject: [PATCH 1/4] Add commands frequency to statistics dump
---
lldb/inclu
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/80602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> @bulbazord in the most recent commit I moved this internal-only enum from
> lldb-enumerations.h to lldb-private-enumerations.h, but I need to use the
> constexpr templatey thing that LLDB_MARK_AS_BITMASK_ENUM() defines for the
> enum so I can use bit-wise | & operations with
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/80368
>From 3f3d7aeffe1d156efd4f54cdce6f6c6ca933da75 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 25 Jan 2024 11:05:02 +
Subject: [PATCH 1/2] [lldb] Add frame recognizer for __builtin_verbose_trap
Thi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/80368
>From 3f3d7aeffe1d156efd4f54cdce6f6c6ca933da75 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 25 Jan 2024 11:05:02 +
Subject: [PATCH 1/3] [lldb] Add frame recognizer for __builtin_verbose_trap
Thi
Author: Dave Lee
Date: 2024-02-05T10:49:46-08:00
New Revision: ac585ab71470d4f20c96a95b49e852ee1c967003
URL:
https://github.com/llvm/llvm-project/commit/ac585ab71470d4f20c96a95b49e852ee1c967003
DIFF:
https://github.com/llvm/llvm-project/commit/ac585ab71470d4f20c96a95b49e852ee1c967003.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/80602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-02-05T10:52:30-08:00
New Revision: 0c02ea05c8414e72339e2521d1fdae54e91569bb
URL:
https://github.com/llvm/llvm-project/commit/0c02ea05c8414e72339e2521d1fdae54e91569bb
DIFF:
https://github.com/llvm/llvm-project/commit/0c02ea05c8414e72339e2521d1fdae54e91569bb.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/80618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3055,8 +3055,8 @@ void CommandInterpreter::PrintCommandOutput(IOHandler
&io_handler,
}
std::lock_guard guard(io_handler.GetOutputMutex());
- if (had_output && INTERRUPT_REQUESTED(GetDebugger(),
-"Interrupted dumping command ou
@@ -307,7 +311,8 @@ llvm::json::Value DebuggerStats::ReportStatistics(Debugger
&debugger,
{"totalModuleCount", num_modules},
{"totalModuleCountHasDebugInfo", num_modules_has_debug_info},
{"totalModuleCountWithVariableErrors", num_modules_with_variable_errors}
@@ -1788,12 +1792,13 @@ class CommandObjectCommandsScriptDelete : public
CommandObjectParsed {
return;
}
const char *leaf_cmd = command[num_args - 1].c_str();
-llvm::Error llvm_error = container->RemoveUserSubcommand(leaf_cmd,
-
@@ -1644,8 +1647,9 @@ class CommandObjectCommandsScriptAdd : public
CommandObjectParsed,
llvm::Error llvm_error =
m_container->LoadUserSubcommand(m_cmd_name, new_cmd_sp, m_overwrite);
if (llvm_error)
-result.AppendErrorWithFormat("cannot add comma
@@ -355,6 +360,25 @@ def test_modules(self):
self.assertNotEqual(exe_module, None)
self.verify_keys(exe_module, 'module dict for "%s"' % (exe),
module_keys)
+def test_commands(self):
+"""
+Test "statistics dump" and the command information.
https://github.com/kusmour approved this pull request.
https://github.com/llvm/llvm-project/pull/80375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
+
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
--
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/80375
>From 59e1499ec0afebb533c4952f079278341b957241 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 1 Feb 2024 18:07:51 -0800
Subject: [PATCH 1/5] Add commands frequency to statistics dump
---
lldb/inclu
@@ -326,6 +326,48 @@ InstructionCost
RISCVTTIImpl::getShuffleCost(TTI::ShuffleKind Kind,
switch (Kind) {
default:
break;
+case TTI::SK_ExtractSubvector:
+ if (isa(SubTp) &&
+ LT.second.getVectorElementType() != MVT::i1) {
+unsigned TpReg
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/80368
>From 3f3d7aeffe1d156efd4f54cdce6f6c6ca933da75 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 25 Jan 2024 11:05:02 +
Subject: [PATCH 1/4] [lldb] Add frame recognizer for __builtin_verbose_trap
Thi
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
--
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
+
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/80375
>From 59e1499ec0afebb533c4952f079278341b957241 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 1 Feb 2024 18:07:51 -0800
Subject: [PATCH 1/6] Add commands frequency to statistics dump
---
lldb/inclu
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/80164
>From cfd0dcfa1f5fabd12cf4d7bf8d5a10bd324ace0a Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Wed, 31 Jan 2024 16:47:49 +
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
@@ -326,6 +326,48 @@ InstructionCost
RISCVTTIImpl::getShuffleCost(TTI::ShuffleKind Kind,
switch (Kind) {
default:
break;
+case TTI::SK_ExtractSubvector:
+ if (isa(SubTp) &&
+ LT.second.getVectorElementType() != MVT::i1) {
+unsigned TpReg
glandium wrote:
This broke the wasi-threads target:
`clang: error: version 'threads' in target triple 'wasm32-unknown-wasi-threads'
is invalid`
https://github.com/llvm/llvm-project/pull/78655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
Author: jeffreytan81
Date: 2024-02-05T13:17:29-08:00
New Revision: 76706090c2f672ae933798292bfa889f9e3dac3d
URL:
https://github.com/llvm/llvm-project/commit/76706090c2f672ae933798292bfa889f9e3dac3d
DIFF:
https://github.com/llvm/llvm-project/commit/76706090c2f672ae933798292bfa889f9e3dac3d.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/80375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/6] [lldb] Add QSupported key to report watchpoint types
sup
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/7] [lldb] Add QSupported key to report watchpoint types
sup
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
jasonmolenda wrote:
Thanks for the feedback Alex & David, I think this one might be good enough now.
https://github.com/llvm/llvm-project/pull/80376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/kusmour created
https://github.com/llvm/llvm-project/pull/80745
Added a new --summary option to statistics dump command so that it is much
light weight than the full version.
Per my benchmark against AdFinder, full statistics dump takes 20 ~ 30
seconds to complete while
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Wanyi (kusmour)
Changes
Added a new --summary option to statistics dump command so that it is much
light weight than the full version.
Per my benchmark against AdFinder, full statistics dump takes 20 ~ 30
seconds to complete while stat
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
76706090c2f672ae933798292bfa889f9e3dac3d...ebf4db52352c39f33e483affa2bcee88298b353a
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 76706090c2f672ae933798292bfa889f9e3dac3d
ebf4db52352c39f33e483affa2bcee88298b353a --
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/80745
>From 429a44aa6332440e879f7c5f91037741814d1a17 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Fri, 2 Feb 2024 15:42:01 -0800
Subject: [PATCH 1/2] Support statistics dump summary only mode
Summary:
Added a new --s
https://github.com/clayborg approved this pull request.
Looks great with the updates. Much more clear.
https://github.com/llvm/llvm-project/pull/80167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/alexey-bataev updated
https://github.com/llvm/llvm-project/pull/77529
>From 7440ee8ba235fd871af0999f66d5d6130456400b Mon Sep 17 00:00:00 2001
From: Alexey Bataev
Date: Tue, 9 Jan 2024 21:43:31 +
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
https://github.com/pzread updated
https://github.com/llvm/llvm-project/pull/80331
>From 70f54b51bef87bde5e3f5ee067c0f2414d34e915 Mon Sep 17 00:00:00 2001
From: Jerry Wu
Date: Thu, 1 Feb 2024 19:57:26 +
Subject: [PATCH 1/4] Add replaceWithZeroTripCheck to LoopLikeOpInterface
---
.../mlir/I
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
+
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
--
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/80745
>From 30d723ba9808c7a8109b11dd0f20b4d8808e9ad5 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Fri, 2 Feb 2024 15:42:01 -0800
Subject: [PATCH 1/2] Support statistics dump summary only mode
Summary:
Added a new --s
https://github.com/JDevlieghere approved this pull request.
LGTM if @DavidSpickett and @bulbazord are happy.
https://github.com/llvm/llvm-project/pull/80376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/80753
This adds a layer between `SounceBreakpoint`/`FunctionBreakpoint` and
`BreakpointBase` to have better separation and encapsulation so we are not
directly operating on `SBBreakpoint`.
I basically moved the `SB
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This adds a layer between `SounceBreakpoint`/`FunctionBreakpoint` and
`BreakpointBase` to have better separation and encapsulation so we are not
directly operating on `SBBreakpoint`.
I basically moved the `SB
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 41ea02261224446dadb1b1561d70137699255518
c4b767909a9ffc2a3015dc9021e4c265da0d877d --
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/80745
>From 36c84ce56e9ea288d64833aa1f927a7f97fd904c Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Fri, 2 Feb 2024 15:42:01 -0800
Subject: [PATCH 1/2] Support statistics dump summary only mode
Summary:
Added a new --s
https://github.com/hawkinsw commented:
Thank you for doing this! I hope that these little nits are helpful!
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/hawkinsw edited
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1412,4 +1412,7 @@ let Command = "trace schema" in {
let Command = "statistics dump" in {
def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
Desc<"Include statistics for all targets.">;
+ def statistics_dump_summary: Option<"summary", "s">, Group<1>,
+
@@ -1412,4 +1412,7 @@ let Command = "trace schema" in {
let Command = "statistics dump" in {
def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
Desc<"Include statistics for all targets.">;
+ def statistics_dump_summary: Option<"summary", "s">, Group<1>,
+
@@ -100,60 +101,91 @@ llvm::json::Value ConstStringStats::ToJSON() const {
return obj;
}
-json::Value TargetStats::ToJSON(Target &target) {
- CollectStats(target);
+json::Value TargetStats::ToJSON(Target &target, bool summary_only) {
+ json::Object target_metrics_json;
+
@@ -186,6 +186,10 @@ class SymbolFileDWARF : public SymbolFileCommon {
GetMangledNamesForFunction(const std::string &scope_qualified_name,
std::vector &mangled_names) override;
+ // Return total currently loaded debug info
hawki
@@ -74,7 +75,7 @@ json::Value ModuleStats::ToJSON() const {
if (!symfile_modules.empty()) {
json::Array symfile_ids;
-for (const auto symfile_id: symfile_modules)
+for (const auto symfile_id : symfile_modules)
hawkinsw wrote:
Is this just a whit
https://github.com/pzread updated
https://github.com/llvm/llvm-project/pull/80331
>From 70f54b51bef87bde5e3f5ee067c0f2414d34e915 Mon Sep 17 00:00:00 2001
From: Jerry Wu
Date: Thu, 1 Feb 2024 19:57:26 +
Subject: [PATCH 1/6] Add replaceWithZeroTripCheck to LoopLikeOpInterface
---
.../mlir/I
ZijunZhaoCCK wrote:
> This broke the wasi-threads target: `clang: error: version 'threads' in
> target triple 'wasm32-unknown-wasi-threads' is invalid`
Because `threads` is not in EnvironmentType list:
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/TargetParser/Triple.h#L231
@@ -0,0 +1,101 @@
+//===- LoopLikeInterfaceTest.cpp - Unit tests for Loop Like Interfaces.
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/pzread updated
https://github.com/llvm/llvm-project/pull/80331
>From 70f54b51bef87bde5e3f5ee067c0f2414d34e915 Mon Sep 17 00:00:00 2001
From: Jerry Wu
Date: Thu, 1 Feb 2024 19:57:26 +
Subject: [PATCH 1/7] Add replaceWithZeroTripCheck to LoopLikeOpInterface
---
.../mlir/I
@@ -220,6 +220,31 @@ def LoopLikeOpInterface :
OpInterface<"LoopLikeOpInterface"> {
/*defaultImplementation=*/[{
return ::mlir::failure();
}]
+>,
+InterfaceMethod<[{
+Add a zero-trip-check around the loop to check if the loop body is ever
+
glandium wrote:
We stumbled upon this downstream because we have jobs building wasi-sdk with
clang-trunk, and wasi-sdk builds some things with that target. It apparently
comes from https://github.com/WebAssembly/wasi-libc/pull/381
https://github.com/llvm/llvm-project/pull/78655
___
glandium wrote:
There's apparently also wasm32-wasi-preview2 and wasm32-wasi-pthread, which I
suppose are equally broken by this change.
https://github.com/llvm/llvm-project/pull/78655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -74,7 +75,7 @@ json::Value ModuleStats::ToJSON() const {
if (!symfile_modules.empty()) {
json::Array symfile_ids;
-for (const auto symfile_id: symfile_modules)
+for (const auto symfile_id : symfile_modules)
kusmour wrote:
Yes I can revert tha
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/80745
>From 36c84ce56e9ea288d64833aa1f927a7f97fd904c Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Fri, 2 Feb 2024 15:42:01 -0800
Subject: [PATCH 1/3] Support statistics dump summary only mode
Summary:
Added a new --s
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/80376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Okay, I made one more trivial change, I switched the `varname` field to `dest`
so it matched what argparse had, and I renamed the `usage` entry to `help` so
it matches the argparse usage as well.
https://github.com/llvm/llvm-project/pull/70734
_
jimingham wrote:
At this point, I'd like to get this in so I can iterate on it in future PR's
rather than churning this one. If folks have a bit to look over this, that
would be great. Thanks!
https://github.com/llvm/llvm-project/pull/70734
___
lld
ZijunZhaoCCK wrote:
> There's apparently also wasm32-wasi-preview2 and wasm32-wasi-pthread, which I
> suppose are equally broken by this change.
Yes, I think so. I think adding these environment types in wasi-libc repo could
help fix those errors.
https://github.com/llvm/llvm-project/pull/786
@@ -2687,7 +2687,7 @@ uint64_t SymbolFileDWARF::GetDebugInfoSize() {
if (cu == nullptr)
continue;
-SymbolFileDWARFDwo *dwo = cu->GetDwoSymbolFile();
+SymbolFileDWARFDwo *dwo = cu->GetDwoSymbolFile(false);
jeffreytan81 wrote:
Instead of hard-
glandium wrote:
> Yes, I think so. I think adding these environment types in wasi-libc repo
> could help fix those errors.
WDYM?
https://github.com/llvm/llvm-project/pull/78655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/80745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 166 matches
Mail list logo
