[Lldb-commits] [lldb] Don't cause a premature UpdateIfNeeded when checking in SBValue::GetSP (PR #80222)

2024-01-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes Don't cause a premature UpdateIfNeeded when checking whether an otherwise invalid SBValue with a useful error should be handed out from GetSP. This is a follow-on to e8a2fd5e7be2. In that change, I used GetError t

[Lldb-commits] [lldb] Don't cause a premature UpdateIfNeeded when checking in SBValue::GetSP (PR #80222)

2024-01-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a03a6e99647318a86ea398c42e241da43e3c550e c6d76783fce826f01fe4713e3cc58504d591aebf --

[Lldb-commits] [lldb] Don't cause a premature UpdateIfNeeded when checking in SBValue::GetSP (PR #80222)

2024-01-31 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/80222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Don't cause a premature UpdateIfNeeded when checking in SBValue::GetSP (PR #80222)

2024-01-31 Thread Greg Clayton via lldb-commits
@@ -458,7 +458,12 @@ class ValueObject { virtual bool GetDeclaration(Declaration &decl); // The functions below should NOT be modified by subclasses + // This gets the current error for this ValueObject, it may update the value + // to ensure that the error is up to date

[Lldb-commits] [lldb] Don't cause a premature UpdateIfNeeded when checking in SBValue::GetSP (PR #80222)

2024-01-31 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: LGTM with a possible rename mentioned in inline comments. Anyone else have anything? https://github.com/llvm/llvm-project/pull/80222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-31 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/79932 >From ee09231ea101d97c1607552e161adcfe911a23f5 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 29 Jan 2024 18:25:42 -0800 Subject: [PATCH 1/3] [lldb][DWARFIndex] Use IDX_parent to impl

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-31 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: @adrian-prantl I've added a log message with the `Error` itself being logged as well. That said, printing any information specific to the entry itself would require parsing other Form and, given that we already failed to parse one, I figured it would be better not to atte

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #80218)

2024-01-31 Thread via lldb-commits
@@ -2667,6 +2667,29 @@ static bool UpdateCompilerContextForSimpleTemplateNames(TypeQuery &match) { } return any_context_updated; } + +uint64_t SymbolFileDWARF::GetDebugInfoSize() { + DWARFDebugInfo &info = DebugInfo(); + uint32_t num_comp_units = info.GetNumUnits(); + +

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #80218)

2024-01-31 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/80218 >From abfec9a970dd5fb4d5612638e14208555afe582e Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 31 Jan 2024 15:53:46 -0800 Subject: [PATCH 1/3] Fix debug info size statistics for split dwarf --- .../

[Lldb-commits] [lldb] 147d7a6 - [lldb] Add support for large watchpoints in lldb (#79962)

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T21:03:38-08:00 New Revision: 147d7a64f8493e78669581097a3ff06c985aa3a1 URL: https://github.com/llvm/llvm-project/commit/147d7a64f8493e78669581097a3ff06c985aa3a1 DIFF: https://github.com/llvm/llvm-project/commit/147d7a64f8493e78669581097a3ff06c985aa3a1.diff

[Lldb-commits] [libcxx] [llvm] [lldb] [clang-tools-extra] [libc] [clang] [flang] [compiler-rt] [lld] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-31 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH 1/5] Make clang report invalid target versions for all environme

[Lldb-commits] [lldb] 3b76b86 - Add debug prints to diagnose a crash on arm-ubuntu bot

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T21:38:07-08:00 New Revision: 3b76b86491d13ced848f2ed6f411754f54befaba URL: https://github.com/llvm/llvm-project/commit/3b76b86491d13ced848f2ed6f411754f54befaba DIFF: https://github.com/llvm/llvm-project/commit/3b76b86491d13ced848f2ed6f411754f54befaba.diff

[Lldb-commits] [lldb] fdd98e5 - Skip 2 of the three test sets to narrow down the arm-ubuntu

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T22:06:23-08:00 New Revision: fdd98e506d77514d8cbd5099e8fc98130244f6ff URL: https://github.com/llvm/llvm-project/commit/fdd98e506d77514d8cbd5099e8fc98130244f6ff DIFF: https://github.com/llvm/llvm-project/commit/fdd98e506d77514d8cbd5099e8fc98130244f6ff.diff

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #80218)

2024-01-31 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/80218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 021a2b4 - Uncomment the 2GB max tests and see if that works on arm-ubuntu

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T22:58:38-08:00 New Revision: 021a2b4ba254eb9e06fece5c18e5596cbb4896e6 URL: https://github.com/llvm/llvm-project/commit/021a2b4ba254eb9e06fece5c18e5596cbb4896e6 DIFF: https://github.com/llvm/llvm-project/commit/021a2b4ba254eb9e06fece5c18e5596cbb4896e6.diff

[Lldb-commits] [lldb] 54f324f - Trying to refine which test is crashing on arm-ubuntu.

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T23:18:18-08:00 New Revision: 54f324f377a92a64fcc5c1d401da9b07bf50a2f1 URL: https://github.com/llvm/llvm-project/commit/54f324f377a92a64fcc5c1d401da9b07bf50a2f1 DIFF: https://github.com/llvm/llvm-project/commit/54f324f377a92a64fcc5c1d401da9b07bf50a2f1.diff

[Lldb-commits] [lldb] 90e6808 - Skip two WatchpointAlgorithm tests for 32-bit lldb's

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T23:58:06-08:00 New Revision: 90e68086d8fdbfb32dfc7e7e3498f44365274ce8 URL: https://github.com/llvm/llvm-project/commit/90e68086d8fdbfb32dfc7e7e3498f44365274ce8 DIFF: https://github.com/llvm/llvm-project/commit/90e68086d8fdbfb32dfc7e7e3498f44365274ce8.diff

[Lldb-commits] [lldb] eaa3d5e - Done iterating with arm-ubuntu bot, I see the problem test.

2024-01-31 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-01-31T23:58:06-08:00 New Revision: eaa3d5e26665ca85d488e9194b9fbe304db6fa21 URL: https://github.com/llvm/llvm-project/commit/eaa3d5e26665ca85d488e9194b9fbe304db6fa21 DIFF: https://github.com/llvm/llvm-project/commit/eaa3d5e26665ca85d488e9194b9fbe304db6fa21.diff

<    1   2