[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/79962 This patch is the next piece of work in my Large Watchpoint proposal, https://discourse.llvm.org/t/rfc-large-watchpoint-support-in-lldb/72116 This patch breaks a user's watchpoint into one or more Watchpoin

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes This patch is the next piece of work in my Large Watchpoint proposal, https://discourse.llvm.org/t/rfc-large-watchpoint-support-in-lldb/72116 This patch breaks a user's watchpoint into one or more Watch

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/79962 >From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 30 Jan 2024 00:16:30 -0800 Subject: [PATCH 1/2] [lldb] Add support for large watchpoints in lldb This p

[Lldb-commits] [libc] [libcxx] [compiler-rt] [lldb] [flang] [clang-tools-extra] [lld] [clang] [llvm] LLVM_FAULTMAPS section can be put after the DWARF section. (PR #77107)

2024-01-30 Thread Rafael Ávila de Espíndola via lldb-commits
espindola wrote: I no longer work on llvm: https://lists.llvm.org/pipermail/llvm-dev/2018-May/122922.html shamithoke ***@***.***> writes: > @espindola > > -- > Reply to this email directly or view it on GitHub: > https://github.com/llvm/llvm-project/pull/77107#issuecomment-1914952526 > You

[Lldb-commits] [lld] [flang] [clang] [clang-tools-extra] [libc] [libcxx] [llvm] [lldb] [compiler-rt] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via lldb-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79698 >From 39f64e6fa02392415f0e2776166d4451346e7e81 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 28 Jan 2024 01:17:32 +0800 Subject: [PATCH] [concepts] Set up an instantiation scope for constraint expressio

[Lldb-commits] [lld] [flang] [clang] [clang-tools-extra] [libc] [libcxx] [llvm] [lldb] [compiler-rt] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via lldb-commits
zyn0217 wrote: I'll try the CI again before landing it. https://github.com/llvm/llvm-project/pull/79698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread David Spickett via lldb-commits
@@ -86,20 +86,45 @@ def execute(self, test, litConfig): if timeoutInfo: return lit.Test.TIMEOUT, output -# Parse the dotest output from stderr. -result_regex = r"\((\d+) passes, (\d+) failures, (\d+) errors, (\d+) skipped, (\d+) expected fa

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/79945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: I ran this on Arm and AArch64 Linux. One test `lldb/test/API/functionalities/breakpoint/hardware_breakpoints/require_hw_breakpoints/TestRequireHWBreakpoints.py` was xfailed on AArch64 is now not. Before: ``` PASS: LLDB (/home/david.spickett/build-llvm-aarch64/bin/clang-aarc

[Lldb-commits] [lld] [clang] [llvm] [lldb] [clang-tools-extra] [libc] [compiler-rt] [libcxx] [flang] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #7

2024-01-30 Thread Younan Zhang via lldb-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79985 >From 7ee1874af426d7879d218c6b8852fca0a87b1836 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 30 Jan 2024 18:49:08 +0800 Subject: [PATCH] [concepts] Push a CurContext before substituting into out-of-line

[Lldb-commits] [lld] [clang] [llvm] [lldb] [clang-tools-extra] [libc] [compiler-rt] [libcxx] [flang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via lldb-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/79698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lld] [libc] [lldb] [llvm] [clang-tools-extra] [flang] [libcxx] [compiler-rt] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #7

2024-01-30 Thread Younan Zhang via lldb-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79985 >From 7ee1874af426d7879d218c6b8852fca0a87b1836 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 30 Jan 2024 18:49:08 +0800 Subject: [PATCH] [concepts] Push a CurContext before substituting into out-of-line

[Lldb-commits] [lldb] [lldb][gdb-remote][RISCV] Fix connection error to gdb server for RISC-V (PR #79990)

2024-01-30 Thread via lldb-commits
https://github.com/ita-sc created https://github.com/llvm/llvm-project/pull/79990 This patch fix connection for LLDB for remote gdb server running on RISC-V. You can test connection with OpenOCD or qemu-riscv64. >From 54cc2f5f35d64266a74e3192e6fefb03844359ea Mon Sep 17 00:00:00 2001 From: Ivan

[Lldb-commits] [lldb] [lldb][gdb-remote][RISCV] Fix connection error to gdb server for RISC-V (PR #79990)

2024-01-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (ita-sc) Changes This patch fix connection for LLDB for remote gdb server running on RISC-V. You can test connection with OpenOCD or qemu-riscv64. --- Full diff: https://github.com/llvm/llvm-project/pull/79990.diff 1 Files Affected:

[Lldb-commits] [openmp] [libc] [libcxx] [libcxxabi] [compiler-rt] [mlir] [flang] [libunwind] [lld] [llvm] [clang-tools-extra] [lldb] [clang] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 01/15] [clang] static operators should evaluate object argumen

[Lldb-commits] [openmp] [libc] [libcxx] [libcxxabi] [compiler-rt] [mlir] [flang] [libunwind] [lld] [llvm] [clang-tools-extra] [lldb] [clang] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
SuperSodaSea wrote: Ping @MitalAshok, are you happy with this PR? https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [compiler-rt] [lldb] [libcxxabi] [llvm] [clang-tools-extra] [lld] [flang] [libunwind] [libcxx] [mlir] [clang] [openmp] [clang] static operators should evaluate object argument (P

2024-01-30 Thread via lldb-commits
https://github.com/cor3ntin approved this pull request. Feel free to land this if he doesn't reply within the day. @AaronBallman can we backport that? It's a pretty nasty bug https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing lis

[Lldb-commits] [compiler-rt] [libcxxabi] [llvm] [lld] [mlir] [openmp] [libunwind] [clang-tools-extra] [clang] [libcxx] [lldb] [libc] [flang] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 01/15] [clang] static operators should evaluate object argumen

[Lldb-commits] [openmp] [lld] [clang-tools-extra] [flang] [compiler-rt] [clang] [lldb] [libunwind] [llvm] [libcxx] [libcxxabi] [mlir] [libc] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
SuperSodaSea wrote: Should be easy to backport using llvmbot once it is merged. https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7565ae6 - [lldb][test][NFC] Refactor xfails in TestRequireHWBreakpoints.py

2024-01-30 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-01-30T13:46:09Z New Revision: 7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe URL: https://github.com/llvm/llvm-project/commit/7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe DIFF: https://github.com/llvm/llvm-project/commit/7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe.diff LOG

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread David Spickett via lldb-commits
@@ -130,14 +130,14 @@ def expectedFailure_impl(func): def expectedFailureIfFn(expected_fn, bugnumber=None): def expectedFailure_impl(func): -if isinstance(func, type) and issubclass(func, unittest2.TestCase): +if isinstance(func, type) and issubclass(func,

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: I've simplified that strange xfail in https://github.com/llvm/llvm-project/commit/7565ae6eb99b6d3c5d83d04404a2df1b3785dbfe. Still seeing the tests fail instead of xfail though, see my comment. https://github.com/llvm/llvm-project/pull/79945

[Lldb-commits] [lldb] [lldb][RISCV] Fix connection error to gdb server for RISC-V (PR #79990)

2024-01-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/79990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Fix connection error to gdb server for RISC-V (PR #79990)

2024-01-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Fix connection error to gdb server for RISC-V (PR #79990)

2024-01-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/79990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8774d29 - [lldb][RISCV] Fix connection error to gdb server for RISC-V (#79990)

2024-01-30 Thread via lldb-commits
Author: ita-sc Date: 2024-01-30T14:02:49Z New Revision: 8774d2936dd1cf0ee8d74ff600359d465179d009 URL: https://github.com/llvm/llvm-project/commit/8774d2936dd1cf0ee8d74ff600359d465179d009 DIFF: https://github.com/llvm/llvm-project/commit/8774d2936dd1cf0ee8d74ff600359d465179d009.diff LOG: [lldb]

[Lldb-commits] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [libc] [flang] [clang] [lldb] [llvm] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #7

2024-01-30 Thread Erich Keane via lldb-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/79985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [mlir] [compiler-rt] [libcxx] [lld] [flang] [libcxxabi] [libc] [lldb] [libunwind] [openmp] [clang] [llvm] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
@@ -5865,10 +5867,24 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType, const CGCallee &OrigCallee break; } } + +if (const auto *MD = +dyn_cast_if_present(OCE->getCalleeDecl()); +MD && MD->isStatic()) + StaticOperator = true

[Lldb-commits] [lldb] [clang] [llvm] [libc] [compiler-rt] [lld] [libcxx] [clang-tools-extra] [libcxxabi] [flang] [SLP]Improve findReusedOrderedScalars and graph rotation. (PR #77529)

2024-01-30 Thread Alexey Bataev via lldb-commits
https://github.com/alexey-bataev updated https://github.com/llvm/llvm-project/pull/77529 >From 7440ee8ba235fd871af0999f66d5d6130456400b Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Tue, 9 Jan 2024 21:43:31 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[Lldb-commits] [lldb] [openmp] [clang] [llvm] [libc] [libcxx] [libcxxabi] [mlir] [flang] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXDefaultInitExpr (PR #80001)

2024-01-30 Thread via lldb-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/80001 >From 1e45decdaeb529904fd2076b9be42234dbd5a871 Mon Sep 17 00:00:00 2001 From: yronglin Date: Tue, 30 Jan 2024 21:11:48 +0800 Subject: [PATCH] [Clang] Dump the rewritten sub-expressions in CXXDefaultArgExpr/CXXD

[Lldb-commits] [lld] [clang-tools-extra] [clang] [flang] [openmp] [compiler-rt] [mlir] [llvm] [libc] [lldb] [libcxx] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-30 Thread Oleksandr Alex Zinenko via lldb-commits
https://github.com/ftynse approved this pull request. https://github.com/llvm/llvm-project/pull/79626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libcxx] [mlir] [flang] [llvm] [clang-tools-extra] [clang] [libc] [lldb] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-30 Thread Dawei Pan via lldb-commits
dwpan wrote: > Hello. Can you explain why this is needed, as opposed to using the equivalent > shift/and/ors? In Verilog/SystemVerilog language, the basic type is bit or bit vector, and length is arbitrary, insert/extract bits are common features in language. Introducing corresponding intrin

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > I ran this on Arm and AArch64 Linux. One test > `lldb/test/API/functionalities/breakpoint/hardware_breakpoints/require_hw_breakpoints/TestRequireHWBreakpoints.py` > was xfailed on AArch64 is now not. Before: > > ``` > PASS: LLDB (/home/david.spickett/build-llvm-aarch64/bin/c

[Lldb-commits] [clang-tools-extra] [lld] [clang] [flang] [compiler-rt] [llvm] [libc] [lldb] [libcxx] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-30 Thread Mariya Podchishchaeva via lldb-commits
Fznamznon wrote: Given the problem in https://github.com/llvm/llvm-project/pull/77753#issuecomment-1912258038 , @cor3ntin , @AaronBallman WDYT about adding new flags to `CXXRecordDecl`, saying that constructor/destructor is not really `constexpr` before C++23? https://github.com/llvm/llvm-pro

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libunwind] [clang-tools-extra] [libc] [mlir] [compiler-rt] [clang] [lld] [llvm] [openmp] [flang] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
@@ -5865,10 +5867,24 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType, const CGCallee &OrigCallee break; } } + +if (const auto *MD = +dyn_cast_if_present(OCE->getCalleeDecl()); +MD && MD->isStatic()) + StaticOperator = true

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [mlir] [clang-tools-extra] [libc] [compiler-rt] [clang] [lld] [llvm] [openmp] [flang] [mlir][transform] Add elementwise criteria to `match.structured.body` (

2024-01-30 Thread via lldb-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[Lldb-commits] [libcxx] [llvm] [mlir] [libcxxabi] [clang] [compiler-rt] [openmp] [flang] [lld] [clang-tools-extra] [libc] [lldb] [libunwind] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
@@ -5865,10 +5867,24 @@ RValue CodeGenFunction::EmitCall(QualType CalleeType, const CGCallee &OrigCallee break; } } + +if (const auto *MD = +dyn_cast_if_present(OCE->getCalleeDecl()); +MD && MD->isStatic()) + StaticOperator = true

[Lldb-commits] [libcxx] [llvm] [mlir] [libcxxabi] [clang] [compiler-rt] [openmp] [flang] [lld] [clang-tools-extra] [libc] [lldb] [libunwind] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: LGTM now, thank you for bearing with me! Do you need one of us to commit this on your behalf? https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [llvm] [libcxx] [libcxxabi] [compiler-rt] [openmp] [clang] [libc] [libunwind] [mlir] [clang-tools-extra] [lld] [flang] [lldb] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
SuperSodaSea wrote: Yeah, I'd be happy if anyone with write access could help. I'll create a backport issue after the commit. https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [libc] [compiler-rt] [mlir] [clang] [libcxx] [flang] [libcxxabi] [lld] [lldb] [llvm] [mlir][sparse] Expand LevelType to 64 bits and implement n out of m (PR #79935)

2024-01-30 Thread Yinying Li via lldb-commits
https://github.com/yinying-lisa-li updated https://github.com/llvm/llvm-project/pull/79935 >From fa5210448dea1f88d8e0a242543ad1be655087e0 Mon Sep 17 00:00:00 2001 From: Yinying Li Date: Tue, 30 Jan 2024 01:01:52 + Subject: [PATCH 1/3] [mlir][sparse] Expand LevelType to 64 bit and implement

[Lldb-commits] [libc] [mlir] [compiler-rt] [openmp] [clang-tools-extra] [clang] [libcxx] [flang] [libunwind] [libcxxabi] [lld] [lldb] [llvm] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [llvm] [mlir] [libcxxabi] [clang] [compiler-rt] [openmp] [flang] [lld] [clang-tools-extra] [libc] [lldb] [libunwind] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: > Yeah, I'd be happy if anyone with write access could help. I'll create a > backport issue after the commit. I've landed the changes, thank you for the fix and the offer to help backport! https://github.com/llvm/llvm-project/pull/68485 _

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread Adrian Prantl via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread Adrian Prantl via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread Adrian Prantl via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread Adrian Prantl via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [clang] [flang] [compiler-rt] [lld] [lldb] [libcxx] [llvm] [libc] [clang-tools-extra] [libcxxabi] Move ExpandMemCmp and MergeIcmp to the middle end (PR #77370)

2024-01-30 Thread Gabriel Baraldi via lldb-commits
gbaraldi wrote: Ok, it seems CI is finally a bit happier, not sure what was going on. @nikic what do you think is needed to get this in? https://github.com/llvm/llvm-project/pull/77370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [openmp] [mlir] [clang] [flang] [compiler-rt] [lld] [lldb] [libcxx] [libunwind] [llvm] [libc] [clang-tools-extra] [libcxxabi] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Nico Weber via lldb-commits
nico wrote: This might've broken clangd tests: http://45.33.8.238/linux/129484/step_9.txt Does that look related? If so, please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commit

[Lldb-commits] [openmp] [clang] [lldb] [libc] [compiler-rt] [flang] [libcxxabi] [libcxx] [llvm] [mlir] [clang-tools-extra] [lld] [mlir][transform] Add elementwise criteria to `match.structured.body` (

2024-01-30 Thread via lldb-commits
srcarroll wrote: anyone know what's up with the buildkite failure? https://github.com/llvm/llvm-project/pull/79626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [clang] [libc] [compiler-rt] [lldb] [flang] [openmp] [libcxx] [libunwind] [llvm] [mlir] [clang-tools-extra] [lld] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: Hmmm that does look related. I'll revert so we get back to green. CC @sam-mccall in case he has opinions on how we can ease tension between making fixes in Clang that impact clangd tests (clangd is a consumer of Clang and we usually expect consumers to react when their test

[Lldb-commits] [compiler-rt] [libc] [clang] [flang] [lldb] [libcxx] [llvm] [mlir] [clang-tools-extra] [OpenMP] atomic compare weak : Parser & AST support (PR #79475)

2024-01-30 Thread via lldb-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/79475 >From 6614e517cf0888b4502efc0af974d1612fa7a822 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Thu, 25 Jan 2024 10:37:20 -0600 Subject: [PATCH 1/3] Changes to Support Parsing & Sema of atomic comp

[Lldb-commits] [clang-tools-extra] [clang] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-30 Thread Andrey Ali Khan Bolshakov via lldb-commits
bolshakov-a wrote: @eaeltsin, could you try out [that branch](https://github.com/bolshakov-a/llvm-project/tree/avoid_regressions)? https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [flang] [mlir] [libunwind] [libcxx] [compiler-rt] [clang] [openmp] [llvm] [lld] [libcxxabi] [lldb] [clang-tools-extra] [libc] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Erich Keane via lldb-commits
erichkeane wrote: I have absolutely no idea how to fix it as I don't understand the syntax of the clangd tests, but it SEEMS like it is just a source-location type thing that is wrong? https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/unittests/InlayHintTests.cpp#L810 >F

[Lldb-commits] [libcxx] [flang] [clang-tools-extra] [compiler-rt] [mlir] [llvm] [lldb] [libc] [clang] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

2024-01-30 Thread Dawei Pan via lldb-commits
dwpan wrote: > Hello. Can you explain why this is needed, as opposed to using the equivalent > shift/and/ors? In Verilog/SystemVerilog language, the basic type is bit or bit vector, and length is arbitrary, insert/extract bits are common features in language. Introducing corresponding intrins

[Lldb-commits] [libc] [lldb] [libcxxabi] [llvm] [lld] [libcxx] [clang] [flang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [libcxx] [clang] [llvm] [lld] [libcxxabi] [lldb] [libc] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79924 >From 07043d27155ffd89e23b64c77a99880b2fa57e57 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 29 Jan 2024 17:02:18 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[Lldb-commits] [flang] [libcxx] [clang] [llvm] [lld] [libcxxabi] [lldb] [libc] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Fangrui Song via lldb-commits
MaskRay wrote: > LGTM in general. > > But the downside here is that the compiler won't be able to optimize away > repeated stores if they are transformed to memset calls. Maybe introduce some > threshold and only memset() sizes greater than, say, 64? (IIRC that's what > `-ftrivial-auto-var-in

[Lldb-commits] [flang] [libcxx] [clang] [llvm] [lld] [libcxxabi] [lldb] [libc] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79924 >From 07043d27155ffd89e23b64c77a99880b2fa57e57 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 29 Jan 2024 17:02:18 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[Lldb-commits] [flang] [compiler-rt] [mlir] [lldb] [openmp] [lld] [libunwind] [libcxx] [libcxxabi] [llvm] [clang] [clang-tools-extra] [libc] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
SuperSodaSea wrote: It seems that clangd doesn't like the new usage for the static operator of the CXXOperatorCallExpr, so the hint is misplaced. I'm looking into **clang-tools-extra/clangd/InlayHints.cpp** now... https://github.com/llvm/llvm-project/pull/68485

[Lldb-commits] [libunwind] [compiler-rt] [libcxx] [clang-tools-extra] [libcxxabi] [libc] [lld] [openmp] [mlir] [flang] [llvm] [clang] [lldb] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: CC @zyn0217 as the original author of that test case and @HighCommander4 as the original reviewer. https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79912 >From af9a5581702b5c9ca8009fc32c7ae10a1654d391 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 29 Jan 2024 15:29:46 -0800 Subject: [PATCH 1/2] [lldb][progress] Correctly check total for determin

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData { GetAsStructuredData(const Event *event_ptr); uint64_t GetID() const { return m_id; } - bool IsFinite() const { return m_total != UINT64_MAX; } + bool IsFinite() const { return m_total != 1; }

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,125 @@ +//===-- ProgressReportTest.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [llvm] [clang-tools-extra] [libc] [compiler-rt] [flang] [libcxx] [openmp] [clang] [libcxxabi] [lldb] [libunwind] [lld] [mlir] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
SuperSodaSea wrote: https://github.com/SuperSodaSea/llvm-project/blob/1ceaae47b2b43fd8fa5512e20e0b32a7e8f4ab5b/clang-tools-extra/clangd/InlayHints.cpp#L660-L664 ```diff if (const CXXMethodDecl *Method = dyn_cast_or_null(Callee.Decl)) - if (Method->isInstance() && -

[Lldb-commits] [llvm] [clang-tools-extra] [libc] [compiler-rt] [flang] [libcxx] [openmp] [clang] [libcxxabi] [lldb] [libunwind] [lld] [mlir] [clang] static operators should evaluate object argument (P

2024-01-30 Thread Tianlan Zhou via lldb-commits
SuperSodaSea wrote: By the way, maybe we should add a clangd label to this PR? https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/79912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I ran the test suite locally (macOS on arm64) and `TestRequireHWBreakpoints.py` is the only regression I found, but that's covered by the other PR. I'm happy to go ahead with landing both PRs and fixing the bots if there's fallout. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [lldb][test] Switch LLDB API tests from vendored unittest2 to unittest (PR #79945)

2024-01-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/79945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-30 Thread via lldb-commits
eaeltsin wrote: > @eaeltsin, could you try out [that > branch](https://github.com/bolshakov-a/llvm-project/tree/avoid_regressions)? @bolshakov-a yes, this patch makes the "undefined symbol" linker error go away. Will you proceed with submitting? https://github.com/llvm/llvm-project/pull/78

[Lldb-commits] [lldb] 733b86d - [lldb][progress] Correctly check total for deterministic progress (#79912)

2024-01-30 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-01-30T12:00:38-08:00 New Revision: 733b86d3ff8087f1e267c23eb315bb16e3c6c953 URL: https://github.com/llvm/llvm-project/commit/733b86d3ff8087f1e267c23eb315bb16e3c6c953 DIFF: https://github.com/llvm/llvm-project/commit/733b86d3ff8087f1e267c23eb315bb16e3c6c953.d

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/79912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-30 Thread Andrey Ali Khan Bolshakov via lldb-commits
bolshakov-a wrote: #80050 opened. Nevertheless, a reproducer for future work would be appreciated. https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Alex Langford via lldb-commits
@@ -0,0 +1,146 @@ +//===-- WatchpointAlgorithms.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I haven't looked at the algorithm in great detail yet but a lot of the surrounding stuff looks pretty reasonable I think. https://github.com/llvm/llvm-project/pull/79962 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Alex Langford via lldb-commits
@@ -0,0 +1,38 @@ +//===-- WatchpointAlgorithms.h *- C++ bulbazord wrote: The header needs adjustment https://github.com/llvm/llvm-project/pull/79962 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/79962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Alex Langford via lldb-commits
@@ -0,0 +1,38 @@ +//===-- WatchpointAlgorithms.h *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

2024-01-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: > > Thanks for the fix! I did test this patch with both our regression issue, > > and also allowing us to remove the double-lookup working around #53904 and > > can confirm it addressed both issues. Thanks again! > > Glad it worked! It will also be a huge improvement in the ex

[Lldb-commits] [libcxx] [llvm] [lld] [flang] [clang] [lldb] [libc] [libcxxabi] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Florian Mayer via lldb-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/79924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread David Blaikie via lldb-commits
@@ -0,0 +1,210 @@ +//===-- DWARFDIETest.cpp --=---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread David Blaikie via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread David Blaikie via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread David Blaikie via lldb-commits
@@ -0,0 +1,210 @@ +//===-- DWARFDIETest.cpp --=---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread David Blaikie via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [llvm] [lldb] [lld] [libc] [libcxx] [flang] [libcxxabi] [clang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Vitaly Buka via lldb-commits
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public InstVisitor { } if (!ElemTy->isSized()) return; -Value *SizeVal = - IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy)); +auto Size = DL.getTypeStoreSize(ElemTy); +Value *Siz

[Lldb-commits] [lldb] [lldb][DWARFIndex] Use IDX_parent to implement GetFullyQualifiedType query (PR #79932)

2024-01-30 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( m_fallback.GetCompleteObjCClass(class_name, must_be_implementation, callback); } +namespace { +using Entry = llvm::DWARFDebugNames::Entry; + +/// If `entry` and all of its parents have an `IDX_parent`, u

[Lldb-commits] [llvm] [lldb] [lld] [libc] [libcxx] [flang] [libcxxabi] [clang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Vitaly Buka via lldb-commits
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public InstVisitor { } if (!ElemTy->isSized()) return; -Value *SizeVal = - IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy)); +auto Size = DL.getTypeStoreSize(ElemTy); +Value *Siz

[Lldb-commits] [llvm] [lldb] [lld] [libc] [libcxx] [flang] [libcxxabi] [clang] [msan] Unpoison indirect outputs for userspace using llvm.memset.* (PR #79924)

2024-01-30 Thread Vitaly Buka via lldb-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/79924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

2024-01-30 Thread Greg Clayton via lldb-commits
clayborg wrote: The main issue we have is they way that clang works currently with the external AST source. We currently create a forward declaration type "struct Foo;" and we allow it to be completed once. Once it is completed clang expects the struct type to have everything that it needs, li

[Lldb-commits] [lldb] [llvm] [libcxxabi] [libcxx] [libc] [lld] [clang] [flang] [msan] Unpoison indirect outputs for userspace using memset for large operands (PR #79924)

2024-01-30 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/79924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

2024-01-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: How'd this work before your recent changes, then - when each repeated query would get one level further down in the nesting? How'd that work given the clang limitations you're describing? In any case, the extra clang requirements here seem like they might be of uncertain cost

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/79962 >From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 30 Jan 2024 00:16:30 -0800 Subject: [PATCH 1/3] [lldb] Add support for large watchpoints in lldb This p

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/79962 >From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 30 Jan 2024 00:16:30 -0800 Subject: [PATCH 1/4] [lldb] Add support for large watchpoints in lldb This p

[Lldb-commits] [lldb] [lldb] Add support for large watchpoints in lldb (PR #79962)

2024-01-30 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/79962 >From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 30 Jan 2024 00:16:30 -0800 Subject: [PATCH 1/5] [lldb] Add support for large watchpoints in lldb This p

[Lldb-commits] [lldb] [lldb] Fix a crash when using .dwp files and make type lookup reliable with the index cache (PR #79544)

2024-01-30 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/79544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a crash when using .dwp files and make type lookup reliable with the index cache (PR #79544)

2024-01-30 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. High level makes sense. Can you add test to ensure both dwarf4 & dwarf5 work? Also the modified test covers dwp, have you tested dwo without dwp scenario for completeness? https://github.com/llvm/llvm-project/pull/79544

[Lldb-commits] [lldb] [lldb] Fix a crash when using .dwp files and make type lookup reliable with the index cache (PR #79544)

2024-01-30 Thread via lldb-commits
@@ -1675,20 +1675,20 @@ Type *SymbolFileDWARF::ResolveType(const DWARFDIE &die, CompileUnit * SymbolFileDWARF::GetCompUnitForDWARFCompUnit(DWARFCompileUnit &dwarf_cu) { + if (dwarf_cu.IsDWOUnit()) { -DWARFCompileUnit *non_dwo_cu = -static_cast(dwarf_cu.GetUserDa

  1   2   >