https://github.com/boomanaiden154 closed
https://github.com/llvm/llvm-project/pull/76653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/78316
>From cf33d7ce01aafe0fa29b8a38a9824a0b03d24f05 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 16 Jan 2024 09:16:10 -0800
Subject: [PATCH 1/4] [clang] Fix assertion failure with deleted overl
@@ -1618,22 +1621,25 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
for (uint32_t i = 0; i < num_matches; ++i) {
Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]);
if (symbol) {
+Stream::HighlightSettings pattern_info(
+
@@ -260,10 +271,9 @@ class Stream {
/// The ANSI color code to end colorization. This is
/// environment-dependent.
- void PutCStringColorHighlighted(llvm::StringRef text,
- llvm::StringRef pattern = "",
-
@@ -262,14 +263,12 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
}
if (ConstString demangled = m_mangled.GetDemangledName()) {
s->PutCString(", name=\"");
-s->PutCStringColorHighlighted(demangled.GetStringRef(), pattern,
-
@@ -72,23 +72,20 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
-void Stream::PutCStringColorHighlighted(llvm::StringRef text,
-llvm::StringRef pattern,
-llvm::String
SuperSodaSea wrote:
Ping.
https://github.com/llvm/llvm-project/pull/68485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> Do you think the commit message is good enough?
The commit spends a lot of time talking about the previous PR not saying what
this PR does. "Follow up to #..." is enough to give context.
This PR puts all the highlighting settings into a single struct for easier
handling
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/78605
>From 48c6e5edc1dc5f832f8f5c922c61af9070ad341d Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Thu, 18 Jan 2024 09:09:50 -0800
Subject: [PATCH 1/8] Added settings for cache location and timeout
---
.../Debugi
zahiraam wrote:
@rjmccall thanks for the review and clarification. @andykaylor do you have any
other comments about this?
https://github.com/llvm/llvm-project/pull/78330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
zahiraam wrote:
@AaronBallman any comments about this? Thanks.
https://github.com/llvm/llvm-project/pull/78330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/AaronBallman commented:
I think the current changes are reasonable to land for Clang 18 so we get the
fix out to users. I don't have strong opinions on pushing this down into LLVM
or outlining the function like John suggested; either approach is fine by me. I
think outlining
@@ -2712,9 +2712,22 @@ static void EmitComplexRangeDiag(const Driver &D,
<< EnumComplexRangeToStr(Range1) << EnumComplexRangeToStr(Range2);
}
-static std::string RenderComplexRangeOption(std::string Range) {
+static std::string
+RenderComplexRangeOption(LangOptions::Co
jayfoad wrote:
Can you add a GFX12 RUN line to
clang/test/CodeGenOpenCL/builtins-amdgcn-fp8.cl? That will probably require
adding "fp8-conversion-insts" to the GFX12 part of TargetParser.cpp. You can do
this in a separate patch if you want.
https://github.com/llvm/llvm-project/pull/78414
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,10 @@
+# REQUIRES: x86
+# RUN: mkdir -p %t
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s
-o %t/hello.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/main.o
+# RUN: %lld -L %t %t/main.o %t/hello.o -o %t/a.out
---
@@ -90,6 +90,9 @@ static std::optional findLibrary(StringRef name) {
return entry->second;
auto doFind = [&] {
+// Special case for Csu support files.
oontvoo wrote:
nit: would be helpful to either expand what Csu are ... (not a very common
thing -
@@ -2712,9 +2712,22 @@ static void EmitComplexRangeDiag(const Driver &D,
<< EnumComplexRangeToStr(Range1) << EnumComplexRangeToStr(Range2);
}
-static std::string RenderComplexRangeOption(std::string Range) {
+static std::string
+RenderComplexRangeOption(LangOptions::Co
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/78628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From fb2383f3e6e2124e4f14e8e0f6a04df4bed15f65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 18 Jan 2024 20:03:25 -0300
Subject: [PATCH 1/2] refactor PutCStringColorHighlight |
@@ -1618,22 +1621,25 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
for (uint32_t i = 0; i < num_matches; ++i) {
Symbol *symbol = symtab->SymbolAtIndex(match_indexes[i]);
if (symbol) {
+Stream::HighlightSettings pattern_info(
+
@@ -260,10 +271,9 @@ class Stream {
/// The ANSI color code to end colorization. This is
/// environment-dependent.
- void PutCStringColorHighlighted(llvm::StringRef text,
- llvm::StringRef pattern = "",
-
cor3ntin wrote:
@SuperSodaSea I can merge this for you if both @MitalAshok and @shafik are
happy with it!
https://github.com/llvm/llvm-project/pull/68485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/78330
>From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 16 Jan 2024 11:24:03 -0800
Subject: [PATCH 1/5] Fixed a bug in Smith's algorithm and made sure last
option i
junior-jl wrote:
Last commit changes:
- Renamed `pattern_info` to `settings` in all of its uses.
- Moved `HighlightSettings` declaration outside `for` loop.
- Edited commit message as suggested.
> So you're asking about "stacked PRs" and I myself haven't tried this. LLVM
> has recently enabled
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> Question: Would be good/necessary to refactor LookupSymbolInModule into some
> smaller functions? At least separating the printing part?
Maybe this is me being used to monster functions in lldb, but this one seems
fi
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -23,6 +23,16 @@
namespace lldb_private {
+struct Information {
DavidSpickett wrote:
Looks like you already did this and yes it's a good thing, it means folks can't
forget to give all 3 bits of inform
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -178,8 +170,7 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
ansi_prefix = target_sp->GetDebugger().GetRegexMatchAnsiPrefix();
ansi_suffix = target_sp->GetDebugger().G
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -524,8 +525,7 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
ansi_suffix =
DavidSpickett wrote:
Is this unused now?
https://github.com/llvm/llvm-
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett commented:
Do a check for unused calls to getregexmatch, I found a few I think.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
l
@@ -836,36 +834,18 @@ Status PlatformDarwinKernel::GetSharedModuleKernel(
module_sp.reset(new Module(kern_spec));
if (module_sp && module_sp->GetObjectFile() &&
module_sp->MatchesModuleSpec(kern_spec)) {
-// module_sp is an actual kernel binary we
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -1609,6 +1612,11 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
}
if (num_matches > 0) {
+llvm::StringRef ansi_prefix =
+interpreter.GetDebugger().GetRegexMatchAnsiPrefix();
+
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/78605
>From 773740afcf9c54ef45a1178ee681ee46c29c9759 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Thu, 18 Jan 2024 09:09:50 -0800
Subject: [PATCH 1/8] Added settings for cache location and timeout
---
.../Debugi
mariusz-sikora-at-amd wrote:
> Can you add a GFX12 RUN line to
> clang/test/CodeGenOpenCL/builtins-amdgcn-fp8.cl? That will probably require
> adding "fp8-conversion-insts" to the GFX12 part of TargetParser.cpp. You can
> do this in a separate patch if you want.
Done
https://github.com/llvm/
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
@@ -4833,9 +4833,26 @@ void CXXNameMangler::mangleExpression(const Expr *E,
unsigned Arity,
E = cast(E)->getSubExpr();
goto recurse;
- case Expr::SubstNonTypeTemplateParmExprClass:
+ case Expr::SubstNonTypeTemplateParmExprClass: {
+// Mangle a substituted parame
https://github.com/AaronBallman commented:
Ping @rjmccall for Itanium mangling expertise to make sure we're matching the
spec.
There are a few merge conflicts that also cropped up which need to be resolved,
but overall I think this is pretty close to ready to try to re-land. It would
be nice
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6472,7 +6494,20 @@ void CXXNameMangler::mangleValueInTemplateArg(QualType
T, const APValue &V,
Out << "plcvPcad";
Kind = Offset;
} else {
- if (!V.getLValuePath().empty() || V.isLValueOnePastTheEnd()) {
+ // Clang 11 and before mangled an array su
@@ -5401,6 +5409,8 @@ std::string CGDebugInfo::GetName(const Decl *D, bool
Qualified) const {
// feasible some day.
return TA.getAsIntegral().getBitWidth() <= 64 &&
IsReconstitutableType(TA.getIntegralType());
+ case Template
https://github.com/OldWorldOrdr updated
https://github.com/llvm/llvm-project/pull/78628
>From e73fc2d0263e9e601f2964a90cfe347e8d2bb87c Mon Sep 17 00:00:00 2001
From: OldWorldOrdr
Date: Thu, 18 Jan 2024 16:20:52 -0500
Subject: [PATCH 1/4] [lld-macho] Find objects in library search path
---
lld
@@ -90,6 +90,9 @@ static std::optional findLibrary(StringRef name) {
return entry->second;
auto doFind = [&] {
+// Special case for Csu support files.
OldWorldOrdr wrote:
Is the new comment ok?
https://github.com/llvm/llvm-project/pull/78628
__
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5c150e7eeba9db13cc65b329b3c3537b613ae61d
e5c118067bd049da924010b26fe420267567eade --
junior-jl wrote:
> Maybe this is me being used to monster functions in lldb, but this one seems
> fine. At least the volume of code.
What you could do is "early return" (/early continue) in a couple of places to
reduce the indentation.
> 1. You could early return if there are no matches.
> 2.
Author: Jordan Rupprecht
Date: 2024-01-19T10:50:05-06:00
New Revision: d0d072710468316edbd4130e50f1146c5a6aca89
URL:
https://github.com/llvm/llvm-project/commit/d0d072710468316edbd4130e50f1146c5a6aca89
DIFF:
https://github.com/llvm/llvm-project/commit/d0d072710468316edbd4130e50f1146c5a6aca89.di
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/73067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> I see. But this would need to be in another PR, right?
Yes.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/OldWorldOrdr updated
https://github.com/llvm/llvm-project/pull/78628
>From e73fc2d0263e9e601f2964a90cfe347e8d2bb87c Mon Sep 17 00:00:00 2001
From: OldWorldOrdr
Date: Thu, 18 Jan 2024 16:20:52 -0500
Subject: [PATCH 1/5] [lld-macho] Find objects in library search path
---
lld
https://github.com/mordante approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/78215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -555,6 +556,7 @@ inline _LIBCPP_HIDE_FROM_ABI
_LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST _ValueType
template
inline _LIBCPP_HIDE_FROM_ABI add_pointer_t>
any_cast(any const* __any) _NOEXCEPT {
+ static_assert(!is_void_v<_ValueType>, "_ValueType may not be void.");
-
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/78215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -144,7 +144,8 @@ _LIBCPP_HIDE_FROM_ABI decltype(auto)
__visit_format_arg(_Visitor&& __vis, basic_
__libcpp_unreachable();
}
-# if _LIBCPP_STD_VER >= 26
+# if _LIBCPP_STD_VER >= 26 && (!defined(_LIBCPP_COMPILER_CLANG_BASED) ||
_LIBCPP_CLANG_VER >= 1800)
---
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/78486
>From b0a33481162e24a7106cbd554b33ddb098df7612 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 11:26:52 -0800
Subject: [PATCH 1/5] [lldb][DWARFUnit] Implement PeekDIEName qu
felipepiovezan wrote:
Make comments more grep-able.
https://github.com/llvm/llvm-project/pull/78486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From fb2383f3e6e2124e4f14e8e0f6a04df4bed15f65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 18 Jan 2024 20:03:25 -0300
Subject: [PATCH 1/3] refactor PutCStringColorHighlight |
https://github.com/OldWorldOrdr updated
https://github.com/llvm/llvm-project/pull/78628
>From e73fc2d0263e9e601f2964a90cfe347e8d2bb87c Mon Sep 17 00:00:00 2001
From: OldWorldOrdr
Date: Thu, 18 Jan 2024 16:20:52 -0500
Subject: [PATCH 1/4] [lld-macho] Find objects in library search path
---
lld
junior-jl wrote:
> Do a check for unused calls to getregexmatch, I found a few I think.
Done in the last commit. There was the two you mentioned and another one.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commit
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
LGTM.
Unless you've got commit access yourself, I can land this for you on Monday.
https://github.com/llvm/llvm-project/pull/76112
_
https://github.com/OldWorldOrdr updated
https://github.com/llvm/llvm-project/pull/78628
>From e73fc2d0263e9e601f2964a90cfe347e8d2bb87c Mon Sep 17 00:00:00 2001
From: OldWorldOrdr
Date: Thu, 18 Jan 2024 16:20:52 -0500
Subject: [PATCH 1/5] [lld-macho] Find objects in library search path
---
lld
OldWorldOrdr wrote:
Updated the test to verify the output
https://github.com/llvm/llvm-project/pull/78628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.l
junior-jl wrote:
> LGTM.
>
> Unless you've got commit access yourself, I can land this for you on Monday.
Great!
I don't have write access. So... as soon as this get merged, I'll open the
other PR!
Thanks again for the help here!
https://github.com/llvm/llvm-project/pull/76112
https://github.com/jansvoboda11 approved this pull request.
LGTM once CI passes and Flang conflicts are resolved.
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
mgorny wrote:
`LLVM_DIR` and `Clang_DIR` are merely hints to `find_package()`. If you need to
pass them, it simply means you haven't set `PATH` correctly and CMake can't
find installed LLVM/Clang. However, that shouldn't make any difference as long
as you provide paths to **installed** LLVM/Cl
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/77121
>From 6d5fec644004c4c1ad84ef29761306651f22fcf7 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 11:24:39 -0800
Subject: [PATCH 1/3] [llvm][DebugNames] Implement Entry::GetPar
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/78773
BroadcastEvent currently takes its EventData* param and shoves it into an Event
object, which takes ownership of the pointer and places it into a shared_ptr to
manage the lifetime.
Instead of relying on `new`
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
BroadcastEvent currently takes its EventData* param and shoves it into an Event
object, which takes ownership of the pointer and places it into a shared_ptr to
manage the lifetime.
Instead of relying on `
https://github.com/clayborg commented:
Looks good to me on the LLDB side, but you should probably get the ok from the
maintainers of the debug infod library for those changes.
https://github.com/llvm/llvm-project/pull/78605
___
lldb-commits mailing li
kevinfrei wrote:
> Looks good to me on the LLDB side, but you should probably get the ok from
> the maintainers of the debug infod library for those changes.
I think that was @mysterymath
https://github.com/llvm/llvm-project/pull/78605
___
lldb-commi
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/78655
>From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Fri, 19 Jan 2024 00:47:05 +
Subject: [PATCH] Make clang report invalid target versions for all
environment.
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/78655
>From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Fri, 19 Jan 2024 00:47:05 +
Subject: [PATCH] Make clang report invalid target versions for all
environment.
https://github.com/clayborg approved this pull request.
Now this is safe and all my issues are gone. Thanks for improving.
https://github.com/llvm/llvm-project/pull/78486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/mysterymath approved this pull request.
https://github.com/llvm/llvm-project/pull/78605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/78655
>From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Fri, 19 Jan 2024 00:47:05 +
Subject: [PATCH 1/2] Make clang report invalid target versions for all
environme
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/78811
lldb-dap instances managed by other extensions benefit from having a welcome
message with, for example, a basic user guide or a troubleshooting message.
This PR adds a cmake variable for defining such me
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
lldb-dap instances managed by other extensions benefit from having a welcome
message with, for example, a basic user guide or a troubleshooting message.
This PR adds a cmake variable for defining
walter-erquinigo wrote:
Merging this innocuous PR very quickly due to time constraints, but very happy
to apply any feedback in a subsequent PR.
https://github.com/llvm/llvm-project/pull/78811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Walter Erquinigo
Date: 2024-01-19T18:55:40-05:00
New Revision: 8bef2f27a0f7df05c7879186cc50fc8ec4a81132
URL:
https://github.com/llvm/llvm-project/commit/8bef2f27a0f7df05c7879186cc50fc8ec4a81132
DIFF:
https://github.com/llvm/llvm-project/commit/8bef2f27a0f7df05c7879186cc50fc8ec4a81132.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/78811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -664,7 +674,7 @@ void request_attach(const llvm::json::Object &request) {
// Run any initialize LLDB commands the user specified in the launch.json
if (llvm::Error err = g_dap.RunInitCommands()) {
-response["success"] = false;
+ response["success"] = false;
https://github.com/clayborg commented:
Looks like the typo will break the buildbots and we want the welcome message to
be printed for launches too right?
https://github.com/llvm/llvm-project/pull/78811
___
lldb-commits mailing list
lldb-commits@lists.
@@ -655,6 +663,8 @@ void request_attach(const llvm::json::Object &request) {
g_dap.SetFrameFormat(GetString(arguments, "customFrameFormat"));
g_dap.SetThreadFormat(GetString(arguments, "customThreadFormat"));
+ PrintWelcomeMessage();
clayborg wrote:
We w
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/78811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jie Fu
Date: 2024-01-20T08:09:20+08:00
New Revision: 904cf66ec1d4089e5e661eb996487ba132b97664
URL:
https://github.com/llvm/llvm-project/commit/904cf66ec1d4089e5e661eb996487ba132b97664
DIFF:
https://github.com/llvm/llvm-project/commit/904cf66ec1d4089e5e661eb996487ba132b97664.diff
LOG: [
felipepiovezan wrote:
> Now this is safe and all my issues are gone. Thanks for improving.
Thanks for spotting the issue with the first implementation!
https://github.com/llvm/llvm-project/pull/78486
___
lldb-commits mailing list
lldb-commits@lists.l
Author: Felipe de Azevedo Piovezan
Date: 2024-01-19T16:11:08-08:00
New Revision: 46845074557484a82f4dc73647dad399e1c00e89
URL:
https://github.com/llvm/llvm-project/commit/46845074557484a82f4dc73647dad399e1c00e89
DIFF:
https://github.com/llvm/llvm-project/commit/46845074557484a82f4dc73647dad399e
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/78486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/78817
None
>From 52b3baa5905b7562fc5872bae8a2f6599ec9e040 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Fri, 19 Jan 2024 16:17:17 -0800
Subject: [PATCH] [lldb] Skip ObjC timezone tests on macOS >= 14 (NFC)
---
.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/78817.diff
1 Files Affected:
- (modified)
lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
(+16-10)
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
I was thinking about DIE -> name stuff, and was wondering if we would benefit
from a cache of DIE offset to `DW_AT_name` and DIE offset to
`DW_AT_linkage_name`. Not sure how many times we might lookup DIE names
multiple times.
https://github.com/llvm/llvm-project/pull/78486
__
Author: Jason Molenda
Date: 2024-01-19T17:03:19-08:00
New Revision: bd3838ff6b4310fb8ff68649ef87e5e962bab1fd
URL:
https://github.com/llvm/llvm-project/commit/bd3838ff6b4310fb8ff68649ef87e5e962bab1fd
DIFF:
https://github.com/llvm/llvm-project/commit/bd3838ff6b4310fb8ff68649ef87e5e962bab1fd.diff
https://github.com/antangelo updated
https://github.com/llvm/llvm-project/pull/78670
>From 227504aa6da6dd2199c83563b9149dd3873e1a11 Mon Sep 17 00:00:00 2001
From: Antonio Abbatangelo
Date: Thu, 18 Jan 2024 23:27:16 -0500
Subject: [PATCH] Reland "[clang] Fix CTAD for aggregates for nested templa
antangelo wrote:
Thanks for the review! Apologies for the delayed response but I'm available to
merge this in now.
https://github.com/llvm/llvm-project/pull/78670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/antangelo closed
https://github.com/llvm/llvm-project/pull/78670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/78562
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/78215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/78157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 102 matches
Mail list logo
