DavidSpickett wrote:
> A WebAssembly debugging session can be started using the new command:
> wasm [:]
What about wasm requires a new command, given that you are connecting to a GDB
server as existing targets do.
https://github.com/llvm/llvm-project/pull/77949
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/78022
>From 0988bb25a35e5d50b44bf53d459098777280c3e5 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sat, 13 Jan 2024 16:00:16 +0800
Subject: [PATCH 1/3] [clang-tidy]Add new check
readability-avoid-nested-condit
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/78022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3358,14 +3396,17 @@ genOMP(Fortran::lower::AbstractConverter &converter,
.t);
// Currently only private/firstprivate clause is handled, and
// all privatization is done within `omp.section` operations.
+ symTable.pushScope();
skatrak wrot
https://github.com/skatrak approved this pull request.
Thanks for addressing my comments, LGTM.
https://github.com/llvm/llvm-project/pull/77758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/77758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -110,6 +110,34 @@ static void gatherFuncAndVarSyms(
}
}
+static Fortran::lower::pft::Evaluation *
+getCollapsedEval(Fortran::lower::pft::Evaluation &eval, int collapseValue) {
skatrak wrote:
Nit: Maybe `getCollapsedLoopEval` would be slightly more self-e
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/77758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kiranchandramohan approved this pull request.
LG.
Please add a pointer to the discussion where it was agreed to pass a reference
to the localSymbolTable.
https://github.com/llvm/llvm-project/pull/77758
___
lldb-commits mailing list
@@ -110,6 +110,34 @@ static void gatherFuncAndVarSyms(
}
}
+static Fortran::lower::pft::Evaluation *
+getCollapsedEval(Fortran::lower::pft::Evaluation &eval, int collapseValue) {
+ // Return the Evaluation of the innermost collapsed loop, or the current
+ // evaluation, if
@@ -80,6 +81,13 @@ class TemplateArgument {
/// that was provided for an integral non-type template parameter.
Integral,
+/// The template argument is a non-type template argument that can't be
+/// represented by the special-case Declaration, NullPtr, or Integ
cor3ntin wrote:
> > Should we add a couple of PCH tests ?
>
> [clang/test/Modules/odr_hash.cpp](https://github.com/llvm/llvm-project/pull/78041/files#diff-b0662120e3a8a2bf3ccd95b9e8943640816b457c00e662ebfdd648632e383314)
> should cover AST serialization/deserialization. But I could missing
> s
cor3ntin wrote:
I'm tempted to think that we should accept / merge this now @AaronBallman
The logic is that this is a pretty big hole in our C++20 support and I don't
think it's reasonable to try a merge after the deadline for 18. WDYT?
https://github.com/llvm/llvm-project/pull/78041
Author: Pavel Labath
Date: 2024-01-15T12:49:24Z
New Revision: 14268ad2a2ea0b3bbe6b767d67ace1d0ae992a6d
URL:
https://github.com/llvm/llvm-project/commit/14268ad2a2ea0b3bbe6b767d67ace1d0ae992a6d
DIFF:
https://github.com/llvm/llvm-project/commit/14268ad2a2ea0b3bbe6b767d67ace1d0ae992a6d.diff
LOG:
Endilll wrote:
> The logic is that this is a pretty big hole in our C++20 support and I don't
> think it's reasonable to try a merge after the deadline for 18. WDYT?
>From our past experience with release managers, they seem quite generous with
>deadlines to merge stuff in, as long as maintain
kparzysz wrote:
Here's link to my comment about symbol table in the thread, followed by
response from Valentin:
https://discourse.llvm.org/t/openmp-lowering-from-pft-to-fir/75263/49
https://github.com/llvm/llvm-project/pull/77758
___
lldb-commits mail
@@ -110,6 +110,34 @@ static void gatherFuncAndVarSyms(
}
}
+static Fortran::lower::pft::Evaluation *
+getCollapsedEval(Fortran::lower::pft::Evaluation &eval, int collapseValue) {
kparzysz wrote:
I'll make this change in another commit.
https://github.com/l
@@ -110,6 +110,34 @@ static void gatherFuncAndVarSyms(
}
}
+static Fortran::lower::pft::Evaluation *
+getCollapsedEval(Fortran::lower::pft::Evaluation &eval, int collapseValue) {
+ // Return the Evaluation of the innermost collapsed loop, or the current
+ // evaluation, if
https://github.com/kparzysz closed
https://github.com/llvm/llvm-project/pull/77758
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kparzysz edited
https://github.com/llvm/llvm-project/pull/77759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Fznamznon wrote:
Ping.
https://github.com/llvm/llvm-project/pull/73099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kparzysz wrote:
Suggested changed made in
https://github.com/llvm/llvm-project/commit/705d9273c5417e04dc542f0e46b90960c235c753.
The buildkite times are really long now (7h on Friday), and I didn't want to
delay merging of this PR by that much, plus the changes were really minor.
https://githu
https://github.com/CarlosAlbertoEnciso updated
https://github.com/llvm/llvm-project/pull/77901
>From cea029185ad219a4a0b6d03be00b0612675933ab Mon Sep 17 00:00:00 2001
From: Carlos Alberto Enciso
Date: Fri, 12 Jan 2024 09:27:53 +
Subject: [PATCH] [IPSCCP] Variable not visible at Og:
https:/
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/77759
>From 62f31654ec66fe0e2a27200d0484d3c70d4ce2c1 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Wed, 20 Dec 2023 15:12:04 -0600
Subject: [PATCH 1/7] [Flang][OpenMP] Separate creation of work-sharing and
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,52 @@
+//===--- AvoidNestedConditionalOperatorCheck.cpp - clang-tidy --===//
EugeneZelenko wrote:
Please add `-`
https://github.com/llvm/llvm-project/pull/78022
___
lldb-commits mailing list
lldb-com
kiranchandramohan wrote:
> Introduce createSectionOp
`genSectionOp`?
https://github.com/llvm/llvm-project/pull/77759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kiranchandramohan approved this pull request.
LG.
https://github.com/llvm/llvm-project/pull/77759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kparzysz closed
https://github.com/llvm/llvm-project/pull/77759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kparzysz wrote:
> > Introduce createSectionOp
>
> `genSectionOp`?
Yes---fixed the commit message.
https://github.com/llvm/llvm-project/pull/77759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/78029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/78029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rampitec updated
https://github.com/llvm/llvm-project/pull/74537
>From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Mon, 4 Dec 2023 16:11:53 -0800
Subject: [PATCH 01/11] [AMDGPU] Use alias info to relax waitcounts for LDS
@@ -1183,9 +1228,21 @@ bool
SIInsertWaitcnts::generateWaitcntInstBefore(MachineInstr &MI,
// No need to wait before load from VMEM to LDS.
if (TII->mayWriteLDSThroughDMA(MI))
continue;
-unsigned RegNo = SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS;
+
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/77547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/78210
This allows release teams to customize the bug report url for lldb. It also
removes unnecessary constructions of `llvm::PrettyStackTraceProgram` as it's
already constructed inside `llvm::InitLLVM`.
>From 69623
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This allows release teams to customize the bug report url for lldb. It also
removes unnecessary constructions of `llvm::PrettyStackTraceProgram` as it's
already constructed inside `llvm::InitLLVM`.
---
Full di
walter-erquinigo wrote:
nice!
https://github.com/llvm/llvm-project/pull/78210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-01-15T21:04:05Z
New Revision: 2bb2a42fa261d728e32ba0b1f9cf27ba7991440f
URL:
https://github.com/llvm/llvm-project/commit/2bb2a42fa261d728e32ba0b1f9cf27ba7991440f
DIFF:
https://github.com/llvm/llvm-project/commit/2bb2a42fa261d728e32ba0b1f9cf27ba7991440f.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/78029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/lhames approved this pull request.
Ok -- local testing seems to confirm that this is the right fix. We need to add
a testcase for this API, but that can happen as a follow-up.
https://github.com/llvm/llvm-project/pull/77185
___
lldb
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/78005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() {
return llvm::json::Value(std::move(scopes));
}
-ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame,
- std::string &text) {
+static std::string
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
https://github.com/walter-erquinigo commented:
This makes a lot of sense. Just a few comments
https://github.com/llvm/llvm-project/pull/78005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() {
return llvm::json::Value(std::move(scopes));
}
-ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame,
- std::string &text) {
+static std::string
@@ -0,0 +1,52 @@
+//===--- AvoidNestedConditionalOperatorCheck.cpp - clang-tidy --===//
HerrCai0907 wrote:
fixed in 10602c2b4a662872d1aaeda1dbc58e5d6f613fda
https://github.com/llvm/llvm-project/pull/78022
___
l
@@ -1172,6 +1198,22 @@ struct Proxy {
requires std::three_way_comparable_with, std::decay_t> {
return lhs.data <=> rhs.data;
}
+
+ // Needed to allow certain types to be weakly_incremental
+ constexpr Proxy& operator++()
+requires(HasPreIncrementOp)
+ {
+++
@@ -0,0 +1,171 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/78210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1149,9 +1171,11 @@ struct Proxy {
// Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues)
// Compare operators are defined for the convenience of the tests
- friend constexpr bool operator==(const Proxy&, const Proxy&)
-requires (std::equality_comparable && !
https://github.com/hstk30-hw closed
https://github.com/llvm/llvm-project/pull/77185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> > A WebAssembly debugging session can be started using the new command:
> > wasm [:]
>
> What about wasm requires a new command, given that you are connecting to a
> GDB server as existing targets do.
+1! I don't think this needs a new command, it could just use `gdb-remo
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/78005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/77547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67309
>From a0aae1f59fcdc9f0266bdc6248544f674b298e85 Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Mon, 25 Sep 2023 13:41:03 +0300
Subject: [PATCH] [lldb] Add SetValueFromCString API to SyntheticFronend
It is a first
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67309
>From 94d31eabaea7edd2cb139a45fdc8b85d2768f29d Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Mon, 25 Sep 2023 13:41:03 +0300
Subject: [PATCH] [lldb] Add SetValueFromCString API to SyntheticFronend
It is a first
60 matches
Mail list logo
