[Lldb-commits] [lldb] [lldb] Skip 2 newly introduced tests from running on DWARF2 and clang 11 (PR #75406)

2023-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/75406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a crash from character type confusion interaction with libedit (PR #75388)

2023-12-13 Thread Kevin Frei via lldb-commits
@@ -978,8 +978,14 @@ void Editline::DisplayCompletions( break; fprintf(editline.m_output_file, "More (Y/n/a): "); -char reply = 'n'; -int got_char = el_getc(editline.m_editline, &reply); +// The type for the output and the type for the parameter are diffe

[Lldb-commits] [lldb] Fix a crash from character type confusion interaction with libedit (PR #75388)

2023-12-13 Thread Kevin Frei via lldb-commits
@@ -978,8 +978,14 @@ void Editline::DisplayCompletions( break; fprintf(editline.m_output_file, "More (Y/n/a): "); -char reply = 'n'; -int got_char = el_getc(editline.m_editline, &reply); +// The type for the output and the type for the parameter are diffe

[Lldb-commits] [lldb] [lldb] DRAFT - Remove 2nd "error: " and print caret (^) below last input line from the developer. (PR #72150)

2023-12-13 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete updated https://github.com/llvm/llvm-project/pull/72150 >From 2e886082f69d85ea719339aa4917c744492988c4 Mon Sep 17 00:00:00 2001 From: Pete Lawrence Date: Mon, 6 Nov 2023 17:16:28 -1000 Subject: [PATCH] Remove secondary "error: " and print diagnostic line with care

[Lldb-commits] [llvm] [openmp] [clang] [libcxx] [lldb] [libcxxabi] [clang-tools-extra] [flang] [mlir] [compiler-rt] [MachineCopyPropagation] When the source of PreviousCopy is undef, we cannot replace

2023-12-13 Thread via lldb-commits
https://github.com/DianQK closed https://github.com/llvm/llvm-project/pull/74682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a crash from character type confusion interaction with libedit (PR #75388)

2023-12-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Looks good to me https://github.com/llvm/llvm-project/pull/75388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-13 Thread Greg Clayton via lldb-commits
clayborg wrote: > @clayborg Do you by any chance happen to already have a version of this patch > that applies cleanly to apple/llvm-project stable/20230725? If not > @Michael137 might try to backport it. I do not, only what is in top of tree. Totally worth backporting this though. I was able

[Lldb-commits] [lldb] [lldb][NFCI] Remove unused parameter from BreakpointResolver*::CreateFromStructuredData (PR #75374)

2023-12-13 Thread Greg Clayton via lldb-commits
clayborg wrote: I would make sure with @jimingham that this isn't used for "breakpoints read" or "breakpoints write"? What were these added for? https://github.com/llvm/llvm-project/pull/75374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

<    1   2