[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-11 Thread Greg Clayton via lldb-commits
clayborg wrote: > > "error: one of your required 'attachCommands' failed, check the debug > > console for details" > > This is a key thing that I didn't consider in the beginning. I'm going to > update this patch to only support `?`, and then I'll make another one for > `!`, because I need to

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: I am ok with this patch. I would just like to document what key/value pairs are extensions because the spec description in the comment was directly from the DAP Protocol website and it would be nice to let people know what are extensions. https://github.

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-11 Thread Greg Clayton via lldb-commits
@@ -1101,6 +1101,29 @@ std::string CreateUniqueVariableNameForDisplay(lldb::SBValue v, // can use this optional information to present the // children in a paged UI and fetch them in chunks." // } +// "declaration": { +//

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > > > > Sorry, it's been a while since I last reviewed this and I must admit I > > > > forgot about this in the mean time. The only thing I'd like to check > > > > before we can land this is to hear from @Michael137 who has been > > > > actively working on FindTypes performan

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-12-11 Thread Michał Górny via lldb-commits
mgorny wrote: "Dylib" is LLVM-speech for `libLLVM.so` ("shared libraries" refer to individual split libraries, while "dylib" refers to the monolith), as in `-DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON`. And yes, that + standalone build with full *source* repository but linking against

<    1   2