[Lldb-commits] [lldb] [LLDB] Display artificial __promise and __coro_frame variables. (PR #71928)

2023-11-11 Thread Michael Buch via lldb-commits
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type): ], ) -# Run until after the `co_yield` process = self.process() + +# Break at a coroutine body +lldbutil.continue_to_source_breakpoint( + self, process, "//

[Lldb-commits] [lldb] [clang] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71780 >From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Nov 2023 01:13:21 + Subject: [PATCH 1/5] Reland "[clang][DebugInfo] Emit global variable definitions

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
@@ -94,16 +94,11 @@ SBError SBWatchpoint::GetError() { int32_t SBWatchpoint::GetHardwareIndex() { LLDB_INSTRUMENT_VA(this); - int32_t hw_index = -1; - - lldb::WatchpointSP watchpoint_sp(GetSP()); - if (watchpoint_sp) { -std::lock_guard guard( -watchpoint_sp->G

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. This makes sense to me. I don't think we should worry too much about MIPS support -- my understanding is that LLDB doesn't really support any MIPS targets right now anyway. The Linux MIPS support has been ripped out and the remaining sup

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/72012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Oh, one more thing: Can you document the deprecation of this method into the release notes? The file is `llvm-project/llvm/docs/ReleaseNotes.rst` and there is an LLDB section. https://github.com/llvm/llvm-project/pull/72012 __

[Lldb-commits] [lldb] [lldb] Fix a off-by-one error in ParseSupportFilesFromPrologue (PR #71984)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: LGTM https://github.com/llvm/llvm-project/pull/71984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: LGTM https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/71843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -601,8 +602,8 @@ SBValue SBFrame::FindValue(const char *name, ValueType value_type, stop_if_block_is_inlined_function, [frame](Variable *v) { return v->IsInScope(frame); }, &variable_list); - if (value_type == eValueT

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -255,6 +255,11 @@ "type": "string", "description": "The escape prefix to use for executing regular LLDB commands in the Debug Console, instead of p

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -324,8 +325,29 @@ class StackFrame : public ExecutionContextScope, ///C string with the assembly instructions for this function. const char *Disassemble(); + /// Print a description of this frame using the provided frame format. + /// + /// \param[out] strm + //

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -947,6 +950,33 @@ SBValue SBFrame::FindRegister(const char *name) { return result; } +bool SBFrame::GetDescriptionWithFormat(const SBFormat &format, SBStream &output, + const char *default_value) { clayborg wrote: r

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/71843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -193,6 +193,27 @@ class LLDB_API SBFrame { bool GetDescription(lldb::SBStream &description); + /// Similar to \a GetDescription() but the format of the description can be + /// configured via the \p format parameter. See + /// https://lldb.llvm.org/use/formatting.html

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,50 @@ +//===-- SBFormat.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -814,9 +815,11 @@ SBValueList SBFrame::GetVariables(const lldb::SBVariablesOptions &options) { if (num_variables) { size_t num_produced = 0; for (const VariableSP &variable_sp : *variable_list) { - if (INTERRUPT_REQUESTED(dbg,

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -1779,18 +1779,36 @@ void StackFrame::CalculateExecutionContext(ExecutionContext &exe_ctx) { exe_ctx.SetContext(shared_from_this()); } +bool StackFrame::DumpUsingFormat(Stream &strm, + const FormatEntity::Entry *format, +

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -785,11 +785,18 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame) { int64_t frame_id = MakeDAPFrameID(frame); object.try_emplace("id", frame_id); - // `function_name` can be a nullptr, which throws an error when assigned to an - // `std::string`. - const c

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Make MemberAttributes const when parsing member DIEs (PR #71921)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/71921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71780 >From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 9 Nov 2023 01:13:21 + Subject: [PATCH 1/6] Reland "[clang][DebugInfo] Emit global variable definitions

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

2023-11-11 Thread Greg Clayton via lldb-commits
@@ -184,6 +184,8 @@ class LLDB_API SBTarget { SBProcess LoadCore(const char *core_file); SBProcess LoadCore(const char *core_file, lldb::SBError &error); + SBProcess LoadCore(SBFile &file); clayborg wrote: Just add the error to your function call: ``` SB

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/71772 >From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 8 Nov 2023 21:14:49 -0800 Subject: [PATCH 1/3] Centralize the code that figures out which memory ranges to s

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/71772 >From f1bd931ff434012888b0b87a75daaf6ba99102c0 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 8 Nov 2023 21:14:49 -0800 Subject: [PATCH 1/3] Centralize the code that figures out which memory ranges to s

[Lldb-commits] [lldb] 215bacb - Centralize the code that figures out which memory ranges to save into core files (#71772)

2023-11-11 Thread via lldb-commits
Author: Greg Clayton Date: 2023-11-11T11:21:32-08:00 New Revision: 215bacb5dc6e7027402434a14e1153e687a4a1cf URL: https://github.com/llvm/llvm-project/commit/215bacb5dc6e7027402434a14e1153e687a4a1cf DIFF: https://github.com/llvm/llvm-project/commit/215bacb5dc6e7027402434a14e1153e687a4a1cf.diff

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

2023-11-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/71772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Alex Langford via lldb-commits
@@ -1779,18 +1779,36 @@ void StackFrame::CalculateExecutionContext(ExecutionContext &exe_ctx) { exe_ctx.SetContext(shared_from_this()); } +bool StackFrame::DumpUsingFormat(Stream &strm, + const FormatEntity::Entry *format, +

[Lldb-commits] [lldb] [lldb-dap] Add an option to provide a format for stack frames (PR #71843)

2023-11-11 Thread Alex Langford via lldb-commits
@@ -0,0 +1,72 @@ + +//===-- SBFormat.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[Lldb-commits] [lldb] [lldb][test] Implement getting thread ID on OpenBSD (PR #71129)

2023-11-11 Thread Brad Smith via lldb-commits
brad0 wrote: Ping. https://github.com/llvm/llvm-project/pull/71129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits