[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/72012 The Watchpoint and Breakpoint objects try to track the hardware index that was used for them, if they are hardware wp/bp's. The majority of our debugging goes over the gdb remote serial protocol, and when w

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The Watchpoint and Breakpoint objects try to track the hardware index that was used for them, if they are hardware wp/bp's. The majority of our debugging goes over the gdb remote serial protocol, and wh

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I started making this change while working a larger "NFC" change in https://github.com/llvm/llvm-project/pull/68845 which has grown quite a lot in its scope and Jonas admonished me to not sneak functional changes into an NFC, so I broke it out into a separate one. https:/

[Lldb-commits] [lldb] 309596f - [LLDB] Ensure the data of apple accelerator tables is kept around (#71828)

2023-11-10 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-11-10T21:53:58-05:00 New Revision: 309596f2497755b371bacff9d72d094a2c942042 URL: https://github.com/llvm/llvm-project/commit/309596f2497755b371bacff9d72d094a2c942042 DIFF: https://github.com/llvm/llvm-project/commit/309596f2497755b371bacff9d72d094a2c942042.di

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

2023-11-10 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove hardware index from watchpoints and breakpoints (PR #72012)

2023-11-10 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I built and tested this on arm64 macos and aarch64 linux. The native process plugins/register contexts are tracking the watchpoint/breakpoint hardware indexes of course, for maintaining the registers, but I think I have everything correct. I might find I missed one when I

<    1   2