https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71459
Print a warning when the debugger detects a mismatch between the MD5
checksum in the DWARF 5 line table and the file on disk.
>From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001
From: Jon
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Print a warning when the debugger detects a mismatch between the MD5
checksum in the DWARF 5 line table and the file on disk.
---
Full diff: https://github.com/llvm/llvm-project/pull/71459.diff
11
JDevlieghere wrote:
Depends on #71458. This is probably incomplete and obviously needs a test, but
I wanted to put up the PR to show what the dependent patches are building
towards.
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mai
https://github.com/clayborg approved this pull request.
There is no LLDB_PLUGIN_DEFINE() macro in ProcessTrace.cpp, so that is why it
was being manually initialized. But this plugin in a problem in that if it's
ProcessTrace::CreateInstance(...) is called, it will always return a valid
Process
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/71465
This patch makes the various Scripted Interface base class abstract by making
the `CreatePluginObject` method pure virtual.
This means that we cannot construct a Scripted Interface base class instance,
so
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch makes the various Scripted Interface base class abstract by making
the `CreatePluginObject` method pure virtual.
This means that we cannot construct a Scripted Interface base class insta
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
medismailben wrote:
@bulbazord @JDevlieghere Here! ht
https://github.com/bulbazord approved this pull request.
This more closely matches my intuition for how I would expect this inheritance
hierarchy to be set up.
If I wanted to add `ScriptedLuaProcessInterface` (as an example), what would I
need to do?
https://github.com/llvm/llvm-project/pull/
medismailben wrote:
> If I wanted to add `ScriptedLuaProcessInterface` (as an example), what would
> I need to do?
In the current state, you'd just need to implement at lease
`ScriptedProcessLuaInterface::CreatePluginObject` to construct the object. But
after I land #71260, you'll also have t
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/71456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/71456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,36 @@
+//===-- Checksum.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- Checksum.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- Checksum.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- Checksum.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -72,7 +75,8 @@ class FileSpec {
/// The style of the path
///
/// \see FileSpec::SetFile (const char *path)
- explicit FileSpec(llvm::StringRef path, Style style = Style::native);
+ explicit FileSpec(llvm::StringRef path, Style style = Style::native,
+
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
You pushed a commit from a different PR btw
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
the dwarf line tables patch LGTM
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
Author: Walter Erquinigo
Date: 2023-11-06T19:45:52-05:00
New Revision: 555a71be457f351411b89c6a6a66aeecf7ca5291
URL:
https://github.com/llvm/llvm-project/commit/555a71be457f351411b89c6a6a66aeecf7ca5291
DIFF:
https://github.com/llvm/llvm-project/commit/555a71be457f351411b89c6a6a66aeecf7ca5291.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/71455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,46 @@
+//===-- Checksum.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
medismailben wrote:
> Depends on #71456.
>
> I considered an alternative where we don't store the `Checksum` in the
> `FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a
> `FileSpec`. The reason I didn't got with this approach is because of the
> `FileSpecList`. The
@@ -0,0 +1,4 @@
+add_subdirectory(Default)
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+ add_subdirectory(DebugSymbols)
kevinfrei wrote:
I'm switching my previous PR to be a "Debuginfod" SymbolLocator plugin, and I
think this plugin name is far too general. @clayb
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -13,15 +13,18 @@
#include
#include
+#include "lldb/Utility/Checksum.h"
#include "lldb/Utility/ConstString.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/FormatVariadic.h"
+#include "llvm/Support/MD5.h"
@@ -420,13 +428,17 @@ class FileSpec {
/// The lifetime of the StringRefs is tied to the lifetime of the FileSpec.
std::vector GetComponents() const;
+ /// Return the checksum for this FileSpec or all zeros if there is none.
+ const Checksum &GetChecksum() const { retu
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -300,6 +300,16 @@ size_t
SourceManager::DisplaySourceLinesWithLineNumbersUsingLastFile(
break;
}
}
+
+Checksum checksum = last_file_sp->GetFileSpec().GetChecksum();
+if (checksum && checksum != last_file_sp->GetChecksum()) {
+ llvm::call_once(
@@ -9,11 +9,13 @@
#ifndef LLDB_CORE_SOURCEMANAGER_H
#define LLDB_CORE_SOURCEMANAGER_H
+#include "lldb/Utility/Checksum.h"
#include "lldb/Utility/FileSpec.h"
#include "lldb/lldb-defines.h"
#include "lldb/lldb-forward.h"
#include "llvm/Support/Chrono.h"
+#include "llvm/Sup
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -466,6 +466,114 @@ Unpoisoning may not be an option, if (for example) you
are not maintaining the a
* You are using allocator, which does not call destructor during deallocation.
* You are aware that memory allocated with an allocator may be accessed, even
when unused by co
https://github.com/AntonRydahl edited
https://github.com/llvm/llvm-project/pull/66968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
Hi David! I'm working with @taalhaataahir0102 on this. I addressed some of your
comments.
First, in the renamed `DumpName`, I tried using `llvm` Regex instead of `std`.
It is passing the tests, so I hope it's okay. One question about it, do you
think `Address` is the right cl
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/71477
BreakpointResolver::CreateFromStructuredData returns a BreakpointResolverSP,
but all of the subclasses return raw pointers. Instead of creating a raw
pointer and shoving it into a shared pointer, it seems reas
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
BreakpointResolver::CreateFromStructuredData returns a BreakpointResolverSP,
but all of the subclasses return raw pointers. Instead of creating a raw
pointer and shoving it into a shared pointer, it seems
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/71477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-07T04:53:54Z
New Revision: 7c3707aea8a6f1fc245ad2862982b8a51b6c0fea
URL:
https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea
DIFF:
https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea.diff
LOG:
Author: Michael Buch
Date: 2023-11-07T04:54:01Z
New Revision: 470de2bbec7f5fdd199775aa99c68ac76f4d5c74
URL:
https://github.com/llvm/llvm-project/commit/470de2bbec7f5fdd199775aa99c68ac76f4d5c74
DIFF:
https://github.com/llvm/llvm-project/commit/470de2bbec7f5fdd199775aa99c68ac76f4d5c74.diff
LOG:
Author: Michael Buch
Date: 2023-11-07T04:54:04Z
New Revision: 15fc809404d4715822e5349b76dcca50eb100eec
URL:
https://github.com/llvm/llvm-project/commit/15fc809404d4715822e5349b76dcca50eb100eec
DIFF:
https://github.com/llvm/llvm-project/commit/15fc809404d4715822e5349b76dcca50eb100eec.diff
LOG:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71486
This is a newly added test which XPASSes on Linux
>From acf1ba6c54bc897cf572a01bb0caeeff207f76dc Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 7 Nov 2023 05:10:44 +
Subject: [PATCH] [lldb][test]
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This is a newly added test which XPASSes on Linux
---
Full diff: https://github.com/llvm/llvm-project/pull/71486.diff
1 Files Affected:
- (modified)
lldb/test/API/lang/cpp/const_static_integral_member/T
Author: Michael Buch
Date: 2023-11-07T05:18:23Z
New Revision: d08d9cf55629a300a54ab1660912b044145540f1
URL:
https://github.com/llvm/llvm-project/commit/d08d9cf55629a300a54ab1660912b044145540f1
DIFF:
https://github.com/llvm/llvm-project/commit/d08d9cf55629a300a54ab1660912b044145540f1.diff
LOG:
Author: Michael Buch
Date: 2023-11-07T05:23:46Z
New Revision: 317481b3c8b34b0c3f106c514e6aa39b70886110
URL:
https://github.com/llvm/llvm-project/commit/317481b3c8b34b0c3f106c514e6aa39b70886110
DIFF:
https://github.com/llvm/llvm-project/commit/317481b3c8b34b0c3f106c514e6aa39b70886110.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/71465
>From 54bde6b52bb02d1626611926e6d4e4b282a28081 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 6 Nov 2023 16:12:36 -0800
Subject: [PATCH] [lldb/Interpreter] Make Scripted*Interface base class
a
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -443,6 +455,9 @@ class FileSpec {
/// The unique'd filename path.
ConstString m_filename;
+ /// The optional MD5 checksum of the file.
+ Checksum m_checksum;
+
clayborg wrote:
This will increase the byte size of every FileSpec object by 16 bytes whic
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -443,6 +455,9 @@ class FileSpec {
/// The unique'd filename path.
ConstString m_filename;
+ /// The optional MD5 checksum of the file.
+ Checksum m_checksum;
+
clayborg wrote:
The DWARF 5 line table should have a file list where can we easily compute
101 - 154 of 154 matches
Mail list logo
